kramdown-prismic 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae42e32a63e34a7692e2f6dd7af5ec86638bb253
-  data.tar.gz: 0eecb39a28de782cb45e5dba7dbceed5d07b356a
+  metadata.gz: 5465bc67c1f2cc29208888f196e1a2eb3b67abf6
+  data.tar.gz: 421a8ce16fea41e776293fa57bdaf39ea3f029a8
 SHA512:
-  metadata.gz: c231aed1d32708a75cc1812595970aa470b3d5d185916a414484a624c6ec7d1051299690201629b551ca47e53e6449f94ede6b4c0f31e0315fc88553635c692b
-  data.tar.gz: 2564bfd26fb1a5aa616610f6f4dfd6ecd2523c7ec191f5c179afbf5cdaf1f9f8f92b15ad7abfaabe141239875478f03a21687ece16bdc3a681751123323c4cc3
+  metadata.gz: bd90c77232680328ee30a3a08a3b7b434cf69255de143dfa40c4ff0e44beb4c5345b5c65dca726771596b5697eeb9dbca3bab17253d77d456133e2e34a18ed85
+  data.tar.gz: b75ef505d3fb1f7b4cb389cf7a026b45babb98b0322ee6d626b4a81da06b17206db48fde683b916affc4e64fc24ef6cd07802ec531f7ceba8f93b9cbd41ba5c6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    kramdown-prismic (0.0.2)
+    kramdown-prismic (0.0.3)
       kramdown (~> 1.0)
 
 GEM

data/README.md

@@ -21,7 +21,7 @@ TODO:
 - [x] hyperlink
 - [x] o-list-item
 - [x] list-item
-- [ ] Image
+- [x] Image
 - [ ] Embed
 
 ## Difference between markdown and rich text
@@ -30,10 +30,12 @@ TODO:
 |------------------|----------------------------|
 | Blockquote       | translated to preformatted |
 | hr               | nothing                    |
-| img              | moved to to level          |
+| img              | moved to the top level     |
+| nested list      | moved to the top level     |
+| br               |                            |
 | dl               |                            |
 | dt               |                            |
-| dl               |                            |
+| dd               |                            |
 | table            |                            |
 | thead            |                            |
 | tobdy            |                            |
@@ -42,11 +44,11 @@ TODO:
 | td               |                            |
 | math             |                            |
 | footnote         |                            |
-| entity           |                            |
+| entity           | Transformed to unicode     |
 | typographic_sym  |                            |
 | smart_quote      |                            |
 | abbreviation     |                            |
-| html_element     |                            |
+| html_element     | not supported              |
 | xml_comment      |                            |
 | xml_pi           |                            |
 | comment          |                            |

data/lib/kramdown-prismic/version.rb

@@ -1,3 +1,3 @@
 module KramdownPrismic
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/kramdown/converter/prismic.rb

@@ -4,27 +4,42 @@ module Kramdown
   module Converter
     class Prismic < Base
       def convert(root)
-        move_img_to_top_level(root).map { |child|
+        cleanup_ast(root).map { |child|
           convert_element(child)
         }.compact.flatten
       end
 
       private
 
-      def move_img_to_top_level(root)
+      def cleanup_ast(root)
+        remove_blanks(root)
         root.children.map do |child|
-          imgs = find_imgs(child)
-          [child, imgs]
+          elements = extract_non_nestable_elements(child)
+          [child, elements]
         end.flatten.compact
       end
 
-      def find_imgs(child)
+      def remove_blanks(root)
+        root.children.each do |child|
+          if child.type == :blank
+            root.children.slice!(root.children.find_index(child))
+          else
+            remove_blanks(child)
+          end
+        end
+      end
+
+      def extract_non_nestable_elements(child)
         child.children.map do |element|
           if element.type == :img
             child.children.slice!(child.children.find_index(element))
             element
+          elsif element.type == :ul
+            warning('nested list moved to the top level')
+            child.children.slice!(child.children.find_index(element))
+            [element, extract_non_nestable_elements(element)]
           else
-            find_imgs(element)
+            extract_non_nestable_elements(element)
           end
         end
       end
@@ -33,9 +48,6 @@ module Kramdown
         send("convert_#{element.type}", element)
       end
 
-      def convert_blank(element)
-      end
-
       def convert_header(element)
         {
           type: "heading#{element.options[:level]}",
@@ -149,6 +161,14 @@ module Kramdown
         extract_content(element, memo)
       end
 
+      def extract_span_br(element, memo)
+        memo[:text] += "\n"
+      end
+
+      def extract_span_html_element(element, memo)
+        warning('translating html elements is not supported')
+      end
+
       def extract_span_entity(element, memo)
         memo[:text] += unicode_char(element.value.code_point)
       end

data/test/kramdown-prismic_test.rb

@@ -201,6 +201,59 @@ class KramdownPrismicTest < Minitest::Test
     assert_equal expected, Kramdown::Document.new(markdown, input: :markdown).to_prismic
   end
 
+  def test_convert_nested_ul
+    expected = [
+      {
+        type: "list-item",
+        content: {
+          text: "item1\n",
+          spans: []
+        }
+      },
+      {
+        type: "list-item",
+        content: {
+          text: "item2",
+          spans: []
+        }
+      }
+    ]
+    markdown = "- item1\n  - item2"
+    doc = Kramdown::Document.new(markdown, input: :markdown)
+    assert_equal expected, doc.to_prismic
+    assert_equal 1, doc.warnings.size
+  end
+
+  def test_convert_nested_nested_ul
+    expected = [
+      {
+        type: "list-item",
+        content: {
+          text: "item1\n",
+          spans: []
+        }
+      },
+      {
+        type: "list-item",
+        content: {
+          text: "item2\n",
+          spans: []
+        }
+      },
+      {
+        type: "list-item",
+        content: {
+          text: "item3",
+          spans: []
+        }
+      }
+    ]
+    markdown = "- item1\n  - item2\n    - item3"
+    doc = Kramdown::Document.new(markdown, input: :markdown)
+    assert_equal expected, doc.to_prismic
+    assert_equal 2, doc.warnings.size
+  end
+
   def test_convert_preformatted
     expected = [
       {
@@ -235,6 +288,19 @@ class KramdownPrismicTest < Minitest::Test
     assert_equal expected, Kramdown::Document.new(markdown, input: :markdown).to_prismic
   end
 
+  def test_convert_span_blank
+    expected = [
+      {type: "o-list-item",
+       content: {
+         text: "Testtest",
+         spans: []
+       }
+      }
+    ]
+    markdown = "1. Test\n\n    test"
+    assert_equal expected, Kramdown::Document.new(markdown, input: :markdown).to_prismic
+  end
+
   def test_convert_hr
     expected = []
     markdown = "---"
@@ -277,4 +343,32 @@ class KramdownPrismicTest < Minitest::Test
     markdown = "&nbsp;"
     assert_equal expected, Kramdown::Document.new(markdown, input: :markdown).to_prismic
   end
+
+  def test_convert_br
+    expected = [
+      {type: "paragraph",
+       content: {
+         text: "Test\n",
+         spans: []
+       }
+      }
+    ]
+    html = "<p>Test<br></p>"
+    assert_equal expected, Kramdown::Document.new(html, input: :html).to_prismic
+  end
+
+  def test_convert_span_html
+    expected = [
+      {type: "paragraph",
+       content: {
+         text: "",
+         spans: []
+       }
+      }
+    ]
+    html = "<br>"
+    doc = Kramdown::Document.new(html, input: :markdown)
+    assert_equal expected, doc.to_prismic
+    assert_equal 1, doc.warnings.size
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kramdown-prismic
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - François de Metz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-29 00:00:00.000000000 Z
+date: 2017-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kramdown