kraken_ruby 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec8b50b8dc92dd736d696e55e0c5a6d9d053afc0
-  data.tar.gz: 93cd06c2b0f5985a6322290d4500238e27103a42
+  metadata.gz: 60837e2ad5baa1c1bc95134a33aee85b9e4fecd2
+  data.tar.gz: 8439a69deba784ef9bf3ea2e39f94d836c6fa157
 SHA512:
-  metadata.gz: 076941c2f85cf77902c745bea8555bae9f5a607167038ffe6aabb1b3ccb6d0e168f707ff1c554296c316734ecddd942bb57e2946e4bbf9618154786c48b69f40
-  data.tar.gz: 3ed194a84dddc2319d67dc509a84a6fc03c6e667f9a3fa9f6b20022f2247c01e0545bb492d182629f833bc50181331d74ad4d5b9303df809b904f5a55ddaaa20
+  metadata.gz: e1bd273af83305d4b321a6fa436fe68870ab7b703159d1a799c7069b97c84df4c554eeb51dbc1e1a4734ae1c82ceb2fe4ca793ee0f11094cd910aacc9c58004e
+  data.tar.gz: 894ec8af3e84cb059ff9dd853bb4c4d250af0880b08afe818e0d05b91fdec6d9d985ddc2de768949d6ea2617cd225acf422345ae08433ed1485e2eab882f59d3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    kraken_ruby (0.2.0)
+    kraken_ruby (0.3.0)
       addressable
       hashie
       httparty

data/README.md

@@ -189,4 +189,4 @@ volume = kraken.query_ledgers(asset_pairs)
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+5. Create new Pull Request

data/lib/kraken_ruby/client.rb

@@ -1,6 +1,6 @@
 require 'httparty'
 require 'hashie'
-require 'Base64'
+require 'base64'
 require 'addressable/uri'
 
 
@@ -35,7 +35,7 @@ module Kraken
       opts = { 'pair' => pairs }
       get_public 'Ticker', opts
     end
-    
+
     def order_book(pair, opts={})
       opts['pair'] = pair
       get_public 'Depth', opts
@@ -111,7 +111,7 @@ module Kraken
     def add_order(opts={})
       required_opts = %w{pair, type, ordertype, volume}
       opts.keys.each do |key|
-        unless required_opts.include?(1) 
+        unless required_opts.include?(1)
           raise "Required options, not given. Input must include #{required_opts}"
         end
       end
@@ -131,7 +131,7 @@ module Kraken
 
         headers = {
           'API-Key' => @api_key,
-          'API-Sign' => generate_signature(method, post_data, opts) 
+          'API-Sign' => generate_signature(method, post_data, opts)
         }
 
         url = @base_uri + url_path(method)
@@ -139,8 +139,14 @@ module Kraken
         r['error'].empty? ? r['result'] : r['error']
       end
 
+      # Generate a 64-bit nonce where the 32 high bits come directly from the current
+      # timestamp and the low 32 bits are pseudorandom. We can't use a pure [P]RNG here
+      # because the Kraken API requires every request within a given session to use a
+      # monotonically increasing nonce value. This approach splits the difference.
       def nonce
-        Time.now.to_i.to_s.ljust(16,'0')
+        high_bits = Time.now.to_i << 32
+        low_bits  = SecureRandom.random_number(2 ** 32) & 0xffffffff
+        (high_bits | low_bits).to_s
       end
 
       def encode_options(opts)
@@ -167,6 +173,5 @@ module Kraken
       def url_path(method)
         '/' + @api_version + '/private/' + method
       end
-
   end
 end

data/lib/kraken_ruby/version.rb

@@ -1,3 +1,3 @@
 module KrakenRuby
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

data/spec/client_spec.rb

@@ -2,11 +2,12 @@ require 'kraken_ruby'
 
 describe Kraken::Client do
 
-	# YOU MUST REPLACE THE PLACEHOLDERS BELOW WITH YOUR API KEYS 
-	# TO TEST PRIVATE DATA QUERIES. PRIVATE TESTS WILL FAIL OTHERWISE
+	# YOU MUST SET ENVIRONMENT VARIABLES KRAKEN_API_KEY AND
+  # KRAKEN_API_SECRET TO TEST PRIVATE DATA QUERIES. PRIVATE
+  # TESTS WILL FAIL OTHERWISE.
 
-	API_KEY = 'ADD YOUR KEY HERE'
-	API_SECRET = 'ADD YOUR SECRET HERE'
+  API_KEY    = ENV['KRAKEN_API_KEY']
+  API_SECRET = ENV['KRAKEN_API_SECRET']
 
 	before :each do
 		sleep 0.3 # to prevent rapidly pinging the Kraken server
@@ -52,10 +53,16 @@ describe Kraken::Client do
 		end
 	end
 
-	context "private data" do # More tests to come		
+	context "private data" do # More tests to come
 		it "gets the user's balance" do
 			expect(kraken.balance).to be_instance_of(Hash)
 		end
+
+    it "uses a 64 bit nonce" do
+      nonce = kraken.send :nonce
+      expect(nonce.to_i.size).to eq(8)
+      expect(nonce.to_i).to be_instance_of(Bignum)
+    end
 	end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kraken_ruby
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Alexander Leishman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-27 00:00:00.000000000 Z
+date: 2014-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler