kpm 0.8.2 → 0.9.0

data/spec/kpm/unit/sha1_checker_spec.rb

@@ -36,9 +36,9 @@ describe KPM::Sha1Checker do
   it 'should create intermediate directories' do
     Dir.mktmpdir do |dir|
       config = File.join(dir, 'foo', 'bar', 'baz', 'sha1.yml')
-      expect(File.exist?(config)).to be_false
+      expect(File.exist?(config)).to be_falsey
       KPM::Sha1Checker.from_file(config)
-      expect(File.exist?(config)).to be_true
+      expect(File.exist?(config)).to be_truthy
     end
   end
 

data/spec/kpm/unit/uninstaller_spec.rb

@@ -29,16 +29,16 @@ describe KPM::Uninstaller do
   let(:version2) { '2.0' }
 
   before do
-    KPM::PluginsManager.stub(:new).and_return(plugins_manager_mock)
-    KPM::Sha1Checker.stub(:from_file).and_return(sha1_checker_mock)
+    allow(KPM::PluginsManager).to receive(:new).and_return(plugins_manager_mock)
+    allow(KPM::Sha1Checker).to receive(:from_file).and_return(sha1_checker_mock)
 
     # Calls by the Inspector
-    plugins_manager_mock.stub(:get_identifier_key_and_entry) do
+    allow(plugins_manager_mock).to receive(:get_identifier_key_and_entry) do
       [plugin_key, { 'group_id' => plugin_info[:group_id],
                      'artifact_id' => plugin_info[:artifact_id],
                      'packaging' => plugin_info[:packaging] }]
     end
-    sha1_checker_mock.stub(:all_sha1) { {} }
+    allow(sha1_checker_mock).to receive(:all_sha1) { {} }
   end
 
   context 'utility methods' do
@@ -94,33 +94,33 @@ describe KPM::Uninstaller do
     end
 
     it 'uninstalls if user confirms action' do
-      KPM.ui.should_receive(:ask).and_return('y')
+      expect(KPM.ui).to receive(:ask).and_return('y')
 
-      plugins_manager_mock.should_receive(:remove_plugin_identifier_key).with(plugin_key)
-      sha1_checker_mock.should_receive(:remove_entry!).with("group:artifact:jar:#{version1}")
-      sha1_checker_mock.should_receive(:remove_entry!).with("group:artifact:jar:#{version2}")
+      expect(plugins_manager_mock).to receive(:remove_plugin_identifier_key).with(plugin_key)
+      expect(sha1_checker_mock).to receive(:remove_entry!).with("group:artifact:jar:#{version1}")
+      expect(sha1_checker_mock).to receive(:remove_entry!).with("group:artifact:jar:#{version2}")
 
-      uninstaller.uninstall_plugin(plugin_name).should be_true
+      expect(uninstaller.uninstall_plugin(plugin_name)).to be_truthy
     end
 
     it 'does nothing if user cancels' do
-      KPM.ui.should_receive(:ask).and_return('n')
+      expect(KPM.ui).to receive(:ask).and_return('n')
 
-      uninstaller.uninstall_plugin(plugin_name).should be_false
+      expect(uninstaller.uninstall_plugin(plugin_name)).to be_falsey
     end
 
     it 'uninstalls all plugins without confirmation if the force option is given' do
-      plugins_manager_mock.should_receive(:remove_plugin_identifier_key).with(plugin_key)
-      sha1_checker_mock.should_receive(:remove_entry!).with("group:artifact:jar:#{version1}")
-      sha1_checker_mock.should_receive(:remove_entry!).with("group:artifact:jar:#{version2}")
+      expect(plugins_manager_mock).to receive(:remove_plugin_identifier_key).with(plugin_key)
+      expect(sha1_checker_mock).to receive(:remove_entry!).with("group:artifact:jar:#{version1}")
+      expect(sha1_checker_mock).to receive(:remove_entry!).with("group:artifact:jar:#{version2}")
 
-      uninstaller.uninstall_plugin(plugin_name, true).should be_true
+      expect(uninstaller.uninstall_plugin(plugin_name, true)).to be_truthy
     end
 
     it 'uninstalls one version without confirmation if the force option is given' do
-      sha1_checker_mock.should_receive(:remove_entry!).with("group:artifact:jar:#{version1}")
+      expect(sha1_checker_mock).to receive(:remove_entry!).with("group:artifact:jar:#{version1}")
 
-      uninstaller.uninstall_plugin(plugin_name, true, version1).should be_true
+      expect(uninstaller.uninstall_plugin(plugin_name, true, version1)).to be_truthy
     end
 
     it 'raises an error when uninstalling a version that does not exist' do
@@ -134,21 +134,21 @@ describe KPM::Uninstaller do
     end
 
     it 'does not cleanup if dry-run is set' do
-      expect(uninstaller.uninstall_non_default_plugins(true)).to be_false
+      expect(uninstaller.uninstall_non_default_plugins(true)).to be_falsey
     end
 
     it 'does cleanup if dry-run isn\'t set' do
-      sha1_checker_mock.should_receive(:remove_entry!).with("group:artifact:jar:#{version1}")
+      expect(sha1_checker_mock).to receive(:remove_entry!).with("group:artifact:jar:#{version1}")
 
       plugin_info_copy = Marshal.load(Marshal.dump(plugin_info))
       expect(KPM::Inspector.new.inspect(destination)).to eq({ plugin_name => plugin_info_copy })
 
-      expect(uninstaller.uninstall_non_default_plugins(false)).to be_true
+      expect(uninstaller.uninstall_non_default_plugins(false)).to be_truthy
       plugin_info_copy[:versions].delete_at(0)
       expect(KPM::Inspector.new.inspect(destination)).to eq({ plugin_name => plugin_info_copy })
 
       # Second time is a no-op
-      expect(uninstaller.uninstall_non_default_plugins).to be_false
+      expect(uninstaller.uninstall_non_default_plugins).to be_falsey
     end
   end
 end

data/spec/kpm/unit_mysql/account_spec.rb

@@ -37,7 +37,7 @@ describe KPM::Account do
       end
 
       it 'when initialized with options' do
-        account_class.should be_an_instance_of(KPM::Account)
+        expect(account_class).to be_an_instance_of(KPM::Account)
         expect(account_class.instance_variable_get(:@killbill_api_key)).to eq(killbill_api_key)
         expect(account_class.instance_variable_get(:@killbill_api_secret)).to eq(killbill_api_secret)
         expect(account_class.instance_variable_get(:@killbill_user)).to eq(killbill_user)
@@ -58,7 +58,7 @@ describe KPM::Account do
 
       it 'when account id found' do
         expect(account_id).to match(/\w{8}(-\w{4}){3}-\w{12}?/)
-        expect { account_class.send(:fetch_export_data, account_id) }.not_to raise_error(Interrupt, 'Account id not found')
+        expect { account_class.send(:fetch_export_data, account_id) }.not_to raise_error
         expect(account_class.send(:fetch_export_data, account_id)).to match(account_id)
       end
     end
@@ -99,12 +99,12 @@ describe KPM::Account do
 
     context 'when exporting data' do
       it 'when file created' do
-        expect(File.exist?(account_class.send(:export, dummy_data))).to be_true
+        expect(File.exist?(account_class.send(:export, dummy_data))).to be_truthy
       end
 
       it 'when file contains account record' do
-        expect(File.readlines(account_class.send(:export, dummy_data)).grep(/#{table_name}/)).to be_true
-        expect(File.readlines(account_class.send(:export, dummy_data)).grep(/#{cols_names}/)).to be_true
+        expect(File.readlines(account_class.send(:export, dummy_data)).grep(/#{table_name}/)).to be_truthy
+        expect(File.readlines(account_class.send(:export, dummy_data)).grep(/#{cols_names}/)).to be_truthy
       end
     end
   end
@@ -119,13 +119,13 @@ describe KPM::Account do
 
       it 'when file created' do
         expect(account_id).to match(/\w{8}(-\w{4}){3}-\w{12}?/)
-        expect(File.exist?(account_class.export_data(account_id))).to be_true
+        expect(File.exist?(account_class.export_data(account_id))).to be_truthy
       end
 
       it 'when file contains account record' do
         expect(account_id).to match(/\w{8}(-\w{4}){3}-\w{12}?/)
-        expect(File.readlines(account_class.export_data(account_id)).grep(/#{table_name}/)).to be_true
-        expect(File.readlines(account_class.export_data(account_id)).grep(/#{cols_names}/)).to be_true
+        expect(File.readlines(account_class.export_data(account_id)).grep(/#{table_name}/)).to be_truthy
+        expect(File.readlines(account_class.export_data(account_id)).grep(/#{cols_names}/)).to be_truthy
       end
     end
   end
@@ -155,7 +155,7 @@ describe KPM::Account do
     include_context 'account'
 
     it 'when valid date value' do
-      expect { DateTime.parse(account_class.send(:fix_dates, '2017-04-05T15:01:39.000+0000')) }.not_to raise_error(ArgumentError)
+      expect { DateTime.parse(account_class.send(:fix_dates, '2017-04-05T15:01:39.000+0000')) }.not_to raise_error
     end
 
     it 'when valid date value match YYYY-MM-DD HH:MM:SS' do
@@ -307,7 +307,7 @@ describe KPM::Account do
         File.open(dummy_data_file, 'w') do |io|
           io.puts(dummy_data)
         end
-        expect { account_class.import_data(dummy_data_file, nil, true, false, true) }.not_to raise_error(Interrupt)
+        expect { account_class.import_data(dummy_data_file, nil, true, false, true) }.not_to raise_error
 
         verify_data(dummy_account_id)
 
@@ -321,7 +321,7 @@ describe KPM::Account do
         File.open(dummy_data_file, 'w') do |io|
           io.puts(dummy_data)
         end
-        expect { account_class.import_data(dummy_data_file, nil, true, false, false) }.not_to raise_error(Interrupt)
+        expect { account_class.import_data(dummy_data_file, nil, true, false, false) }.not_to raise_error
 
         verify_data(dummy_account_id)
 
@@ -335,7 +335,7 @@ describe KPM::Account do
         File.open(dummy_data_file, 'w') do |io|
           io.puts(dummy_data)
         end
-        expect { account_class.import_data(dummy_data_file, 10, true, false, true) }.not_to raise_error(Interrupt)
+        expect { account_class.import_data(dummy_data_file, 10, true, false, true) }.not_to raise_error
 
         verify_data(dummy_account_id)
 
@@ -349,7 +349,7 @@ describe KPM::Account do
         File.open(dummy_data_file, 'w') do |io|
           io.puts(dummy_data)
         end
-        expect { account_class.import_data(dummy_data_file, 10, true, true, true) }.not_to raise_error(Interrupt)
+        expect { account_class.import_data(dummy_data_file, 10, true, true, true) }.not_to raise_error
         new_account_id = account_class.instance_variable_get(:@tables_id)
 
         verify_data(new_account_id['accounts_id'])

data/spec/spec_helper.rb

@@ -10,7 +10,7 @@ require 'yaml'
 require 'killbill_client'
 
 RSpec.configure do |config|
-  config.color_enabled = true
+  config.color_mode    = :on
   config.tty           = true
   config.formatter     = 'documentation'
   config.filter_run_excluding skip_me_if_nil: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kpm
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.9.0
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-17 00:00:00.000000000 Z
+date: 2020-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -70,36 +70,30 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 10.0.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 11.0.0
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 10.0.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 11.0.0
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.12.0
+        version: '3.9'
 description: A package manager for Kill Bill.
 email: killbilling-users@googlegroups.com
 executables:
@@ -133,6 +127,7 @@ files:
 - lib/kpm/killbill_server_artifact.rb
 - lib/kpm/migrations.rb
 - lib/kpm/nexus_helper/actions.rb
+- lib/kpm/nexus_helper/github_api_calls.rb
 - lib/kpm/nexus_helper/nexus_api_calls_v2.rb
 - lib/kpm/nexus_helper/nexus_facade.rb
 - lib/kpm/plugins_directory.rb
@@ -160,6 +155,7 @@ files:
 - release.sh
 - spec/kpm/remote/base_artifact_spec.rb
 - spec/kpm/remote/base_installer_spec.rb
+- spec/kpm/remote/github_api_calls_spec.rb
 - spec/kpm/remote/installer_spec.rb
 - spec/kpm/remote/kaui_artifact_spec.rb
 - spec/kpm/remote/killbill_plugin_artifact_spec.rb