kpm 0.8.2 → 0.10.2

data/spec/kpm/remote/killbill_server_artifact_spec.rb

@@ -18,16 +18,16 @@ describe KPM::KillbillServerArtifact do
                                               KPM::BaseArtifact::KILLBILL_CLASSIFIER,
                                               'LATEST',
                                               dir)
-      info[:file_name].should eq "killbill-profiles-killbill-#{info[:version]}.war"
-      info[:size].should eq File.size(info[:file_path])
+      expect(info[:file_name]).to eq "killbill-profiles-killbill-#{info[:version]}.war"
+      expect(info[:size]).to eq File.size(info[:file_path])
     end
   end
 
   it 'should be able to list versions' do
     versions = KPM::KillbillServerArtifact.versions(KPM::BaseArtifact::KILLBILL_ARTIFACT_ID).to_a
     expect(versions.size).to be >= 2
-    versions[0].should eq '0.11.10'
-    versions[1].should eq '0.11.11'
+    expect(versions[0]).to eq '0.11.10'
+    expect(versions[1]).to eq '0.11.11'
   end
 
   it 'should get dependencies information' do
@@ -36,23 +36,23 @@ describe KPM::KillbillServerArtifact do
     Dir.mktmpdir do |dir|
       sha1_file = "#{dir}/sha1.yml"
       info = KPM::KillbillServerArtifact.info('0.15.9', sha1_file)
-      info['killbill'].should eq '0.15.9'
-      info['killbill-oss-parent'].should eq '0.62'
-      info['killbill-api'].should eq '0.27'
-      info['killbill-plugin-api'].should eq '0.16'
-      info['killbill-commons'].should eq '0.10'
-      info['killbill-platform'].should eq '0.13'
-      KPM::Sha1Checker.from_file(sha1_file).killbill_info('0.15.9').should eq info
+      expect(info['killbill']).to eq '0.15.9'
+      expect(info['killbill-oss-parent']).to eq '0.62'
+      expect(info['killbill-api']).to eq '0.27'
+      expect(info['killbill-plugin-api']).to eq '0.16'
+      expect(info['killbill-commons']).to eq '0.10'
+      expect(info['killbill-platform']).to eq '0.13'
+      expect(KPM::Sha1Checker.from_file(sha1_file).killbill_info('0.15.9')).to eq info
 
       # Verify the download is skipped gracefully when Nexus isn't reachable
       KPM::KillbillServerArtifact.info('0.15.9', sha1_file, false, nil, nexus_down)
 
       # Verify the download fails when Nexus isn't reachable and force_download is set
-      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, true, nil, nexus_down) }.to raise_error
+      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, true, nil, nexus_down) }.to raise_exception(SocketError, /(Failed to open TCP connection to does.not.exist:443|getaddrinfo)/)
 
       # Verify the download fails when Nexus isn't reachable and the Nexus cache is empty
       KPM::Sha1Checker.from_file(sha1_file).cache_killbill_info('0.15.9', nil)
-      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, false, nil, nexus_down) }.to raise_error
+      expect { KPM::KillbillServerArtifact.info('0.15.9', sha1_file, false, nil, nexus_down) }.to raise_exception(SocketError, /(Failed to open TCP connection to does.not.exist:443|getaddrinfo)/)
     end
   end
 end

data/spec/kpm/remote/migrations_spec.rb

@@ -7,13 +7,13 @@ describe KPM::Migrations, skip_me_if_nil: ENV['TOKEN'].nil? do
     it 'should be able to find migrations for a java plugin' do
       migrations = KPM::Migrations.new('analytics-plugin-3.0.2', nil, 'killbill/killbill-analytics-plugin', ENV['TOKEN']).migrations
       # No migration yet
-      migrations.size.should eq 0
+      expect(migrations.size).to eq 0
     end
 
     it 'should be able to find migrations for a ruby plugin' do
       migrations = KPM::Migrations.new('master', nil, 'killbill/killbill-cybersource-plugin', ENV['TOKEN']).migrations
       # No migration yet
-      migrations.size.should eq 1
+      expect(migrations.size).to eq 1
     end
   end
 
@@ -21,19 +21,19 @@ describe KPM::Migrations, skip_me_if_nil: ENV['TOKEN'].nil? do
     it 'should be able to find migrations between two versions' do
       migrations = KPM::Migrations.new('killbill-0.16.3', 'killbill-0.16.4', 'killbill/killbill', ENV['TOKEN']).migrations
 
-      migrations.size.should eq 1
-      migrations.first[:name].should eq 'V20160324060345__revisit_payment_methods_indexes_509.sql'
-      migrations.first[:sql].should eq "drop index payment_methods_active_accnt on payment_methods;\n"
+      expect(migrations.size).to eq 1
+      expect(migrations.first[:name]).to eq 'V20160324060345__revisit_payment_methods_indexes_509.sql'
+      expect(migrations.first[:sql]).to eq "drop index payment_methods_active_accnt on payment_methods;\n"
 
-      KPM::Migrations.new('master', 'master', 'killbill/killbill', ENV['TOKEN']).migrations.size.should eq 0
+      expect(KPM::Migrations.new('master', 'master', 'killbill/killbill', ENV['TOKEN']).migrations.size).to eq 0
     end
 
     it 'should be able to find migrations for a given version' do
       migrations = KPM::Migrations.new('killbill-0.16.4', nil, 'killbill/killbill', ENV['TOKEN']).migrations
 
-      migrations.size.should eq 1
-      migrations.first[:name].should eq 'V20160324060345__revisit_payment_methods_indexes_509.sql'
-      migrations.first[:sql].should eq "drop index payment_methods_active_accnt on payment_methods;\n"
+      expect(migrations.size).to eq 1
+      expect(migrations.first[:name]).to eq 'V20160324060345__revisit_payment_methods_indexes_509.sql'
+      expect(migrations.first[:sql]).to eq "drop index payment_methods_active_accnt on payment_methods;\n"
     end
   end
 end

data/spec/kpm/remote/nexus_facade_spec.rb

@@ -51,7 +51,7 @@ describe KPM::NexusFacade do
     destination = Dir.mktmpdir('artifact')
     expect { response = nexus_remote.pull_artifact(coordinates, destination) }.not_to raise_exception
     destination = File.join(File.expand_path(destination), response[:file_name])
-    expect(File.exist?(destination)).to be_true
+    expect(File.exist?(destination)).to be_truthy
   end
 
   it 'when pull artifact with classifier' do
@@ -59,6 +59,6 @@ describe KPM::NexusFacade do
     destination = Dir.mktmpdir('artifact')
     expect { response = nexus_remote.pull_artifact(coordinates_with_classifier, destination) }.not_to raise_exception
     destination = File.join(File.expand_path(destination), response[:file_name])
-    expect(File.exist?(destination)).to be_true
+    expect(File.exist?(destination)).to be_truthy
   end
 end

data/spec/kpm/remote/tenant_config_spec.rb

@@ -29,7 +29,7 @@ describe KPM::TenantConfig do
       end
 
       it 'when initialized with options' do
-        tenant_config_class.should be_an_instance_of(KPM::TenantConfig)
+        expect(tenant_config_class).to be_an_instance_of(KPM::TenantConfig)
         expect(tenant_config_class.instance_variable_get(:@killbill_api_key)).to eq(killbill_api_key)
         expect(tenant_config_class.instance_variable_get(:@killbill_api_secret)).to eq(killbill_api_secret)
         expect(tenant_config_class.instance_variable_get(:@killbill_user)).to eq(killbill_user)
@@ -49,8 +49,8 @@ describe KPM::TenantConfig do
 
       # get created tenant config
       export_file = tenant_config_class.export(key)
-      expect(File.exist?(export_file)).to be_true
-      expect(File.readlines(export_file).grep(/#{key}/)).to be_true
+      expect(File.exist?(export_file)).to be_truthy
+      expect(File.readlines(export_file).grep(/#{key}/)).to be_truthy
 
       # remove created tenant config
       KillBillClient::Model::Tenant.delete_tenant_user_key_value(key, user, nil, nil, options)

data/spec/kpm/remote/tomcat_manager_spec.rb

@@ -13,10 +13,10 @@ describe KPM::TomcatManager do
       manager = KPM::TomcatManager.new(dir, @logger)
 
       tomcat_path = manager.download
-      tomcat_path.should_not be_nil
+      expect(tomcat_path).not_to be_nil
 
       root_war_path = manager.setup
-      root_war_path.should_not be_nil
+      expect(root_war_path).not_to be_nil
     end
   end
 end

data/spec/kpm/unit/actions_spec.rb

@@ -8,7 +8,7 @@ describe KPM::NexusFacade::Actions do
   let(:nexus_mock) { double(KPM::NexusFacade::NexusApiCallsV2) }
 
   before do
-    KPM::NexusFacade::NexusApiCallsV2.stub(:new).and_return(nexus_mock)
+    allow(KPM::NexusFacade::NexusApiCallsV2).to receive(:new).and_return(nexus_mock)
   end
 
   context 'when Nexus throws a non-retryable exception' do
@@ -45,7 +45,7 @@ describe KPM::NexusFacade::Actions do
         raise OpenSSL::SSL::SSLErrorWaitReadable if calls < 2
 
         true
-      end).to be_true
+      end).to be_truthy
       expect(calls).to eq(2)
     end
   end

data/spec/kpm/unit/base_artifact_spec.rb

@@ -14,16 +14,16 @@ describe KPM::BaseArtifact do
     Dir.mktmpdir do |dir|
       info = KPM::BaseArtifact.pull_from_fs(@logger, file_path, dir)
 
-      info[:skipped].should be_false
-      info[:is_tgz].should be_false
-      info[:repository_path].should eq file_path
-      info[:dir_name].should eq dir
-      info[:bundle_dir].should eq dir
-      info[:file_name].should eq 'sha1_test.yml'
+      expect(info[:skipped]).to be_falsey
+      expect(info[:is_tgz]).to be_falsey
+      expect(info[:repository_path]).to eq file_path
+      expect(info[:dir_name]).to eq dir
+      expect(info[:bundle_dir]).to eq dir
+      expect(info[:file_name]).to eq 'sha1_test.yml'
 
       files_in_dir = Dir[dir + '/*']
-      files_in_dir.size.should eq 1
-      files_in_dir[0].should eq info[:file_path]
+      expect(files_in_dir.size).to eq 1
+      expect(files_in_dir[0]).to eq info[:file_path]
     end
   end
 
@@ -83,11 +83,11 @@ describe KPM::BaseArtifact do
 
     KPM::BaseArtifact.send('populate_fs_info', info, specified_destination_path)
 
-    info[:repository_path].should eq repository_path
-    info[:is_tgz].should eq is_tgz
-    info[:version].should eq version
-    info[:dir_name].should eq expected_dir_name
-    info[:file_name].should eq expected_file_name
-    info[:file_path].should eq expected_file_path
+    expect(info[:repository_path]).to eq repository_path
+    expect(info[:is_tgz]).to eq is_tgz
+    expect(info[:version]).to eq version
+    expect(info[:dir_name]).to eq expected_dir_name
+    expect(info[:file_name]).to eq expected_file_name
+    expect(info[:file_path]).to eq expected_file_path
   end
 end

data/spec/kpm/unit/inspector_spec.rb

@@ -31,34 +31,34 @@ describe KPM::Inspector do
 
     inspector = KPM::Inspector.new
     all_plugins = inspector.inspect(@bundles_dir)
-    all_plugins.size.should eq 2
-
-    all_plugins['plugin_bar'][:plugin_key].should eq 'bar'
-    all_plugins['plugin_bar'][:plugin_path].should eq @java_plugins_dir.join('plugin_bar').to_s
-    all_plugins['plugin_bar'][:versions].size.should eq 1
-    all_plugins['plugin_bar'][:versions][0][:version].should eq '1.0.0'
-    all_plugins['plugin_bar'][:versions][0][:is_default].should eq false
-    all_plugins['plugin_bar'][:versions][0][:is_disabled].should eq false
-    all_plugins['plugin_bar'][:versions][0][:sha1].should eq '98765'
-
-    all_plugins['plugin_foo'][:plugin_key].should eq 'foo'
-    all_plugins['plugin_foo'][:plugin_path].should eq @ruby_plugins_dir.join('plugin_foo').to_s
-    all_plugins['plugin_foo'][:versions].size.should eq 3
-
-    all_plugins['plugin_foo'][:versions][0][:version].should eq '1.2.3'
-    all_plugins['plugin_foo'][:versions][0][:is_default].should eq false
-    all_plugins['plugin_foo'][:versions][0][:is_disabled].should eq true
-    all_plugins['plugin_foo'][:versions][0][:sha1].should eq '12345'
-
-    all_plugins['plugin_foo'][:versions][1][:version].should eq '2.0.0'
-    all_plugins['plugin_foo'][:versions][1][:is_default].should eq false
-    all_plugins['plugin_foo'][:versions][1][:is_disabled].should eq false
-    all_plugins['plugin_foo'][:versions][1][:sha1].should eq '23456'
-
-    all_plugins['plugin_foo'][:versions][2][:version].should eq '2.0.1'
-    all_plugins['plugin_foo'][:versions][2][:is_default].should eq true
-    all_plugins['plugin_foo'][:versions][2][:is_disabled].should eq false
-    all_plugins['plugin_foo'][:versions][2][:sha1].should eq '34567'
+    expect(all_plugins.size).to eq 2
+
+    expect(all_plugins['plugin_bar'][:plugin_key]).to eq 'bar'
+    expect(all_plugins['plugin_bar'][:plugin_path]).to eq @java_plugins_dir.join('plugin_bar').to_s
+    expect(all_plugins['plugin_bar'][:versions].size).to eq 1
+    expect(all_plugins['plugin_bar'][:versions][0][:version]).to eq '1.0.0'
+    expect(all_plugins['plugin_bar'][:versions][0][:is_default]).to eq false
+    expect(all_plugins['plugin_bar'][:versions][0][:is_disabled]).to eq false
+    expect(all_plugins['plugin_bar'][:versions][0][:sha1]).to eq '98765'
+
+    expect(all_plugins['plugin_foo'][:plugin_key]).to eq 'foo'
+    expect(all_plugins['plugin_foo'][:plugin_path]).to eq @ruby_plugins_dir.join('plugin_foo').to_s
+    expect(all_plugins['plugin_foo'][:versions].size).to eq 3
+
+    expect(all_plugins['plugin_foo'][:versions][0][:version]).to eq '1.2.3'
+    expect(all_plugins['plugin_foo'][:versions][0][:is_default]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][0][:is_disabled]).to eq true
+    expect(all_plugins['plugin_foo'][:versions][0][:sha1]).to eq '12345'
+
+    expect(all_plugins['plugin_foo'][:versions][1][:version]).to eq '2.0.0'
+    expect(all_plugins['plugin_foo'][:versions][1][:is_default]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][1][:is_disabled]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][1][:sha1]).to eq '23456'
+
+    expect(all_plugins['plugin_foo'][:versions][2][:version]).to eq '2.0.1'
+    expect(all_plugins['plugin_foo'][:versions][2][:is_default]).to eq true
+    expect(all_plugins['plugin_foo'][:versions][2][:is_disabled]).to eq false
+    expect(all_plugins['plugin_foo'][:versions][2][:sha1]).to eq '34567'
   end
 
   private

data/spec/kpm/unit/installer_spec.rb

@@ -8,11 +8,11 @@ describe KPM::Installer do
 
     it 'finds the right stable versions' do
       config = KPM::Installer.build_default_config(all_kb_versions)
-      config['killbill'].should_not be_nil
-      config['killbill']['version'].should eq '0.16.11'
+      expect(config['killbill']).not_to be_nil
+      expect(config['killbill']['version']).to eq '0.16.11'
 
-      config['kaui'].should_not be_nil
-      config['kaui']['version'].should eq 'LATEST'
+      expect(config['kaui']).not_to be_nil
+      expect(config['kaui']['version']).to eq 'LATEST'
     end
   end
 end

data/spec/kpm/unit/plugins_directory_spec.rb

@@ -5,48 +5,48 @@ require 'spec_helper'
 describe KPM::PluginsDirectory do
   it 'should parse the plugins directory' do
     directory = KPM::PluginsDirectory.all(false)
-    directory.size.should > 0
+    expect(directory.size).to be > 0
   end
 
   it 'should lookup plugins' do
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20.11')
-    group_id.should eq 'org.kill-bill.billing.plugin.java'
-    artifact_id.should eq 'analytics-plugin'
-    packaging.should eq 'jar'
-    classifier.should be_nil
-    version.should eq '6.0.1'
-    type.should eq :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20.11-SNAPSHOT')
-    group_id.should eq 'org.kill-bill.billing.plugin.java'
-    artifact_id.should eq 'analytics-plugin'
-    packaging.should eq 'jar'
-    classifier.should be_nil
-    version.should eq '6.0.1'
-    type.should eq :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.20')
-    group_id.should eq 'org.kill-bill.billing.plugin.java'
-    artifact_id.should eq 'analytics-plugin'
-    packaging.should eq 'jar'
-    classifier.should be_nil
-    version.should eq '6.0.1'
-    type.should eq :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq '6.0.1'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, 'LATEST')
-    group_id.should eq 'org.kill-bill.billing.plugin.java'
-    artifact_id.should eq 'analytics-plugin'
-    packaging.should eq 'jar'
-    classifier.should be_nil
-    version.should eq 'LATEST'
-    type.should eq :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq 'LATEST'
+    expect(type).to eq :java
 
     group_id, artifact_id, packaging, classifier, version, type = KPM::PluginsDirectory.lookup('analytics', false, '0.42')
-    group_id.should eq 'org.kill-bill.billing.plugin.java'
-    artifact_id.should eq 'analytics-plugin'
-    packaging.should eq 'jar'
-    classifier.should be_nil
-    version.should eq 'LATEST'
-    type.should eq :java
+    expect(group_id).to eq 'org.kill-bill.billing.plugin.java'
+    expect(artifact_id).to eq 'analytics-plugin'
+    expect(packaging).to eq 'jar'
+    expect(classifier).to be_nil
+    expect(version).to eq 'LATEST'
+    expect(type).to eq :java
   end
 end

data/spec/kpm/unit/plugins_manager_spec.rb

@@ -15,7 +15,7 @@ describe KPM::PluginsManager do
     FileUtils.mkdir_p(@plugin_dir.join('1.0.0'))
     FileUtils.mkdir_p(@plugin_dir.join('2.0.0'))
 
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_false
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_falsey
   end
 
   after(:each) do
@@ -25,74 +25,74 @@ describe KPM::PluginsManager do
   it 'creates a plugin identifier entry with no coordinate' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
   end
 
   it 'creates a plugin identifier entry with coordinates' do
     # Verifies file gets created if does not exist
     coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map)
-    identifiers.size.should eq 1
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['bar']['group_id'].should eq 'group'
-    identifiers['bar']['artifact_id'].should eq 'artifact'
-    identifiers['bar']['packaging'].should eq 'packaging'
-    identifiers['bar']['classifier'].should.nil?
-    identifiers['bar']['version'].should eq 'version'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['group_id']).to eq 'group'
+    expect(identifiers['bar']['artifact_id']).to eq 'artifact'
+    expect(identifiers['bar']['packaging']).to eq 'packaging'
+    expect(identifiers['bar']['classifier']).to be_nil
+    expect(identifiers['bar']['version']).to eq 'version'
   end
 
   it 'creates plugin identifier with multiple entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('foo', 'foo_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', nil)
-    identifiers.size.should eq 2
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
+    expect(identifiers.size).to eq 2
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
 
     # Verify file was created from previous entry (prev value was read)
     identifiers = @manager.add_plugin_identifier_key('zoe', 'zoe_name', 'type', nil)
-    identifiers.size.should eq 3
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['foo']['plugin_name'].should eq 'foo_name'
-    identifiers['zoe']['plugin_name'].should eq 'zoe_name'
+    expect(identifiers.size).to eq 3
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['foo']['plugin_name']).to eq 'foo_name'
+    expect(identifiers['zoe']['plugin_name']).to eq 'zoe_name'
   end
 
   it 'creates plugin identifiers with duplicate entries' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['kewl']['plugin_name'].should eq 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
 
     # Add with a different plugin_name
     identifiers = @manager.add_plugin_identifier_key('kewl', 'kewl_name2', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['kewl']['plugin_name'].should eq 'kewl_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['kewl']['plugin_name']).to eq 'kewl_name'
   end
 
   it 'creates plugin identifiers and remove entry' do
     # Verifies file gets created if does not exist
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['lol']['plugin_name'].should eq 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove wrong entry, nothing happens
     identifiers = @manager.remove_plugin_identifier_key('lol2')
-    identifiers.size.should eq 1
-    identifiers['lol']['plugin_name'].should eq 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
 
     # Remove correct entry
     identifiers = @manager.remove_plugin_identifier_key('lol')
-    identifiers.size.should eq 0
+    expect(identifiers.size).to eq 0
 
     # Add same entry again
     identifiers = @manager.add_plugin_identifier_key('lol', 'lol_name', 'type', nil)
-    identifiers.size.should eq 1
-    identifiers['lol']['plugin_name'].should eq 'lol_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['lol']['plugin_name']).to eq 'lol_name'
   end
 
   it 'creates plugin identifiers and validate entry' do
@@ -100,15 +100,15 @@ describe KPM::PluginsManager do
     coordinate_map = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
     identifiers = @manager.add_plugin_identifier_key('yoyo', 'yoyo_name', 'type', coordinate_map)
-    identifiers.size.should eq 1
-    identifiers['yoyo']['plugin_name'].should eq 'yoyo_name'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['yoyo']['plugin_name']).to eq 'yoyo_name'
 
-    @manager.validate_plugin_identifier_key('yoyo', coordinate_map).should eq true
+    expect(@manager.validate_plugin_identifier_key('yoyo', coordinate_map)).to eq true
 
     # Negative validation
     invalid_coordinate_map = { group_id: 'group1', artifact_id: 'artifact', packaging: 'packaging', version: 'version' }
 
-    @manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map).should eq false
+    expect(@manager.validate_plugin_identifier_key('yoyo', invalid_coordinate_map)).to eq false
   end
 
   it 'creates a plugin identifier entry with a new version' do
@@ -117,36 +117,36 @@ describe KPM::PluginsManager do
     coordinate_map1 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version1' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map1)
-    identifiers.size.should eq 1
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['bar']['version'].should eq 'version1'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version1'
 
     coordinate_map2 = { group_id: 'group', artifact_id: 'artifact', packaging: 'packaging', version: 'version2' }
 
     identifiers = @manager.add_plugin_identifier_key('bar', 'bar_name', 'type', coordinate_map2)
-    identifiers.size.should eq 1
-    identifiers['bar']['plugin_name'].should eq 'bar_name'
-    identifiers['bar']['version'].should eq 'version2'
+    expect(identifiers.size).to eq 1
+    expect(identifiers['bar']['plugin_name']).to eq 'bar_name'
+    expect(identifiers['bar']['version']).to eq 'version2'
   end
 
   it 'sets a path as active' do
     @manager.set_active(@plugin_dir.join('1.0.0'))
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
 
     @manager.set_active(@plugin_dir.join('2.0.0'))
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
   end
 
   it 'sets a plugin version as active' do
     @manager.set_active('killbill-stripe', '2.0.0')
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('2.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('2.0.0').to_s
 
     @manager.set_active('killbill-stripe', '1.0.0')
-    File.exist?(@plugin_dir.join('SET_DEFAULT')).should be_true
-    File.readlink(@plugin_dir.join('SET_DEFAULT')).should eq @plugin_dir.join('1.0.0').to_s
+    expect(File.exist?(@plugin_dir.join('SET_DEFAULT'))).to be_truthy
+    expect(File.readlink(@plugin_dir.join('SET_DEFAULT'))).to eq @plugin_dir.join('1.0.0').to_s
   end
 
   it 'uninstalls a plugin via a path' do
@@ -190,19 +190,19 @@ describe KPM::PluginsManager do
   end
 
   it 'guesses the plugin name' do
-    @manager.guess_plugin_name('tripe').should be_nil
+    expect(@manager.guess_plugin_name('tripe')).to be_nil
     # Short name
-    @manager.guess_plugin_name('stripe').should eq 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe')).to eq 'killbill-stripe'
     # Artifact id
-    @manager.guess_plugin_name('stripe-plugin').should eq 'killbill-stripe'
+    expect(@manager.guess_plugin_name('stripe-plugin')).to eq 'killbill-stripe'
     # Plugin name (top directory in the .tar.gz)
-    @manager.guess_plugin_name('killbill-stripe').should eq 'killbill-stripe'
+    expect(@manager.guess_plugin_name('killbill-stripe')).to eq 'killbill-stripe'
   end
 
   private
 
   def check_state(version, has_restart, has_disabled)
-    File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt')).should eq has_restart
-    File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt')).should eq has_disabled
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('restart.txt'))).to eq has_restart
+    expect(File.exist?(@plugin_dir.join(version).join('tmp').join('disabled.txt'))).to eq has_disabled
   end
 end