kpm 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d32e55ddd75d39d7bba5dd1aaf3e4cc36e55ff0a
-  data.tar.gz: 8af60c027a733158657017bfb5e6bb988e2eec8c
+  metadata.gz: 1de7630338f4ae249d6dd349fdeaa10939b0f9e5
+  data.tar.gz: 5b3848aa883c400c784db73f3b336022cc7101e9
 SHA512:
-  metadata.gz: 43cd9a9d22b0ec6f7ec329ab48e864ec58d4c445a37b350070fa9305fcb2c9efb31218a0b66cc0e1bd31fc860626c6e5433642c8d2276c58a9ab11550e17f659
-  data.tar.gz: 2e0d9a390f24f5809e2af2e369540696165690a34923da046433c29a85c1907740dfeef232cb0dae8b237f373a38d47c3c20fbe39b8e46f783b4471b1e91d4f5
+  metadata.gz: c9835a80ad3a36ce4037efec42119427eda9e5945dee8ef9bf4d76d9a6f62758c13cadfcb3c830fa4ec34c815a839240ff2eb91ce7b93fb03b38fa0929b86168
+  data.tar.gz: ab104ebd24feea1aa14e69d4f8c235865ed31c3c7d6bd71a902fde86cf4c7557bed2ad74c7e415f2020ee21832559c90bf4c84f940652d31343cfc2b33a63ab4

data/Rakefile

@@ -3,3 +3,18 @@
 # Install tasks to build and release the plugin
 require 'bundler/setup'
 Bundler::GemHelper.install_tasks
+
+# Install test tasks
+require 'rspec/core/rake_task'
+namespace :test do
+  namespace :remote do
+    desc 'Run RSpec remote tests'
+    RSpec::Core::RakeTask.new do |task|
+      task.name    = 'spec'
+      task.pattern = './spec/*/remote/*_spec.rb'
+    end
+  end
+end
+
+# Run tests by default
+task :default => 'test:remote:spec'

data/lib/kpm/base_artifact.rb

@@ -1,15 +1,43 @@
+require 'digest/sha1'
 require 'nexus_cli'
+require 'rexml/document'
 
 module KPM
+
+  class ArtifactCorruptedException < IOError
+    def message
+      'Downloaded artifact failed checksum verification'
+    end
+  end
+
   class BaseArtifact
-    KILLBILL_GROUP_ID             = 'org.kill-bill.billing'
-    KILLBILL_JAVA_PLUGIN_GROUP_ID = 'org.kill-bill.billing.plugin.java'
-    KILLBILL_RUBY_PLUGIN_GROUP_ID = 'org.kill-bill.billing.plugin.ruby'
+    KILLBILL_GROUP_ID = 'org.kill-bill.billing'
+
+    KILLBILL_ARTIFACT_ID = 'killbill-profiles-killbill'
+    KILLBILL_PACKAGING   = 'war'
+    KILLBILL_CLASSIFIER  = 'jar-with-dependencies'
+
+    KILLPAY_ARTIFACT_ID = 'killbill-profiles-killpay'
+    KILLPAY_PACKAGING   = 'war'
+    KILLPAY_CLASSIFIER  = 'jar-with-dependencies'
+
+    KILLBILL_JAVA_PLUGIN_GROUP_ID   = 'org.kill-bill.billing.plugin.java'
+    KILLBILL_JAVA_PLUGIN_PACKAGING  = 'jar'
+    KILLBILL_JAVA_PLUGIN_CLASSIFIER = nil
+
+    KILLBILL_RUBY_PLUGIN_GROUP_ID   = 'org.kill-bill.billing.plugin.ruby'
+    KILLBILL_RUBY_PLUGIN_PACKAGING  = 'tar.gz'
+    KILLBILL_RUBY_PLUGIN_CLASSIFIER = nil
+
+    KAUI_GROUP_ID    = 'org.kill-bill.billing.kaui'
+    KAUI_ARTIFACT_ID = 'kaui-standalone'
+    KAUI_PACKAGING   = 'war'
+    KAUI_CLASSIFIER  = nil
 
     class << self
-      def pull(group_id, artifact_id, packaging='jar', version='LATEST', destination=nil, overrides={}, ssl_verify=true)
-        coordinates = build_coordinates(group_id, artifact_id, packaging, nil, version)
-        nexus_remote(overrides, ssl_verify).pull_artifact(coordinates, destination)
+      def pull(logger, group_id, artifact_id, packaging='jar', classifier=nil, version='LATEST', destination_path=nil, overrides={}, ssl_verify=true)
+        coordinates = build_coordinates(group_id, artifact_id, packaging, classifier, version)
+        pull_and_put_in_place(logger, coordinates, destination_path, is_ruby_plugin_and_should_skip_top_dir(group_id, artifact_id), overrides, ssl_verify)
       end
 
       def nexus_remote(overrides={}, ssl_verify=true)
@@ -18,13 +46,80 @@ module KPM
 
       def nexus_defaults
         {
-          url: 'https://repository.sonatype.org',
-          repository: 'central-proxy'
+            url:        'https://repository.sonatype.org',
+            repository: 'central-proxy'
         }
       end
 
       protected
 
+      def pull_and_put_in_place(logger, coordinates, destination_path=nil, skip_top_dir=true, overrides={}, ssl_verify=true)
+        destination_path = KPM::root if destination_path.nil?
+
+        # Create the destination directory
+        if path_looks_like_a_directory(destination_path)
+          destination_dir = destination_path
+        else
+          destination_dir = File.dirname(destination_path)
+        end
+        FileUtils.mkdir_p(destination_dir)
+
+        # Download the artifact in a temporary directory in case of failures
+        info = {}
+        Dir.mktmpdir do |tmp_destination_dir|
+          logger.info "      Starting download of #{coordinates} to #{tmp_destination_dir}"
+
+          info   = pull_and_verify(logger, coordinates, tmp_destination_dir, overrides, ssl_verify)
+
+          # Move the file to the final destination, unpacking if necessary
+          is_tgz = info[:file_path].end_with?('.tar.gz') || info[:file_path].end_with?('.tgz')
+          if is_tgz
+            Utils.unpack_tgz(info[:file_path], destination_path, skip_top_dir)
+            FileUtils.rm info[:file_path]
+          else
+            FileUtils.mv info[:file_path], destination_path
+          end
+
+          # Update the info hash with the real destination
+          if File.directory?(destination_path) && !is_tgz
+            destination = File.join(File.expand_path(destination_path), info[:file_name])
+          else
+            destination = destination_path
+          end
+          info[:file_path] = File.expand_path(destination)
+
+          if is_tgz
+            info[:file_name] = nil
+            info[:size]      = nil
+          else
+            info[:file_name] = File.basename(destination)
+          end
+
+          logger.info "Successful installation of #{coordinates} to #{info[:file_path]}"
+        end
+        info
+      end
+
+      def pull_and_verify(logger, coordinates, destination_dir, overrides={}, ssl_verify=true)
+        info = nexus_remote(overrides, ssl_verify).pull_artifact(coordinates, destination_dir)
+        raise ArtifactCorruptedException unless verify(logger, coordinates, info[:file_path], overrides, ssl_verify)
+        info
+      end
+
+      def verify(logger, coordinates, file_path, overrides={}, ssl_verify=true)
+        artifact_info = nexus_remote(overrides, ssl_verify).get_artifact_info(coordinates)
+        sha1_element  = REXML::Document.new(artifact_info).elements['//sha1']
+        # Can't check :(
+        if sha1_element.nil?
+          logger.warn("Unable to find sha1 in Nexus repo for #{coordinates}. Artifact info: #{artifact_info.inspect}")
+          return true
+        end
+
+        local_sha1 = Digest::SHA1.file(file_path).hexdigest
+        sha1       = sha1_element.text
+        local_sha1 == sha1
+      end
+
       def build_coordinates(group_id, artifact_id, packaging, classifier, version=nil)
         if classifier.nil?
           if version.nil?
@@ -40,6 +135,34 @@ module KPM
           end
         end
       end
+
+      # Magic methods...
+
+      def is_ruby_plugin_and_should_skip_top_dir(group_id, artifact_id)
+        # The second check is for custom ruby plugins
+        group_id == KILLBILL_RUBY_PLUGIN_GROUP_ID || artifact_id.include?('plugin')
+      end
+
+      def path_looks_like_a_directory(path)
+        # It already is!
+        return true if File.directory?(path)
+        # It already isn't!
+        return false if File.file?(path)
+
+        last_part = File.basename(path).downcase
+
+        %w(.pom .xml .war .jar .xsd .tar.gz .tgz .gz .zip).each do |classic_file_extension|
+          return false if last_part.end_with?(classic_file_extension)
+        end
+
+        # Known magic files
+        %w(root).each do |classic_filename|
+          return false if last_part == classic_filename
+        end
+
+        # Probably a directory
+        true
+      end
     end
   end
 end

data/lib/kpm/installer.rb

@@ -11,15 +11,18 @@ module KPM
 
     def initialize(raw_config, logger=nil)
       raise(ArgumentError, 'killbill or kaui section must be specified') if raw_config['killbill'].nil? and raw_config['kaui'].nil?
-      @config = raw_config['killbill']
+      @config      = raw_config['killbill']
       @kaui_config = raw_config['kaui']
 
       if logger.nil?
-        @logger = Logger.new(STDOUT)
+        @logger       = Logger.new(STDOUT)
         @logger.level = Logger::INFO
       else
         @logger = logger
       end
+
+      @nexus_config     = @config['nexus']
+      @nexus_ssl_verify = !@nexus_config.nil? ? @nexus_config['ssl_verify'] : true
     end
 
     def install
@@ -36,19 +39,14 @@ module KPM
     private
 
     def install_killbill_server
-      group_id = @config['group_id'] || BaseArtifact::KILLBILL_GROUP_ID
-      artifact_id = @config['artifact_id'] || KillbillServerArtifact::KILLBILL_ARTIFACT_ID
-      packaging = @config['packaging'] || KillbillServerArtifact::KILLBILL_PACKAGING
-      classifier = @config['classifier'] || KillbillServerArtifact::KILLBILL_CLASSIFIER
-      version = @config['version'] || LATEST_VERSION
+      group_id    = @config['group_id'] || KPM::BaseArtifact::KILLBILL_GROUP_ID
+      artifact_id = @config['artifact_id'] || KPM::BaseArtifact::KILLBILL_ARTIFACT_ID
+      packaging   = @config['packaging'] || KPM::BaseArtifact::KILLBILL_PACKAGING
+      classifier  = @config['classifier'] || KPM::BaseArtifact::KILLBILL_CLASSIFIER
+      version     = @config['version'] || LATEST_VERSION
       webapp_path = @config['webapp_path'] || KPM::root
 
-      webapp_dir = File.dirname(webapp_path)
-      FileUtils.mkdir_p(webapp_dir)
-
-      @logger.info "Installing Kill Bill server (#{group_id}:#{artifact_id}:#{packaging}:#{classifier}:#{version}) to #{webapp_path}"
-      file = KillbillServerArtifact.pull(group_id, artifact_id, packaging, classifier, version, webapp_dir, @config['nexus'], @config['nexus']['ssl_verify'])
-      FileUtils.mv file[:file_path], webapp_path
+      KPM::KillbillServerArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, webapp_path, @nexus_config, @nexus_ssl_verify)
     end
 
     def install_plugins
@@ -61,67 +59,67 @@ module KPM
     def install_java_plugins(bundles_dir)
       return if @config['plugins'].nil? or @config['plugins']['java'].nil?
 
+      infos = []
       @config['plugins']['java'].each do |plugin|
-        artifact_id = plugin['name']
-        version = plugin['version'] || LATEST_VERSION
+        group_id    = plugin['group_id'] || KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_GROUP_ID
+        artifact_id = plugin['artifact_id'] || plugin['name']
+        packaging   = plugin['packaging'] || KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_PACKAGING
+        classifier  = plugin['classifier'] || KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_CLASSIFIER
+        version     = plugin['version'] || LATEST_VERSION
         destination = "#{bundles_dir}/plugins/java/#{artifact_id}/#{version}"
 
-        FileUtils.mkdir_p(destination)
-
-        @logger.info "Installing Kill Bill Java plugin #{artifact_id} #{version} to #{destination}"
-        KillbillPluginArtifact.pull(artifact_id, version, :java, destination, @config['nexus'], @config['nexus']['ssl_verify'])
+        infos << KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, @nexus_config, @nexus_ssl_verify)
       end
+
+      infos
     end
 
     def install_ruby_plugins(bundles_dir)
       return if @config['plugins'].nil? or @config['plugins']['ruby'].nil?
 
+      infos = []
       @config['plugins']['ruby'].each do |plugin|
-        artifact_id = plugin['name']
-        version = plugin['version'] || LATEST_VERSION
+        group_id    = plugin['group_id'] || KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_GROUP_ID
+        artifact_id = plugin['artifact_id'] || plugin['name']
+        packaging   = plugin['packaging'] || KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_PACKAGING
+        classifier  = plugin['classifier'] || KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_CLASSIFIER
+        version     = plugin['version'] || LATEST_VERSION
         destination = "#{bundles_dir}/plugins/ruby"
 
-        FileUtils.mkdir_p(destination)
-
-        @logger.info "Installing Kill Bill Ruby plugin #{artifact_id} #{version} to #{destination}"
-        archive = KillbillPluginArtifact.pull(artifact_id, version, :ruby, destination, @config['nexus'], @config['nexus']['ssl_verify'])
-
-        Utils.unpack_tgz(archive[:file_path], destination, true)
-        FileUtils.rm archive[:file_path]
+        infos << KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, @nexus_config, @nexus_ssl_verify)
       end
+
+      infos
     end
 
     def install_default_bundles
       return if @config['default_bundles'] == false
 
-      group_id = 'org.kill-bill.billing'
+      group_id    = 'org.kill-bill.billing'
       artifact_id = 'killbill-platform-osgi-bundles-defaultbundles'
-      packaging = 'tar.gz'
-      version = @config['version'] || LATEST_VERSION
+      packaging   = 'tar.gz'
+      classifier  = nil
+      version     = @config['version'] || LATEST_VERSION
       destination = "#{@config['plugins_dir']}/platform"
 
-      FileUtils.mkdir_p(destination)
-
-      @logger.info "Installing Kill Bill #{artifact_id} #{version} to #{destination}"
-      archive = BaseArtifact.pull(group_id, artifact_id, packaging, version, destination, @config['nexus'], @config['nexus']['ssl_verify'])
-
-      Utils.unpack_tgz(archive[:file_path], destination)
-      FileUtils.rm archive[:file_path]
+      info = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, @nexus_config, @nexus_ssl_verify)
 
       # The special JRuby bundle needs to be called jruby.jar
+      # TODO .first - code smell
       File.rename Dir.glob("#{destination}/killbill-platform-osgi-bundles-jruby-*.jar").first, "#{destination}/jruby.jar"
+
+      info
     end
 
     def install_kaui
-      version = @kaui_config['version'] || LATEST_VERSION
+      group_id    = @kaui_config['group_id'] || KPM::BaseArtifact::KAUI_GROUP_ID
+      artifact_id = @kaui_config['artifact_id'] || KPM::BaseArtifact::KAUI_ARTIFACT_ID
+      packaging   = @kaui_config['packaging'] || KPM::BaseArtifact::KAUI_PACKAGING
+      classifier  = @kaui_config['classifier'] || KPM::BaseArtifact::KAUI_CLASSIFIER
+      version     = @kaui_config['version'] || LATEST_VERSION
       webapp_path = @kaui_config['webapp_path'] || KPM::root
 
-      webapp_dir = File.dirname(webapp_path)
-      FileUtils.mkdir_p(webapp_dir)
-
-      @logger.info "Installing Kaui #{version} to #{webapp_path}"
-      file = KauiArtifact.pull(version, webapp_dir, @kaui_config['nexus'], @kaui_config['nexus']['ssl_verify'])
-      FileUtils.mv file[:file_path], webapp_path
+      KPM::KauiArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, webapp_path, @nexus_config, @nexus_ssl_verify)
     end
   end
 end

data/lib/kpm/kaui_artifact.rb

@@ -4,16 +4,14 @@ require 'set'
 module KPM
   class KauiArtifact < BaseArtifact
     class << self
-      KAUI_WAR = "org.kill-bill.billing.kaui:kaui-standalone:war"
-
-      def pull(version='LATEST', destination=nil, overrides={}, ssl_verify=true)
-        nexus_remote(overrides, ssl_verify).pull_artifact("#{KAUI_WAR}:#{version}", destination)
-      end
-
       def versions(overrides={}, ssl_verify=true)
-        response = REXML::Document.new nexus_remote(overrides, ssl_verify).search_for_artifacts(KAUI_WAR)
-        versions = SortedSet.new
-        response.elements.each("search-results/data/artifact/version") { |element| versions << element.text }
+        coordinates = build_coordinates(KPM::BaseArtifact::KAUI_GROUP_ID,
+                                        KPM::BaseArtifact::KAUI_ARTIFACT_ID,
+                                        KPM::BaseArtifact::KAUI_PACKAGING,
+                                        KPM::BaseArtifact::KAUI_CLASSIFIER)
+        response    = REXML::Document.new nexus_remote(overrides, ssl_verify).search_for_artifacts(coordinates)
+        versions    = SortedSet.new
+        response.elements.each('search-results/data/artifact/version') { |element| versions << element.text }
         versions
       end
     end

data/lib/kpm/killbill_plugin_artifact.rb

@@ -4,27 +4,15 @@ require 'set'
 module KPM
   class KillbillPluginArtifact < BaseArtifact
     class << self
-      def pull(artifact_id, version='LATEST', type=:java, destination=nil, overrides={}, ssl_verify=true)
-        if type == :java
-          group_id = BaseArtifact::KILLBILL_JAVA_PLUGIN_GROUP_ID
-          packaging = 'jar'
-        else
-          group_id = BaseArtifact::KILLBILL_RUBY_PLUGIN_GROUP_ID
-          packaging = 'tar.gz'
-        end
-        coordinates = "#{group_id}:#{artifact_id}:#{packaging}:#{version}"
-        nexus_remote(overrides, ssl_verify).pull_artifact(coordinates, destination)
-      end
-
       def versions(overrides={}, ssl_verify=true)
-        plugins = { :java => {}, :ruby => {} }
+        plugins = {:java => {}, :ruby => {}}
 
         nexus = nexus_remote(overrides, ssl_verify)
 
-        [[:java, BaseArtifact::KILLBILL_JAVA_PLUGIN_GROUP_ID], [:ruby, BaseArtifact::KILLBILL_RUBY_PLUGIN_GROUP_ID]].each do |type_and_group_id|
+        [[:java, KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_GROUP_ID], [:ruby, KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_GROUP_ID]].each do |type_and_group_id|
           response = REXML::Document.new nexus.search_for_artifacts(type_and_group_id[1])
           response.elements.each('search-results/data/artifact') do |element|
-            artifact_id = element.elements['artifactId'].text
+            artifact_id                                = element.elements['artifactId'].text
             plugins[type_and_group_id[0]][artifact_id] ||= SortedSet.new
             plugins[type_and_group_id[0]][artifact_id] << element.elements['version'].text
           end

data/lib/kpm/killbill_server_artifact.rb

@@ -3,25 +3,12 @@ require 'set'
 
 module KPM
   class KillbillServerArtifact < BaseArtifact
-    KILLBILL_ARTIFACT_ID = 'killbill-profiles-killbill'
-    KILLBILL_PACKAGING   = 'war'
-    KILLBILL_CLASSIFIER  = 'jar-with-dependencies'
-
-    KILLPAY_ARTIFACT_ID = 'killbill-profiles-killpay'
-    KILLPAY_PACKAGING   = 'war'
-    KILLPAY_CLASSIFIER  = 'jar-with-dependencies'
-
     class << self
-      def pull(group_id, artifact_id, packaging=BaseArtifact::KILLBILL_PACKAGING, classifier=BaseArtifact::KILLBILL_CLASSIFIER, version='LATEST', destination=nil, overrides={}, ssl_verify=true)
-        coordinates = build_coordinates(group_id, artifact_id, packaging, classifier, version)
-        nexus_remote(overrides, ssl_verify).pull_artifact(coordinates, destination)
-      end
-
-      def versions(group_id, artifact_id, packaging=BaseArtifact::KILLBILL_PACKAGING, classifier=BaseArtifact::KILLBILL_CLASSIFIER, overrides={}, ssl_verify=true)
-        coordinates = build_coordinates(group_id, artifact_id, packaging, classifier)
-        response = REXML::Document.new nexus_remote(overrides, ssl_verify).search_for_artifacts(coordinates)
-        versions = SortedSet.new
-        response.elements.each("search-results/data/artifact/version") { |element| versions << element.text }
+      def versions(artifact_id, packaging=KPM::BaseArtifact::KILLBILL_PACKAGING, classifier=KPM::BaseArtifact::KILLBILL_CLASSIFIER, overrides={}, ssl_verify=true)
+        coordinates = build_coordinates(KPM::BaseArtifact::KILLBILL_GROUP_ID, artifact_id, packaging, classifier)
+        response    = REXML::Document.new nexus_remote(overrides, ssl_verify).search_for_artifacts(coordinates)
+        versions    = SortedSet.new
+        response.elements.each('search-results/data/artifact/version') { |element| versions << element.text }
         versions
       end
     end

data/lib/kpm/tasks.rb

@@ -1,4 +1,5 @@
 require 'highline'
+require 'logger'
 require 'thor'
 
 module KPM
@@ -8,71 +9,111 @@ module KPM
       base.class_eval do
 
         class_option :overrides,
-                     :type => :hash,
+                     :type    => :hash,
                      :default => nil,
-                     :desc => "A hashed list of overrides. Available options are 'url', 'repository', 'username', and 'password'."
+                     :desc    => "A hashed list of overrides. Available options are 'url', 'repository', 'username', and 'password'."
 
         class_option :ssl_verify,
-                     :type => :boolean,
+                     :type    => :boolean,
                      :default => true,
-                     :desc => "Set to false to disable SSL Verification."
+                     :desc    => 'Set to false to disable SSL Verification.'
 
-        desc "install config_file", "Install Kill Bill server and plugins according to the specified YAML configuration file."
+        desc 'install config_file', 'Install Kill Bill server and plugins according to the specified YAML configuration file.'
         def install(config_file)
           Installer.from_file(config_file).install
         end
 
         method_option :destination,
-                      :type => :string,
+                      :type    => :string,
                       :default => nil,
-                      :desc => "A different folder other than the current working directory."
-        desc "pull_kb_server_war version", "Pulls Kill Bill server war from Sonatype and places it on your machine."
+                      :desc    => 'A different folder other than the current working directory.'
+        desc 'pull_kb_server_war version', 'Pulls Kill Bill server war from Sonatype and places it on your machine.'
         def pull_kb_server_war(version='LATEST')
-          response = KillbillServerArtifact.pull(BaseArtifact::KILLBILL_GROUP_ID, KillbillServerArtifact::KILLBILL_ARTIFACT_ID, KillbillServerArtifact::KILLBILL_PACKAGING, KillbillServerArtifact::KILLBILL_CLASSIFIER, version, options[:destination], options[:overrides], options[:ssl_verify])
+          response = KillbillServerArtifact.pull(logger,
+                                                 KillbillServerArtifact::KILLBILL_GROUP_ID,
+                                                 KillbillServerArtifact::KILLBILL_ARTIFACT_ID,
+                                                 KillbillServerArtifact::KILLBILL_PACKAGING,
+                                                 KillbillServerArtifact::KILLBILL_CLASSIFIER,
+                                                 version,
+                                                 options[:destination],
+                                                 options[:overrides],
+                                                 options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
         end
 
-        desc "search_for_kb_server", "Searches for all versions of Kill Bill server and prints them to the screen."
+        desc 'search_for_kb_server', 'Searches for all versions of Kill Bill server and prints them to the screen.'
         def search_for_kb_server
-          say "Available versions: #{KillbillServerArtifact.versions(BaseArtifact::KILLBILL_GROUP_ID, KillbillServerArtifact::KILLBILL_ARTIFACT_ID, KillbillServerArtifact::KILLBILL_PACKAGING, KillbillServerArtifact::KILLBILL_CLASSIFIER, options[:overrides], options[:ssl_verify]).to_a.join(', ')}", :green
+          say "Available versions: #{KillbillServerArtifact.versions(KillbillServerArtifact::KILLBILL_ARTIFACT_ID,
+                                                                     KillbillServerArtifact::KILLBILL_PACKAGING,
+                                                                     KillbillServerArtifact::KILLBILL_CLASSIFIER,
+                                                                     options[:overrides],
+                                                                     options[:ssl_verify]).to_a.join(', ')}", :green
         end
 
         method_option :destination,
-                      :type => :string,
+                      :type    => :string,
                       :default => nil,
-                      :desc => "A different folder other than the current working directory."
-        desc "pull_kp_server_war version", "Pulls Kill Pay server war from Sonatype and places it on your machine."
+                      :desc    => 'A different folder other than the current working directory.'
+        desc 'pull_kp_server_war version', 'Pulls Kill Pay server war from Sonatype and places it on your machine.'
         def pull_kp_server_war(version='LATEST')
-          response = KillbillServerArtifact.pull(BaseArtifact::KILLBILL_GROUP_ID, KillbillServerArtifact::KILLPAY_ARTIFACT_ID, KillbillServerArtifact::KILLPAY_PACKAGING, KillbillServerArtifact::KILLPAY_CLASSIFIER, version, options[:destination], options[:overrides], options[:ssl_verify])
+          response = KillbillServerArtifact.pull(logger,
+                                                 KillbillServerArtifact::KILLBILL_GROUP_ID,
+                                                 KillbillServerArtifact::KILLPAY_ARTIFACT_ID,
+                                                 KillbillServerArtifact::KILLPAY_PACKAGING,
+                                                 KillbillServerArtifact::KILLPAY_CLASSIFIER,
+                                                 version,
+                                                 options[:destination],
+                                                 options[:overrides],
+                                                 options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
         end
 
-        desc "search_for_kp_server", "Searches for all versions of Kill Pay server and prints them to the screen."
+        desc 'search_for_kp_server', 'Searches for all versions of Kill Pay server and prints them to the screen.'
         def search_for_kp_server
-          say "Available versions: #{KillbillServerArtifact.versions(BaseArtifact::KILLBILL_GROUP_ID, KillbillServerArtifact::KILLPAY_ARTIFACT_ID, KillbillServerArtifact::KILLPAY_PACKAGING, KillbillServerArtifact::KILLPAY_CLASSIFIER, options[:overrides], options[:ssl_verify]).to_a.join(', ')}", :green
+          say "Available versions: #{KillbillServerArtifact.versions(KillbillServerArtifact::KILLPAY_ARTIFACT_ID,
+                                                                     KillbillServerArtifact::KILLPAY_PACKAGING,
+                                                                     KillbillServerArtifact::KILLPAY_CLASSIFIER,
+                                                                     options[:overrides],
+                                                                     options[:ssl_verify]).to_a.join(', ')}", :green
         end
 
         method_option :destination,
-                      :type => :string,
+                      :type    => :string,
                       :default => nil,
-                      :desc => "A different folder other than the current working directory."
-        desc "pull_java_plugin artifact_id", "Pulls a java plugin from Sonatype and places it on your machine."
+                      :desc    => 'A different folder other than the current working directory.'
+        desc 'pull_java_plugin artifact_id', 'Pulls a java plugin from Sonatype and places it on your machine.'
         def pull_java_plugin(artifact_id, version='LATEST')
-          response = KillbillPluginArtifact.pull(artifact_id, version, :java, options[:destination], options[:overrides], options[:ssl_verify])
+          response = KillbillPluginArtifact.pull(logger,
+                                                 KillbillPluginArtifact::KILLBILL_JAVA_PLUGIN_GROUP_ID,
+                                                 artifact_id,
+                                                 KillbillPluginArtifact::KILLBILL_JAVA_PLUGIN_PACKAGING,
+                                                 KillbillPluginArtifact::KILLBILL_JAVA_PLUGIN_CLASSIFIER,
+                                                 version,
+                                                 options[:destination],
+                                                 options[:overrides],
+                                                 options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
         end
 
         method_option :destination,
-                      :type => :string,
+                      :type    => :string,
                       :default => nil,
-                      :desc => "A different folder other than the current working directory."
-        desc "pull_ruby_plugin artifact_id", "Pulls a ruby plugin from Sonatype and places it on your machine."
+                      :desc    => 'A different folder other than the current working directory.'
+        desc 'pull_ruby_plugin artifact_id', 'Pulls a ruby plugin from Sonatype and places it on your machine.'
         def pull_ruby_plugin(artifact_id, version='LATEST')
-          response = KillbillPluginArtifact.pull(artifact_id, version, :ruby, options[:destination], options[:overrides], options[:ssl_verify])
+          response = KillbillPluginArtifact.pull(logger,
+                                                 KillbillPluginArtifact::KILLBILL_RUBY_PLUGIN_GROUP_ID,
+                                                 artifact_id,
+                                                 KillbillPluginArtifact::KILLBILL_RUBY_PLUGIN_PACKAGING,
+                                                 KillbillPluginArtifact::KILLBILL_RUBY_PLUGIN_CLASSIFIER,
+                                                 version,
+                                                 options[:destination],
+                                                 options[:overrides],
+                                                 options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
         end
 
-        desc "search_for_plugins", "Searches for all available plugins and prints them to the screen."
+        desc 'search_for_plugins', 'Searches for all available plugins and prints them to the screen.'
         def search_for_plugins
           all_plugins = KillbillPluginArtifact.versions(options[:overrides], options[:ssl_verify])
 
@@ -88,19 +129,35 @@ module KPM
         end
 
         method_option :destination,
-                      :type => :string,
+                      :type    => :string,
                       :default => nil,
-                      :desc => "A different folder other than the current working directory."
-        desc "pull_kaui_war version", "Pulls Kaui war from Sonatype and places it on your machine."
+                      :desc    => 'A different folder other than the current working directory.'
+        desc 'pull_kaui_war version', 'Pulls Kaui war from Sonatype and places it on your machine.'
         def pull_kaui_war(version='LATEST')
-          response = KauiArtifact.pull(version, options[:destination], options[:overrides], options[:ssl_verify])
+          response = KauiArtifact.pull(logger,
+                                       KauiArtifact::KAUI_GROUP_ID,
+                                       KauiArtifact::KAUI_ARTIFACT_ID,
+                                       KauiArtifact::KAUI_PACKAGING,
+                                       KauiArtifact::KAUI_CLASSIFIER,
+                                       version,
+                                       options[:destination],
+                                       options[:overrides],
+                                       options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
         end
 
-        desc "search_for_kaui", "Searches for all versions of Kaui and prints them to the screen."
+        desc 'search_for_kaui', 'Searches for all versions of Kaui and prints them to the screen.'
         def search_for_kaui
           say "Available versions: #{KauiArtifact.versions(options[:overrides], options[:ssl_verify]).to_a.join(', ')}", :green
         end
+
+        private
+
+        def logger
+          logger       = ::Logger.new(STDOUT)
+          logger.level = Logger::INFO
+          logger
+        end
       end
     end
   end

data/lib/kpm/version.rb

@@ -1,3 +1,3 @@
 module KPM
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/spec/kpm/remote/base_artifact_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+
+describe KPM::BaseArtifact do
+
+  before(:all) do
+    @logger       = Logger.new(STDOUT)
+    @logger.level = Logger::INFO
+  end
+
+  it 'should be able to download and verify regular artifacts' do
+    Dir.mktmpdir do |dir|
+      test_download dir, 'foo-oss.pom.xml'
+    end
+
+    Dir.mktmpdir do |dir|
+      test_download dir
+    end
+  end
+
+  # This test makes sure the top level directory is correctly skipped
+  it 'should be able to download and verify .tar.gz ruby artifacts' do
+    # Use the payment-test-plugin as a test, as it is fairly small (2.5M)
+    group_id    = 'org.kill-bill.billing.plugin.ruby'
+    artifact_id = 'payment-test-plugin'
+    packaging   = 'tar.gz'
+    classifier  = nil
+    version     = '1.8.7'
+
+    Dir.mktmpdir do |dir|
+      info = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, dir)
+      info[:file_name].should be_nil
+
+      files_in_dir = Dir[info[:file_path] + '/*']
+      files_in_dir.size.should == 1
+      files_in_dir[0].should == info[:file_path] + '/killbill-payment-test'
+
+      File.read(info[:file_path] + '/killbill-payment-test/1.8.7/killbill.properties').should == "mainClass=PaymentTest::PaymentPlugin\nrequire=payment_test\npluginType=PAYMENT\n"
+    end
+  end
+
+  it 'should be able to download and verify generic .tar.gz artifacts' do
+    # The artifact is not small unfortunately (23.7M)
+    group_id    = 'org.kill-bill.billing'
+    artifact_id = 'killbill-osgi-bundles-defaultbundles'
+    packaging   = 'tar.gz'
+    classifier  = nil
+    version     = '0.11.3'
+
+    Dir.mktmpdir do |dir|
+      info = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, dir)
+      info[:file_name].should be_nil
+
+      files_in_dir = Dir[info[:file_path] + '/*']
+      files_in_dir.size.should == 20
+
+      File.file?(info[:file_path] + '/killbill-osgi-bundles-jruby-0.11.3.jar').should be_true
+    end
+  end
+
+  def test_download(dir, filename=nil)
+    path = filename.nil? ? dir : dir + '/' + filename
+    info = KPM::BaseArtifact.pull(@logger, 'org.kill-bill.billing', 'killbill-oss-parent', 'pom', nil, 'LATEST', path)
+    info[:file_name].should == (filename.nil? ? "killbill-oss-parent-#{info[:version]}.pom" : filename)
+    info[:size].should == File.size(info[:file_path])
+  end
+end

data/spec/kpm/remote/installer_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+describe KPM::Installer do
+
+  before(:all) do
+    @logger       = Logger.new(STDOUT)
+    @logger.level = Logger::INFO
+  end
+
+  it 'should be able to install all artifacts' do
+    Dir.mktmpdir do |dir|
+      kb_webapp_path   = dir + '/KB_ROOT.war'
+      kaui_webapp_path = dir + '/KAUI_ROOT.war'
+      plugins_dir      = dir + '/bundles'
+      installer        = KPM::Installer.new({
+                                                'killbill' => {
+                                                    'webapp_path' => kb_webapp_path,
+                                                    'plugins_dir' => plugins_dir,
+                                                    'plugins'     => {
+                                                        'java' => [{
+                                                                       'name'    => 'analytics-plugin',
+                                                                       'version' => '0.7.1'
+                                                                   }],
+                                                        'ruby' => [{
+                                                                       'name'    => 'payment-test-plugin',
+                                                                       'version' => '1.8.7'
+                                                                   }]
+                                                    },
+                                                },
+                                                'kaui'     => {
+                                                    'webapp_path' => kaui_webapp_path
+                                                }
+
+                                            },
+                                            @logger)
+
+      installer.install
+
+      [
+          plugins_dir,
+          plugins_dir + '/platform',
+          plugins_dir + '/plugins',
+          plugins_dir + '/plugins/java',
+          plugins_dir + '/plugins/java/analytics-plugin',
+          plugins_dir + '/plugins/java/analytics-plugin/0.7.1',
+          plugins_dir + '/plugins/ruby',
+          plugins_dir + '/plugins/ruby/killbill-payment-test',
+          plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7'
+      ].each do |dir|
+        File.directory?(dir).should be_true
+      end
+
+      [
+          kb_webapp_path,
+          kaui_webapp_path,
+          plugins_dir + '/platform/jruby.jar',
+          plugins_dir + '/plugins/java/analytics-plugin/0.7.1/analytics-plugin-0.7.1.jar',
+          plugins_dir + '/plugins/ruby/killbill-payment-test/1.8.7/killbill.properties'
+      ].each do |file|
+        File.file?(file).should be_true
+      end
+    end
+  end
+end

data/spec/kpm/remote/kaui_artifact_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe KPM::KillbillPluginArtifact do
+
+  before(:all) do
+    @logger       = Logger.new(STDOUT)
+    @logger.level = Logger::INFO
+  end
+
+  it 'should be able to download and verify artifacts' do
+    Dir.mktmpdir do |dir|
+      info = KPM::KauiArtifact.pull(@logger,
+                                    KPM::BaseArtifact::KAUI_GROUP_ID,
+                                    KPM::BaseArtifact::KAUI_ARTIFACT_ID,
+                                    KPM::BaseArtifact::KAUI_PACKAGING,
+                                    KPM::BaseArtifact::KAUI_CLASSIFIER,
+                                    'LATEST',
+                                    dir)
+      info[:file_name].should == "kaui-standalone-#{info[:version]}.war"
+      info[:size].should == File.size(info[:file_path])
+    end
+  end
+
+  it 'should be able to list versions' do
+    versions = KPM::KauiArtifact.versions.to_a
+    versions.size.should >= 2
+    versions[0].should == '0.0.1'
+    versions[1].should == '0.0.2'
+  end
+end

data/spec/kpm/remote/killbill_plugin_artifact_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe KPM::KillbillPluginArtifact do
+
+  before(:all) do
+    @logger       = Logger.new(STDOUT)
+    @logger.level = Logger::INFO
+  end
+
+  it 'should be able to download and verify artifacts' do
+    Dir.mktmpdir do |dir|
+      info = KPM::KillbillPluginArtifact.pull(@logger,
+                                              KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_GROUP_ID,
+                                              'analytics-plugin',
+                                              KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_PACKAGING,
+                                              KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_CLASSIFIER,
+                                              'LATEST',
+                                              dir)
+      info[:file_name].should == "analytics-plugin-#{info[:version]}.jar"
+      info[:size].should == File.size(info[:file_path])
+    end
+
+    Dir.mktmpdir do |dir|
+      info = KPM::KillbillPluginArtifact.pull(@logger,
+                                              KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_GROUP_ID,
+                                              'logging-plugin',
+                                              KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_PACKAGING,
+                                              KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_CLASSIFIER,
+                                              'LATEST',
+                                              dir)
+
+      # No file name - since we untar'ed it
+      info[:file_name].should be_nil
+    end
+  end
+
+  it 'should be able to list versions' do
+    versions = KPM::KillbillPluginArtifact.versions
+
+    versions[:java].should_not be_nil
+    versions[:java]['analytics-plugin'].should_not be_nil
+    logging_plugin_versions = versions[:java]['analytics-plugin'].to_a
+    logging_plugin_versions.size.should >= 3
+    logging_plugin_versions[0].should == '0.6.0'
+    logging_plugin_versions[1].should == '0.7.0'
+    logging_plugin_versions[2].should == '0.7.1'
+
+    versions[:ruby].should_not be_nil
+    versions[:ruby]['logging-plugin'].should_not be_nil
+    logging_plugin_versions = versions[:ruby]['logging-plugin'].to_a
+    logging_plugin_versions.size.should >= 1
+    logging_plugin_versions[0].should == '1.7.0'
+  end
+end

data/spec/kpm/remote/killbill_server_artifact_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe KPM::KillbillServerArtifact do
+
+  before(:all) do
+    @logger       = Logger.new(STDOUT)
+    @logger.level = Logger::INFO
+  end
+
+  # Takes about 7 minutes...
+  it 'should be able to download and verify artifacts' do
+    Dir.mktmpdir do |dir|
+      info = KPM::KillbillServerArtifact.pull(@logger,
+                                              KPM::BaseArtifact::KILLBILL_GROUP_ID,
+                                              KPM::BaseArtifact::KILLBILL_ARTIFACT_ID,
+                                              KPM::BaseArtifact::KILLBILL_PACKAGING,
+                                              KPM::BaseArtifact::KILLBILL_CLASSIFIER,
+                                              'LATEST',
+                                              dir)
+      info[:file_name].should == "killbill-profiles-killbill-#{info[:version]}-jar-with-dependencies.war"
+      info[:size].should == File.size(info[:file_path])
+    end
+  end
+
+  it 'should be able to list versions' do
+    versions = KPM::KillbillServerArtifact.versions(KPM::BaseArtifact::KILLBILL_ARTIFACT_ID).to_a
+    versions.size.should >= 2
+    versions[0].should == '0.11.5'
+    versions[1].should == '0.11.6'
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,10 @@
+require 'tmpdir'
+require 'kpm'
+require 'logger'
+require 'rspec'
+
+RSpec.configure do |config|
+  config.color_enabled = true
+  config.tty           = true
+  config.formatter     = 'documentation'
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kpm
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-10 00:00:00.000000000 Z
+date: 2014-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -104,6 +104,12 @@ files:
 - lib/kpm/tasks.rb
 - lib/kpm/utils.rb
 - lib/kpm/version.rb
+- spec/kpm/remote/base_artifact_spec.rb
+- spec/kpm/remote/installer_spec.rb
+- spec/kpm/remote/kaui_artifact_spec.rb
+- spec/kpm/remote/killbill_plugin_artifact_spec.rb
+- spec/kpm/remote/killbill_server_artifact_spec.rb
+- spec/spec_helper.rb
 homepage: http://kill-bill.org
 licenses:
 - Apache License (2.0)
@@ -130,4 +136,10 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Kill Bill package manager.
-test_files: []
+test_files:
+- spec/kpm/remote/base_artifact_spec.rb
+- spec/kpm/remote/installer_spec.rb
+- spec/kpm/remote/kaui_artifact_spec.rb
+- spec/kpm/remote/killbill_plugin_artifact_spec.rb
+- spec/kpm/remote/killbill_server_artifact_spec.rb
+- spec/spec_helper.rb