kpm 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db96b11608798cde3ec2a9dfd2efaa308454f4e4
-  data.tar.gz: 61338181fe1bdf34b9c1cd94b13bd7b44478034c
+  metadata.gz: 7bd75221bd8f34ed62f708280f0daf46b888d9c4
+  data.tar.gz: 524193c742b657dd1df0a613327746a920b66303
 SHA512:
-  metadata.gz: 03cf860cb590f67dbd904e8b26f77f7d479289b7c1a8c62bf623505736925f3e58bd8b5811f8c096103f71d17834d234d379668e891575c57612e4a13258cd42
-  data.tar.gz: c1eced6bfdef0b4003a7f0ba6bfc612e5702d10b0fc3fb2e5993e89e3cf39d3d0d6981e0668c79ee084c5a56c6daf9d75282ff207df3f7a5c4bffda80597915b
+  metadata.gz: bca02c62a3a8eaa29d2633515d5e0fe8155e48d743981437ee069333b06db82018862eba5d4845aad89a7f0dc849533393908a7de717b5bd3559287baa0d52cc
+  data.tar.gz: a476e9358742d977dcdcd1f5e878ad2e0806274ac9548f48372859432c82e1bc90bb8f8cce73532f5eae29200e812634d5b7e28a362fb3dbf94b93594e30e1a9

data/README.md

@@ -0,0 +1,50 @@
+KPM: the Kill Bill Package Manager
+==================================
+
+The goal of KPM is to facilitate the installation of Kill Bill and its plugins.
+
+kpm can be used interactively to search and download individual artifacts (Kill Bill war, plugins, etc.) or to perform an automatic Kill Bill installation using a configuration file.
+
+Installation
+------------
+
+    gem install kpm
+
+Ruby 2.1+ or JRuby 1.7.11+ is recommended.
+
+Quick start
+-----------
+
+Create a kpm.yml file as follows:
+
+    killbill:
+      version: 0.12.1
+      webapp_path: /opt/tomcat/webapps/ROOT
+      plugins_dir: /var/tmp/bundles
+      plugins:
+        java:
+          - name: analytics-plugin
+            version: 0.7.2
+        ruby:
+          - name: stripe-plugin
+            version: 0.2.1
+    kaui:
+      version: LATEST
+      webapp_path: /opt/tomcat/webapps/kaui
+
+This instructs kpm to:
+* Download the Kill Bill war (version 0.12.1) and install it as `/opt/tomcat/webapps/ROOT`
+* Setup the Analytics (Java) plugin (version 0.7.2) and the Stripe (Ruby) plugin (version 0.2.1) under `/var/tmp/bundles`
+* Download the latest Kaui war and install it as `/opt/tomcat/webapps/kaui`
+
+To start the installation:
+
+    kpm install kpm.yml
+
+To help you with discovery of plugins, you can run
+
+    kpm search_for_plugins
+
+This will list available (official) plugins. We maintain a list of recommended versions to use at https://github.com/killbill/killbill-cloud/blob/master/kpm/lib/kpm/plugins_directory.yml.
+
+There are more advanced commands and options available, just run `kpm --help` for details.

data/lib/kpm.rb

@@ -1,6 +1,7 @@
 module KPM
   autoload :Utils, 'kpm/utils'
   autoload :BaseArtifact, 'kpm/base_artifact'
+  autoload :Sha1Checker, 'kpm/sha1_checker'
   autoload :KillbillServerArtifact, 'kpm/killbill_server_artifact'
   autoload :KillbillPluginArtifact, 'kpm/killbill_plugin_artifact'
   autoload :KauiArtifact, 'kpm/kaui_artifact'

data/lib/kpm/base_artifact.rb

@@ -35,9 +35,9 @@ module KPM
     KAUI_CLASSIFIER  = nil
 
     class << self
-      def pull(logger, group_id, artifact_id, packaging='jar', classifier=nil, version='LATEST', destination_path=nil, overrides={}, ssl_verify=true)
+      def pull(logger, group_id, artifact_id, packaging='jar', classifier=nil, version='LATEST', destination_path=nil, sha1_file=nil, force_download=false,  overrides={}, ssl_verify=true)
         coordinates = build_coordinates(group_id, artifact_id, packaging, classifier, version)
-        pull_and_put_in_place(logger, coordinates, destination_path, is_ruby_plugin_and_should_skip_top_dir(group_id, artifact_id), overrides, ssl_verify)
+        pull_and_put_in_place(logger, coordinates, destination_path, is_ruby_plugin_and_should_skip_top_dir(group_id, artifact_id), sha1_file, force_download, overrides, ssl_verify)
       end
 
       def nexus_remote(overrides={}, ssl_verify=true)
@@ -53,7 +53,7 @@ module KPM
 
       protected
 
-      def pull_and_put_in_place(logger, coordinates, destination_path=nil, skip_top_dir=true, overrides={}, ssl_verify=true)
+      def pull_and_put_in_place(logger, coordinates, destination_path=nil, skip_top_dir=true, sha1_file=nil, force_download=false, overrides={}, ssl_verify=true)
         destination_path = KPM::root if destination_path.nil?
 
         # Create the destination directory
@@ -64,60 +64,103 @@ module KPM
         end
         FileUtils.mkdir_p(destination_dir)
 
+        # Build artifact info
+        artifact_info = artifact_info(coordinates, destination_path, overrides, ssl_verify)
+        if !force_download && skip_if_exists(artifact_info, coordinates, sha1_file)
+          logger.info "Skipping installation of #{coordinates} to #{artifact_info[:file_path]}, file already exists"
+          artifact_info[:skipped] = true
+          return artifact_info
+        end
+
         # Download the artifact in a temporary directory in case of failures
-        info = {}
         Dir.mktmpdir do |tmp_destination_dir|
           logger.info "      Starting download of #{coordinates} to #{tmp_destination_dir}"
 
-          info   = pull_and_verify(logger, coordinates, tmp_destination_dir, overrides, ssl_verify)
-
-          # Move the file to the final destination, unpacking if necessary
-          is_tgz = info[:file_path].end_with?('.tar.gz') || info[:file_path].end_with?('.tgz')
-          if is_tgz
-            Utils.unpack_tgz(info[:file_path], destination_path, skip_top_dir)
-            FileUtils.rm info[:file_path]
+          downloaded_artifact_info  = pull_and_verify(logger, artifact_info[:sha1], coordinates, tmp_destination_dir, sha1_file, overrides, ssl_verify)
+          if artifact_info[:is_tgz]
+            Utils.unpack_tgz(downloaded_artifact_info[:file_path], destination_path, skip_top_dir)
+            FileUtils.rm downloaded_artifact_info[:file_path]
           else
-            FileUtils.mv info[:file_path], destination_path
+            FileUtils.mv downloaded_artifact_info[:file_path], destination_path
+            artifact_info[:size] = downloaded_artifact_info[:size]
           end
+          logger.info "Successful installation of #{coordinates} to #{artifact_info[:file_path]}"
+        end
+        artifact_info
+      end
 
-          # Update the info hash with the real destination
-          if File.directory?(destination_path) && !is_tgz
-            destination = File.join(File.expand_path(destination_path), info[:file_name])
-          else
-            destination = destination_path
-          end
-          info[:file_path] = File.expand_path(destination)
+      def skip_if_exists(artifact_info, coordinates, sha1_file)
 
-          if is_tgz
-            info[:file_name] = nil
-            info[:size]      = nil
-          else
-            info[:file_name] = File.basename(destination)
-          end
+        # Unclear if this is even possible
+        return false if artifact_info[:sha1].nil?
+
+        # Check entry in sha1_file if exists
+        if sha1_file && File.exists?(sha1_file)
+          sha1_checker = Sha1Checker.from_file(sha1_file)
+          local_sha1 = sha1_checker.sha1(coordinates)
+          return true if local_sha1 == artifact_info[:sha1]
+        end
 
-          logger.info "Successful installation of #{coordinates} to #{info[:file_path]}"
+        # If not using sha1_file mechanism, exit early if file_path odes not exist or is a directory
+        if !File.exists?(artifact_info[:file_path]) ||
+            File.directory?(artifact_info[:file_path])
+          return false
         end
+
+        # Finally check if remote_sha1 matches what we have locally
+        local_sha1 = Digest::SHA1.file(artifact_info[:file_path]).hexdigest
+        local_sha1 == artifact_info[:sha1]
+      end
+
+
+      def artifact_info(coordinates, destination_path, overrides={}, ssl_verify=true)
+
+        info = {}
+        nexus_info = nexus_remote(overrides, ssl_verify).get_artifact_info(coordinates)
+
+        xml = REXML::Document.new(nexus_info)
+        repository_path = xml.elements['//repositoryPath'].text unless xml.elements['//repositoryPath'].nil?
+        sha1 = xml.elements['//sha1'].text unless xml.elements['//sha1'].nil?
+        version = xml.elements['//version'].text unless xml.elements['//version'].nil?
+
+        info[:sha1] = sha1
+        info[:version] = version
+        info[:is_tgz] = repository_path.end_with?('.tar.gz') || repository_path.end_with?('.tgz')
+        if File.directory?(destination_path) && !info[:is_tgz]
+          destination = File.join(File.expand_path(destination_path), File.basename(repository_path))
+          info[:file_name] = File.basename(repository_path)
+        else
+          # The destination was a fully specified path or this is an archive and we keep the directory
+          destination = destination_path
+          info[:file_name] = File.basename(destination_path) if !info[:is_tgz]
+        end
+        info[:file_path] = File.expand_path(destination)
+        info[:skipped] = false
         info
       end
 
-      def pull_and_verify(logger, coordinates, destination_dir, overrides={}, ssl_verify=true)
+
+      def pull_and_verify(logger, remote_sha1, coordinates, destination_dir, sha1_file, overrides={}, ssl_verify=true)
         info = nexus_remote(overrides, ssl_verify).pull_artifact(coordinates, destination_dir)
-        raise ArtifactCorruptedException unless verify(logger, coordinates, info[:file_path], overrides, ssl_verify)
+        raise ArtifactCorruptedException unless verify(logger, info[:file_path], remote_sha1)
+
+        if sha1_file
+          sha1_checker = Sha1Checker.from_file(sha1_file)
+          sha1_checker.add_or_modify_entry!(coordinates, remote_sha1)
+        end
+
         info
       end
 
-      def verify(logger, coordinates, file_path, overrides={}, ssl_verify=true)
-        artifact_info = nexus_remote(overrides, ssl_verify).get_artifact_info(coordinates)
-        sha1_element  = REXML::Document.new(artifact_info).elements['//sha1']
+      def verify(logger, file_path, remote_sha1)
         # Can't check :(
-        if sha1_element.nil?
-          logger.warn("Unable to find sha1 in Nexus repo for #{coordinates}. Artifact info: #{artifact_info.inspect}")
+        if remote_sha1.nil?
+          logger.warn("Unable to verify sha1 for #{coordinates}. Artifact info: #{artifact_info.inspect}")
           return true
         end
 
         local_sha1 = Digest::SHA1.file(file_path).hexdigest
-        sha1       = sha1_element.text
-        local_sha1 == sha1
+        local_sha1 == remote_sha1
       end
 
       def build_coordinates(group_id, artifact_id, packaging, classifier, version=nil)

data/lib/kpm/installer.rb

@@ -4,6 +4,7 @@ require 'yaml'
 module KPM
   class Installer
     LATEST_VERSION = 'LATEST'
+    SHA1_FILENAME = 'sha1.yml'
 
     def self.from_file(config_path, logger=nil)
       Installer.new(YAML::load_file(config_path), logger)
@@ -25,7 +26,7 @@ module KPM
       @nexus_ssl_verify = !@nexus_config.nil? ? @nexus_config['ssl_verify'] : true
     end
 
-    def install
+    def install(force_download=false)
       unless @config.nil?
         install_killbill_server
         install_plugins
@@ -34,6 +35,7 @@ module KPM
       unless @kaui_config.nil?
         install_kaui
       end
+      @force_download = force_download
     end
 
     private
@@ -46,12 +48,11 @@ module KPM
       version     = @config['version'] || LATEST_VERSION
       webapp_path = @config['webapp_path'] || KPM::root
 
-      KPM::KillbillServerArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, webapp_path, @nexus_config, @nexus_ssl_verify)
+      KPM::KillbillServerArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, webapp_path, nil, @force_download, @nexus_config, @nexus_ssl_verify)
     end
 
     def install_plugins
       bundles_dir = @config['plugins_dir']
-
       install_java_plugins(bundles_dir)
       install_ruby_plugins(bundles_dir)
     end
@@ -67,8 +68,9 @@ module KPM
         classifier  = plugin['classifier'] || KPM::BaseArtifact::KILLBILL_JAVA_PLUGIN_CLASSIFIER
         version     = plugin['version'] || LATEST_VERSION
         destination = "#{bundles_dir}/plugins/java/#{artifact_id}/#{version}"
+        sha1_file = "#{bundles_dir}/#{SHA1_FILENAME}"
 
-        infos << KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, @nexus_config, @nexus_ssl_verify)
+        infos << KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, sha1_file, @force_download, @nexus_config, @nexus_ssl_verify)
       end
 
       infos
@@ -85,8 +87,9 @@ module KPM
         classifier  = plugin['classifier'] || KPM::BaseArtifact::KILLBILL_RUBY_PLUGIN_CLASSIFIER
         version     = plugin['version'] || LATEST_VERSION
         destination = "#{bundles_dir}/plugins/ruby"
+        sha1_file = "#{bundles_dir}/#{SHA1_FILENAME}"
 
-        infos << KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, @nexus_config, @nexus_ssl_verify)
+        infos << KPM::KillbillPluginArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, sha1_file, @force_download, @nexus_config, @nexus_ssl_verify)
       end
 
       infos
@@ -102,7 +105,7 @@ module KPM
       version     = @config['default_bundles_version'] || LATEST_VERSION
       destination = "#{@config['plugins_dir']}/platform"
 
-      info = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, @nexus_config, @nexus_ssl_verify)
+      info = KPM::BaseArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, destination, nil, @force_download, @nexus_config, @nexus_ssl_verify)
 
       # The special JRuby bundle needs to be called jruby.jar
       # TODO .first - code smell
@@ -119,7 +122,7 @@ module KPM
       version     = @kaui_config['version'] || LATEST_VERSION
       webapp_path = @kaui_config['webapp_path'] || KPM::root
 
-      KPM::KauiArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, webapp_path, @nexus_config, @nexus_ssl_verify)
+      KPM::KauiArtifact.pull(@logger, group_id, artifact_id, packaging, classifier, version, webapp_path, nil, @force_download, @nexus_config, @nexus_ssl_verify)
     end
   end
 end

data/lib/kpm/plugins_directory.yml

@@ -21,7 +21,7 @@
 :paypal:
   :type: :ruby
   :artifact_id: paypal-express-plugin
-  :stable_version: 1.7.1
+  :stable_version: 1.8.1
   :require:
   - :signature
   - :login
@@ -29,6 +29,6 @@
 :stripe:
   :type: :ruby
   :artifact_id: stripe-plugin
-  :stable_version: 0.2.0
+  :stable_version: 0.2.1
   :require:
   - :api_secret_key

data/lib/kpm/sha1_checker.rb

@@ -0,0 +1,61 @@
+require 'logger'
+require 'yaml'
+
+module KPM
+  class Sha1Checker
+
+    def self.from_file(sha1_file, logger=nil)
+      Sha1Checker.new(sha1_file, logger)
+    end
+
+    def initialize(sha1_file, logger=nil)
+      @sha1_file = sha1_file
+      init!
+
+      if logger.nil?
+        @logger       = Logger.new(STDOUT)
+        @logger.level = Logger::INFO
+      else
+        @logger = logger
+      end
+    end
+
+    def sha1(coordinates)
+      @sha1_config['sha1'][coordinates]
+    end
+
+    def add_or_modify_entry!(coordinates, sha1)
+      @sha1_config['sha1'][coordinates] = sha1
+      save!
+    end
+
+    private
+
+    def save!
+      Dir.mktmpdir do |tmp_destination_dir|
+        tmp_file = File.join(tmp_destination_dir, File.basename(@sha1_file))
+        File.open(tmp_file, 'w') do |file|
+          file.write(@sha1_config.to_yaml)
+        end
+        FileUtils.copy(tmp_file, @sha1_file)
+      end
+      reload!
+    end
+
+    def init!
+      if !File.exists?(@sha1_file)
+        init_config = {}
+        init_config['sha1'] = {}
+        File.open(@sha1_file, 'w') do |file|
+          file.write(init_config.to_yaml)
+        end
+      end
+      reload!
+    end
+
+    def reload!
+      @sha1_config = YAML::load_file(@sha1_file)
+    end
+
+  end
+end

data/lib/kpm/tasks.rb

@@ -18,15 +18,24 @@ module KPM
                      :default => true,
                      :desc    => 'Set to false to disable SSL Verification.'
 
+
         desc 'install config_file', 'Install Kill Bill server and plugins according to the specified YAML configuration file.'
+        method_option :force_download,
+                      :type    => :boolean,
+                      :default => false,
+                      :desc    => 'Force download of the artifact even if it exists'
         def install(config_file)
-          Installer.from_file(config_file).install
+          Installer.from_file(config_file).install(options[:force_download])
         end
 
         method_option :destination,
                       :type    => :string,
                       :default => nil,
                       :desc    => 'A different folder other than the current working directory.'
+        method_option :force_download,
+                      :type    => :boolean,
+                      :default => false,
+                      :desc    => 'Force download of the artifact even if it exists'
         desc 'pull_kb_server_war version', 'Pulls Kill Bill server war from Sonatype and places it on your machine.'
         def pull_kb_server_war(version='LATEST')
           response = KillbillServerArtifact.pull(logger,
@@ -36,6 +45,8 @@ module KPM
                                                  KillbillServerArtifact::KILLBILL_CLASSIFIER,
                                                  version,
                                                  options[:destination],
+                                                 nil,
+                                                 options[:force_download],
                                                  options[:overrides],
                                                  options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
@@ -54,6 +65,10 @@ module KPM
                       :type    => :string,
                       :default => nil,
                       :desc    => 'A different folder other than the current working directory.'
+        method_option :force_download,
+                      :type    => :boolean,
+                      :default => false,
+                      :desc    => 'Force download of the artifact even if it exists'
         desc 'pull_kp_server_war version', 'Pulls Kill Pay server war from Sonatype and places it on your machine.'
         def pull_kp_server_war(version='LATEST')
           response = KillbillServerArtifact.pull(logger,
@@ -63,6 +78,8 @@ module KPM
                                                  KillbillServerArtifact::KILLPAY_CLASSIFIER,
                                                  version,
                                                  options[:destination],
+                                                 nil,
+                                                 options[:force_download],
                                                  options[:overrides],
                                                  options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
@@ -81,6 +98,14 @@ module KPM
                       :type    => :string,
                       :default => nil,
                       :desc    => 'A different folder other than the current working directory.'
+        method_option :force_download,
+                      :type    => :boolean,
+                      :default => false,
+                      :desc    => 'Force download of the artifact even if it exists'
+        method_option :sha1_file,
+                      :type    => :string,
+                      :default => nil,
+                      :desc    => 'Location of the sha1 file'
         desc 'pull_java_plugin artifact_id', 'Pulls a java plugin from Sonatype and places it on your machine.'
         def pull_java_plugin(artifact_id, version='LATEST')
           response = KillbillPluginArtifact.pull(logger,
@@ -90,6 +115,8 @@ module KPM
                                                  KillbillPluginArtifact::KILLBILL_JAVA_PLUGIN_CLASSIFIER,
                                                  version,
                                                  options[:destination],
+                                                 options[:sha1_file],
+                                                 options[:force_download],
                                                  options[:overrides],
                                                  options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
@@ -99,6 +126,14 @@ module KPM
                       :type    => :string,
                       :default => nil,
                       :desc    => 'A different folder other than the current working directory.'
+        method_option :force_download,
+                      :type    => :boolean,
+                      :default => false,
+                      :desc    => 'Force download of the artifact even if it exists'
+        method_option :sha1_file,
+                      :type    => :string,
+                      :default => nil,
+                      :desc    => 'Location of the sha1 file'
         desc 'pull_ruby_plugin artifact_id', 'Pulls a ruby plugin from Sonatype and places it on your machine.'
         def pull_ruby_plugin(artifact_id, version='LATEST')
           response = KillbillPluginArtifact.pull(logger,
@@ -108,6 +143,8 @@ module KPM
                                                  KillbillPluginArtifact::KILLBILL_RUBY_PLUGIN_CLASSIFIER,
                                                  version,
                                                  options[:destination],
+                                                 options[:sha1_file],
+                                                 options[:force_download],
                                                  options[:overrides],
                                                  options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green
@@ -132,6 +169,14 @@ module KPM
                       :type    => :string,
                       :default => nil,
                       :desc    => 'A different folder other than the current working directory.'
+        method_option :force_download,
+                      :type    => :boolean,
+                      :default => false,
+                      :desc    => 'Force download of the artifact even if it exists'
+        method_option :sha1_file,
+                      :type    => :string,
+                      :default => nil,
+                      :desc    => 'Location of the sha1 file'
         desc 'pull_kaui_war version', 'Pulls Kaui war from Sonatype and places it on your machine.'
         def pull_kaui_war(version='LATEST')
           response = KauiArtifact.pull(logger,
@@ -141,6 +186,8 @@ module KPM
                                        KauiArtifact::KAUI_CLASSIFIER,
                                        version,
                                        options[:destination],
+                                       options[:sha1_file],
+                                       options[:force_download],
                                        options[:overrides],
                                        options[:ssl_verify])
           say "Artifact has been retrieved and can be found at path: #{response[:file_path]}", :green

data/lib/kpm/version.rb

@@ -1,3 +1,3 @@
 module KPM
-  VERSION = '0.0.10'
+  VERSION = '0.0.11'
 end

data/spec/kpm/remote/base_artifact_spec.rb

@@ -10,14 +10,24 @@ describe KPM::BaseArtifact do
   it 'should be able to download and verify regular artifacts' do
     Dir.mktmpdir do |dir|
       test_download dir, 'foo-oss.pom.xml'
+      # Verify we skip the second time
+      test_download dir, 'foo-oss.pom.xml', true
+      # Verify the download happens when we set force_download
+      test_download dir, 'foo-oss.pom.xml', false, true
     end
 
     Dir.mktmpdir do |dir|
-      test_download dir
+      test_download dir, nil
+      # Verify we skip the second time
+      test_download dir, nil, true
+      # Verify the download happens when we set force_download
+      test_download dir, nil, false, true
     end
+
+
   end
 
-  # This test makes sure the top level directory is correctly skipped
+  # This test makes sure the top level directory is correctly verify_is_skipped
   it 'should be able to download and verify .tar.gz ruby artifacts' do
     # Use the payment-test-plugin as a test, as it is fairly small (2.5M)
     group_id    = 'org.kill-bill.billing.plugin.ruby'
@@ -57,10 +67,14 @@ describe KPM::BaseArtifact do
     end
   end
 
-  def test_download(dir, filename=nil)
+
+  def test_download(dir, filename=nil, verify_is_skipped=false, force_download=false)
     path = filename.nil? ? dir : dir + '/' + filename
-    info = KPM::BaseArtifact.pull(@logger, 'org.kill-bill.billing', 'killbill-oss-parent', 'pom', nil, 'LATEST', path)
+    info = KPM::BaseArtifact.pull(@logger, 'org.kill-bill.billing', 'killbill-oss-parent', 'pom', nil, 'LATEST', path, nil, force_download, {}, true)
     info[:file_name].should == (filename.nil? ? "killbill-oss-parent-#{info[:version]}.pom" : filename)
-    info[:size].should == File.size(info[:file_path])
+    info[:skipped].should == verify_is_skipped
+    if !info[:skipped]
+      info[:size].should == File.size(info[:file_path])
+    end
   end
 end

data/spec/kpm/unit/sha1_checker_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+
+describe KPM::Sha1Checker do
+
+  before(:all) do
+    @logger = Logger.new(STDOUT)
+    @logger.level = Logger::INFO
+
+    tmp_destination_dir = Dir.tmpdir()
+    init_config = File.join(File.dirname(__FILE__), 'sha1_test.yml')
+    FileUtils.copy(init_config, tmp_destination_dir)
+    @tmp_config = File.join(tmp_destination_dir, 'sha1_test.yml')
+    puts "tmp config = #{@tmp_config}"
+    @sha1_checker = KPM::Sha1Checker.from_file(@tmp_config)
+  end
+
+  it 'should find matching sha1' do
+    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+  end
+
+  it 'should NOT find sha1' do
+    existing = @sha1_checker.sha1('killbill-plugin-nomatch-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should_not == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+  end
+
+  it 'should NOT find matching sha1' do
+    existing = @sha1_checker.sha1('killbill-plugin-foo-1.0.0.tar.gz')
+    existing.should be_nil
+  end
+
+  it 'should add an entry and find them all' do
+    @sha1_checker.add_or_modify_entry!('killbill-plugin-new-1.1.0.0.tar.gz', 'abc068c3fd5f95646ce0d09852f43ff67f06f111')
+
+    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+
+    existing = @sha1_checker.sha1('killbill-plugin-new-1.1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'abc068c3fd5f95646ce0d09852f43ff67f06f111'
+
+
+    existing = @sha1_checker.sha1('killbill-plugin-other-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'bbb068c3fd5f95646ce0d09852f43ff67f06fccc'
+  end
+
+  it 'should add allow to modify an entry and find them all' do
+
+    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'fce068c3fd5f95646ce0d09852f43ff67f06f0b9'
+
+    @sha1_checker.add_or_modify_entry!('killbill-plugin-match-1.0.0.tar.gz', 'dde068c3fd5f95646ce0d09852f43ff67f06f0aa')
+
+
+    existing = @sha1_checker.sha1('killbill-plugin-match-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'dde068c3fd5f95646ce0d09852f43ff67f06f0aa'
+
+    existing = @sha1_checker.sha1('killbill-plugin-other-1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'bbb068c3fd5f95646ce0d09852f43ff67f06fccc'
+  end
+
+  it 'should work with empty config' do
+
+    tmp_destination_dir = Dir.tmpdir()
+    empty_config = File.join(tmp_destination_dir, 'sha1_test.yml')
+    if File.exists?(empty_config)
+      # Just to be sure
+      File.delete(empty_config)
+    end
+    @sha1_checker = KPM::Sha1Checker.from_file(empty_config)
+
+    @sha1_checker.add_or_modify_entry!('killbill-plugin-new-1.1.0.0.tar.gz', 'abc068c3fd5f95646ce0d09852f43ff67f06f111')
+    existing = @sha1_checker.sha1('killbill-plugin-new-1.1.0.0.tar.gz')
+    existing.should_not be_nil
+    existing.should == 'abc068c3fd5f95646ce0d09852f43ff67f06f111'
+  end
+
+
+end

data/spec/kpm/unit/sha1_test.yml

@@ -0,0 +1,4 @@
+sha1:
+  killbill-plugin-match-1.0.0.tar.gz: fce068c3fd5f95646ce0d09852f43ff67f06f0b9
+  killbill-plugin-nomatch-1.0.0.tar.gz: ace068c3fd5f95646ce0d09852f43ff67f06f0b8
+  killbill-plugin-other-1.0.0.tar.gz: bbb068c3fd5f95646ce0d09852f43ff67f06fccc

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kpm
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Kill Bill core team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-18 00:00:00.000000000 Z
+date: 2014-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -90,6 +90,7 @@ files:
 - ".gemrelease"
 - ".gitignore"
 - Gemfile
+- README.md
 - Rakefile
 - bin/kpm
 - install_example.yml
@@ -103,6 +104,7 @@ files:
 - lib/kpm/killbill_server_artifact.rb
 - lib/kpm/plugins_directory.rb
 - lib/kpm/plugins_directory.yml
+- lib/kpm/sha1_checker.rb
 - lib/kpm/tasks.rb
 - lib/kpm/utils.rb
 - lib/kpm/version.rb
@@ -111,6 +113,8 @@ files:
 - spec/kpm/remote/kaui_artifact_spec.rb
 - spec/kpm/remote/killbill_plugin_artifact_spec.rb
 - spec/kpm/remote/killbill_server_artifact_spec.rb
+- spec/kpm/unit/sha1_checker_spec.rb
+- spec/kpm/unit/sha1_test.yml
 - spec/spec_helper.rb
 homepage: http://kill-bill.org
 licenses:
@@ -144,4 +148,6 @@ test_files:
 - spec/kpm/remote/kaui_artifact_spec.rb
 - spec/kpm/remote/killbill_plugin_artifact_spec.rb
 - spec/kpm/remote/killbill_server_artifact_spec.rb
+- spec/kpm/unit/sha1_checker_spec.rb
+- spec/kpm/unit/sha1_test.yml
 - spec/spec_helper.rb