kosher 0.2.11 → 0.2.12

data/lib/kosher/availability.rb

@@ -1,15 +1,11 @@
 module Kosher
   class Availability < Struct.new(:hours)
-    def kosher?
-      hours <= threshold
-    end
+    include Threshold
 
-    def threshold
-      @threshold ||= 48
-    end
+    THRESHOLD = 48
 
-    def threshold=(hours)
-      @threshold = hours
+    def kosher?
+      hours <= threshold
     end
   end
 end

data/lib/kosher/condition.rb

@@ -1,5 +1,9 @@
 module Kosher
   class Condition < Struct.new(:grade)
+    include Threshold
+
+    THRESHOLD = 4
+
     def kosher?
       grade <= threshold
     end
@@ -8,14 +12,6 @@ module Kosher
       grade == 1
     end
 
-    def threshold
-      @threshold ||= 4
-    end
-
-    def threshold=(grade)
-      @threshold = grade
-    end
-
     def used?
       !new?
     end

data/lib/kosher/seller.rb

@@ -1,27 +1,29 @@
 module Kosher
   class Seller < Struct.new(:id, :name, :rating, :location)
-    def blacklist
-      @blacklist ||= []
+    include Threshold
+
+    THRESHOLD = 4.8
+
+    class << self
+      def blacklist
+        @blacklist ||= []
+      end
+
+      def blacklist=(ids)
+        @blacklist = ids
+      end
     end
 
-    def blacklist=(ids)
-      @blacklist = ids
+    def blacklist
+      self.class.blacklist
     end
 
     def blacklisted?
-      blacklist.include? id
+      blacklist.include?(id)
     end
 
     def kosher?
       !blacklisted? && (rating.to_f == 0.0 || rating >= threshold)
     end
-
-    def threshold
-      @threshold ||= 4.8
-    end
-
-    def threshold=(rating)
-      @threshold = rating
-    end
   end
 end

data/lib/kosher/threshold.rb

@@ -0,0 +1,21 @@
+module Kosher
+  module Threshold
+    def self.included(klass)
+      klass.extend(ClassMethods)
+    end
+
+    def threshold
+      self.class.threshold
+    end
+
+    module ClassMethods
+      def threshold
+        @threshold ||= THRESHOLD
+      end
+
+      def threshold=(value)
+        @threshold = value
+      end
+    end
+  end
+end

data/lib/kosher/version.rb

@@ -1,3 +1,3 @@
 module Kosher
-  VERSION = '0.2.11'
+  VERSION = '0.2.12'
 end

data/lib/kosher.rb

@@ -1,5 +1,7 @@
 require 'money'
 
+require 'kosher/threshold'
+
 require 'kosher/availability'
 require 'kosher/condition'
 require 'kosher/description'

data/spec/kosher/availability_spec.rb

@@ -8,7 +8,7 @@ module Kosher
 
     describe "#kosher?" do
       before do
-        @availability.threshold = 48
+        Availability.threshold = 48
       end
 
       context "when available within threshold" do

data/spec/kosher/condition_spec.rb

@@ -8,7 +8,7 @@ module Kosher
 
     describe "#kosher?" do
       before do
-        @condition.threshold = 4
+        Condition.threshold = 4
       end
 
       context "when grade within threshold" do

data/spec/kosher/seller_spec.rb

@@ -14,7 +14,7 @@ module Kosher
 
     describe "#blacklisted?" do
       before do
-        @seller.blacklist = ['foo']
+        Seller.blacklist = ['foo']
       end
 
       it "returns true if the seller is blacklisted" do
@@ -30,7 +30,7 @@ module Kosher
 
     describe "#kosher?" do
       before do
-        @seller.threshold = 4.8
+        Seller.threshold = 4.8
       end
 
       it "returns true if rating is 0.0" do
@@ -54,7 +54,7 @@ module Kosher
 
       it "returns false if seller is blacklisted" do
         @seller.id = ['foo']
-        @seller.blacklist = [@seller.id]
+        Seller.blacklist = [@seller.id]
         @seller.should_not be_kosher
       end
     end

metadata

@@ -2,7 +2,7 @@
 name: kosher
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.11
+  version: 0.2.12
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -71,6 +71,7 @@ files:
 - lib/kosher/seller.rb
 - lib/kosher/shipping.rb
 - lib/kosher/snapshot.rb
+- lib/kosher/threshold.rb
 - lib/kosher/version.rb
 - spec/kosher/availability_spec.rb
 - spec/kosher/condition_spec.rb