kosher 0.2.10 → 0.2.11

data/lib/kosher/offer.rb

@@ -6,8 +6,7 @@ module Kosher
       if self.kosher? != other.kosher?
         self.kosher? ? -1 : 1
       else
-        currency = base_currency
-        self.price.exchange_to(currency) <=> other.price.exchange_to(currency)
+        self.price.exchange_to(base_currency) <=> other.price.exchange_to(base_currency)
       end
     end
 

data/lib/kosher/snapshot.rb

@@ -1,4 +1,9 @@
 module Kosher
   class Snapshot < Struct.new(:venue, :isbn, :asin, :sales_rank, :offers_count, :offers, :created_at)
+    def best_kosher_offer
+      offer = offers.sort.first
+
+      offer.kosher? ? offer : nil
+    end
   end
 end

data/lib/kosher/version.rb

@@ -1,3 +1,3 @@
 module Kosher
-  VERSION = '0.2.10'
+  VERSION = '0.2.11'
 end

data/spec/kosher/snapshot_spec.rb

@@ -1,5 +1,71 @@
 require 'spec_helper'
 
 module Kosher
-  describe Snapshot
+  describe Snapshot do
+    describe "#best_kosher_offer" do
+      before do
+        @snapshot = Snapshot.new
+        @snapshot.offers = []
+
+        @offer1 = Offer.new
+        @offer2 = Offer.new
+      end
+
+      context "when there are more than one kosher offers" do
+        before do
+          @offer1.stub!(:kosher?).and_return(true)
+          @offer1.stub!(:price).and_return(Money.new(200, 'EUR'))
+          @snapshot.offers << @offer1
+
+          @offer2.stub!(:kosher?).and_return(true)
+          @offer2.stub!(:price).and_return(Money.new(100, 'EUR'))
+          @snapshot.offers << @offer2
+        end
+
+        it "returns the kosher offer with the lower price" do
+          @snapshot.best_kosher_offer.should eql @offer2
+        end
+      end
+
+      context "when there is one kosher and one unkosher offer" do
+        before do
+          @offer1.stub!(:kosher?).and_return(true)
+          @offer1.stub!(:price).and_return(Money.new(200, 'EUR'))
+          @snapshot.offers << @offer1
+
+          @offer2.stub!(:kosher?).and_return(false)
+          @offer2.stub!(:price).and_return(Money.new(100, 'EUR'))
+          @snapshot.offers << @offer2
+        end
+
+        it "returns the best kosher offer" do
+          @snapshot.best_kosher_offer.should eql @offer1
+        end
+      end
+
+      context "when there is one kosher offer" do
+        before do
+          @offer1.stub!(:kosher?).and_return(true)
+          @offer1.stub!(:price).and_return(Money.new(100, 'EUR'))
+          @snapshot.offers << @offer1
+        end
+
+        it "returns the kosher offer" do
+          @snapshot.best_kosher_offer.should eql @offer1
+        end
+      end
+
+      context "when there is one unkosher offer" do
+        before do
+          @offer1.stub!(:kosher?).and_return(false)
+          @offer1.stub!(:price).and_return(Money.new(100, 'EUR'))
+          @snapshot.offers << @offer1
+        end
+
+        it "returns nil" do
+          @snapshot.best_kosher_offer.should be_nil
+        end
+      end
+    end
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: kosher
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.10
+  version: 0.2.11
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-10 00:00:00 +00:00
+date: 2011-03-16 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency