kosher 0.1.12 → 0.2.0

data/spec/kosher/offer_spec.rb

@@ -2,71 +2,33 @@ require 'spec_helper'
 
 module Kosher
   describe Offer do
-    let(:offer) { Fabricate(:offer) }
-
-    describe ".build" do
-      use_vcr_cassette '0143105825'
-
-      let(:asin) { '0143105825' }
-
-      let(:doc) do
-        request = Request.new(credentials)
-        request.locale = :us
-        request.batchify([asin])
-        algorithm = request.get
-
-        response = algorithm.instance_variable_get(:@response)
-        response.find('Offer').first
-      end
-
-      it "should build an offer" do
-        offer = Offer.build(doc)
-
-        offer.should be_a Offer
-        expect do
-          offer.kosher?
-        end.should_not raise_error
-      end
-
-      it "populates the offer listing ID" do
-        offer = Offer.build(doc)
-        offer.listing_id.should_not be_nil
-      end
-
-      it "populates the exchange ID" do
-        offer = Offer.build(doc)
-        offer.exchange_id.should_not be_nil
-      end
-
-      it "should handle blank descriptions" do
-        doc['OfferAttributes']['ConditionNote'] = ''
-        offer = Offer.build(doc)
-
-        offer.description.should eql ''
-      end
-    end
+    let(:offer) { Offer.new }
 
     describe "#kosher?" do
-      context "when condition is kosher" do
+      describe "when condition is kosher" do
         before do
-          offer.condition = Fabricate(:kosher_condition, :grade => 1)
+          offer.condition = Condition.new(1)
         end
 
-        context "when seller is kosher" do
+        describe "when seller is kosher" do
           before do
-            offer.seller = Fabricate(:good_seller)
+            offer.seller = Seller.new
           end
 
-          context "when description is kosher" do
-            context "when offer ships now" do
+          describe "when description is kosher" do
+            before do
+              offer.description = Description.new
+            end
+
+            describe "when offer ships now" do
               it "returns true" do
                 offer.should be_kosher
               end
             end
 
-            context "when offer does not ship now" do
+            describe "when offer does not ship now" do
               before do
-                offer.ships_in = 96
+                offer.hours_shipped = 72
               end
 
               it "returns false" do
@@ -75,9 +37,9 @@ module Kosher
             end
           end
 
-          context "when description is not kosher" do
+          describe "when description is not kosher" do
             before do
-              offer.description = Kosher::Description.new("Withdrawn library book")
+              offer.description = Description.new('Withdrawn library book')
             end
 
             it "returns false" do
@@ -86,9 +48,9 @@ module Kosher
           end
         end
 
-        context "when seller is not kosher" do
+        describe "when seller is not kosher" do
           before do
-            offer.seller = Fabricate(:bad_seller)
+            offer.seller = Seller.new('foo', 'bar', 4.0)
           end
 
           it "returns false" do
@@ -97,9 +59,9 @@ module Kosher
         end
       end
 
-      context "when condition is not kosher" do
+      describe "when condition is not kosher" do
         before do
-          offer.condition = Fabricate(:kosher_condition, :grade => 5)
+          offer.condition = Condition.new(5)
         end
 
         it "returns false" do
@@ -108,24 +70,106 @@ module Kosher
       end
     end
 
-    describe "#ships_now?" do
-      context "when offer ships within 48 hours" do
-        before do
-          offer.ships_in = 48
-        end
+    describe "#available?" do
+      before do
+        Config.max_hours_shipped = 48
+      end
 
+      describe "when offer is expected to ship on time" do
         it "returns true" do
-          offer.send(:ships_now?).should be_true
+          offer.hours_shipped = 48
+          offer.should be_available
         end
       end
 
-      context "when offer ships in over 48 hours" do
+      describe "when offer is not expected to ship on time" do
+        it "returns false" do
+          offer.hours_shipped = 96
+          offer.should_not be_available
+        end
+      end
+    end
+
+    describe "#price" do
+      it "returns the price" do
+        offer.price_in_cents = 100
+        offer.currency = 'USD'
+
+        offer.price.should be_kind_of Money
+        offer.price.format.should eql '$1.00'
+      end
+    end
+
+    describe "#<=>" do
+      before do
+        offer.condition = Condition.new(1)
+        offer.seller = Seller.new
+        offer.description = Description.new
+        offer.price_in_cents = 100
+        offer.currency = 'EUR'
+        @another_offer = offer.dup
+      end
+
+      context "when kosher" do
+        it "is greater than a non-kosher offer" do
+          @another_offer.condition = Condition.new(5)
+          offer.should be_kosher
+          @another_offer.should_not be_kosher
+
+          offer.should be > @another_offer
+        end
+
+        context "when the other offer is kosher too" do
+          it "is greater than another kosher offer with a higher price" do
+            @another_offer.price_in_cents = 200
+
+            offer.should be > @another_offer
+          end
+
+          it "is equal to another kosher offer with an equal price" do
+            offer.should be == @another_offer
+          end
+
+          it "is less than another kosher offer with a lower price" do
+            @another_offer.price_in_cents = 50
+
+            offer.should be < @another_offer
+          end
+        end
+      end
+
+      context "when not kosher" do
         before do
-          offer.ships_in = 96
+          offer.condition = Condition.new(5)
         end
 
-        it "returns false" do
-          offer.send(:ships_now?).should be_false
+        it "is less than a kosher offer" do
+          offer.should_not be_kosher
+          @another_offer.should be_kosher
+
+          offer.should be < @another_offer
+        end
+
+        context "when the other offer is not kosher either" do
+          before do
+            @another_offer.condition = Condition.new(5)
+          end
+
+          it "is greater than another unkosher offer with a higher price" do
+            @another_offer.price_in_cents = 200
+
+            offer.should be > @another_offer
+          end
+
+          it "is equal to another unkosher offer with an equal price" do
+            offer.should be == @another_offer
+          end
+
+          it "is less than another unkosher offer with a lower price" do
+            @another_offer.price_in_cents = 50
+
+            offer.should be < @another_offer
+          end
         end
       end
     end

data/spec/kosher/seller_spec.rb

@@ -2,68 +2,54 @@ require 'spec_helper'
 
 module Kosher
   describe Seller do
-    describe ".build" do
-      use_vcr_cassette '0143105825'
-
-      let(:asin) { '0143105825' }
-
-      let(:response) do
-        request = Request.new(credentials)
-        request.locale = :us
-        request.batchify([asin])
-        algorithm = request.get
-
-        algorithm.instance_variable_get(:@response)
-      end
+    before do
+      Config.blacklist = nil
+    end
 
-      let(:seller) do
-        docs = response.find('Merchant')
-        Seller.build(docs.first)
+    describe "#blacklisted?" do
+      before do
+        Config.blacklist = ['foo']
       end
 
-      it "populates the merchant ID of a seller" do
-        seller.merchant_id.should match /^[0-9A-Z]{13,14}$/
+      it "returns true if the seller is blacklisted" do
+        Seller.new('foo').should be_blacklisted
       end
 
-      it "populates the name of a seller" do
-        seller.name.should_not be_nil
+      it "returns false if the seller is not blacklisted" do
+        Seller.new('bar').should_not be_blacklisted
       end
+    end
 
-      it "populates the average rating of a seller" do
-        seller.average_rating.should be_an_instance_of Float
+    describe "#kosher?" do
+      before do
+        Config.min_rating = 4.8
       end
 
-      it "builds a newly-launched seller" do
-        doc = response.find('Merchant').detect { |doc| doc["AverageFeedbackRating"] == "0.0" }
-        new_seller = Seller.build(doc)
-
-        new_seller.average_rating.should eql 0.0
+      it "returns true if seller's average rating is 0.0" do
+        seller = Seller.new('foo', 'bar', 0.0)
+        seller.should be_kosher
       end
-    end
 
-    describe "#kosher?" do
-      it "returns true if seller's average rating is 0.0" do
-        seller = Fabricate(:new_seller)
+      it "returns true if seller's average rating is nil" do
+        seller = Seller.new
         seller.should be_kosher
       end
 
-      it "returns true if seller's average rating is above 4.7" do
-        seller = Fabricate(:good_seller)
+      it "returns true if seller's average rating is equal to or above the min average rating" do
+        seller = Seller.new('foo', 'bar', 4.8)
         seller.should be_kosher
       end
 
-      it "returns false if sellers' average rating is 4.7 or below" do
-        seller = Fabricate(:bad_seller)
+      it "returns false if sellers' average rating is below the min average rating" do
+        seller = Seller.new('foo', 'bar', 4.7)
         seller.should_not be_kosher
       end
 
       it "returns false if seller is blacklisted" do
-        seller = Fabricate(:good_seller)
+        seller = Seller.new('foo', 'bar', 5.0)
         seller.should be_kosher
 
-        seller.merchant_id = Faker::Amazon.merchant_id
-        Seller.blacklist = [seller.merchant_id]
-
+        Config.blacklist = [seller.id]
         seller.should_not be_kosher
       end
     end

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 require 'rubygems'
 require 'bundler/setup'
 require 'rspec'
-require 'fabrication'
 
 require File.expand_path('../../lib/kosher', __FILE__)
 

metadata

@@ -2,7 +2,7 @@
 name: kosher
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.12
+  version: 0.2.0
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -10,86 +10,31 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-07 00:00:00 +00:00
+date: 2011-03-09 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: json
+  name: money
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.5.1
+        version: 3.6.1
   type: :runtime
   version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: sucker
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 1.3.1
-  type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: fabrication
-  prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 0.9.5
-  type: :development
-  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: rspec
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
         version: 2.5.0
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: ruby-debug19
-  prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 0.11.6
-  type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: vcr
-  prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 1.7.0
-  type: :development
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: webmock
-  prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: 1.6.2
-  type: :development
-  version_requirements: *id007
+  version_requirements: *id002
 description: Kosher wraps Amazon in a loving embrace.
 email: code@papercavalier.com
 executables: []
@@ -106,34 +51,18 @@ files:
 - Rakefile
 - kosher.gemspec
 - lib/kosher.rb
-- lib/kosher/algorithm.rb
 - lib/kosher/condition.rb
+- lib/kosher/config.rb
 - lib/kosher/description.rb
-- lib/kosher/errors.rb
-- lib/kosher/item.rb
 - lib/kosher/offer.rb
-- lib/kosher/request.rb
 - lib/kosher/seller.rb
-- lib/kosher/struct.rb
 - lib/kosher/version.rb
-- spec/fabricators/condition_fabricator.rb
-- spec/fabricators/offer_fabricator.rb
-- spec/fabricators/seller_fabricator.rb
-- spec/fixtures/cassette_library/0143105825.yml
-- spec/fixtures/cassette_library/batch-request.yml
-- spec/kosher/algorithm_spec.rb
 - spec/kosher/condition_spec.rb
+- spec/kosher/config_spec.rb
 - spec/kosher/description_spec.rb
-- spec/kosher/item_spec.rb
 - spec/kosher/offer_spec.rb
-- spec/kosher/request_spec.rb
 - spec/kosher/seller_spec.rb
-- spec/kosher/struct_spec.rb
 - spec/spec_helper.rb
-- spec/support/credentials.rb
-- spec/support/faker.rb
-- spec/support/vcr.rb
-- walter_benjamin.jpg
 has_rdoc: true
 homepage: https://rubygems.org/gems/kosher
 licenses: []
@@ -163,20 +92,9 @@ signing_key:
 specification_version: 3
 summary: Wraps Amazon in a loving embrace.
 test_files: 
-- spec/fabricators/condition_fabricator.rb
-- spec/fabricators/offer_fabricator.rb
-- spec/fabricators/seller_fabricator.rb
-- spec/fixtures/cassette_library/0143105825.yml
-- spec/fixtures/cassette_library/batch-request.yml
-- spec/kosher/algorithm_spec.rb
 - spec/kosher/condition_spec.rb
+- spec/kosher/config_spec.rb
 - spec/kosher/description_spec.rb
-- spec/kosher/item_spec.rb
 - spec/kosher/offer_spec.rb
-- spec/kosher/request_spec.rb
 - spec/kosher/seller_spec.rb
-- spec/kosher/struct_spec.rb
 - spec/spec_helper.rb
-- spec/support/credentials.rb
-- spec/support/faker.rb
-- spec/support/vcr.rb

data/lib/kosher/algorithm.rb

@@ -1,25 +0,0 @@
-module Kosher
-  class Algorithm
-    def initialize(response)
-      raise ResponseNotValidError unless response.valid?
-
-      @response = response
-    end
-
-    def items
-      @response.map('Item') do |item|
-        Item.build(item)
-      end
-    end
-
-    def errors
-      @response.errors.map do |error|
-        error['Message'].scan(/[0-9A-Z]{10}/).first rescue nil
-      end.compact
-    end
-
-    def response
-      @response
-    end
-  end
-end

data/lib/kosher/errors.rb

@@ -1,3 +0,0 @@
-module Kosher
-  class ResponseNotValidError < StandardError; end
-end

data/lib/kosher/item.rb

@@ -1,29 +0,0 @@
-module Kosher
-  class Item < Struct.new(:asin, :offers, :offers_count, :sales_rank)
-
-    class << self
-      def build(doc)
-        asin         = doc['ASIN']
-        sales_rank   = doc['SalesRank'].to_i
-        offers_count = doc['Offers']['TotalOffers'].to_i
-        offers       = build_offers(doc['Offers']['Offer'])
-
-        new(asin, offers, offers_count, sales_rank)
-      end
-
-      private
-
-      def build_offers(offers)
-        [offers].flatten.compact.map do |offer|
-
-          # Senify Yen because Ruby Money says so
-          if offer['OfferListing']['Price']['CurrencyCode'] == 'JPY'
-            offer['OfferListing']['Price']['Amount'] = offer['OfferListing']['Price']['Amount'].to_i * 100
-          end
-
-          Offer.build(offer)
-        end
-      end
-    end
-  end
-end

data/lib/kosher/request.rb

@@ -1,28 +0,0 @@
-module Kosher
-  class Request < Sucker::Request
-    def initialize(args={})
-      super
-      add_parameters
-    end
-
-    def batchify(asins)
-      self.<<({ 'ItemLookup.1.ItemId' => asins[0, 10] })
-      self.<<({ 'ItemLookup.2.ItemId' => asins[10, 10] }) if asins.size > 10
-    end
-
-    def get
-      Algorithm.new(super)
-    end
-
-    private
-
-    def add_parameters
-      self.<<({
-        'Operation'                       => 'ItemLookup',
-        'ItemLookup.Shared.IdType'        => 'ASIN',
-        'ItemLookup.Shared.Condition'     => 'All',
-        'ItemLookup.Shared.MerchantId'    => 'All',
-        'ItemLookup.Shared.ResponseGroup' => ['OfferFull', 'SalesRank'] })
-    end
-  end
-end

data/lib/kosher/struct.rb

@@ -1,15 +0,0 @@
-require 'json'
-
-module Kosher
-  class Struct < ::Struct
-    def to_map
-      map = Hash.new
-      self.members.each { |m| map[m] = self[m] }
-      map
-    end
-
-    def to_json(*a)
-      to_map.to_json(*a)
-    end
-  end
-end

data/spec/fabricators/condition_fabricator.rb

@@ -1,7 +0,0 @@
-Fabricator(:kosher_condition, :class_name => 'kosher/condition') do
-  grade 1
-end
-
-Fabricator(:unkosher_condition, :class_name => 'kosher/condition') do
-  grade 5
-end

data/spec/fabricators/offer_fabricator.rb

@@ -1,8 +0,0 @@
-Fabricator(:offer, :class_name => 'kosher/offer') do
-  seller { Fabricate(:good_seller) }
-  description Kosher::Description.new('')
-  condition { Fabricate(:kosher_condition) }
-  ships_free false
-  ships_in 48
-  cents 100
-end

data/spec/fabricators/seller_fabricator.rb

@@ -1,15 +0,0 @@
-Fabricator(:seller, :class_name => 'kosher/seller') do
-  merchant_id Faker::Amazon.merchant_id
-end
-
-Fabricator(:new_seller, :from => :seller) do
-  average_rating 0.0
-end
-
-Fabricator(:good_seller, :from => :seller) do
-  average_rating 5.0
-end
-
-Fabricator(:bad_seller, :from => :seller) do
-  average_rating 4.5
-end