kosher 0.0.3 → 0.1.0

data/spec/kosher/algorithm_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+
+module Kosher
+  describe Algorithm do
+    use_vcr_cassette 'batch-request'
+
+    let(:asins) do
+
+      # The last ASIN does not exist.
+      %w{
+        0816614024 0143105825 0485113600 0816616779 0942299078
+        0816614008 144006654X 0486400360 0486417670 087220474X
+        0486454398 0268018359 1604246014 184467598X 0312427182
+        1844674282 0745640974 0745646441 0826489540 2081232191 }
+    end
+
+    let(:algorithm) do
+      request = Request.new(credentials)
+      request.locale = :us
+      request.batchify(asins)
+      request.get
+    end
+
+    describe "#items" do
+      it "should return found items" do
+        algorithm.items.count.should eql 19
+        algorithm.items.first.should be_a Item
+      end
+    end
+
+    describe "#errors" do
+      it "should return ASINs that are not found" do
+        algorithm.errors.count.should eql 1
+        algorithm.errors.first.should eql '2081232191'
+      end
+    end
+  end
+end

data/spec/kosher/condition_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+module Kosher
+  describe Condition do
+    describe "#to_i" do
+      def this(str)
+        Condition.new(str).to_i
+      end
+
+      it "casts as integer" do
+        this("new").should eql 1
+        this("mint").should eql 2
+        this("verygood").should eql 3
+        this("good").should eql 4
+        this("acceptable").should eql 5
+      end
+
+      it "casts unrecognized conditions as 6" do
+        this("refurbished").should eql 6
+      end
+    end
+
+    describe "#kosher?" do
+      it "returns true if condition is good or better" do
+        Condition.new("verygood").should be_kosher
+        Condition.new("good").should be_kosher
+        Condition.new("acceptable").should_not be_kosher
+      end
+    end
+  end
+end

data/spec/kosher/{string_spec.rb → description_spec.rb}

@@ -1,9 +1,13 @@
 require "spec_helper"
 
 module Kosher
-  describe String do
-    def this(val)
-      Kosher::String.new(val)
+  describe Description do
+    def this(value)
+      Description.new(value)
+    end
+
+    it "inherits from String" do
+      Description.ancestors.should include String
     end
 
     it "validates a blank description" do
@@ -14,7 +18,7 @@ module Kosher
       this("foo").should be_kosher
     end
 
-    it "does not validate advance reviews" do
+    it "does not validate advance review copies" do
       this("Uncorrected review copy").should_not be_kosher
       this("arc").should_not be_kosher
       this("arc.").should_not be_kosher

data/spec/kosher/item_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+module Kosher
+  describe Item do
+    describe ".build" do
+      use_vcr_cassette '0143105825', :match_requests_on  => [:host]
+
+      let(:asin) { '0143105825' }
+
+      let(:response) do
+        request = Request.new(credentials)
+        request.locale = :us
+        request.batchify([asin])
+        algorithm = request.get
+
+        algorithm.instance_variable_get(:@response)
+      end
+
+      let(:item) do
+        doc = response.find('Item').first
+        Item.build(doc)
+      end
+
+      it "should build an item" do
+        item.should be_a Item
+        item.asin.should eql asin
+      end
+
+      it "should build the offers of an item" do
+        item.offers.count.should > 0
+        item.offers.first.should be_a Offer
+      end
+    end
+  end
+end

data/spec/kosher/offer_spec.rb

@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+module Kosher
+  describe Offer do
+    let(:offer) { Fabricate(:offer) }
+
+    describe ".build" do
+      use_vcr_cassette '0143105825', :match_requests_on  => [:host]
+
+      let(:asin) { '0143105825' }
+
+      let(:doc) do
+        request = Request.new(credentials)
+        request.locale = :us
+        request.batchify([asin])
+        algorithm = request.get
+
+        response = algorithm.instance_variable_get(:@response)
+        response.find('Offer').first
+      end
+
+      it "should build an offer" do
+        offer = Offer.build(doc)
+
+        offer.should be_a Offer
+        expect do
+          offer.kosher?
+        end.should_not raise_error
+      end
+
+      it "should handle blank descriptions" do
+        doc['OfferAttributes']['ConditionNote'] = ''
+        offer = Offer.build(doc)
+
+        offer.description.should eql ''
+      end
+    end
+
+    describe "#kosher?" do
+      context "when condition is kosher" do
+        before do
+          offer.condition = Fabricate(:kosher_condition, :in_words => 'new')
+        end
+
+        context "when seller is kosher" do
+          before do
+            offer.seller = Fabricate(:good_seller)
+          end
+
+          context "when description is kosher" do
+            context "when offer ships now" do
+              it "returns true" do
+                offer.should be_kosher
+              end
+            end
+
+            context "when offer does not ship now" do
+              before do
+                offer.ships_in = 96
+              end
+
+              it "returns false" do
+                offer.should_not be_kosher
+              end
+            end
+          end
+
+          context "when description is not kosher" do
+            before do
+              offer.description = Kosher::Description.new("Withdrawn library book")
+            end
+
+            it "returns false" do
+              offer.should_not be_kosher
+            end
+          end
+        end
+
+        context "when seller is not kosher" do
+          before do
+            offer.seller = Fabricate(:bad_seller)
+          end
+
+          it "returns false" do
+            offer.should_not be_kosher
+          end
+        end
+      end
+
+      context "when condition is not kosher" do
+        before do
+          offer.condition = Fabricate(:kosher_condition, :in_words => "acceptable")
+        end
+
+        it "returns false" do
+          offer.should_not be_kosher
+        end
+      end
+    end
+
+    describe "#ships_now?" do
+      context "when offer ships within 48 hours" do
+        before do
+          offer.ships_in = 48
+        end
+
+        it "returns true" do
+          offer.send(:ships_now?).should be_true
+        end
+      end
+
+      context "when offer ships in over 48 hours" do
+        before do
+          offer.ships_in = 96
+        end
+
+        it "returns false" do
+          offer.send(:ships_now?).should be_false
+        end
+      end
+    end
+  end
+end

data/spec/kosher/request_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+module Kosher
+  describe Request do
+    let(:request) { Request.new(credentials) }
+
+    describe ".new" do
+      it "should define a batch request" do
+        request.parameters['Operation'].should eql 'ItemLookup'
+        request.parameters['ItemLookup.Shared.IdType'].should eql 'ASIN'
+        request.parameters['ItemLookup.Shared.Condition'].should eql 'All'
+        request.parameters['ItemLookup.Shared.MerchantId'].should eql 'All'
+        request.parameters['ItemLookup.Shared.ResponseGroup'].should eql ['OfferFull', 'SalesRank']
+      end
+    end
+
+    describe "#batchify" do
+      it "should add up to 20 ASINs to the worker's parameters" do
+        asins = (0..19).to_a
+        request.batchify(asins)
+
+        request.parameters['ItemLookup.1.ItemId'].should eql (0..9).to_a
+        request.parameters['ItemLookup.2.ItemId'].should eql (10..19).to_a
+      end
+    end
+
+    describe "#request" do
+      before do
+        VCR.http_stubbing_adapter.http_connections_allowed = true
+      end
+
+      it "should return an algorithm" do
+        Kosher::Request.stub!(:get)
+
+        request.locale = :us
+        request.batchify('foo')
+
+        request.get.should be_a Algorithm
+      end
+    end
+  end
+end

data/spec/kosher/seller_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+module Kosher
+  describe Seller do
+    describe ".build" do
+      use_vcr_cassette "0143105825", :match_requests_on  => [:host]
+
+      let(:asin) { '0143105825' }
+
+      let(:response) do
+        request = Request.new(credentials)
+        request.locale = :us
+        request.batchify([asin])
+        algorithm = request.get
+
+        algorithm.instance_variable_get(:@response)
+      end
+
+      let(:sellers) do
+        response.find("Merchant")
+      end
+
+      it "builds a seller" do
+        seller = Seller.build(sellers.first)
+
+        seller.merchant_id.should match /^[0-9A-Z]{13,14}$/
+        seller.average_rating.should be_an_instance_of Float
+      end
+
+      it "builds a newly-launched seller" do
+        doc = sellers.detect { |doc| doc["AverageFeedbackRating"] == "0.0" }
+        new_seller = Seller.build(doc)
+
+        new_seller.average_rating.should eql 0.0
+      end
+    end
+
+    describe "#kosher?" do
+      it "returns true if seller's average rating is 0.0" do
+        seller = Fabricate(:new_seller)
+        seller.should be_kosher
+      end
+
+      it "returns true if seller's average rating is above 4.7" do
+        seller = Fabricate(:good_seller)
+        seller.should be_kosher
+      end
+
+      it "returns false if sellers' average rating is 4.7 or below" do
+        seller = Fabricate(:bad_seller)
+        seller.should_not be_kosher
+      end
+
+      it "returns false if seller is blacklisted" do
+        seller = Fabricate(:good_seller)
+        seller.should be_kosher
+
+        seller.merchant_id = Faker::Amazon.merchant_id
+        Seller.blacklist = [seller.merchant_id]
+
+        seller.should_not be_kosher
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,7 +1,8 @@
-require "rubygems"
-require "bundler/setup"
-require "rspec"
+require 'rubygems'
+require 'bundler/setup'
+require 'rspec'
+require 'fabrication'
 
-require File.expand_path("../../lib/kosher", __FILE__)
+require File.expand_path('../../lib/kosher', __FILE__)
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }

data/spec/support/credentials.rb

@@ -0,0 +1,3 @@
+def credentials
+  @credentials ||= YAML::load_file(File.dirname(__FILE__) + "/credentials.yml")
+end

data/spec/support/faker.rb

@@ -0,0 +1,19 @@
+module Faker
+  module Amazon
+    class << self
+      def asin
+        raw = 9.times.map { rand(10).to_s }
+        (raw << Bookland::ISBN.new.send(:check_digit_10, raw)).join
+      end
+
+      def ean
+        Bookland::ISBN.to_13(asin)
+      end
+
+      def merchant_id
+        seed = ('A'..'Z').to_a + (0..9).to_a
+        14.times.map { seed[rand(seed.size)] }.join
+      end
+    end
+  end
+end

data/spec/support/vcr.rb

@@ -0,0 +1,12 @@
+require 'vcr'
+
+VCR.config do |c|
+  c.cassette_library_dir     = "#{File.dirname(__FILE__)}/../fixtures/cassette_library"
+  c.stub_with                  :webmock
+  c.ignore_localhost         = true
+  c.default_cassette_options = { :record => :new_episodes }
+end
+
+RSpec.configure do |config|
+  config.extend VCR::RSpec::Macros
+end

metadata

@@ -1,12 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: kosher
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 0
-  - 3
-  version: 0.0.3
+  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -14,27 +10,88 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-06 00:00:00 +00:00
+date: 2011-03-03 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: sucker
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        segments: 
-        - 2
-        - 4
-        - 0
-        version: 2.4.0
-  type: :development
+        version: 1.3.1
+  type: :runtime
   version_requirements: *id001
-description: Have you ever wondered if you should buy a book?
-email: 
-- code@papercvalier.com
+- !ruby/object:Gem::Dependency 
+  name: throttler
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 0.2.4
+  type: :runtime
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: fabrication
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 0.9.5
+  type: :development
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 2.5.0
+  type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: ruby-debug19
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 0.11.6
+  type: :development
+  version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: vcr
+  prerelease: false
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 1.7.0
+  type: :development
+  version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: webmock
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 1.6.2
+  type: :development
+  version_requirements: *id007
+description: Kosher wraps Amazon in a loving embrace.
+email: code@papercavalier.com
 executables: []
 
 extensions: []
@@ -43,23 +100,39 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
-- .rspec
-- .rvmrc
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - kosher.gemspec
 - lib/kosher.rb
-- lib/kosher/regexps.rb
-- lib/kosher/string.rb
+- lib/kosher/algorithm.rb
+- lib/kosher/condition.rb
+- lib/kosher/description.rb
+- lib/kosher/item.rb
+- lib/kosher/offer.rb
+- lib/kosher/request.rb
+- lib/kosher/seller.rb
 - lib/kosher/version.rb
-- spec/kosher/string_spec.rb
-- spec/kosher_spec.rb
+- spec/fabricators/condition_fabricator.rb
+- spec/fabricators/offer_fabricator.rb
+- spec/fabricators/seller_fabricator.rb
+- spec/fixtures/cassette_library/0143105825.yml
+- spec/fixtures/cassette_library/batch-request.yml
+- spec/kosher/algorithm_spec.rb
+- spec/kosher/condition_spec.rb
+- spec/kosher/description_spec.rb
+- spec/kosher/item_spec.rb
+- spec/kosher/offer_spec.rb
+- spec/kosher/request_spec.rb
+- spec/kosher/seller_spec.rb
 - spec/spec_helper.rb
+- spec/support/credentials.rb
+- spec/support/faker.rb
+- spec/support/vcr.rb
 - walter_benjamin.jpg
 has_rdoc: true
-homepage: ""
+homepage: https://rubygems.org/gems/kosher
 licenses: []
 
 post_install_message: 
@@ -72,25 +145,34 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: kosher
-rubygems_version: 1.3.7
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
-summary: Kosher validates descriptions
+summary: Wraps Amazon in a loving embrace.
 test_files: 
-- spec/kosher/string_spec.rb
-- spec/kosher_spec.rb
+- spec/fabricators/condition_fabricator.rb
+- spec/fabricators/offer_fabricator.rb
+- spec/fabricators/seller_fabricator.rb
+- spec/fixtures/cassette_library/0143105825.yml
+- spec/fixtures/cassette_library/batch-request.yml
+- spec/kosher/algorithm_spec.rb
+- spec/kosher/condition_spec.rb
+- spec/kosher/description_spec.rb
+- spec/kosher/item_spec.rb
+- spec/kosher/offer_spec.rb
+- spec/kosher/request_spec.rb
+- spec/kosher/seller_spec.rb
 - spec/spec_helper.rb
+- spec/support/credentials.rb
+- spec/support/faker.rb
+- spec/support/vcr.rb

data/.rspec

@@ -1,2 +0,0 @@
---color
---format documentation

data/.rvmrc

@@ -1 +0,0 @@
-rvm --create use 1.9.2@kosher

data/lib/kosher/regexps.rb

@@ -1,7 +0,0 @@
-module Kosher
-  DAMAGED     = "\\b(?:missing|torn|broken|split|discard|withdrawn|rent|stain|school|damaged|water)"
-  EXLIBRARY   = "(?:e?x|discarded|retired|former|has|have)[\\s._-]*lib"
-  MARKED      = "(highlight|hilit|underlin)"
-  MISSING_VOL = "(vols?|volume) only"
-  REVIEW_COPY = "\\b(?:uncorrected|advanced?\\sreview|arc)\\b"
-end

data/lib/kosher/string.rb

@@ -1,50 +0,0 @@
-module Kosher
-  class String < String
-    def kosher?
-      !(present? && (
-        damaged?        ||
-        ex_library?     ||
-        marked?         ||
-        missing_volume? ||
-        review_copy?))
-    end
-
-    private
-
-    def expect(str)
-      !!match(Regexp.new(str, true))
-    end
-
-    def do_not_expect(str)
-      !match(Regexp.new(str, true))
-    end
-
-    def damaged?
-      expect(DAMAGED)
-    end
-
-    def ex_library?
-      expect(EXLIBRARY) && do_not_expect(negation_of(EXLIBRARY))
-    end
-
-    def marked?
-      expect(MARKED) && do_not_expect(negation_of(MARKED))
-    end
-
-    def missing_volume?
-      expect(MISSING_VOL)
-    end
-
-    def negation_of(str)
-      "(?:no|not an?)\\s+#{str}"
-    end
-
-    def present?
-      self != ''
-    end
-
-    def review_copy?
-      expect(REVIEW_COPY)
-    end
-  end
-end

data/spec/kosher_spec.rb

@@ -1,9 +0,0 @@
-require "spec_helper"
-
-describe Kosher do
-  describe(".new") do
-    it "returns an instance of Kosher::String" do
-      Kosher.new("foo").should be_a_kind_of Kosher::String
-    end
-  end
-end