kontoapi-ruby 0.1.1 → 0.2.0

data/README.markdown

@@ -1,7 +1,7 @@
 Konto API Ruby Library
 ======================
 
-This library provides an easy way to access the Konto API (https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german bank accounts.
+This library provides an easy way to access the [Konto API](https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german and international bank accounts.
 
 INSTALLATION
 ------------
@@ -19,10 +19,22 @@ USAGE
     # optional settings
     KontoAPI::timeout = 10   # 10 seconds is the default
 
-    # Check account validity: KontoAPI::valid?(account_number, bank_code)
-    KontoAPI::valid?('1234567', '12312312')
+    # Check account validity: KontoAPI::valid?(options)
+    KontoAPI::valid?( :ktn => '1234567', :blz => '12312312' )
     #=> false
-    KontoAPI::valid?('49379110', '10010010')
+    KontoAPI::valid?( :ktn => '49379110', :blz => '10010010' )
+    #=> true
+    
+    # Check IBAN only
+    KontoAPI::valid?( :iban => 'DE71100100100068118106' )
+    #=> true
+    
+    # Check BIC only
+    KontoAPI::valid?( :bic => 'PBNKDEFF100' )
+    #=> true
+    
+    # Check both IBAN and BIC
+    KontoAPI::valid?( :iban => 'DE71100100100068118106', :bic => 'PBNKDEFF100' )
     #=> true
 
     # Get the name of a bank by its code: KontoAPI::bank_name(bank_code)

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.2.0

data/kontoapi-ruby.gemspec

@@ -4,14 +4,14 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.name = %q{kontoapi-ruby}
-  s.version = "0.1.1"
+  s.name = "kontoapi-ruby"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jan Schwenzien"]
-  s.date = %q{2011-04-20}
-  s.description = %q{A ruby library to access the Konto API (https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german bank accounts.}
-  s.email = %q{jan@general-scripting.com}
+  s.date = "2012-04-08"
+  s.description = "A ruby library to access the Konto API (https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german bank accounts."
+  s.email = "jan@general-scripting.com"
   s.extra_rdoc_files = [
     "LICENSE",
     "README.markdown"
@@ -28,11 +28,11 @@ Gem::Specification.new do |s|
     "spec/kontoapi-ruby_spec.rb",
     "spec/spec_helper.rb"
   ]
-  s.homepage = %q{http://github.com/GeneralScripting/kontoapi-ruby}
+  s.homepage = "http://github.com/GeneralScripting/kontoapi-ruby"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.7.2}
-  s.summary = %q{Konto API Ruby Library}
+  s.rubygems_version = "1.8.15"
+  s.summary = "Konto API Ruby Library"
   s.test_files = [
     "spec/kontoapi-ruby_spec.rb",
     "spec/spec_helper.rb"

data/lib/kontoapi-ruby.rb

@@ -28,9 +28,9 @@ module KontoAPI
     @@timeout || DEFAULT_TIMEOUT
   end
 
-  def valid?(account_number, bank_code)
-    return false if account_number.to_s.strip.empty? || bank_code.to_s.strip.empty?
-    response = ask_for(:validity, { :ktn => account_number.to_s, :blz => bank_code.to_s })
+  def valid?(options={})
+    return false  unless (!options[:ktn].to_s.strip.empty? && !options[:blz].to_s.strip.empty?) || !options[:iban].to_s.strip.empty? || !options[:bic].to_s.strip.empty?
+    response = ask_for(:validity, options)
     response['answer'].eql?('yes')
   end
 

data/spec/kontoapi-ruby_spec.rb

@@ -3,36 +3,36 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 describe "KontoAPI" do
 
   it "should raise if no api key was provided" do
-    lambda { KontoAPI::valid?('1234567', '12312312') }.should raise_error(RuntimeError)
+    lambda { KontoAPI::valid?( :ktn => '1234567', :blz => '12312312' ) }.should raise_error(RuntimeError)
   end
 
   it "should raise if api key is invalid" do
     FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/validity.json?.*|, :body => '{"error":"unauthenticated"}', :status => ["401", "Unauthorized"])
     KontoAPI::api_key = 'abc123'
-    lambda { KontoAPI::valid?('1234567', '12312312') }.should raise_error(Net::HTTPServerException)
+    lambda { KontoAPI::valid?( :ktn => '1234567', :blz => '12312312' ) }.should raise_error(Net::HTTPServerException)
   end
 
   context "checking validity" do
 
     it "should return false if account number or bank code are empty" do
-      KontoAPI::valid?(nil, nil).should be_false
-      KontoAPI::valid?('123', nil).should be_false
-      KontoAPI::valid?(nil, '123').should be_false
-      KontoAPI::valid?('', '').should be_false
-      KontoAPI::valid?('123', '').should be_false
-      KontoAPI::valid?('', '123').should be_false
+      KontoAPI::valid?( :ktn => nil, :blz => nil ).should be_false
+      KontoAPI::valid?( :ktn => '123', :blz => nil ).should be_false
+      KontoAPI::valid?( :ktn => nil, :blz => '123' ).should be_false
+      KontoAPI::valid?( :ktn => '', :blz => '' ).should be_false
+      KontoAPI::valid?( :ktn => '123', :blz => '' ).should be_false
+      KontoAPI::valid?( :ktn => '', :blz => '123' ).should be_false
     end
 
     it "should return true for successfull validity checks" do
       FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/validity.json?.*|, :body => '{"answer":"yes"}')
       KontoAPI::api_key = 'abc123'
-      KontoAPI::valid?('correct_account_number', '12312312').should be_true
+      KontoAPI::valid?( :ktn => 'correct_account_number', :blz => '12312312' ).should be_true
     end
 
     it "should return false for unsuccessfull validity checks" do
       FakeWeb.register_uri(:get, %r|https://ask\.kontoapi\.de/for/validity.json?.*|, :body => '{"answer":"no"}')
       KontoAPI::api_key = 'abc123'
-      KontoAPI::valid?('incorrect_account_number', '12312312').should be_false
+      KontoAPI::valid?( :ktn => 'incorrect_account_number', :blz => '12312312' ).should be_false
     end
 
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: kontoapi-ruby
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
-  - 1
-  - 1
-  version: 0.1.1
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Jan Schwenzien
@@ -15,12 +15,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-20 00:00:00 Z
+date: 2012-04-08 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: addressable
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -29,12 +27,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  name: addressable
+  prerelease: false
   type: :runtime
-  version_requirements: *id001
+  requirement: *id001
 - !ruby/object:Gem::Dependency 
-  name: yajl-ruby
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -43,12 +41,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  name: yajl-ruby
+  prerelease: false
   type: :runtime
-  version_requirements: *id002
+  requirement: *id002
 - !ruby/object:Gem::Dependency 
-  name: rspec
-  prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -59,12 +57,12 @@ dependencies:
         - 3
         - 0
         version: 2.3.0
+  name: rspec
+  prerelease: false
   type: :development
-  version_requirements: *id003
+  requirement: *id003
 - !ruby/object:Gem::Dependency 
-  name: bundler
-  prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -75,12 +73,12 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
+  name: bundler
+  prerelease: false
   type: :development
-  version_requirements: *id004
+  requirement: *id004
 - !ruby/object:Gem::Dependency 
-  name: jeweler
-  prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -91,12 +89,12 @@ dependencies:
         - 5
         - 2
         version: 1.5.2
+  name: jeweler
+  prerelease: false
   type: :development
-  version_requirements: *id005
+  requirement: *id005
 - !ruby/object:Gem::Dependency 
-  name: rcov
-  prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -105,12 +103,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  name: rcov
+  prerelease: false
   type: :development
-  version_requirements: *id006
+  requirement: *id006
 - !ruby/object:Gem::Dependency 
-  name: fakeweb
-  prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  version_requirements: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -119,8 +117,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  name: fakeweb
+  prerelease: false
   type: :development
-  version_requirements: *id007
+  requirement: *id007
 description: A ruby library to access the Konto API (https://www.kontoapi.de/), a webservice that performs validity checks and other services regarding german bank accounts.
 email: jan@general-scripting.com
 executables: []
@@ -170,7 +170,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.7.2
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Konto API Ruby Library