kontena-cli 0.16.3 → 0.17.0.pre1

data/spec/kontena/cli/stacks/yaml/service_extender_spec.rb

@@ -0,0 +1,128 @@
+require_relative '../../../../spec_helper'
+require 'kontena/cli/stacks/yaml/service_extender'
+
+describe Kontena::Cli::Stacks::YAML::ServiceExtender do
+  let(:options) do
+    {
+      'image' => 'alpine:latest',
+      'ports' => '80:80'
+    }
+  end
+
+  let(:parent_options) do
+    {
+      'build' => '.'
+    }
+  end
+
+  describe '#extend' do
+    it 'merges options' do
+      result = described_class.new(options).extend_from(parent_options)
+      expected_result = {
+        'image' => 'alpine:latest',
+        'build' => '.',
+        'ports' => '80:80',
+        'environment' => [],
+        'secrets' => []
+      }
+      expect(result).to eq(expected_result)
+    end
+
+    context 'environment variables' do
+      it 'inherites env vars from upper level' do
+        from = { 'environment' => ['FOO=bar'] }
+        to = {}
+        result = described_class.new(to).extend_from(from)
+        expect(result['environment']).to eq(['FOO=bar'])
+      end
+
+      it 'overrides values' do
+        from = { 'environment' => ['FOO=bar'] }
+        to = { 'environment' => ['FOO=baz'] }
+        result = described_class.new(to).extend_from(from)
+        expect(result['environment']).to eq(['FOO=baz'])
+      end
+
+      it 'combines variables' do
+        from = { 'environment' => ['FOO=bar'] }
+        to = { 'environment' => ['BAR=baz'] }
+        result = described_class.new(to).extend_from(from)
+        expect(result['environment']).to eq(['BAR=baz', 'FOO=bar'])
+      end
+    end
+
+    context 'secrets' do
+      it 'inherites secrets from upper level' do
+        secret = {
+          'secret' => 'CUSTOMER_DB_PASSWORD',
+          'name' => 'MYSQL_PASSWORD',
+          'type' => 'env'
+        }
+        from = { 'secrets' => [secret] }
+        to = {}
+        result = described_class.new(to).extend_from(from)
+        expect(result['secrets']).to eq([secret])
+      end
+
+      it 'overrides secrets' do
+        from_secret = {
+          'secret' => 'CUSTOMER_DB_PASSWORD',
+          'name' => 'MYSQL_PASSWORD',
+          'type' => 'env'
+        }
+
+        to_secret = {
+          'secret' => 'CUSTOMER_DB_PASSWORD',
+          'name' => 'MYSQL_ROOT_PASSWORD',
+          'type' => 'env'
+        }
+        from = { 'secrets' => [from_secret] }
+        to = { 'secrets' => [to_secret] }
+        result = described_class.new(to).extend_from(from)
+        expect(result['secrets']).to eq([to_secret])
+      end
+
+      it 'combines secrets' do
+        from_secret = {
+          'secret' => 'CUSTOMER_DB_PASSWORD',
+          'name' => 'MYSQL_PASSWORD',
+          'type' => 'env'
+        }
+
+        to_secret = {
+          'secret' => 'CUSTOMER_API_TOKEN',
+          'name' => 'API_TOKEN',
+          'type' => 'env'
+        }
+        from = { 'secrets' => [from_secret] }
+        to = { 'secrets' => [to_secret] }
+        result = described_class.new(to).extend_from(from)
+        expect(result['secrets']).to eq([to_secret, from_secret])
+      end
+    end
+
+    context 'build args' do
+      it 'inherits build args from upper level' do
+        from = { 'build' => { 'args' => {'foo' => 'bar'}} }
+        to = {}
+        result = described_class.new(to).extend_from(from)
+        expect(result['build']['args']).to eq({'foo' => 'bar'})
+      end
+
+      it 'overrides values' do
+        from = { 'build' => { 'args' => {'foo' => 'bar'}} }
+        to = { 'build' => { 'args' => {'foo' => 'baz'}} }
+        result = described_class.new(to).extend_from(from)
+        expect(result['build']['args']).to eq({'foo' => 'baz'})
+      end
+
+      it 'combines variables' do
+        from = { 'build' => { 'args' => {'foo' => 'bar'}} }
+        to = { 'build' => { 'args' => {'baz' => 'baf'}} }
+        result = described_class.new(to).extend_from(from)
+        expect(result['build']['args']).to eq({'foo' => 'bar', 'baz' => 'baf'})
+      end
+    end
+
+  end
+end

data/spec/kontena/cli/stacks/yaml/validator_v3_spec.rb

@@ -0,0 +1,302 @@
+require_relative '../../../../spec_helper'
+require 'kontena/cli/stacks/yaml/validator_v3'
+
+describe Kontena::Cli::Stacks::YAML::ValidatorV3 do
+  describe '#validate_options' do
+    context 'build' do
+      it 'can be string' do
+        result = subject.validate_options('build' => '.')
+        expect(result.valid?).to be_truthy
+        expect(result.errors.key?('build')).to be_falsey
+      end
+
+      it 'can be hash' do
+        result = subject.validate_options('build' => { 'context' => '.' })
+        expect(result.valid?).to be_truthy
+        expect(result.errors.key?('build')).to be_falsey
+      end
+
+      it 'returns error if build is hash and context is missing' do
+        result = subject.validate_options('build' => {})
+        expect(result.valid?).to be_falsey
+        expect(result.errors.key?('build')).to be_truthy
+      end
+
+      it 'returns error if optional dockerfile is not string' do
+        result = subject.validate_options('build' => {
+          'context' => '.',
+          'dockerfile' => 123
+        })
+        expect(result.valid?).to be_falsey
+        expect(result.errors.key?('build')).to be_truthy
+      end
+    end
+    it 'validates image is string' do
+      result = subject.validate_options('image' => true)
+      expect(result.valid?).to be_falsey
+      expect(result.errors.key?('image')).to be_truthy
+    end
+
+    it 'validates stateful is boolean' do
+      result = subject.validate_options('stateful' => 'bool')
+      expect(result.errors.key?('stateful')).to be_truthy
+    end
+
+    it 'validates network_mode is host or bridge' do
+      result = subject.validate_options('network_mode' => 'invalid')
+      expect(result.errors.key?('network_mode')).to be_truthy
+
+      result = subject.validate_options('network_mode' => 'bridge')
+      expect(result.errors.key?('network_mode')).to be_falsey
+
+      result = subject.validate_options('network_mode' => 'host')
+      expect(result.errors.key?('network_mode')).to be_falsey
+    end
+
+    context 'affinity' do
+      it 'is optional' do
+        result = subject.validate_options({})
+        expect(result.errors.key?('affinity')).to be_falsey
+      end
+
+      it 'must be array' do
+        result = subject.validate_options('affinity' => 'node==node1')
+        expect(result.errors.key?('affinity')).to be_truthy
+        result = subject.validate_options('affinity' => ['node==node1'])
+        expect(result.errors.key?('affinity')).to be_falsey
+      end
+
+      it 'validates format' do
+        result = subject.validate_options('affinity' => ['node=node1'])
+        expect(result.errors.key?('affinity')).to be_truthy
+
+        result = subject.validate_options('affinity' => ['node==node1', 'service!=mariadb'])
+        expect(result.errors.key?('affinity')).to be_falsey
+      end
+    end
+
+    context 'command' do
+      it 'is optional' do
+        result = subject.validate_options({})
+        expect(result.errors.key?('command')).to be_falsey
+      end
+
+      it 'must be string or empty' do
+        result = subject.validate_options('command' => 1234)
+        expect(result.errors.key?('command')).to be_truthy
+
+        result = subject.validate_options('command' => nil)
+        expect(result.errors.key?('command')).to be_falsey
+
+        result = subject.validate_options('command' => 'bundle exec rails s')
+        expect(result.errors.key?('command')).to be_falsey
+      end
+    end
+
+    it 'validates cpu_shares is integer' do
+      result = subject.validate_options('cpu_shares' => '1m')
+      expect(result.errors.key?('cpu_shares')).to be_truthy
+      result = subject.validate_options('cpu_shares' => 1024)
+      expect(result.errors.key?('cpu_shares')).to be_falsey
+      result = subject.validate_options({})
+      expect(result.errors.key?('cpu_shares')).to be_falsey
+    end
+
+    it 'validates environment is array or hash' do
+      result = subject.validate_options('environment' => 'KEY=VALUE')
+      expect(result.errors.key?('environment')).to be_truthy
+      result = subject.validate_options('environment' => ['KEY=VALUE'])
+      expect(result.errors.key?('environment')).to be_falsey
+      result = subject.validate_options('environment' => { 'KEY' => 'VALUE' })
+      expect(result.errors.key?('environment')).to be_falsey
+    end
+
+    context 'validates secrets' do
+      it 'must be array' do
+        result = subject.validate_options('secrets' => {})
+        expect(result.errors.key?('secrets')).to be_truthy
+      end
+
+      context 'item' do
+        it 'must contain secret' do
+          result = subject.validate_options('secrets' => [{ 'name' => 'test', 'type' => 'env' }])
+          expect(result.errors.key?('secrets')).to be_truthy
+        end
+
+        it 'must contain name' do
+          result = subject.validate_options('secrets' => [{ 'secret' => 'test', 'type' => 'env' }])
+          expect(result.errors.key?('secrets')).to be_truthy
+        end
+
+        it 'must contain type' do
+          result = subject.validate_options('secrets' => [{ 'secret' => 'test', 'name' => 'test' }])
+          expect(result.errors.key?('secrets')).to be_truthy
+        end
+
+        it 'accepts valid input' do
+          result = subject.validate_options('secrets' =>
+            [
+              {
+                'secret' => 'test',
+                'name' => 'test',
+                'type' => 'env'
+              }
+            ])
+          expect(result.errors.key?('secrets')).to be_falsey
+        end
+      end
+    end
+
+    context 'logging' do
+      context 'options' do
+        it 'must be hash' do
+          result = subject.validate_options('logging' => { 'options' => [] })
+          expect(result.errors.key?('logging')).to be_truthy
+          data = {
+            'logging' => {
+              'options' => {
+                  'syslog-address' => "tcp://192.168.0.42:123"
+              }
+            }
+          }
+          result = subject.validate_options(data)
+          expect(result.errors.key?('logging')).to be_falsey
+        end
+      end
+    end
+
+    context 'hooks' do
+      context 'validates pre_build' do
+        it 'must be array' do
+          result = subject.validate_options('hooks' => { 'pre_build' => {} })
+          expect(result.errors.key?('hooks')).to be_truthy
+          data = {
+            'hooks' => {
+              'pre_build' => [
+                {
+                  'cmd' => 'rake db:migrate'
+                }
+              ]
+            }
+          }
+          result = subject.validate_options(data)
+          expect(result.errors.key?('hooks')).to be_falsey
+        end
+      end
+      context 'post_start' do
+        it 'must be array' do
+          result = subject.validate_options('hooks' => { 'post_start' => {} })
+          expect(result.errors.key?('hooks')).to be_truthy
+          data = {
+            'hooks' => {
+              'post_start' => [
+                {
+                  'name' => 'migrate',
+                  'cmd' => 'rake db:migrate',
+                  'instances' => '*'
+                }
+              ]
+            }
+          }
+          result = subject.validate_options(data)
+          expect(result.errors.key?('hooks')).to be_falsey
+        end
+
+        context 'item' do
+          it 'must contain name' do
+            result = subject.validate_options('hooks' =>
+            {
+              'post_start' => [
+                {
+                  'cmd' => 'rake db:migrate',
+                  'instances' => '1'
+                }
+              ]
+            })
+            expect(result.errors.key?('hooks.post_start')).to be_truthy
+          end
+
+          it 'must contain cmd' do
+            result = subject.validate_options('hooks' =>
+            {
+              'post_start' => [
+                {
+                  'name' => 'migrate',
+                  'instances' => '1'
+                }
+              ]
+            })
+            expect(result.errors.key?('hooks.post_start')).to be_truthy
+          end
+
+          it 'must contain instance number or *' do
+            result = subject.validate_options('hooks' =>
+            {
+              'post_start' => [
+                { 'name' => 'migrate',
+                  'cmd' => 'rake db:migrate'
+                }
+              ]
+            })
+            expect(result.errors.key?('hooks.post_start')).to be_truthy
+            data = {
+              'hooks' => {
+                'post_start' => [
+                  {
+                    'name' => 'migrate',
+                    'cmd' => 'rake db:migrate',
+                    'instances' => 'all',
+                    'oneshot' => true
+                  }
+                ]
+              }
+            }
+            result = subject.validate_options(data)
+            expect(result.errors.key?('hooks.post_start')).to be_truthy
+          end
+
+          it 'may contain boolean oneshot' do
+            data = {
+              'hooks' => {
+                'post_start' => [
+                  {
+                    'name' => 'migrate',
+                    'cmd' => 'rake db:migrate',
+                    'instances' => '*',
+                    'oneshot' => 'true'
+                  }
+                ]
+              }
+            }
+            result = subject.validate_options(data)
+            expect(result.errors.key?('hooks.post_start')).to be_truthy
+          end
+        end
+
+        it 'validates depends_on is array' do
+          result = subject.validate_options('depends_on' => 'web')
+          expect(result.errors.key?('depends_on')).to be_truthy
+
+          result = subject.validate_options('depends_on' => ['web'])
+          expect(result.errors.key?('depends_on')).to be_falsey
+        end
+
+        it 'validates volumes is array' do
+          result = subject.validate_options('volumes' => '/app')
+          expect(result.errors.key?('volumes')).to be_truthy
+
+          result = subject.validate_options('volumes' => ['/app'])
+          expect(result.errors.key?('volumes')).to be_falsey
+        end
+
+        it 'validates volumes_from is array' do
+          result = subject.validate_options('volumes_from' => 'mysql_data')
+          expect(result.errors.key?('volumes_from')).to be_truthy
+
+          result = subject.validate_options('volumes_from' => ['mysql_data'])
+          expect(result.errors.key?('volumes_from')).to be_falsey
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -40,10 +40,12 @@ RSpec.configure do |config|
   end
 
   config.around(:each) do |example|
-    begin
-      example.run
-    rescue SystemExit
-      puts "Got SystemExit: #{$!.message} - Exit code: #{$!.status}"
+    catch :exit_with_error do
+      begin
+        example.run
+      rescue SystemExit
+        puts "Got SystemExit: #{$!.message} - Exit code: #{$!.status}"
+      end
     end
   end
 

data/spec/support/client_helpers.rb

@@ -27,6 +27,7 @@ module ClientHelpers
       RSpec::Mocks.space.proxy_for(File).reset
       allow(subject).to receive(:client).and_return(client)
       allow(subject).to receive(:current_grid).and_return('test-grid')
+      allow(File).to receive(:exist?).with(File.join(Dir.home, '.kontena/certs/.pem')).and_return(false)
       allow(File).to receive(:exist?).with(File.join(Dir.home, '.kontena_client.json')).and_return(true)
       allow(File).to receive(:readable?).with(File.join(Dir.home, '.kontena_client.json')).and_return(true)
       allow(File).to receive(:read).and_call_original