konstructor 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f8f7d3b8b3ecacc95f4337c122cfc4512a77c54
-  data.tar.gz: 142074c98c848d53e43a813d20306d95f275323d
+  metadata.gz: e2e01d5343a1a1b9e7e1ec11b75f657717721964
+  data.tar.gz: a399ad13acee21bf15a41a0b19928442b4923c8e
 SHA512:
-  metadata.gz: 3ac30ef4daa2c4f8c90470b99012df4e506b7f81e846a8ab93d1f6e7407fcdf9d0887ef4e55db0dc02811c97dfffe0cc5ea58372ee59b18d4c22790689887629
-  data.tar.gz: c09a1ea90372ed7a4b49facfabdc84a21df96032095dc01ed2947fb9d4bc3b0c2c3d4eeacd3b874c708093c32fa70ad74664f5a944d43ed02311f329c7d9409d
+  metadata.gz: 856443c125c10b4b8110bcc4289b8d1c03894a9f8d7152873a386e2bd8a7324062e2765a445db16574f9d06852d28c20ae5676ef8ee0c07927bb450bb54b0485
+  data.tar.gz: 182d3b562c86109bf3d7368fbc11ccc426f03c23c7b0d990b1a1d7c6d9950a7ec50c917866a6b7099f6a3afa93f3718d4710d4b5ea001a1b797956db5a1c732c

data/README.md

@@ -239,9 +239,9 @@ since all work is done during class definition and then it's just
 standard Ruby instance creation. 
 
 Cost of `konstructor` declaration at initial load time is roughly the 
-same as declaring 3 properties with `attr_accessor`.
+same as declaring 5 properties with `attr_accessor`.
 ```ruby
-  attr_accessor :one, :two, :three
+  attr_accessor :one, :two, :three, :four, :five
   
   # following declaration takes the same time as above declaration
   konstructor
@@ -254,11 +254,13 @@ for details.
 #### Dependencies and requirements
 
 Konstructor doesn't depend on other gems. 
-Requires Ruby `1.9.3` or higher. 
+Requires Ruby `1.9.3` or higher. Works with JRuby.
   
 #### Thread safety
   
-Konstructor is thread safe.
+Konstructor is thread-safe in both CRuby and JRuby,
+see [Thread safety page](https://github.com/snovity/konstructor/wiki/Thread-safety) 
+for details.
 
 ## Contributing
 

data/Rakefile

@@ -12,25 +12,53 @@ task :benchmark do
   n = 10000
 
   Benchmark.bm(30) do |x|
-    x.report('def:') do
+    x.report('25 def:') do
       n.times do
         Class.new do
-          def one; end
-          def two; end
-          def three; end
-          def four; end
-          def five; end
+          def one1; end
+          def two1; end
+          def three1; end
+          def four1; end
+          def five1; end
+
+          def one2; end
+          def two2; end
+          def three2; end
+          def four2; end
+          def five2; end
+
+          def one3; end
+          def two3; end
+          def three3; end
+          def four3; end
+          def five3; end
+
+          def one4; end
+          def two4; end
+          def three4; end
+          def four4; end
+          def five4; end
+
+          def one5; end
+          def two5; end
+          def three5; end
+          def four5; end
+          def five5; end
         end
       end
     end
-    x.report('attr_accessor:') do
+    x.report('25 props via attr_accessor:') do
       n.times do
         Class.new do
-          attr_accessor :one, :two, :three, :four, :five
+          attr_accessor :one1, :two1, :three1, :four1, :five1,
+                        :one2, :two2, :three2, :four2, :five2,
+                        :one3, :two3, :three3, :four3, :five3,
+                        :one4, :two4, :three4, :four4, :five4,
+                        :one5, :two5, :three5, :four5, :five5
         end
       end
     end
-    x.report('konstructor after:') do
+    x.report(' 5 konstructors after:') do
       n.times do
         Class.new do
           def one; end
@@ -43,7 +71,7 @@ task :benchmark do
         end
       end
     end
-    x.report('konstructor before:') do
+    x.report(' 5 konstructors before:') do
       n.times do
         Class.new do
           konstructor :one, :two, :three, :four, :five
@@ -56,7 +84,7 @@ task :benchmark do
         end
       end
     end
-    x.report('konstructor nameless:') do
+    x.report(' 5 konstructors nameless:') do
       n.times do
         Class.new do
           konstructor

data/konstructor.gemspec

@@ -1,5 +1,7 @@
 # coding: utf-8
-require_relative 'lib/konstructor/version'
+# require_relative 'lib/konstructor/version' <- doesn't work with Ruby 1.9.3 in gemspec when building gem
+require File.expand_path('../lib/konstructor/version', __FILE__)
+
 
 Gem::Specification.new do |spec|
   spec.name          = 'konstructor'

data/lib/konstructor/factory.rb

@@ -5,14 +5,16 @@ module Konstructor
     def initialize(klass)
       @klass = klass
       @konstructor_names = []
-      @next_method_is_konstructor = false
+      # converting string to symbol for much quicker hash lookups
+      @thread_next_method_var_name = :"konstructor#{object_id}"
+      reset_next_method_is_konstructor!
     end
 
     def declare(new_names)
       if new_names.empty?
-        @next_method_is_konstructor = true
+        next_method_is_konstructor!
       else
-        @next_method_is_konstructor = false
+        reset_next_method_is_konstructor!
         process_new_names(new_names)
       end
     end
@@ -24,8 +26,8 @@ module Konstructor
     def method_added_to_klass(name)
       name = name.to_sym
 
-      if @next_method_is_konstructor
-        @next_method_is_konstructor = false
+      if next_method_is_konstructor?
+        reset_next_method_is_konstructor!
         @konstructor_names << name
         process_declaration(name)
       elsif declared?(name)
@@ -35,6 +37,18 @@ module Konstructor
 
     private
 
+    def next_method_is_konstructor!
+      Thread.current[@thread_next_method_var_name] = true
+    end
+
+    def reset_next_method_is_konstructor!
+      Thread.current[@thread_next_method_var_name] = false
+    end
+
+    def next_method_is_konstructor?
+       Thread.current[@thread_next_method_var_name]
+    end
+
     def declared_in_self?(name)
       @konstructor_names.include?(name.to_sym)
     end

data/lib/konstructor/main.rb

@@ -67,6 +67,8 @@ module Konstructor
   DEFAULT_NAMES = [:initialize]
   RESERVED_NAMES = [:new, :initialize]
 
+  extend MonitorMixin
+
   class << self
     def reserved?(name)
       RESERVED_NAMES.include?(name.to_sym)
@@ -90,11 +92,15 @@ module Konstructor
 
     def declare(klass, new_method_names)
       setup_method_added_hook(klass)
-      get_or_init_factory(klass).declare(new_method_names)
+      synchronize do
+        get_or_init_factory(klass).declare(new_method_names)
+      end
     end
 
     def method_added_to_klass(klass, method_name)
-      get_or_init_factory(klass).method_added_to_klass(method_name)
+      synchronize do
+        get_or_init_factory(klass).method_added_to_klass(method_name)
+      end
     end
 
     def is?(klass, method_name)

data/lib/konstructor/version.rb

@@ -1,3 +1,3 @@
 module Konstructor
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: konstructor
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Dima Lashkov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-26 00:00:00.000000000 Z
+date: 2017-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler