konacha 2.4.0 → 2.5.0

data/History.md

@@ -1,5 +1,9 @@
 # master
 
+# 2.5.0
+
+* Made port of the runner configurable
+
 # 2.4.0
 
 * Support requesting files with periods in the name

data/konacha.gemspec

@@ -17,7 +17,7 @@ the asset pipeline and engines.}
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = "konacha"
   gem.require_paths = ["lib"]
-  gem.version       = "2.4.0"
+  gem.version       = "2.5.0"
   gem.license       = "MIT"
 
   gem.add_dependency "railties", ">= 3.1", "< 5"

data/lib/konacha.rb

@@ -29,7 +29,7 @@ module Konacha
       yield config
     end
 
-    delegate :port, :spec_dir, :spec_matcher, :application, :driver, :to => :config
+    delegate :port, :spec_dir, :spec_matcher, :application, :driver, :runner_port, :to => :config
 
     def spec_root
       File.join(Rails.root, config.spec_dir)

data/lib/konacha/engine.rb

@@ -34,6 +34,7 @@ module Konacha
       options.driver       ||= :selenium
       options.stylesheets  ||= %w(application)
       options.verbose      ||= false
+      options.runner_port  ||= nil
 
       app.config.assets.paths << app.root.join(options.spec_dir).to_s
     end

data/lib/konacha/reporter.rb

@@ -16,11 +16,10 @@ module Konacha
       'suite end' => :example_group_finished,
     }
 
-    attr_reader :start_time, :duration, :example_count, :failure_count, :pending_count
+    attr_reader :start_time, :duration, :examples
 
     def initialize(*formatters)
       @formatters = formatters
-      @example_count = @failure_count = @pending_count = 0
       @duration = @start_time = nil
       @examples, @groups = {}, {}
     end
@@ -36,7 +35,7 @@ module Konacha
         process_event :start_dump
         process_event :dump_pending
         process_event :dump_failures
-        process_event :dump_summary, @duration, @example_count, @failure_count, @pending_count
+        process_event :dump_summary, duration, example_count, failure_count, pending_count
         process_event :seed, seed if seed
       ensure
         process_event :close
@@ -49,7 +48,7 @@ module Konacha
     end
 
     def passed?
-      @examples.values.all? { |example| example.passed? || example.pending? }
+      failure_count == 0
     end
 
     def process_mocha_event(event)
@@ -63,23 +62,26 @@ module Konacha
       end
     end
 
-    def process_event(method, *args, &block)
-      case method
-        when :example_started
-          @example_count += 1
-        when :example_failed
-          @failure_count += 1
-        when :example_pending
-          @pending_count += 1
-      end
+    def example_count
+      examples.count
+    end
+
+    def failure_count
+      examples.values.count { |example| example.failed? }
+    end
+
+    def pending_count
+      examples.values.count { |example| example.pending? }
+    end
 
+    def process_event(method, *args, &block)
       @formatters.each do |formatter|
         formatter.send method, *args, &block
       end
     end
 
     def update_or_create_object(data, type)
-      collection = type == 'test' ? @examples : @groups
+      collection = type == 'test' ? examples : @groups
       object = collection[data['fullTitle']]
       if object
         object.update_metadata(data)

data/lib/konacha/runner.rb

@@ -3,6 +3,7 @@ require "capybara"
 module Konacha
   class Runner
     def self.start
+      Capybara.server_port = Konacha.runner_port
       new.run
     end
 

data/spec/konacha_spec.rb

@@ -15,6 +15,12 @@ describe Konacha do
         subject.spec_matcher.should == /_spec\.|_test\./
       end
     end
+
+    describe ".runner_port" do
+      it "defaults to nil" do
+        subject.runner_port.should == nil
+      end
+    end
   end
 
   describe ".spec_paths" do

data/spec/reporter_spec.rb

@@ -73,23 +73,6 @@ describe Konacha::Reporter do
   end
 
   describe "#process_event" do
-    describe "increments counts" do
-      it "increments example count" do
-        subject.process_event(:example_started)
-        subject.example_count.should == 1
-      end
-
-      it "increments pending count" do
-        subject.process_event(:example_pending)
-        subject.pending_count.should == 1
-      end
-
-      it "increments failed count" do
-        subject.process_event(:example_failed)
-        subject.failure_count.should == 1
-      end
-    end
-
     it "forwards the call on to the formatters" do
       formatter.should_receive(:example_started).with('arg!')
       subject.process_event(:example_started, 'arg!')
@@ -120,4 +103,42 @@ describe Konacha::Reporter do
       object.parent.should == suite
     end
   end
+
+  describe "#passed?" do
+    it 'passes if failure count is zero' do
+      subject.should be_passed
+    end
+
+    it 'does not pass if failure count is not zero' do
+      subject.stub(:failure_count => 1)
+      subject.should_not be_passed
+    end
+  end
+
+  context "counters" do
+    describe "#example_count" do
+      it "is 0 by default" do
+        subject.example_count.should be_zero
+      end
+
+      it "returns examples count" do
+        subject.stub(:examples => {:omg => :two, :examples => :wow})
+        subject.example_count.should == 2
+      end
+    end
+
+    describe "#pending_count" do
+      it "returns pending examples count" do
+        subject.stub(:examples => {:first => double(:pending? => true), :second => double(:pending? => false)})
+        subject.pending_count.should == 1
+      end
+    end
+
+    describe "#failure_count" do
+      it "returns failed examples count" do
+        subject.stub(:examples => {:first => double(:failed? => true), :second => double(:failed? => false)})
+        subject.failure_count.should == 1
+      end
+    end
+  end
 end

data/spec/runner_spec.rb

@@ -31,6 +31,14 @@ describe Konacha::Runner do
     end
   end
 
+  describe ".start" do
+    it 'sets the Capybara.server_port' do
+      Capybara.should_receive(:server_port=).with(Konacha.runner_port)
+      Konacha::Runner.any_instance.stub(:run)
+      Konacha::Runner.start
+    end
+  end
+
   shared_examples_for "Konacha::Runner" do |driver|
     before do
       Konacha.configure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: konacha
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-27 00:00:00.000000000 Z
+date: 2013-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -328,7 +328,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2894895241222942879
+      hash: 2309042468152930805
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -337,7 +337,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2894895241222942879
+      hash: 2309042468152930805
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24