koala 1.2.0beta1 → 1.2.1

data/spec/cases/test_users_spec.rb

@@ -13,6 +13,13 @@ describe "Koala::Facebook::TestUsers" do
         raise Exception, "Must supply OAuth app id, secret, app_access_token, and callback to run live subscription tests!"
       end
     end
+    
+    after :each do
+      # clean up any test users
+      ((@network || []) + [@user1, @user2]).each do |u|
+        puts "Unable to delete test user #{u.inspect}" if u && !(@test_users.delete(u) rescue false)
+      end
+    end
 
     describe "when initializing" do
       # basic initialization
@@ -83,14 +90,14 @@ describe "Koala::Facebook::TestUsers" do
       describe ".create" do
         it "should create a test user when not given installed" do
           result = @test_users.create(false)
-          @temporary_object_id = result["id"]
+          @user1 = result["id"]
           result.should be_a(Hash)
           (result["id"] && result["access_token"] && result["login_url"]).should
         end
 
         it "should create a test user when not given installed, ignoring permissions" do
           result = @test_users.create(false, "read_stream")
-          @temporary_object_id = result["id"]
+          @user1 = result["id"]
           result.should be_a(Hash)
           (result["id"] && result["access_token"] && result["login_url"]).should
         end
@@ -107,7 +114,7 @@ describe "Koala::Facebook::TestUsers" do
 
         it "should create a test user when given installed and a permission" do
           result = @test_users.create(true, "read_stream")
-          @temporary_object_id = result["id"]
+          @user1 = result["id"]
           result.should be_a(Hash)
           (result["id"] && result["access_token"] && result["login_url"]).should
         end
@@ -131,11 +138,6 @@ describe "Koala::Facebook::TestUsers" do
           @user2 = @test_users.create(true, "read_stream,user_interests")
         end
 
-        after :each do
-          @test_users.delete(@user1) if @user1
-          @test_users.delete(@user2) if @user2
-        end
-
         it "should delete a user by id" do
           @test_users.delete(@user1['id']).should be_true
           @user1 = nil
@@ -163,24 +165,26 @@ describe "Koala::Facebook::TestUsers" do
       describe ".update" do
         before :each do
           @updates = {:name => "Foo Baz"}
+          # we stub out :graph_call, but still need to be able to delete the users
+          @test_users2 = Koala::Facebook::TestUsers.new(:app_id => @test_users.app_id, :app_access_token => @test_users.app_access_token)
         end
 
         it "makes a POST with the test user Graph API " do
-          user = @test_users.create(true)
-          @test_users.graph_api.should_receive(:graph_call).with(anything, anything, "post", anything)
-          @test_users.update(user, @updates)
+          @user1 = @test_users2.create(true)
+          @test_users2.graph_api.should_receive(:graph_call).with(anything, anything, "post", anything)
+          @test_users2.update(@user1, @updates)
         end
 
         it "makes a request to the test user with the update params " do
-          user = @test_users.create(true)
-          @test_users.graph_api.should_receive(:graph_call).with(user["id"], @updates, anything, anything)
-          @test_users.update(user, @updates)
+          @user1 = @test_users2.create(true)
+          @test_users2.graph_api.should_receive(:graph_call).with(@user1["id"], @updates, anything, anything)
+          @test_users2.update(@user1, @updates)
         end
 
         it "works" do
-          user = @test_users.create(true)
-          @test_users.update(user, @updates)
-          user_info = Koala::Facebook::API.new(user["access_token"]).get_object(user["id"])
+          @user1 = @test_users.create(true)
+          @test_users.update(@user1, @updates)
+          user_info = Koala::Facebook::API.new(@user1["access_token"]).get_object(@user1["id"])
           user_info["name"].should == @updates[:name]
         end
       end
@@ -191,11 +195,6 @@ describe "Koala::Facebook::TestUsers" do
           @user2 = @test_users.create(true, "read_stream,user_interests")
         end
 
-        after :each do
-          @test_users.delete(@user1)
-          @test_users.delete(@user2)
-        end
-
         it "should list test users" do
           result = @test_users.list
           result.should be_an(Array)
@@ -243,16 +242,6 @@ describe "Koala::Facebook::TestUsers" do
       end
 
       describe "tests that create users" do
-        before :each do
-          test_users = Koala::Facebook::TestUsers.new({:app_access_token => @app_access_token, :app_id => @app_id})
-          test_users.delete_all
-        end
-
-        after :each do
-          test_users = Koala::Facebook::TestUsers.new({:app_access_token => @app_access_token, :app_id => @app_id})
-          test_users.delete_all
-        end
-
         it "should create a 5 person network" do
           size = 5
           @network = @test_users.create_network(size)
@@ -261,10 +250,11 @@ describe "Koala::Facebook::TestUsers" do
         end
       end
 
-      it "should limit to a 50 person network" do
-        @test_users.should_receive(:create).exactly(50).times
+      it "has no built-in network size limit" do
+        times = 100
+        @test_users.should_receive(:create).exactly(times).times
         @test_users.stub!(:befriend)
-        @network = @test_users.create_network(51)
+        @network = @test_users.create_network(times)
       end
 
       it "should pass on the installed and permissions parameters to create" do

data/spec/cases/uploadable_io_spec.rb

@@ -86,6 +86,34 @@ describe "Koala::UploadableIO" do
       end
     end
 
+    describe "when given an IO object" do
+      before(:each) do
+        @io = StringIO.open("abcdefgh")
+        @koala_io_params = [@io]
+      end
+
+      describe "and a content type" do
+        before :each do
+          @koala_io_params.concat(["image/jpg"])
+        end
+
+        it "returns an UploadableIO with the same io" do
+          Koala::UploadableIO.new(*@koala_io_params).io_or_path.should == @koala_io_params[0]
+        end
+
+        it "returns an UploadableIO with the same content_type" do
+          content_stub = @koala_io_params[1] = stub('Content Type')
+          Koala::UploadableIO.new(*@koala_io_params).content_type.should == content_stub
+        end
+      end
+
+      describe "and no content type" do
+        it "raises an exception" do
+          lambda { Koala::UploadableIO.new(*@koala_io_params) }.should raise_exception(Koala::KoalaError)
+        end
+      end
+    end
+
     describe "when given a Rails 3 ActionDispatch::Http::UploadedFile" do
       before(:each) do
         @tempfile, @uploaded_file = rails_3_mocks

data/spec/fixtures/facebook_data.yml

@@ -30,11 +30,12 @@ oauth_test_data:
     # note: the tests stub the time class so these default cookies are always valid (if you're using the default app)
     # if not you may want to remove the stubbing to test expiration
     fbs_119908831367602: '"access_token=119908831367602|2.LKE7ksSPOx0V_8mHPr2NHQ__.3600.1273363200-2905623|CMpi0AYbn03Oukzv94AUha2qbO4.&expires=1273363200&secret=lT_9zm5r5IbJ6Aa5O54nFw__&session_key=2.LKE7ksSPOx0V_8mHPr2NHQ__.3600.1273363200-2905623&sig=9515e93113921f9476a4efbdd4a3c746&uid=2905623"'
-  expired_cookies:
-    fbs_119908831367602: '"access_token=119908831367602|2.xv9mi6QSOpr474s4n2X_pw__.3600.1273287600-2905623|yVt5WH_S6J5p3gFa5_5lBzckhws.&expires=1273287600&secret=V_E79ovQnXqxGctFuC_n5A__&session_key=2.xv9mi6QSOpr474s4n2X_pw__.3600.1273287600-2905623&sig=eeef60838c0c800258d89b7e6ddddddb&uid=2905623"'
   offline_access_cookies:
     # note: I've revoked the offline access for security reasons, so you can't make calls against this :)
     fbs_119908831367602: '"access_token=119908831367602|08170230801eb225068e7a70-2905623|Q3LDCYYF8CX9cstxnZLsxiR0nwg.&expires=0&secret=78abaee300b392e275072a9f2727d436&session_key=08170230801eb225068e7a70-2905623&sig=423b8aa4b6fa1f9a571955f8e929d567&uid=2905623"'
+  valid_signed_cookies: 
+    "fbsr_119908831367602": "f1--LHwjHVCxfs97hRHL-4cF-0jNxZRc6MGzo1qHLb0.eyJhbGdvcml0aG0iOiJITUFDLVNIQTI1NiIsImNvZGUiOiIyLkFRQm90a0pBWlhVY1l3RkMuMzYwMC4xMzE0ODEzNjAwLjEtMjkwNTYyM3x4V2xya0d0UmJIZlpIclRnVWwxQmxJcVhRbjQiLCJpc3N1ZWRfYXQiOjEzMTQ4MDY2NTUsInVzZXJfaWQiOiIyOTA1NjIzIn0"
+
 
   # These values from the OAuth Playground (see above) will work out of the box
   # You can update this to live data if desired

data/spec/fixtures/mock_facebook_responses.yml

@@ -33,6 +33,10 @@ rest_api:
       get:
         with_token: '[{"name":"query1", "fql_result_set":[{"first_name":"Luke"}]},{"name":"query2", "fql_result_set":[{"first_name":"Alex"}]}]'
         no_token: '[{"name":"query1", "fql_result_set":[{"first_name":"Luke"}]},{"name":"query2", "fql_result_set":[{"first_name":"Alex"}]}]'
+  /method/admin.setAppProperties:
+    'properties={"desktop":0}':
+      post:
+        with_token: 'true'
 
 
 
@@ -87,10 +91,10 @@ graph_api:
         with_token: '[{"headers":[{"name":"Location","value":"http://google.com"}]}]'
     batch=<%= MultiJson.encode([{"method" => "get", "relative_url" => "me"},{"method" => "get", "relative_url" => "me/friends"}]) %>:
       post:
-        with_token: '[{"body":"{\"id\":\"123\"}"}, {"body":"{\"data\":[]}"}]'
+        with_token: '[{"body":"{\"id\":\"123\"}"}, {"body":"{\"data\":[],\"paging\":{}}"}]'
     batch=<%= MultiJson.encode([{"method"=>"get", "relative_url"=>"me"}, {"method"=>"get", "relative_url"=>"#{OAUTH_DATA["app_id"]}/insights?access_token=#{CGI.escape APP_ACCESS_TOKEN}"}]) %>:
       post:
-        with_token: '[{"body":"{\"id\":\"123\"}"}, {"body":"{\"data\":[]}"}]'
+        with_token: '[{"body":"{\"id\":\"123\"}"}, {"body":"{\"data\":[],\"paging\":{}}"}]'
     batch=<%= MultiJson.encode([{"method"=>"get", "relative_url"=>"#{OAUTH_DATA["app_id"]}/insights"}, {"method"=>"get", "relative_url"=>"koppel?access_token=#{CGI.escape APP_ACCESS_TOKEN}"}]) %>:
       post:
         with_token: '[{"body": "{\"error\":{\"type\":\"AnError\", \"message\":\"An error occurred!.\"}}"},{"body":"{\"id\":\"123\"}"}]'
@@ -113,7 +117,7 @@ graph_api:
         with_token: '[null,{"body":"{}"}]'
     batch=<%= MultiJson.encode([{"method" => "get", "relative_url" => "me/friends?limit=5", "name" => "get-friends", "omit_response_on_success" => false}, {"method" => "get", "relative_url" => "?ids=#{CGI.escape "{result=get-friends:$.data.*.id}"}"}]) %>:
       post:
-        with_token: '[{"body":"{\"data\":[]}"},{"body":"{}"}]'
+        with_token: '[{"body":"{\"data\":[],\"paging\":{}}"},{"body":"{}"}]'
     batch=<%= MultiJson.encode([{"method" => "get", "relative_url" => "me/friends?limit=5"}, {"method" => "get", "relative_url" => "?ids=#{CGI.escape "{result=i-dont-exist:$.data.*.id}"}"}]) %>:
       post:
         with_token: '{"error":190,"error_description":"Error validating access token."}'
@@ -148,6 +152,12 @@ graph_api:
     message=Hello, world, from the test suite, testing comments!:
       post:
         with_token: '{"id": "MOCK_FEED_ITEM"}'
+    message=Hello, world, from the test suite, testing comments again!:
+      post:
+        with_token: '{"id": "MOCK_FEED_ITEM"}'
+    message=Hello, world, from the test suite, testing liking!:
+      post:
+        with_token: '{"id": "MOCK_FEED_ITEM"}'
     message=the cats are asleep:
       post:
         with_token: '{"id": "FEED_ITEM_CATS"}'
@@ -160,6 +170,9 @@ graph_api:
     link=http://oauth.twoalex.com/&message=Hello, world, from the test suite again!&name=OAuth Playground:
       post:
         with_token: '{"id": "FEED_ITEM_CONTEXT"}'
+    link=http://oauth.twoalex.com/&message=body&name=It's a big question&picture=http://oauth.twoalex.com//images/logo.png&properties=<%= {"name"=>"Link1'", "text"=>"Left", "href"=>"http://oauth.twoalex.com/"}.to_s %>=<%= {"name"=>"other", "text"=>"Straight ahead"}.to_s %>&type=link:
+      post:
+        with_token: '{"id": "FEED_ITEM_CONTEXT"}'        
 
   /me/photos:
     source=[FILE]:
@@ -211,7 +224,7 @@ graph_api:
     no_args:
       get:
         <<: *token_required
-        with_token: '{"data": [{}]}'
+        with_token: '{"data": [{}], "paging": {}}'
 
   /lukeshepard/picture:
     type=large:
@@ -261,7 +274,7 @@ graph_api:
       get:
         with_token: '{"data": [{"id": "507731521_100412693339488"}], "paging": {"previous": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000", "next": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000"}}'
         no_token: '{"data": [{"id": "507731521_100412693339488"}], "paging": {"previous": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000", "next": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000"}}'
-    "limit=25&q=facebook&until=2010-09-23T21:17:33+0000":
+    "limit=25&q=facebook&until=<%= TEST_DATA['search_time'] %>":
       get:
         with_token: '{"data": [{"id": "507731521_100412693339488"}], "paging": {"previous": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000", "next": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000"}}'
         no_token: '{"data": [{"id": "507731521_100412693339488"}], "paging": {"previous": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000", "next": "https:\/\/graph.facebook.com\/7204941866\/photos?limit=25&until=2008-09-15T18%3A30%3A25%2B0000"}}'