koala 1.2.0 → 1.3.0

data/spec/support/koala_test.rb

@@ -4,6 +4,7 @@ module KoalaTest
   class << self
     attr_accessor :oauth_token, :app_id, :secret, :app_access_token, :code, :session_key
     attr_accessor :oauth_test_data, :subscription_test_data, :search_time
+    attr_accessor :test_user_api
   end
     
   # Test setup
@@ -28,7 +29,7 @@ module KoalaTest
       KoalaTest.setup_test_data(live_data)
 
       # allow live tests with different adapters
-      adapter = ENV['ADAPTER'] || "typhoeus"# use Typhoeus by default if available
+      adapter = ENV['ADAPTER'] || "typhoeus" # use Typhoeus by default if available
       begin
         require adapter
         Faraday.default_adapter = adapter.to_sym
@@ -57,16 +58,16 @@ module KoalaTest
       end
 
       config.after :each do
-        # clean up any objects posted to Facebook
-        if @temporary_object_id && !KoalaTest.mock_interface?
-          api = @api || (@test_users ? @test_users.graph_api : nil)
-          raise "Unable to locate API when passed temporary object to delete!" unless api
+        # if we're working with a real user, clean up any objects posted to Facebook
+        # no need to do so for test users, since they get deleted at the end
+        if @temporary_object_id && KoalaTest.real_user?
+          raise "Unable to locate API when passed temporary object to delete!" unless @api
 
           # wait 10ms to allow Facebook to propagate data so we can delete it
           sleep(0.01)
 
           # clean up any objects we've posted
-          result = (api.delete_object(@temporary_object_id) rescue false)
+          result = (@api.delete_object(@temporary_object_id) rescue false)
           # if we errored out or Facebook returned false, track that
           puts "Unable to delete #{@temporary_object_id}: #{result} (probably a photo or video, which can't be deleted through the API)" unless result
         end
@@ -94,19 +95,16 @@ module KoalaTest
   end
   
   def self.setup_test_users
-    # note: we don't have to delete the two test users explicitly, since the test user specs do that for us
-    # technically, this is a point of brittleness and would break if the tests were run out of order
-    # however, for now we can live with it since it would slow tests way too much to constantly recreate our test users
     print "Setting up test users..."
     @test_user_api = Koala::Facebook::TestUsers.new(:app_id => self.app_id, :secret => self.secret)
 
     RSpec.configure do |config|
-      config.before :all do
+      config.before :suite do
         # before each test module, create two test users with specific names and befriend them
         KoalaTest.create_test_users
       end
       
-      config.after :all do
+      config.after :suite do
         # after each test module, delete the test users to avoid cluttering up the application
         KoalaTest.destroy_test_users
       end
@@ -116,10 +114,15 @@ module KoalaTest
   end
 
   def self.create_test_users
-    @live_testing_user = @test_user_api.create(true, KoalaTest.testing_permissions, :name => KoalaTest.user1_name)
-    @live_testing_friend = @test_user_api.create(true, KoalaTest.testing_permissions, :name => KoalaTest.user2_name)
-    @test_user_api.befriend(@live_testing_user, @live_testing_friend)
-    self.oauth_token = @live_testing_user["access_token"]
+    begin
+      @live_testing_user = @test_user_api.create(true, KoalaTest.testing_permissions, :name => KoalaTest.user1_name)
+      @live_testing_friend = @test_user_api.create(true, KoalaTest.testing_permissions, :name => KoalaTest.user2_name)
+      @test_user_api.befriend(@live_testing_user, @live_testing_friend)
+      self.oauth_token = @live_testing_user["access_token"]
+    rescue Exception => e
+      Kernel.warn("Problem creating test users! #{e.message}")
+      raise
+    end    
   end
   
   def self.destroy_test_users
@@ -144,7 +147,7 @@ module KoalaTest
   
   # Info about the testing environment
   def self.real_user?
-    !(mock_interface? || @test_user)
+    !(mock_interface? || @test_user_api)
   end
 
   def self.test_user?
@@ -157,10 +160,13 @@ module KoalaTest
 
   # Data for testing
   def self.user1
+    # user ID, either numeric or username
     test_user? ? @live_testing_user["id"] : "koppel"
   end
 
   def self.user1_id
+    # numerical ID, used for FQL
+    # (otherwise the two IDs are interchangeable)
     test_user? ? @live_testing_user["id"] : 2905623
   end
 
@@ -169,10 +175,12 @@ module KoalaTest
   end
 
   def self.user2
+    # see notes for user1
     test_user? ? @live_testing_friend["id"] : "lukeshepard"
   end
 
   def self.user2_id
+    # see notes for user1
     test_user? ? @live_testing_friend["id"] : 2901279
   end
 
@@ -184,4 +192,7 @@ module KoalaTest
     "contextoptional"
   end
 
+  def self.app_properties
+    mock_interface? ? {"desktop" => 0} : {"description" => "A test framework for Koala and its users.  (#{rand(10000).to_i})"}
+  end
 end

data/spec/support/mock_http_service.rb

@@ -56,9 +56,9 @@ module Koala
 
         # create response class object
         response_object = if response.is_a? String
-            Koala::Response.new(200, response, {})
+            Koala::HTTPService::Response.new(200, response, {})
           else
-            Koala::Response.new(response["code"] || 200, response["body"] || "", response["headers"] || {})
+            Koala::HTTPService::Response.new(response["code"] || 200, response["body"] || "", response["headers"] || {})
           end
 
       rescue NoMethodError

data/spec/support/rest_api_shared_examples.rb

@@ -1,7 +1,7 @@
 shared_examples_for "Koala RestAPI" do
   # REST_CALL
   describe "when making a rest request" do
-    it "should use the proper path" do
+    it "uses the proper path" do
       method = stub('methodName')
       @api.should_receive(:api).with(
         "method/#{method}",
@@ -13,7 +13,7 @@ shared_examples_for "Koala RestAPI" do
       @api.rest_call(method)
     end
 
-    it "should always use the rest api" do
+    it "always uses the rest api" do
       @api.should_receive(:api).with(
         anything,
         anything,
@@ -24,7 +24,7 @@ shared_examples_for "Koala RestAPI" do
       @api.rest_call('anything')
     end
 
-    it "should set the read_only option to true if the method is listed in the read-only list" do
+    it "sets the read_only option to true if the method is listed in the read-only list" do
       method = Koala::Facebook::RestAPI::READ_ONLY_METHODS.first
 
       @api.should_receive(:api).with(
@@ -37,7 +37,7 @@ shared_examples_for "Koala RestAPI" do
       @api.rest_call(method)
     end
 
-    it "should set the read_only option to false if the method is not inthe read-only list" do
+    it "sets the read_only option to false if the method is not inthe read-only list" do
       method = "I'm not a read-only method"
 
       @api.should_receive(:api).with(
@@ -51,7 +51,7 @@ shared_examples_for "Koala RestAPI" do
     end
 
 
-    it "should take an optional hash of arguments" do
+    it "takes an optional hash of arguments" do
       args = {:arg1 => 'arg1'}
 
       @api.should_receive(:api).with(
@@ -64,7 +64,7 @@ shared_examples_for "Koala RestAPI" do
       @api.rest_call('anything', args)
     end
 
-    it "should always ask for JSON" do
+    it "always asks for JSON" do
       @api.should_receive(:api).with(
         anything,
         hash_including('format' => 'json'),
@@ -75,7 +75,7 @@ shared_examples_for "Koala RestAPI" do
       @api.rest_call('anything')
     end
 
-    it "should pass any options provided to the API" do
+    it "passes any options provided to the API" do
       options = {:a => 2}
 
       @api.should_receive(:api).with(
@@ -111,175 +111,59 @@ shared_examples_for "Koala RestAPI" do
       @api.rest_call('anything', {}, {}, method)
     end
 
-    it "should throw an APIError if the result hash has an error key" do
-      Koala.stub(:make_request).and_return(Koala::Response.new(500, {"error_code" => "An error occurred!"}, {}))
-      lambda { @api.rest_call("koppel", {}) }.should raise_exception(Koala::Facebook::APIError)
+    it "throws an APIError if the result hash has an error key" do
+      Koala.stub(:make_request).and_return(Koala::HTTPService::Response.new(500, {"error_code" => "An error occurred!"}, {}))
+      lambda { @api.rest_call(KoalaTest.user1, {}) }.should raise_exception(Koala::Facebook::APIError)
     end
+  end
 
-    describe "when making a FQL request" do
-      it "should call fql.query method" do
-        @api.should_receive(:rest_call).with(
-          "fql.query", anything, anything
-        ).and_return(Koala::Response.new(200, "2", {}))
-
-        @api.fql_query stub('query string')
-      end
-
-      it "should pass a query argument" do
-        query = stub('query string')
-
-        @api.should_receive(:rest_call).with(
-          anything, hash_including(:query => query), anything
-        )
-
-        @api.fql_query(query)
-      end
-
-      it "should pass on any other arguments provided" do
-        args = {:a => 2}
-        @api.should_receive(:rest_call).with(anything, hash_including(args), anything)
-        @api.fql_query("a query", args)
-      end
-
-      it "should pass on any http options provided" do
-        opts = {:a => 2}
-        @api.should_receive(:rest_call).with(anything, anything, hash_including(opts))
-        @api.fql_query("a query", {}, opts)
-      end
-    end
-
-    describe "when making a FQL-multiquery request" do
-      it "should call fql.multiquery method" do
-        @api.should_receive(:rest_call).with(
-          "fql.multiquery", anything, anything
-        ).and_return({})
-
-        @api.fql_multiquery 'query string'
-      end
-
-      it "should pass a queries argument" do
-        queries = stub('query string')
-        queries_json = "some JSON"
-        MultiJson.stub(:encode).with(queries).and_return(queries_json)
-
-        @api.should_receive(:rest_call).with(
-          anything,
-          hash_including(:queries => queries_json),
-          anything
-        )
-
-        @api.fql_multiquery(queries)
-      end
-
-      it "simplifies the response format" do
-        raw_results = [
-          {"name" => "query1", "fql_result_set" => [1, 2, 3]},
-          {"name" => "query2", "fql_result_set" => [:a, :b, :c]}
-        ]
-        expected_results = {
-          "query1" => [1, 2, 3],
-          "query2" => [:a, :b, :c]
-        }
-
-        @api.stub(:rest_call).and_return(raw_results)
-        results = @api.fql_multiquery({:query => true})
-        results.should == expected_results
-      end
-
-      it "should pass on any other arguments provided" do
-        args = {:a => 2}
-        @api.should_receive(:rest_call).with(anything, hash_including(args), anything)
-        @api.fql_multiquery("a query", args)
-      end
-
-      it "should pass on any http options provided" do
-        opts = {:a => 2}
-        @api.should_receive(:rest_call).with(anything, anything, hash_including(opts))
-        @api.fql_multiquery("a query", {}, opts)
-      end
-    end
+  it "can use the beta tier" do
+    @api.rest_call("fql.query", {:query => "select first_name from user where uid = #{KoalaTest.user2_id}"}, :beta => true)
   end
 end
 
 shared_examples_for "Koala RestAPI with an access token" do
-  # FQL
-  it "should be able to access public information via FQL" do
-    result = @api.fql_query("select first_name from user where uid = #{KoalaTest.user2_id}")
-    result.size.should == 1
-    result.first['first_name'].should == KoalaTest.user2_name
-  end
-
-  it "should be able to access public information via FQL.multiquery" do
-    result = @api.fql_multiquery(
-      :query1 => "select first_name from user where uid = #{KoalaTest.user2_id}",
-      :query2 => "select first_name from user where uid = #{KoalaTest.user1_id}"
-    )
-    result.size.should == 2
-    result["query1"].first['first_name'].should == KoalaTest.user2_name
-    result["query2"].first['first_name'].should == KoalaTest.user1_name
-  end
-
-  it "should be able to access protected information via FQL" do
-    # Tests agains the permissions fql table
-
-    # get the current user's ID
-    # we're sneakily using the Graph API, which should be okay since it has its own tests
-    g = Koala::Facebook::API.new(@token)
-    id = g.get_object("me", :fields => "id")["id"]
+  describe "#set_app_properties" do
+    it "sends Facebook the properties JSON-encoded as :properties" do
+      props = {:a => 2, :c => [1, 2, "d"]}
+      @api.should_receive(:rest_call).with(anything, hash_including(:properties => MultiJson.encode(props)), anything, anything)
+      @api.set_app_properties(props)
+    end
 
-    # now send a query about your permissions
-    result = @api.fql_query("select read_stream from permissions where uid = #{id}")
+    it "calls the admin.setAppProperties method" do
+      @api.should_receive(:rest_call).with("admin.setAppProperties", anything, anything, anything)
+      @api.set_app_properties({})
+    end
 
-    result.size.should == 1
-    # we've verified that you have read_stream permissions, so we can test against that
-    result.first["read_stream"].should == 1
-  end
+    it "includes any other provided arguments" do
+      args = {:c => 3, :d => "a"}
+      @api.should_receive(:rest_call).with(anything, hash_including(args), anything, anything)
+      @api.set_app_properties({:a => 2}, args)
+    end
 
+    it "includes any http_options provided" do
+      opts = {:c => 3, :d => "a"}
+      @api.should_receive(:rest_call).with(anything, anything, opts, anything)
+      @api.set_app_properties({}, {}, opts)
+    end
+    
+    it "makes a POST" do
+      @api.should_receive(:rest_call).with(anything, anything, anything, "post")
+      @api.set_app_properties({})
+    end
 
-  it "should be able to access protected information via FQL.multiquery" do
-    result = @api.fql_multiquery(
-      :query1 => "select post_id from stream where source_id = me()",
-      :query2 => "select fromid from comment where post_id in (select post_id from #query1)",
-      :query3 => "select uid, name from user where uid in (select fromid from #query2)"
-    )
-    result.size.should == 3
-    result.keys.should include("query1", "query2", "query3")
+    it "can set app properties using the app's access token" do
+      oauth = Koala::Facebook::OAuth.new(KoalaTest.app_id, KoalaTest.secret)
+      app_token = oauth.get_app_access_token
+      @app_api = Koala::Facebook::API.new(app_token)
+      @app_api.set_app_properties(KoalaTest.app_properties).should be_true
+    end
   end
-
 end
 
 
 shared_examples_for "Koala RestAPI without an access token" do
-  # FQL_QUERY
-  describe "when making a FQL request" do
-    it "should be able to access public information via FQL" do
-      result = @api.fql_query("select first_name from user where uid = #{KoalaTest.user2_id}")
-      result.size.should == 1
-      result.first['first_name'].should == KoalaTest.user2_name
-    end
-
-    it "should be able to access public information via FQL.multiquery" do
-      result = @api.fql_multiquery(
-        :query1 => "select first_name from user where uid = #{KoalaTest.user2_id}",
-        :query2 => "select first_name from user where uid = #{KoalaTest.user1_id}"
-      )
-      result.size.should == 2
-      result["query1"].first['first_name'].should == KoalaTest.user2_name
-      result["query2"].first['first_name'].should == KoalaTest.user1_name
-    end
-
-    it "should not be able to access protected information via FQL" do
-      lambda { @api.fql_query("select read_stream from permissions where uid = #{KoalaTest.user2_id}") }.should raise_error(Koala::Facebook::APIError)
-    end
-
-    it "should not be able to access protected information via FQL.multiquery" do
-      lambda {
-        @api.fql_multiquery(
-          :query1 => "select post_id from stream where source_id = me()",
-          :query2 => "select fromid from comment where post_id in (select post_id from #query1)",
-          :query3 => "select uid, name from user where uid in (select fromid from #query2)"
-        )
-      }.should raise_error(Koala::Facebook::APIError)
-    end
+  it "can't use set_app_properties" do
+    lambda { @api.set_app_properties(:desktop => 0) }.should raise_error(Koala::Facebook::APIError)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: koala
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-09-27 00:00:00.000000000Z
+date: 2011-10-04 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70248641333480 !ruby/object:Gem::Requirement
+  requirement: &70194747941160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70248641333480
+  version_requirements: *70194747941160
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70248641333000 !ruby/object:Gem::Requirement
+  requirement: &70194747940100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,21 +32,21 @@ dependencies:
         version: 0.7.0
   type: :runtime
   prerelease: false
-  version_requirements: *70248641333000
+  version_requirements: *70194747940100
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70248641332520 !ruby/object:Gem::Requirement
+  requirement: &70194747938880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: 2.8.0rc1
   type: :development
   prerelease: false
-  version_requirements: *70248641332520
+  version_requirements: *70194747938880
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70248641332040 !ruby/object:Gem::Requirement
+  requirement: &70194747937740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 0.8.7
   type: :development
   prerelease: false
-  version_requirements: *70248641332040
+  version_requirements: *70194747937740
 description: Koala is a lightweight, flexible Ruby SDK for Facebook.  It allows read/write
   access to the social graph via the Graph and REST APIs, as well as support for realtime
   updates and OAuth and Facebook Connect authentication.  Koala is fully tested and
@@ -69,39 +69,45 @@ extra_rdoc_files:
 files:
 - .autotest
 - .gitignore
+- .rspec
 - .travis.yml
+- .yardopts
 - CHANGELOG
 - Gemfile
+- Guardfile
 - LICENSE
 - Manifest
 - Rakefile
 - autotest/discover.rb
 - koala.gemspec
 - lib/koala.rb
-- lib/koala/batch_operation.rb
-- lib/koala/graph_api.rb
-- lib/koala/graph_batch_api.rb
-- lib/koala/graph_collection.rb
+- lib/koala/api.rb
+- lib/koala/api/batch_operation.rb
+- lib/koala/api/graph_api.rb
+- lib/koala/api/graph_batch_api.rb
+- lib/koala/api/graph_collection.rb
+- lib/koala/api/legacy.rb
+- lib/koala/api/rest_api.rb
 - lib/koala/http_service.rb
+- lib/koala/http_service/multipart_request.rb
+- lib/koala/http_service/response.rb
+- lib/koala/http_service/uploadable_io.rb
 - lib/koala/oauth.rb
 - lib/koala/realtime_updates.rb
-- lib/koala/rest_api.rb
 - lib/koala/test_users.rb
-- lib/koala/uploadable_io.rb
 - lib/koala/utils.rb
 - lib/koala/version.rb
 - readme.md
 - spec/cases/api_spec.rb
 - spec/cases/error_spec.rb
-- spec/cases/graph_and_rest_api_spec.rb
 - spec/cases/graph_api_batch_spec.rb
-- spec/cases/graph_api_spec.rb
 - spec/cases/graph_collection_spec.rb
 - spec/cases/http_service_spec.rb
 - spec/cases/koala_spec.rb
+- spec/cases/legacy_spec.rb
+- spec/cases/multipart_request_spec.rb
 - spec/cases/oauth_spec.rb
 - spec/cases/realtime_updates_spec.rb
-- spec/cases/rest_api_spec.rb
 - spec/cases/test_users_spec.rb
 - spec/cases/uploadable_io_spec.rb
 - spec/cases/utils_spec.rb
@@ -110,6 +116,7 @@ files:
 - spec/fixtures/facebook_data.yml
 - spec/fixtures/mock_facebook_responses.yml
 - spec/spec_helper.rb
+- spec/support/custom_matchers.rb
 - spec/support/graph_api_shared_examples.rb
 - spec/support/json_testing_fix.rb
 - spec/support/koala_test.rb
@@ -135,7 +142,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2837078681376474267
+      hash: 3741350754426721879
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -144,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '1.2'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.8
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: A lightweight, flexible library for Facebook with support for the Graph API,
@@ -152,15 +159,14 @@ summary: A lightweight, flexible library for Facebook with support for the Graph
 test_files:
 - spec/cases/api_spec.rb
 - spec/cases/error_spec.rb
-- spec/cases/graph_and_rest_api_spec.rb
 - spec/cases/graph_api_batch_spec.rb
-- spec/cases/graph_api_spec.rb
 - spec/cases/graph_collection_spec.rb
 - spec/cases/http_service_spec.rb
 - spec/cases/koala_spec.rb
+- spec/cases/legacy_spec.rb
+- spec/cases/multipart_request_spec.rb
 - spec/cases/oauth_spec.rb
 - spec/cases/realtime_updates_spec.rb
-- spec/cases/rest_api_spec.rb
 - spec/cases/test_users_spec.rb
 - spec/cases/uploadable_io_spec.rb
 - spec/cases/utils_spec.rb
@@ -169,6 +175,7 @@ test_files:
 - spec/fixtures/facebook_data.yml
 - spec/fixtures/mock_facebook_responses.yml
 - spec/spec_helper.rb
+- spec/support/custom_matchers.rb
 - spec/support/graph_api_shared_examples.rb
 - spec/support/json_testing_fix.rb
 - spec/support/koala_test.rb
@@ -176,3 +183,4 @@ test_files:
 - spec/support/ordered_hash.rb
 - spec/support/rest_api_shared_examples.rb
 - spec/support/uploadable_io_shared_examples.rb
+has_rdoc: 

data/lib/koala/batch_operation.rb

@@ -1,74 +0,0 @@
-module Koala
-  module Facebook
-    class BatchOperation
-      attr_reader :access_token, :http_options, :post_processing, :files, :batch_api, :identifier
-
-      @identifier = 0
-
-      def self.next_identifier
-        @identifier += 1
-      end
-
-      def initialize(options = {})
-        @identifier = self.class.next_identifier
-        @args = (options[:args] || {}).dup # because we modify it below
-        @access_token = options[:access_token]
-        @http_options = (options[:http_options] || {}).dup # dup because we modify it below
-        @batch_args = @http_options.delete(:batch_args) || {}
-        @url = options[:url]
-        @method = options[:method].to_sym
-        @post_processing = options[:post_processing]
-
-        process_binary_args
-
-        raise Koala::KoalaError, "Batch operations require an access token, none provided." unless @access_token
-      end
-
-      def to_batch_params(main_access_token)
-        # set up the arguments
-        args_string = Koala.http_service.encode_params(@access_token == main_access_token ? @args : @args.merge(:access_token => @access_token))
-
-        response = {
-          :method => @method.to_s,
-          :relative_url => @url,
-        }
-
-        # handle batch-level arguments, such as name, depends_on, and attached_files
-        @batch_args[:attached_files] = @files.keys.join(",") if @files
-        response.merge!(@batch_args) if @batch_args
-
-        # for get and delete, we append args to the URL string
-        # otherwise, they go in the body
-        if args_string.length > 0
-          if args_in_url?
-            response[:relative_url] += (@url =~ /\?/ ? "&" : "?") + args_string if args_string.length > 0
-          else
-            response[:body] = args_string if args_string.length > 0
-          end
-        end
-
-        response
-      end
-
-      protected
-
-      def process_binary_args
-        # collect binary files
-        @args.each_pair do |key, value|
-          if UploadableIO.binary_content?(value)
-            @files ||= {}
-            # we use a class-level counter to ensure unique file identifiers across multiple batch operations
-            # (this is thread safe, since we just care about uniqueness)
-            # so remove the file from the original hash and add it to the file store
-            id = "op#{identifier}_file#{@files.keys.length}"
-            @files[id] = @args.delete(key).is_a?(UploadableIO) ? value : UploadableIO.new(value)
-          end
-        end
-      end
-
-      def args_in_url?
-        @method == :get || @method == :delete
-      end
-    end
-  end
-end