koala 1.0.0 → 1.2.0

data/.autotest

@@ -0,0 +1,12 @@
+# Override autotest default magic to rerun all tests every time a
+# change is detected on the file system.
+class Autotest
+  
+  def get_to_green
+    begin
+      rerun_all_tests
+      wait_for_changes unless all_good
+    end until all_good
+  end
+                            
+end

data/.gitignore

@@ -1,3 +1,5 @@
 pkg
 .project
-Gemfile.lock
+Gemfile.lock
+.rvmrc
+*.rbc

data/.travis.yml

@@ -0,0 +1,9 @@
+rvm:
+  - 1.8.7 # (current default)
+  - 1.9.2
+  - 1.9.3
+  - ruby-head
+  - rbx
+  - rbx-2.0
+  - ree
+  - jruby

data/CHANGELOG

@@ -1,3 +1,62 @@
+v1.2
+New methods:
+-- API is now the main API class, contains both Graph and REST methods
+  -- Old classes are aliased with deprecation warnings (non-breaking change)
+-- TestUsers#update lets you update the name or password of an existing test user
+-- API.get_page_access_token lets you easily fetch the access token for a page you manage (thanks, marcgg!)
+-- Added version.rb (Koala::VERSION)
+Updated methods:
+-- OAuth now parses Facebook's new signed cookie format
+-- API.put_picture now accepts URLs to images (thanks, marcgg!)
+-- Bug fixes to put_picture, parse_signed_request, and the test suite (thanks, johnbhall and Will S.!)
+-- Smarter GraphCollection use
+  -- Any pageable result will now become a GraphCollection
+  -- Non-pageable results from get_connections no longer error
+  -- GraphCollection.raw_results allows access to original result data
+-- Koala no longer enforces any limits on the number of test users you create at once
+Internal improvements:
+-- Koala now uses Faraday to make requests, replacing the HTTPServices (see wiki)
+  -- Koala::HTTPService.http_options allows specification of default Faraday connection options
+  -- Koala::HTTPService.faraday_middleware allows custom middleware configurations
+  -- Koala now defaults to Net::HTTP rather than Typhoeus
+  -- Koala::NetHTTPService and Koala::TyphoeusService modules no longer exist
+  -- Koala no longer automatically switches to Net::HTTP when uploading IO objects to Facebook
+-- RealTimeUpdates and TestUsers are no longer subclasses of API, but have their own .api objects
+  -- The old .graph_api accessor is aliases to .api with a deprecation warning
+-- Removed deprecation warnings for pre-1.1 batch interface
+Testing improvements:
+-- Live test suites now run against test users by default
+  -- Test suite can be repeatedly run live without having to update facebook_data.yml
+  -- OAuth code and session key tests cannot be run against test users
+-- Faraday adapter for live tests can be specified with ADAPTER=[your adapter] in the rspec command
+-- Live tests can be run against the beta server by specifying BETA=true in the rspec command
+-- Tests now pass against all rubies on Travis CI
+-- Expanded and refactored test coverage
+-- Fixed bug with YAML parsing in Ruby 1.9
+
+v1.1
+New methods:
+-- Added Batch API support (thanks, seejohnrun and spiegela!)
+  -- includes file uploads, error handling, and FQL
+-- Added GraphAPI#put_video
+-- Added GraphAPI#get_comments_for_urls (thanks, amrnt!)
+-- Added RestAPI#fql_multiquery, which simplifies the results (thanks, amrnt!)
+-- HTTP services support global proxy and timeout settings (thanks, itchy!)
+-- Net::HTTP supports global ca_path, ca_file, and verify_mode settings (thanks, spiegela!)
+Updated methods:
+-- RealtimeUpdates now uses a GraphAPI object instead of its own API
+-- RestAPI#rest_call now has an optional last argument for method, for calls requiring POST, DELETE, etc. (thanks, sshilo!)
+-- Filename can now be specified when uploading (e.g. for Ads API) (thanks, sshilo!)
+-- get_objects([]) returns [] instead of a Facebook error in non-batch mode (thanks, aselder!)
+Internal improvements:
+-- Koala is now more compatible with other Rubies (JRuby, Rubinius, etc.)
+-- HTTP services are more modular and can be changed on the fly (thanks, chadk!)
+  -- Includes support for uploading StringIOs and other non-files via Net::HTTP even when using TyphoeusService
+-- Koala now uses multi_json to improve compatibility with Rubinius and other Ruby versions
+-- Koala now uses the modern Typhoeus API (thanks, aselder!)
+-- Koala now uses the current modern Net::HTTP interface (thanks, romanbsd!)
+-- Fixed bugs and typos (thanks, waynn, mokevnin, and tikh!)
+
 v1.0
 New methods:
 -- Photo and file upload now supported through #put_picture
@@ -6,13 +65,13 @@ New methods:
 -- Added put_connection and delete_connection convenience methods
 Updated methods:
 -- Search can now search places, checkins, etc. (thanks, rickyc!)
--- You can now pass :beta => true in the http options to use Facebook's beta tier.
+-- You can now pass :beta => true in the http options to use Facebook's beta tier
 -- TestUser#befriend now requires user info hashes (id and access token) due to Facebook API changes (thanks, pulsd and kbighorse!)
 -- All methods now accept an http_options hash as their optional last parameter (thanks, spiegela!)
 -- url_for_oauth_code can now take a :display option (thanks, netbe!)
 -- Net::HTTP can now accept :timeout and :proxy options (thanks, gilles!)
 -- Test users now supports using test accounts across multiple apps
-Internal improvements: 
+Internal improvements:
 -- For public requests, Koala now uses http by default (instead of https) to improve speed
   -- This can be overridden through Koala.always_use_ssl= or by passing :use_ssl => true in the options hash for an api call
 -- Read-only REST API requests now go through the faster api-read server
@@ -22,6 +81,7 @@ Internal improvements:
 -- Updated parse_signed_request to match Facebook's current implementation (thanks, imajes!)
 -- APIError is now < StandardError, not Exception
 -- Added KoalaError for non-API errors
+-- Net::HTTP's SSL verification is no longer disabled by default
 Test improvements:
 -- Incorporated joshk's awesome rewrite of the entire Koala test suite (thanks, joshk!)
 -- Expanded HTTP service tests (added Typhoeus test suite and additional Net::HTTP test cases)

data/Gemfile

@@ -1,3 +1,11 @@
 source :rubygems
 
+group :development, :test do
+  gem "typhoeus"
+end
+
+if defined? JRUBY_VERSION
+  gem "jruby-openssl"
+end
+
 gemspec

data/Rakefile

@@ -7,7 +7,6 @@ rescue LoadError
   puts 'although not required, bundler is recommened for running the tests'
 end
 
-
 task :default => :spec
 
 require 'rspec/core/rake_task'

data/autotest/discover.rb

@@ -0,0 +1 @@
+Autotest.add_discovery { "rspec2" }

data/koala.gemspec

@@ -1,9 +1,11 @@
 # -*- encoding: utf-8 -*-
+$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
+require 'koala/version'
 
 Gem::Specification.new do |s|
   s.name    = %q{koala}
-  s.version = "1.0.0"
-  s.date    = %q{2011-05-01}
+  s.version = Koala::VERSION
+  s.date    = %q{2011-09-27}
 
   s.summary     = %q{A lightweight, flexible library for Facebook with support for the Graph API, the REST API, realtime updates, and OAuth authentication.}
   s.description = %q{Koala is a lightweight, flexible Ruby SDK for Facebook.  It allows read/write access to the social graph via the Graph and REST APIs, as well as support for realtime updates and OAuth and Facebook Connect authentication.  Koala is fully tested and supports Net::HTTP and Typhoeus connections out of the box and can accept custom modules for other services.}
@@ -28,23 +30,20 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<json>,          ["~> 1.0"])
-      s.add_runtime_dependency(%q<multipart-post>,  ["~> 1.0"])
-      s.add_development_dependency(%q<rspec>,     ["~> 2.5.0"])
+      s.add_runtime_dependency(%q<multi_json>,      ["~> 1.0"])
+      s.add_runtime_dependency(%q<faraday>,  ["~> 0.7.0"])
+      s.add_development_dependency(%q<rspec>,     ["~> 2.5"])
       s.add_development_dependency(%q<rake>,      ["~> 0.8.7"])
-      s.add_development_dependency(%q<typhoeus>,  ["~> 0.2.4"])
     else
-      s.add_dependency(%q<json>,      ["~> 1.0"])
-      s.add_dependency(%q<multipart-post>,  ["~> 1.0"])
-      s.add_dependency(%q<rspec>,     ["~> 2.5.0"])
+      s.add_dependency(%q<multi_json>,      ["~> 1.0"])
+      s.add_dependency(%q<rspec>,     ["~> 2.5"])
       s.add_dependency(%q<rake>,      ["~> 0.8.7"])
-      s.add_dependency(%q<typhoeus>,  ["~> 0.2.4"])
+      s.add_dependency(%q<faraday>,  ["~> 0.7.0"])
     end
   else
-    s.add_dependency(%q<json>,      ["~> 1.0"])
-    s.add_dependency(%q<multipart-post>,  ["~> 1.0"])
-    s.add_dependency(%q<rspec>,     ["~> 2.5.0"])
+    s.add_dependency(%q<multi_json>,      ["~> 1.0"])
+    s.add_dependency(%q<rspec>,     ["~> 2.5"])
     s.add_dependency(%q<rake>,      ["~> 0.8.7"])
-    s.add_dependency(%q<typhoeus>,  ["~> 0.2.4"])
+    s.add_dependency(%q<faraday>,  ["~> 0.7.0"])
   end
 end

data/lib/koala/batch_operation.rb

@@ -0,0 +1,74 @@
+module Koala
+  module Facebook
+    class BatchOperation
+      attr_reader :access_token, :http_options, :post_processing, :files, :batch_api, :identifier
+
+      @identifier = 0
+
+      def self.next_identifier
+        @identifier += 1
+      end
+
+      def initialize(options = {})
+        @identifier = self.class.next_identifier
+        @args = (options[:args] || {}).dup # because we modify it below
+        @access_token = options[:access_token]
+        @http_options = (options[:http_options] || {}).dup # dup because we modify it below
+        @batch_args = @http_options.delete(:batch_args) || {}
+        @url = options[:url]
+        @method = options[:method].to_sym
+        @post_processing = options[:post_processing]
+
+        process_binary_args
+
+        raise Koala::KoalaError, "Batch operations require an access token, none provided." unless @access_token
+      end
+
+      def to_batch_params(main_access_token)
+        # set up the arguments
+        args_string = Koala.http_service.encode_params(@access_token == main_access_token ? @args : @args.merge(:access_token => @access_token))
+
+        response = {
+          :method => @method.to_s,
+          :relative_url => @url,
+        }
+
+        # handle batch-level arguments, such as name, depends_on, and attached_files
+        @batch_args[:attached_files] = @files.keys.join(",") if @files
+        response.merge!(@batch_args) if @batch_args
+
+        # for get and delete, we append args to the URL string
+        # otherwise, they go in the body
+        if args_string.length > 0
+          if args_in_url?
+            response[:relative_url] += (@url =~ /\?/ ? "&" : "?") + args_string if args_string.length > 0
+          else
+            response[:body] = args_string if args_string.length > 0
+          end
+        end
+
+        response
+      end
+
+      protected
+
+      def process_binary_args
+        # collect binary files
+        @args.each_pair do |key, value|
+          if UploadableIO.binary_content?(value)
+            @files ||= {}
+            # we use a class-level counter to ensure unique file identifiers across multiple batch operations
+            # (this is thread safe, since we just care about uniqueness)
+            # so remove the file from the original hash and add it to the file store
+            id = "op#{identifier}_file#{@files.keys.length}"
+            @files[id] = @args.delete(key).is_a?(UploadableIO) ? value : UploadableIO.new(value)
+          end
+        end
+      end
+
+      def args_in_url?
+        @method == :get || @method == :delete
+      end
+    end
+  end
+end

data/lib/koala/graph_api.rb

@@ -1,53 +1,53 @@
 module Koala
   module Facebook
-    GRAPH_SERVER = "graph.facebook.com"   
+    GRAPH_SERVER = "graph.facebook.com"
 
     module GraphAPIMethods
       # A client for the Facebook Graph API.
-      # 
+      #
       # See http://github.com/arsduo/koala for Ruby/Koala documentation
       # and http://developers.facebook.com/docs/api for Facebook API documentation
-      # 
+      #
       # The Graph API is made up of the objects in Facebook (e.g., people, pages,
       # events, photos) and the connections between them (e.g., friends,
       # photo tags, and event RSVPs). This client provides access to those
       # primitive types in a generic way. For example, given an OAuth access
       # token, this will fetch the profile of the active user and the list
       # of the user's friends:
-      # 
-      #    graph = Koala::Facebook::GraphAPI.new(access_token)
+      #
+      #    graph = Koala::Facebook::API.new(access_token)
       #    user = graph.get_object("me")
       #    friends = graph.get_connections(user["id"], "friends")
-      # 
+      #
       # You can see a list of all of the objects and connections supported
       # by the API at http://developers.facebook.com/docs/reference/api/.
-      # 
+      #
       # You can obtain an access token via OAuth or by using the Facebook
       # JavaScript SDK. See the Koala and Facebook documentation for more information.
-      # 
+      #
       # If you are using the JavaScript SDK, you can use the
       # Koala::Facebook::OAuth.get_user_from_cookie() method below to get the OAuth access token
       # for the active user from the cookie saved by the SDK.
-         
+
       # Objects
 
       def get_object(id, args = {}, options = {})
         # Fetchs the given object from the graph.
         graph_call(id, args, "get", options)
       end
-    
+
       def get_objects(ids, args = {}, options = {})
-        # Fetchs all of the given object from the graph.
-        # We return a map from ID to object. If any of the IDs are invalid,
-        # we raise an exception.
-        graph_call("", args.merge("ids" => ids.join(",")), "get", options)
+        # Fetchs all of the given objects from the graph.
+        # If any of the IDs are invalid, they'll raise an exception.
+        return [] if ids.empty?
+        graph_call("", args.merge("ids" => ids.respond_to?(:join) ? ids.join(",") : ids), "get", options)
       end
-      
+
       def put_object(parent_object, connection_name, args = {}, options = {})
         # Writes the given object to the graph, connected to the given parent.
         # See http://developers.facebook.com/docs/api#publishing for all of
         # the supported writeable objects.
-        # 
+        #
         # For example,
         #     graph.put_object("me", "feed", :message => "Hello, world")
         # writes "Hello, world" to the active user's wall.
@@ -56,7 +56,7 @@ module Koala
         # publishing wall posts requires the "publish_stream" permission. See
         # http://developers.facebook.com/docs/authentication/ for details about
         # extended permissions.
-    
+
         raise APIError.new({"type" => "KoalaMissingAccessToken", "message" => "Write operations require an access token"}) unless @access_token
         graph_call("#{parent_object}/#{connection_name}", args, "post", options)
       end
@@ -66,13 +66,12 @@ module Koala
         raise APIError.new({"type" => "KoalaMissingAccessToken", "message" => "Delete requires an access token"}) unless @access_token
         graph_call(id, {}, "delete", options)
       end
-      
+
       # Connections
-          
+
       def get_connections(id, connection_name, args = {}, options = {})
         # Fetchs the connections for given object.
-        result = graph_call("#{id}/#{connection_name}", args, "get", options)
-        result ? GraphCollection.new(result, self) : nil # when facebook is down nil can be returned
+        graph_call("#{id}/#{connection_name}", args, "get", options)
       end
 
       def put_connections(id, connection_name, args = {}, options = {})
@@ -87,55 +86,56 @@ module Koala
         graph_call("#{id}/#{connection_name}", args, "delete", options)
       end
 
-      # Pictures
-      # to delete pictures, use delete_object(photo_id)
-      # note: you'll need the user_photos permission to actually access photos after uploading them 
-    
+      # Media (photos and videos)
+      # to delete photos or videos, use delete_object(object_id)
+      # note: you'll need the user_photos or user_videos permissions to actually access media after upload
+
       def get_picture(object, args = {}, options = {})
         # Gets a picture object, returning the URL (which Facebook sends as a header)
-        result = graph_call("#{object}/picture", args, "get", options.merge(:http_component => :headers))
-        result["Location"]
-      end    
-      
+        graph_call("#{object}/picture", args, "get", options.merge(:http_component => :headers)) do |result|
+          result["Location"]
+        end
+      end
+
+      # Can be called in multiple ways:
+      #
+      #   put_picture(file, [content_type], ...)
+      #   put_picture(path_to_file, [content_type], ...)
+      #   put_picture(picture_url, ...)
+      #
+      # You can pass in uploaded files directly from Rails or Sinatra.
+      # (See lib/koala/uploadable_io.rb for supported frameworks)
+      #
+      # Optional parameters can be added to the end of the argument list:
+      # - args:       a hash of request parameters (default: {})
+      # - target_id:  ID of the target where to post the picture (default: "me")
+      # - options:    a hash of http options passed to the HTTPService module
+      #
+      #   put_picture(file, content_type, {:message => "Message"}, 01234560)
+      #   put_picture(params[:file], {:message => "Message"})
+      #
+      #   (Note that with URLs, there's no optional content type field)
+      #   put_picture(picture_url, {:message => "Message"}, my_page_id)
+
       def put_picture(*picture_args)
-        # Can be called in multiple ways:
-        #
-        #   put_picture(file, [content_type], ...)
-        #   put_picture(path_to_file, [content_type], ...)
-        #
-        # You can pass in uploaded files directly from Rails or Sinatra.
-        # (See lib/koala/uploadable_io.rb for supported frameworks)
-        #
-        # Optional parameters can be added to the end of the argument list:
-        # - args:       a hash of request parameters (default: {})
-        # - target_id:  ID of the target where to post the picture (default: "me")
-        # - options:    a hash of http options passed to the HTTPService module
-        # 
-        #   put_picture(file, content_type, {:message => "Message"}, 01234560)
-        #   put_picture(params[:file], {:message => "Message"})
-        
-        raise KoalaError.new("Wrong number of arguments for put_picture") unless picture_args.size.between?(1, 5)
-        
-        args_offset = picture_args[1].kind_of?(Hash) || picture_args.size == 1 ? 0 : 1
-        
-        args      = picture_args[1 + args_offset] || {}
-        target_id = picture_args[2 + args_offset] || "me"
-        options   = picture_args[3 + args_offset] || {} 
-        
-        args["source"] = Koala::UploadableIO.new(*picture_args.slice(0, 1 + args_offset))
-        
-        self.put_object(target_id, "photos", args, options)
+        put_object(*parse_media_args(picture_args, "photos"))
+      end
+
+      def put_video(*video_args)
+        args = parse_media_args(video_args, "videos")
+        args.last[:video] = true
+        put_object(*args)
       end
-    
+
       # Wall posts
       # To get wall posts, use get_connections(user, "feed")
       # To delete a wall post, just use delete_object(post_id)
-    
+
       def put_wall_post(message, attachment = {}, profile_id = "me", options = {})
         # attachment is a hash describing the wall post
         # (see X for more details)
-        # For instance, 
-        # 
+        # For instance,
+        #
         #     {"name" => "Link name"
         #      "link" => "http://www.example.com/",
         #      "caption" => "{*actor*} posted a new review",
@@ -144,19 +144,19 @@ module Koala
 
         self.put_object(profile_id, "feed", attachment.merge({:message => message}), options)
       end
-      
+
       # Comments
       # to delete comments, use delete_object(comment_id)
       # to get comments, use get_connections(object, "likes")
-      
+
       def put_comment(object_id, message, options = {})
         # Writes the given comment on the given post.
         self.put_object(object_id, "comments", {:message => message}, options)
       end
-        
+
       # Likes
       # to get likes, use get_connections(user, "likes")
-      
+
       def put_like(object_id, options = {})
         # Likes the given post.
         self.put_object(object_id, "likes", {}, options)
@@ -169,89 +169,102 @@ module Koala
       end
 
       # Search
-            
+
       def search(search_terms, args = {}, options = {})
         args.merge!({:q => search_terms}) unless search_terms.nil?
-        result = graph_call("search", args, "get", options)
-        result ? GraphCollection.new(result, self) : nil # when facebook is down nil can be returned
-      end      
-      
-      # API access
-    
-      def graph_call(*args)
-        # Direct access to the Facebook API
-        # see any of the above methods for example invocations
-        response = api(*args) do |response|
-          # check for Graph API-specific errors
-          if response.is_a?(Hash) && error_details = response["error"]
-            raise APIError.new(error_details)
-          end
+        graph_call("search", args, "get", options)
+      end
+
+      # Convenience Methods
+
+      def get_page_access_token(object_id)
+        result = get_object(object_id, :fields => "access_token") do
+          result ? result["access_token"] : nil
         end
-      
-        response
-      end 
-      
+      end
+
+      def get_comments_for_urls(urls = [], args = {}, options = {})
+        # Fetchs the comments for given URLs (array or comma-separated string)
+        # see https://developers.facebook.com/blog/post/490
+        return [] if urls.empty?
+        args.merge!(:ids => urls.respond_to?(:join) ? urls.join(",") : urls)
+        get_object("comments", args, options)
+      end
+
       # GraphCollection support
-      
       def get_page(params)
         # Pages through a set of results stored in a GraphCollection
         # Used for connections and search results
-        result = graph_call(*params)
-        result ? GraphCollection.new(result, self) : nil # when facebook is down nil can be returned
+        graph_call(*params)
       end
-      
-    end
-    
-    
-    class GraphCollection < Array
-      #This class is a light wrapper for collections returned
-      #from the Graph API.
-      #
-      #It extends Array to allow direct access to the data colleciton
-      #which should allow it to drop in seamlessly.
-      #
-      #It also allows access to paging information and the
-      #ability to get the next/previous page in the collection
-      #by calling next_page or previous_page.
-      attr_reader :paging
-      attr_reader :api
-      
-      def initialize(response, api)
-        super response["data"]
-        @paging = response["paging"]
-        @api = api
+
+      # Batch API
+      def batch(http_options = {}, &block)
+        batch_client = GraphBatchAPI.new(access_token, self)
+        if block
+          yield batch_client
+          batch_client.execute(http_options)
+        else
+          batch_client
+        end
       end
-            
-      # defines methods for NEXT and PREVIOUS pages
-      %w{next previous}.each do |this|
-        
-        # def next_page
-        # def previous_page
-        define_method "#{this.to_sym}_page" do
-          base, args = send("#{this}_page_params")
-          base ? @api.get_page([base, args]) : nil
+      
+      # Direct access to the Facebook API
+      # see any of the above methods for example invocations
+      def graph_call(path, args = {}, verb = "get", options = {}, &post_processing)
+        result = api(path, args, verb, options) do |response|
+          error = check_response(response)
+          raise error if error
         end
+
+        # turn this into a GraphCollection if it's pageable
+        result = GraphCollection.evaluate(result, self)
         
-        # def next_page_params
-        # def previous_page_params
-        define_method "#{this.to_sym}_page_params" do
-          return nil unless @paging and @paging[this]
-          parse_page_url(@paging[this])
-        end
+        # now process as appropriate for the given call (get picture header, etc.)
+        post_processing ? post_processing.call(result) : result
       end
+
+      private
       
-      def parse_page_url(url)
-        match = url.match(/.com\/(.*)\?(.*)/)
-        base = match[1]
-        args = match[2]
-        params = CGI.parse(args)
-        new_params = {}
-        params.each_pair do |key,value|
-          new_params[key] = value.join ","
+      def check_response(response)
+        # check for Graph API-specific errors
+        # this returns an error, which is immediately raised (non-batch)
+        # or added to the list of batch results (batch)
+        if response.is_a?(Hash) && error_details = response["error"]
+          APIError.new(error_details)
+        end
+      end
+
+      def parse_media_args(media_args, method)
+        # photo and video uploads can accept different types of arguments (see above)
+        # so here, we parse the arguments into a form directly usable in put_object
+        raise KoalaError.new("Wrong number of arguments for put_#{method == "photos" ? "picture" : "video"}") unless media_args.size.between?(1, 5)
+
+        args_offset = media_args[1].kind_of?(Hash) || media_args.size == 1 ? 0 : 1
+
+        args      = media_args[1 + args_offset] || {}
+        target_id = media_args[2 + args_offset] || "me"
+        options   = media_args[3 + args_offset] || {}
+
+        if url?(media_args.first)
+          # If media_args is a URL, we can upload without UploadableIO
+          args.merge!(:url => media_args.first)
+        else
+          args["source"] = Koala::UploadableIO.new(*media_args.slice(0, 1 + args_offset))
+        end
+
+        [target_id, method, args, options]
+      end
+
+      def url?(data)
+        return false unless data.is_a? String
+        begin
+          uri = URI.parse(data)
+          %w( http https ).include?(uri.scheme)
+        rescue URI::BadURIError
+          false
         end
-        [base,new_params]
       end
-      
     end
   end
 end