koala 0.9.0 → 1.0.0.beta

data/spec/koala/graph_api/graph_api_tests.rb

@@ -0,0 +1,86 @@
+shared_examples_for "Koala GraphAPI" do
+  # all Graph API instances should pass these tests, regardless of configuration
+
+  # API
+  it "should never use the rest api server" do
+    Koala.should_receive(:make_request).with(
+      anything,
+      anything,
+      anything,
+      hash_not_including(:rest_api => true)
+    ).and_return(Koala::Response.new(200, "", {}))
+
+    @api.api("anything")
+  end
+
+  # GRAPH CALL
+  describe "graph_call" do
+    it "should pass all arguments to the api method" do
+      args = ["koppel", {}, "get", {:a => :b}]
+
+      @api.should_receive(:api).with(*args)
+
+      @api.graph_call(*args)
+    end
+
+    it "should throw an APIError if the result hash has an error key" do
+      Koala.stub(:make_request).and_return(Koala::Response.new(500, {"error" => "An error occurred!"}, {}))
+      lambda { @api.graph_call("koppel", {}) }.should raise_exception(Koala::Facebook::APIError)
+    end
+  end
+
+  # SEARCH
+  it "should be able to search" do
+    result = @api.search("facebook")
+    result.length.should be_an(Integer)
+  end
+
+  # DATA
+  # access public info
+
+  it "should get public data about a user" do
+    result = @api.get_object("koppel")
+    # the results should have an ID and a name, among other things
+    (result["id"] && result["name"]).should_not be_nil
+  end
+
+  it "should get public data about a Page" do
+    result = @api.get_object("contextoptional")
+    # the results should have an ID and a name, among other things
+    (result["id"] && result["name"]).should
+  end
+
+  it "should be able to get multiple objects" do
+    results = @api.get_objects(["contextoptional", "naitik"])
+    results.length.should == 2
+  end
+
+  it "should be able to access a user's picture" do
+    @api.get_picture("chris.baclig").should =~ /http\:\/\//
+  end
+
+  it "should be able to access a user's picture, given a picture type"  do
+    @api.get_picture("chris.baclig", {:type => 'large'}).should =~ /^http\:\/\//
+  end
+
+  it "should be able to access connections from public Pages" do
+    result = @api.get_connections("contextoptional", "photos")
+    result.should be_a(Array)
+  end
+
+  # SEARCH
+  it "should be able to search" do
+    result = @api.search("facebook")
+    result.length.should be_an(Integer)
+  end
+
+  # PAGING THROUGH COLLECTIONS
+  # see also graph_collection_tests
+  it "should make a request for a page when provided a specific set of page params" do
+    query = [1, 2]
+    @api.should_receive(:graph_call).with(*query)
+    @api.get_page(query)
+  end
+
+
+end

data/spec/koala/graph_api/graph_api_with_access_token_tests.rb

@@ -1,150 +1,154 @@
 shared_examples_for "Koala GraphAPI with an access token" do
-  it "should get public data about a user" do
-      result = @api.get_object("koppel")
-      # the results should have an ID and a name, among other things
-      (result["id"] && result["name"]).should_not be_nil
-    end
 
-    it "should get private data about a user" do
-      result = @api.get_object("koppel")
-      # updated_time should be a pretty fixed test case
-      result["updated_time"].should_not be_nil
-    end
+  it "should get private data about a user" do
+    result = @api.get_object("koppel")
+    # updated_time should be a pretty fixed test case
+    result["updated_time"].should_not be_nil
+  end
 
-    it "should get public data about a Page" do
-      result = @api.get_object("contextoptional")
-      # the results should have an ID and a name, among other things
-      (result["id"] && result["name"]).should
-    end
-  
-    it "should get data about 'me'" do
-      result = @api.get_object("me")
-      result["updated_time"].should
-    end
-  
-    it "should be able to get multiple objects" do
-      result = @api.get_objects(["contextoptional", "naitik"])
-      result.length.should == 2
-    end
-  
-    it "should be able to access a user's picture" do
-      @api.get_picture("chris.baclig").should =~ /http\:\/\//
-    end
-  
-    it "should be able to access a user's picture, given a picture type"  do
-      @api.get_picture("chris.baclig", {:type => 'large'}).should =~ /^http\:\/\//
-    end
+  it "should get data about 'me'" do
+    result = @api.get_object("me")
+    result["updated_time"].should
+  end
+
+  it "should be able to get multiple objects" do
+    result = @api.get_objects(["contextoptional", "naitik"])
+    result.length.should == 2
+  end
+  it "should be able to access connections from users" do
+    result = @api.get_connections("lukeshepard", "likes")
+    result.length.should > 0
+  end
+
+  # PUT
+  it "should be able to write an object to the graph" do
+    result = @api.put_wall_post("Hello, world, from the test suite!")
+    @temporary_object_id = result["id"]
+    @temporary_object_id.should_not be_nil
+  end
+
+  # DELETE
+  it "should be able to delete posts" do
+    result = @api.put_wall_post("Hello, world, from the test suite delete method!")
+    object_id_to_delete = result["id"]
+    delete_result = @api.delete_object(object_id_to_delete)
+    delete_result.should == true
+  end
   
-    it "should be able to access connections from users" do
-      result = @api.get_connections("lukeshepard", "likes")
-      result.length.should > 0
-    end
+  it "should be able to delete likes" do
+    result = @api.put_wall_post("Hello, world, from the test suite delete method!")
+    @temporary_object_id = result["id"]
+    @api.put_like(@temporary_object_id)
+    delete_like_result = @api.delete_like(@temporary_object_id)
+    delete_like_result.should == true
+  end
 
-    it "should be able to access connections from public Pages" do
-      result = @api.get_connections("contextoptional", "photos")
-      result.should be_a(Array)
-    end
+  # additional put tests
+  it "should be able to verify messages posted to a wall" do
+    message = "the cats are asleep"
+    put_result = @api.put_wall_post(message)
+    @temporary_object_id = put_result["id"]
+    get_result = @api.get_object(@temporary_object_id)
+
+    # make sure the message we sent is the message that got posted
+    get_result["message"].should == message
+  end
+
+  it "should be able to post a message with an attachment to a feed" do
+    result = @api.put_wall_post("Hello, world, from the test suite again!", {:name => "Context Optional", :link => "http://www.contextoptional.com/"})
+    @temporary_object_id = result["id"]
+    @temporary_object_id.should_not be_nil
+  end
+
+  it "should be able to post photos to the user's wall with an open file object" do
+    file_hash = {
+      "content_type" => "image/jpg",
+      "path" => File.join(File.dirname(__FILE__), "..", "assets", "beach.jpg"),
+      "file" => File.open(File.join(File.dirname(__FILE__), "..", "assets", "beach.jpg"))
+    }
+    result = @api.put_picture(file_hash)
+    @temporary_object_id = result["id"] 
+    @temporary_object_id.should_not be_nil
+  end
+  
+  it "should be able to post photos to the user's wall without an open file object" do
+    file_hash = {
+      "content_type" => "image/jpg",
+      "path" => File.join(File.dirname(__FILE__), "..", "assets", "beach.jpg")
+    }
+    result = @api.put_picture(file_hash)
+    @temporary_object_id = result["id"] 
+    @temporary_object_id.should_not be_nil
+  end
     
-    # paging
-    # see also graph_collection_tests
-    it "should make a request for a page when provided a specific set of page params" do
-      query = [1, 2]
-      @api.should_receive(:graph_call).with(*query)
-      @api.get_page(query)
-    end
+  it "should be able to verify a photo posted to a user's wall" do
+    file_hash = {
+      "content_type" => "image/jpg",
+      "path" => File.join(File.dirname(__FILE__), "..", "assets", "beach.jpg")
+    }
+    expected_message = "This is the test message"
     
+    result = @api.put_picture(file_hash, :message => expected_message)
+    @temporary_object_id = result["id"] 
+    @temporary_object_id.should_not be_nil
     
-    # PUT
-    it "should be able to write an object to the graph" do
-      result = @api.put_wall_post("Hello, world, from the test suite!")
-      @temporary_object_id = result["id"]
-      @temporary_object_id.should_not be_nil
-    end
-
-    # DELETE
-    it "should be able to delete posts" do 
-      result = @api.put_wall_post("Hello, world, from the test suite delete method!")
-      object_id_to_delete = result["id"]
-      delete_result = @api.delete_object(object_id_to_delete)
-      delete_result.should == true
-    end
+    get_result = @api.get_object(@temporary_object_id)
+    get_result["name"].should == expected_message
+  end
+        
+  it "should be able to verify a message with an attachment posted to a feed" do
+    attachment = {"name" => "Context Optional", "link" => "http://www.contextoptional.com/"}
+    result = @api.put_wall_post("Hello, world, from the test suite again!", attachment)
+    @temporary_object_id = result["id"]
+    get_result = @api.get_object(@temporary_object_id)
 
-    # additional put tests
-    it "should be able to verify messages posted to a wall" do
-      message = "the cats are asleep"
-      put_result = @api.put_wall_post(message)
-      @temporary_object_id = put_result["id"]
-      get_result = @api.get_object(@temporary_object_id)
-      
-      # make sure the message we sent is the message that got posted
-      get_result["message"].should == message
-    end
+    # make sure the result we fetch includes all the parameters we sent
+    it_matches = attachment.inject(true) {|valid, param| valid && (get_result[param[0]] == attachment[param[0]])}
+    it_matches.should == true
+  end
 
-    it "should be able to post a message with an attachment to a feed" do
-      result = @api.put_wall_post("Hello, world, from the test suite again!", {:name => "Context Optional", :link => "http://www.contextoptional.com/"})
-      @temporary_object_id = result["id"]
-      @temporary_object_id.should_not be_nil
-    end
-    
-    it "should be able to verify a message with an attachment posted to a feed" do
-      attachment = {"name" => "Context Optional", "link" => "http://www.contextoptional.com/"}
-      result = @api.put_wall_post("Hello, world, from the test suite again!", attachment)
-      @temporary_object_id = result["id"]
-      get_result = @api.get_object(@temporary_object_id)
-
-      # make sure the result we fetch includes all the parameters we sent
-      it_matches = attachment.inject(true) {|valid, param| valid && (get_result[param[0]] == attachment[param[0]])}
-      it_matches.should == true 
-    end
+  it "should be able to comment on an object" do
+    result = @api.put_wall_post("Hello, world, from the test suite, testing comments!")
+    @temporary_object_id = result["id"]
 
-    it "should be able to comment on an object" do
-      result = @api.put_wall_post("Hello, world, from the test suite, testing comments!")
-      @temporary_object_id = result["id"]
-      
-      # this will be deleted when the post gets deleted 
-      comment_result = @api.put_comment(@temporary_object_id, "it's my comment!")
-      comment_result.should_not be_nil
-    end
-    
-    it "should be able to verify a comment posted about an object" do
-      message_text = "Hello, world, from the test suite, testing comments!"
-      result = @api.put_wall_post(message_text)
-      @temporary_object_id = result["id"]
-      
-      # this will be deleted when the post gets deleted 
-      comment_text = "it's my comment!"
-      comment_result = @api.put_comment(@temporary_object_id, comment_text)
-      get_result = @api.get_object(comment_result["id"])
-
-      # make sure the text of the comment matches what we sent
-      get_result["message"].should == comment_text
-    end
+    # this will be deleted when the post gets deleted
+    comment_result = @api.put_comment(@temporary_object_id, "it's my comment!")
+    comment_result.should_not be_nil
+  end
 
-    it "should be able to like an object" do
-      result = @api.put_wall_post("Hello, world, from the test suite, testing comments!")
-      @temporary_object_id = result["id"]
-      like_result = @api.put_like(@temporary_object_id)
-    end
+  it "should be able to verify a comment posted about an object" do
+    message_text = "Hello, world, from the test suite, testing comments!"
+    result = @api.put_wall_post(message_text)
+    @temporary_object_id = result["id"]
 
-    # SEARCH
-    it "should be able to search" do
-      result = @api.search("facebook")
-      result.length.should be_an(Integer)
-    end
+    # this will be deleted when the post gets deleted
+    comment_text = "it's my comment!"
+    comment_result = @api.put_comment(@temporary_object_id, comment_text)
+    get_result = @api.get_object(comment_result["id"])
 
-    # API
-    # the above tests test this already, but we should consider additional api tests
+    # make sure the text of the comment matches what we sent
+    get_result["message"].should == comment_text
+  end
 
-    it_should_behave_like "Koala GraphAPI with GraphCollection"
+  it "should be able to like an object" do
+    result = @api.put_wall_post("Hello, world, from the test suite, testing comments!")
+    @temporary_object_id = result["id"]
+    like_result = @api.put_like(@temporary_object_id)
+    like_result.should be_true
+  end
 end
 
 class FacebookWithAccessTokenTests < Test::Unit::TestCase
   describe "Koala GraphAPI with an access token" do
-    it_should_behave_like "live testing examples"
-    it_should_behave_like "Koala GraphAPI with an access token"
-    
+    include LiveTestingDataHelper
+
     before :each do
       @api = Koala::Facebook::GraphAPI.new(@token)
     end
+
+    it_should_behave_like "Koala GraphAPI"
+    it_should_behave_like "Koala GraphAPI with an access token"
+    it_should_behave_like "Koala GraphAPI with GraphCollection"
+
   end
 end

data/spec/koala/graph_api/graph_collection_tests.rb

@@ -65,7 +65,7 @@ shared_examples_for "Koala GraphAPI with GraphCollection" do
           @api.should_receive(:graph_call).with(@base, @args).and_return(@second_page)
           Koala::Facebook::GraphCollection.should_receive(:new).with(@second_page, @api).and_return(@page_of_results)
       
-          @result.previous_page(@api).should == @page_of_results
+          @result.previous_page.should == @page_of_results
         end
     
         it "should return the next page of results" do
@@ -79,7 +79,7 @@ shared_examples_for "Koala GraphAPI with GraphCollection" do
         it "should return nil it there are no other pages" do
           %w{next previous}.each do |this|
             @result.should_receive("#{this}_page_params".to_sym).and_return(nil)
-            @result.send("#{this}_page", @api).should == nil
+            @result.send("#{this}_page").should == nil
           end
         end
       end

data/spec/koala/live_testing_data_helper.rb

@@ -1,15 +1,43 @@
-shared_examples_for "live testing examples" do
-    before :each do
-      @token = $testing_data["oauth_token"]
-      raise Exception, "Must supply access token to run FacebookWithAccessTokenTests!" unless @token
-    end
-    
-    after :each do 
-      # clean up any temporary objects
-      if @temporary_object_id
-        puts "\nCleaning up temporary object #{@temporary_object_id.to_s}"
-        result = @api.delete_object(@temporary_object_id)
-        raise "Unable to clean up temporary Graph object #{@temporary_object_id}!" unless result
+module LiveTestingDataHelper
+  # in RSpec 2, included example groups no longer share any hooks or state with outside examples 
+  # even if in the same block
+  # so we have to use a module to provide setup and teardown hooks for live testing
+  
+  def self.included(base)
+    base.class_eval do
+      before :each do
+        @token = $testing_data["oauth_token"]
+        raise Exception, "Must supply access token to run FacebookWithAccessTokenTests!" unless @token
+        # track temporary objects created
+        @temporary_object_ids = []
+      end
+  
+      after :each do 
+        # clean up any temporary objects
+        @temporary_object_ids << @temporary_object_id if @temporary_object_id
+        count = @temporary_object_ids.length
+        errors = []
+        
+        if count > 0
+          print "\nCleaning up #{count} temporary #{count > 1 ? "objects" : "object (#{@temporary_object_ids.first})"}..."
+          @temporary_object_ids.each do |id|
+            # get our API
+            api = @api || (@test_users ? @test_users.graph_api : nil)
+            raise "Unable to locate API when passed temporary object to delete!" unless api
+          
+            # delete the object
+            result = (api.delete_object(id) rescue false)
+            # if we errored out or Facebook returned false, track that
+            errors << id unless result
+          end
+          
+          if errors.length == 0
+            puts "done."
+          else 
+            puts "cleaned up #{count - errors.length} objects, but errored out on the following:\n #{errors.join(", ")}"
+          end
+        end
       end
     end
+  end
 end