koala 0.7.1 → 0.7.3

data/examples/oauth_playground/views/index.erb

@@ -0,0 +1,206 @@
+<div id="header">
+	<h1>Facebook OAuth Playground</h1>
+	<h4>Powered by <a href="http://github.com/arsduo/koala" target="_blank">Koala</a></h2>
+	<h4>For novelty use only.  Remember, the application's secret key is public.</h4>
+</div>
+
+<style>
+	#header { 
+		text-align: center; 
+	} 
+	
+	h1, h2, h3, h4 { margin: 0; }
+
+	.section {
+		border: 1px solid black;
+		padding: 10px;
+		-moz-border-radius: 9px;
+		-webkit-border-radius: 9px;
+		margin-bottom: 10px;
+		width: 100%;
+	}
+	
+	#contents {
+		border: 2px solid #CCC;
+		border-width: 2px 0;
+		background-color: #EEE;
+		padding: 14px 3px 8px 8px;
+	}
+	
+	#configurationInfo {
+		float:left;
+		margin-right: 2.5%;
+		width: 25%;
+	}
+	
+	#configurationInfo .section {
+		background-color: #CCC;
+	}
+	
+	#permissions .header {
+		margin-bottom: 5px;
+	}
+	
+	#permissions .list {
+		height: 380px;
+		overflow: auto;
+	}
+	
+	#generatedInfo {
+		float: left;
+		width: 70%;
+	}
+	
+	#generatedInfo .section {
+		border-color: gray;
+		background: #DDD;
+		overflow: auto;
+	}
+	
+	.clearFloat {
+		height: 1px;
+		height: 0px;
+		clear: both;
+		overflow: hidden;
+	}
+	
+	ul, li { margin: 0; padding: 0; list-style: none; }
+	ul { margin: 12px 0; }
+
+	.code {
+		font-family: Courier, fixed;
+		font-size: 1.15em;
+		width: 100%;
+	}
+	
+	.explanation {
+		font-size: 0.9em;
+	}
+	
+	.datumName {
+		font-weight: bold;
+	}
+	
+	.permissionType {
+		font-style: italic;
+	}
+</style>
+	
+</style>
+
+<div id="contents">
+
+	<div id="configurationInfo">
+		<div id="fbApp" class="section">
+			<h3>Facebook App Info</h3>
+			<ul>
+				<% @app_data.each_pair do |key, value| %>
+					<li><span class="datumName"><%= key %>:</span> <%= value %></li>
+				<% end %>
+			</ul>
+		</div>
+		
+		<div id="permissions" class="section">
+			<form method="get">
+				<div class="header">
+					<h3>Permissions</h3>
+					<input type="submit" value="Update permissions" />
+					<a href="/">Reset Selection</a>
+					<div class="explanation">Choose permissions for the OAuth URL and the fb:login button.</div>
+					<% if @fetched_permissions %>
+						<div class="permissionType">Showing currently-active permissions</div>
+						<div class="explanation">(These were fetched by Koala as the page loaded!)</div>
+					<% else %>
+						<div class="permissionType">Showing selected permissions</div>
+					<% end %>
+				</div>
+		
+				<div class="list">
+					<% @available_permissions.each do |permissions| %>
+						<h4><%= permissions[:name] %> Permissions</h4>
+						<ul>
+							<% permissions[:perms].each do |p| %>
+								<li>
+									<input type="checkbox" id="permission<%= p %>" name="permissions[]" value="<%= p %>" <%= @active_permissions.include?(p) ? "checked='checked'" : "" %> />
+									<label for="permission<%= p %>"><%= p %></a> (<a href="#" onclick="FB.api({method: 'auth.revokeExtendedPermission', perm: '<%= p %>'}, function(response) { alert(response) }); return false;">revoke</a>)
+								</li>
+							<% end %>
+						</ul>
+					<% end %>
+				</div>
+			</form>
+		</div>
+	</div>
+
+	<div id="generatedInfo">		
+		<div id="oauthURLs" class="section">
+			<h3>OAuth URLs</h3>
+			<ul>
+				<li><span class="datumName">Generate a code:</span> <a href="<%= @oauth.url_for_oauth_code(:permissions => @permissions) %>"><%=  @oauth.url_for_oauth_code(:permissions => @permissions) %></a></li>
+				<li><span class="datumName">OAuth code:</span> <%= @code || "click on the link above" %></li>
+				<li>
+					<span class="datumName">Access token:</span> <%= @oauth_access_token || "click on the link above" %>
+					<% if @oauth_access_token %><div class="explanation">This was fetched by Koala as the page loaded!</div><% end %>
+				</li>
+				<li><span class="datumName">Expiration:</span> <%= @expiration || "click on the link above" %></li>
+				<li><span class="datumName">Raw access response:</span> <%= @raw_access_response || "click on the link above" %></li>
+				<li><span class="datumName">URL for access code:</span>
+					<% if @code %>
+						<a href="<%= @oauth.url_for_access_token(@code) %>"><%= @oauth.url_for_access_token(@code) %></a>
+					<% else %>
+						click on the link above
+					<% end %>
+				</li>
+			</ul>
+		</div>
+
+		<div id="jsLogin" class="section">
+			<h3>Javascript Login (e.g. Facebook Connect)</h3>
+			<p>
+				<fb:login-button onlogin="location.reload()" perms="<%= (@permissions || []).join(",") %>"></fb:login-button>
+				<% if @permissions %>
+					and prompt for <%= @permissions.join(", ") %>
+				<% end %>
+				<% if @facebook_cookies %>
+					<div class="logout">
+						<a href="#" onclick="FB.logout(function() { location.reload() }); return false;">Logout</a>
+					</div>
+				<% end %>
+			</p>
+		</div>
+
+		<div id="cookieInfo" class="section">
+			<h3>Cookie info</h3>
+			<ul>
+				<% if @facebook_cookies %>
+					<% @facebook_cookies.each_pair do |key, value| %>
+						<li><span class="datumName"><%= key %>:</span> <%= value %></li>
+					<% end %>
+				<% else %>
+					<li>You're not signed in via Javascript.  Login below.</li>
+				<% end %>
+				<li><span class="datumName">Raw hash</span>: 
+					<div class="code"><%= request.cookies.inspect %></div>
+				</li>
+			</ul>
+		</div>
+
+		<div id="koala" class="section">
+			<h3>Koala</h3>
+			<ul>
+				<li><span class="datumName">GraphAPI:</span>
+					<div class="code"><%= @access_token ? "@graph = Koala::Facebook::GraphAPI.new(\"#{@access_token}\")" : "sign in above" %></div>
+				</li>
+				<li><span class="datumName">OAuth:</span> 
+					<div class="code">@oauth = Koala::Facebook::OAuth.new(<%= @app_data["app_id"] %>, "<%= @app_data["secret_key"] %>", "<%= @app_data["callback_url"] %>")</div>
+				</li>
+			</ul>
+		</div>
+	</div>
+
+	<div class="clearFloat">&nbsp;</div>
+</div>
+
+<center>
+	<h5>Check out the playground's code at <a href="http://github.com/arsduo/oauth_playground">http://github.com/arsduo/oauth_playground</a>!</h5>
+</center>

data/examples/oauth_playground/views/layout.erb

@@ -0,0 +1,39 @@
+<html>
+<head>
+	<title>Facebook OAuth Playground</title>
+	<meta name="description" content="Making it easier to play with Facebook's new Graph API and OAuth authentication."></meta>
+	<style>
+		body {
+			font-family: verdana, arial, sans-serif;
+			font-size: 12px;
+			margin: 0px;
+		}
+	</style>
+</head>
+<body>
+
+<script type="text/javascript">
+
+  var _gaq = _gaq || [];
+  _gaq.push(['_setAccount', 'UA-16395421-1']);
+  _gaq.push(['_trackPageview']);
+
+  (function() {
+    var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
+    ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
+    var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
+  })();
+
+</script>
+	
+<%= yield %>		
+		
+<div id="fb-root"></div>
+<script src="http://connect.facebook.net/en_US/all.js"></script>
+<script>
+	FB.init({ appId: <%= @app_data["app_id"] %>, cookie: true, status: true, xfbml: true });
+</script>
+
+</body>
+
+</html>

data/koala.gemspec

@@ -2,15 +2,15 @@
 
 Gem::Specification.new do |s|
   s.name = %q{koala}
-  s.version = "0.7.1"
+  s.version = "0.7.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alex Koppel, Chris Baclig, Rafi Jacoby, Context Optional"]
-  s.date = %q{2010-05-27}
+  s.date = %q{2010-06-22}
   s.description = %q{Koala is a lightweight, flexible Ruby SDK for Facebook.  It allows read/write access to the social graph via the Graph API and the older REST API, as well as support for realtime updates and OAuth and Facebook Connect authentication.  Koala is fully tested and supports Net::HTTP and Typhoeus connections out of the box and can accept custom modules for other services.}
   s.email = %q{alex@alexkoppel.com}
-  s.extra_rdoc_files = ["CHANGELOG", "lib/graph_api.rb", "lib/http_services.rb", "lib/koala.rb", "lib/realtime_updates.rb", "lib/rest_api.rb"]
-  s.files = ["CHANGELOG", "Manifest", "Rakefile", "init.rb", "lib/graph_api.rb", "lib/http_services.rb", "lib/koala.rb", "lib/realtime_updates.rb", "lib/rest_api.rb", "readme.md", "spec/facebook_data.yml", "spec/koala/api_base_tests.rb", "spec/koala/graph_and_rest_api/graph_and_rest_api_no_token_tests.rb", "spec/koala/graph_and_rest_api/graph_and_rest_api_with_token_tests.rb", "spec/koala/graph_api/graph_api_no_access_token_tests.rb", "spec/koala/graph_api/graph_api_with_access_token_tests.rb", "spec/koala/live_testing_data_helper.rb", "spec/koala/net_http_service_tests.rb", "spec/koala/oauth/oauth_tests.rb", "spec/koala/realtime_updates/realtime_updates_tests.rb", "spec/koala/rest_api/rest_api_no_access_token_tests.rb", "spec/koala/rest_api/rest_api_with_access_token_tests.rb", "spec/koala_spec.rb", "spec/koala_spec_helper.rb", "spec/koala_spec_without_mocks.rb", "spec/mock_facebook_responses.yml", "spec/mock_http_service.rb", "koala.gemspec"]
+  s.extra_rdoc_files = ["CHANGELOG", "LICENSE", "lib/koala.rb", "lib/koala/graph_api.rb", "lib/koala/http_services.rb", "lib/koala/realtime_updates.rb", "lib/koala/rest_api.rb"]
+  s.files = ["CHANGELOG", "LICENSE", "Manifest", "Rakefile", "examples/oauth_playground/Capfile", "examples/oauth_playground/LICENSE", "examples/oauth_playground/Rakefile", "examples/oauth_playground/config.ru", "examples/oauth_playground/config/deploy.rb", "examples/oauth_playground/config/facebook.yml", "examples/oauth_playground/lib/load_facebook.rb", "examples/oauth_playground/lib/oauth_playground.rb", "examples/oauth_playground/readme.md", "examples/oauth_playground/spec/oauth_playground_spec.rb", "examples/oauth_playground/spec/spec_helper.rb", "examples/oauth_playground/tmp/restart.txt", "examples/oauth_playground/views/index.erb", "examples/oauth_playground/views/layout.erb", "init.rb", "lib/koala.rb", "lib/koala/graph_api.rb", "lib/koala/http_services.rb", "lib/koala/realtime_updates.rb", "lib/koala/rest_api.rb", "readme.md", "spec/facebook_data.yml", "spec/koala/api_base_tests.rb", "spec/koala/graph_and_rest_api/graph_and_rest_api_no_token_tests.rb", "spec/koala/graph_and_rest_api/graph_and_rest_api_with_token_tests.rb", "spec/koala/graph_api/graph_api_no_access_token_tests.rb", "spec/koala/graph_api/graph_api_with_access_token_tests.rb", "spec/koala/live_testing_data_helper.rb", "spec/koala/net_http_service_tests.rb", "spec/koala/oauth/oauth_tests.rb", "spec/koala/realtime_updates/realtime_updates_tests.rb", "spec/koala/rest_api/rest_api_no_access_token_tests.rb", "spec/koala/rest_api/rest_api_with_access_token_tests.rb", "spec/koala_spec.rb", "spec/koala_spec_helper.rb", "spec/koala_spec_without_mocks.rb", "spec/mock_facebook_responses.yml", "spec/mock_http_service.rb", "koala.gemspec"]
   s.homepage = %q{http://github.com/arsduo/koala}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Koala", "--main", "readme.md"]
   s.require_paths = ["lib"]

data/lib/{graph_api.rb → koala/graph_api.rb}

@@ -47,11 +47,11 @@ module Koala
         graph_call("#{id}/#{connection_name}", args)["data"]
       end
     
-      def get_picture(object)
-        result = graph_call("#{object}/picture", {}, "get", :http_component => :headers)
+      def get_picture(object, args = {})
+        result = graph_call("#{object}/picture", args, "get", :http_component => :headers)
         result["Location"]
-      end
-    
+      end    
+      
       def put_object(parent_object, connection_name, args = {})
         # Writes the given object to the graph, connected to the given parent.
         # 

data/lib/koala.rb

@@ -6,15 +6,15 @@ require 'rubygems'
 require 'json'
 
 # include default http services
-require 'http_services'
+require 'koala/http_services'
 
 # add Graph API methods
-require 'graph_api'
+require 'koala/graph_api'
 
 # add REST API methods
-require 'rest_api'
+require 'koala/rest_api'
 
-require 'realtime_updates'
+require 'koala/realtime_updates'
 
 module Koala
     
@@ -52,6 +52,11 @@ module Koala
         # make the request via the provided service
         result = Koala.make_request(path, args, verb, options)
 
+        # Check for any 500 errors before parsing the body
+        # since we're not guaranteed that the body is valid JSON
+        # in the case of a server error
+        raise APIError.new({"type" => "HTTP #{result.status.to_s}", "message" => "Response body: #{result.body}"}) if result.status >= 500
+        
         # Parse the body as JSON and check for errors if provided a mechanism to do so 
         # Note: Facebook sometimes sends results like "true" and "false", which aren't strictly objects
         # and cause JSON.parse to fail -- so we account for that by wrapping the result in []
@@ -103,11 +108,10 @@ module Koala
         @oauth_callback_url = oauth_callback_url 
       end
     
-      def get_user_from_cookie(cookie_hash)
+      def get_user_info_from_cookie(cookie_hash)
         # Parses the cookie set by the official Facebook JavaScript SDK.
         # 
-        # cookies should be a dictionary-like object mapping cookie names to
-        # cookie values.
+        # cookies should be a Hash, like the one Rails provides
         # 
         # If the user is logged in via Facebook, we return a dictionary with the
         # keys "uid" and "access_token". The former is the user's Facebook ID,
@@ -132,8 +136,20 @@ module Koala
           sig == components["sig"] && (components["expires"] == "0" || Time.now.to_i < components["expires"].to_i) ? components : nil
         end
       end
+      alias_method :get_user_info_from_cookies, :get_user_info_from_cookie
+    
+      def get_user_from_cookie(cookies)
+        # overload this to be backward compatible with older implementations
+        # icky ruby magic, but it's _really_ cool we can do this
+        info = get_user_info_from_cookies(cookies)
+        string = info["uid"]
+
+        overload_as_hash(string, info)
+      end
       alias_method :get_user_from_cookies, :get_user_from_cookie
     
+      # URLs
+    
       def url_for_oauth_code(options = {})
         # for permissions, see http://developers.facebook.com/docs/authentication/permissions
         permissions = options[:permissions]
@@ -156,18 +172,68 @@ module Koala
         raise ArgumentError, "url_for_access_token must get a callback either from the OAuth object or in the parameters!" unless callback
         "https://#{GRAPH_SERVER}/oauth/access_token?client_id=#{@app_id}&redirect_uri=#{callback}&client_secret=#{@app_secret}&code=#{code}"
       end
-      
-      def get_access_token(code)
+            
+      def get_access_token_info(code)
         # convenience method to get a parsed token from Facebook for a given code
         # should this require an OAuth callback URL?
         get_token_from_server(:code => code, :redirect_uri => @oauth_callback_url)
       end
       
-      def get_app_access_token
+      def get_access_token(code)
+        info = get_access_token_info(code)
+        # upstream methods will throw errors if needed
+        string = info["access_token"]
+
+        overload_as_hash(string, info)          
+      end
+      
+      def get_app_access_token_info
         # convenience method to get a the application's sessionless access token 
         get_token_from_server({:type => 'client_cred'}, true)
       end
       
+      def get_app_access_token
+        info = get_app_access_token_info
+        string = info["access_token"]
+
+        overload_as_hash(string, info)
+      end
+      
+      # from session keys
+      def get_token_info_from_session_keys(sessions)
+        # fetch the OAuth tokens from Facebook
+        response = fetch_token_string({
+          :type => 'client_cred',
+          :sessions => sessions.join(",")
+        }, true, "exchange_sessions")
+        
+        # get_token_from_session_key should return an empty body if an empty string or nil is provided
+        # if invalid tokens are provided, it returns an array of nulls, which is a valid result
+        if response == ""
+          raise APIError.new("ArgumentError", "get_token_from_session_key received an error (empty response body) for sessions #{sessions.inspect}!")
+        end
+        
+        JSON.parse(response)
+      end
+  
+      def get_tokens_from_session_keys(sessions)
+        # get the original hash results
+        results = get_token_info_from_session_keys(sessions)
+        # now recollect them as backward-compatible strings
+        # for easier use
+        results.collect do |r|
+          string = r["access_token"]
+
+          overload_as_hash string, r
+        end
+      end
+      
+      def get_token_from_session_key(session)
+        # convenience method for a single key
+        # gets the overlaoded strings automatically
+        get_tokens_from_session_keys([session])[0]
+      end
+      
       protected
       
       def get_token_from_server(args, post = false)
@@ -189,12 +255,29 @@ module Koala
         components 
       end
 
-      def fetch_token_string(args, post = false)
-        Koala.make_request("oauth/access_token", {
+      def fetch_token_string(args, post = false, endpoint = "access_token")
+        Koala.make_request("oauth/#{endpoint}", {
           :client_id => @app_id, 
           :client_secret => @app_secret
         }.merge!(args), post ? "post" : "get").body
       end
+
+      # overload the object to be accessible as a hash
+      # used to make get_*_token methods backward compatible
+      # icky ruby magic, but it's _really_ cool we can do this
+      def overload_as_hash(obj, hash)
+        command = <<-EOS
+          def [](index)
+            puts "WARNING: get_app_access_token now provides the access token as a string; use get_app_access_token_info if you want the hash with expirations.  Otherwise you no longer need to call [] to get the token itself."
+            hash = #{hash.inspect}
+            hash[index]
+          end
+        EOS
+        
+        (class << obj; self; end).class_eval command
+        
+        obj
+      end
     end
   end
   

data/readme.md

@@ -34,7 +34,7 @@ We reserve the right to expand the built-in REST API coverage to additional conv
 OAuth
 -----
 You can use the Graph and REST APIs without an OAuth access token, but the real magic happens when you provide Facebook an OAuth token to prove you're authenticated.  Koala provides an OAuth class to make that process easy:
-     @oauth = Koala::Facebook::OAuth.new(app_id, code, callback_url)
+    @oauth = Koala::Facebook::OAuth.new(app_id, code, callback_url)
 
 If your application uses Koala and the Facebook [JavaScript SDK](http://github.com/facebook/connect-js) (formerly Facebook Connect), you can use the OAuth class to parse the cookies:
     @oauth.get_user_from_cookie(cookies)
@@ -50,6 +50,9 @@ You can also get your application's own access token, which can be used without
 
 That's it!  It's pretty simple once you get the hang of it.  If you're new to OAuth, though, check out the wiki and the OAuth Playground example site (see below).
 
+*Exchanging session keys:* Stuck building tab applications on Facebook?  Wishing you had an OAuth token so you could use the Graph API?  You're in luck! Koala now allows you to exchange session keys for OAuth access tokens:
+    @oauth.get_token_from_session_key(session_key)
+    @oauth.get_tokens_from_session_keys(array_of_session_keys)
 
 Real-time Updates
 -----

data/spec/facebook_data.yml

@@ -5,14 +5,19 @@
  
 # You must supply this value yourself to test the GraphAPI class.
 # Your OAuth token should have publish_stream and read_stream permissions.
-oauth_token: 119908831367602|2.6WkxQTbQPGFCyLblPYdsMg__.3600.1274979600-2905623|8YPVs-jBmpWC6y10pMCWzMRFrdk. 
+oauth_token: 
 
 # for testing the OAuth class    
 # baseline app
 oauth_test_data: 
   # You must supply this value yourself, since they will expire.
-  code:  2.6WkxQTbQPGFCyLblPYdsMg__.3600.1274979600-2905623|zHzbqwoONeqNxOXX7z9LZlpEGdc.
-    
+  code: 
+  # easiest way to get session keys: use multiple test accounts with the Javascript login at http://oauth.twoalex.com
+  session_key: 
+  multiple_session_keys:
+    - 
+    - 
+  
   # These values will work out of the box
   app_id: 119908831367602
   secret: e45e55a333eec232d4206d2703de1307

data/spec/koala/api_base_tests.rb

@@ -29,9 +29,45 @@ class ApiBaseTests < Test::Unit::TestCase
       service.api('anything')
     end
     
-    it "should properly handle the http_component parameter"
+    it "should get the attribute of a Koala::Response given by the http_component parameter" do
+      http_component = :method_name
+      
+      response = mock('Mock KoalaResponse', :body => '', :status => 200)
+      response.should_receive(http_component).and_return('')
+      
+      Koala.stub(:make_request).and_return(response)
+      
+      @service.api('anything', 'get', {}, :http_component => http_component)
+    end
     
-    it "should execute a block to test for errors if passed one"
+    it "should return the body of the request as JSON if no http_component is given" do
+      response = stub('response', :body => 'body', :status => 200)
+      Koala.stub(:make_request).and_return(response)
+      
+      json_body = mock('JSON body')
+      JSON.stub(:parse).and_return([json_body])
+      
+      @service.api('anything').should == json_body
+    end
+    
+    it "should execute a block with the response body if passed one" do
+      body = '{}'
+      Koala.stub(:make_request).and_return(Koala::Response.new(200, body, {}))
+      
+      yield_test = mock('Yield Tester')
+      yield_test.should_receive(:pass)
+      
+      @service.api('anything') do |arg| 
+        yield_test.pass
+        arg.should == JSON.parse(body)
+      end
+    end
+    
+    it "should raise an API error if the HTTP response code is greater than or equal to 500" do
+      Koala.stub(:make_request).and_return(Koala::Response.new(500, 'response body', {}))
+      
+      lambda { @service.api('anything') }.should raise_exception(Koala::Facebook::APIError)
+    end
     
     it "should handle rogue true/false as responses" do
       Koala.should_receive(:make_request).and_return(Koala::Response.new(200, 'true', {}))
@@ -41,4 +77,35 @@ class ApiBaseTests < Test::Unit::TestCase
       @service.api('anything').should be_false
     end
   end
+end
+
+shared_examples_for "methods that return overloaded strings" do
+  before :each do
+    @key ||= "access_token"
+  end
+  
+  it "should be overloaded to be backward compatible" do
+    @result.respond_to?(:[]).should be_true
+  end
+
+  it "should allow hash access to the access token info" do
+    @result[@key].should == @result
+  end
+
+  it "should output a deprecation warning when the result is used as a hash" do 
+    out = nil
+  
+    begin
+      # we want to capture the deprecation warning as well as the output
+      # credit to http://thinkingdigitally.com/archive/capturing-output-from-puts-in-ruby/ for the technique
+      out = StringIO.new
+      $stdout = out
+      @result[@key]
+    ensure
+      $stdout = STDOUT
+    end
+  
+    # ensure we got a warning
+    out.should_not be_nil
+  end
 end

data/spec/koala/graph_api/graph_api_no_access_token_tests.rb

@@ -34,6 +34,10 @@ shared_examples_for "Koala GraphAPI without an access token" do
     @api.get_picture("chris.baclig").should =~ /http\:\/\//
   end
 
+  it "should be able to access a user's picture, given a picture type"  do
+    @api.get_picture("chris.baclig", {:type => 'large'}).should =~ /^http\:\/\//
+  end
+
   it "should be able to access connections from public Pages" do
     result = @api.get_connections("contextoptional", "likes")
     result.should be_a(Array)

data/spec/koala/graph_api/graph_api_with_access_token_tests.rb

@@ -31,6 +31,10 @@ it "should get public data about a user" do
       @api.get_picture("chris.baclig").should =~ /http\:\/\//
     end
   
+    it "should be able to access a user's picture, given a picture type"  do
+      @api.get_picture("chris.baclig", {:type => 'large'}).should =~ /^http\:\/\//
+    end
+  
     it "should be able to access connections from users" do
       result = @api.get_connections("lukeshepard", "likes")
       result.length.should > 0