knockapi 0.4.12 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '068773528aedcda44f03ce1f2378bf78aef474f64fdaf036c92a2aea5c6e0c72'
-  data.tar.gz: 4bcb6204c07762d04460822b7bfb9a60ffc326c939ead527b7477b461a40c8e3
+  metadata.gz: a134ca1b8dfef66365a05c99f1eb70146f647d1df31978da691b81b09016d37e
+  data.tar.gz: ce602039743e58d61f5a926aec90996a95e6635343b148df247c914b33597cd4
 SHA512:
-  metadata.gz: d2bd60b5658cbce9198b83276dec3e7539ba9e7ce434df0736d6abfe1f5365086cb31bf4803fbc881d27bfd123ac13643001fe07bc8b857b5324930a9be47f5a
-  data.tar.gz: 6ea8d6f2669a13f68e14636463ee054a8fab1ecc81dc6260c2831d8c774598ff46743f68f409ed4e0bcc125aad2ac8c955e480ba49e616ea31e663fef4317a02
+  metadata.gz: 78a5c9740fd5fe6328ffaa1b8582dbf93221fc2775bdfc3471935c86de5bbb2fe1b9d80f2e7280c3a8bdb6bdc99cc59180a9e46ab77b6041673aae06ab3d43d7
+  data.tar.gz: 4dd3a4622d8d2cddd6b1b6b895740071603ffc613971e817bd58baa650602cc2c835664935d06500a768d83c00e8961b4eadbbf1e65b8cc91462b9c13d0fc7ee

data/.github/workflows/ruby.yml

@@ -9,42 +9,37 @@ name: Ruby
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["main"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 permissions:
   contents: read
 
 jobs:
   test:
-
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.6', '2.7', '3.0']
+        ruby-version: ["2.7", "3.0", "3.1", "3.2"]
 
     steps:
-    - uses: actions/checkout@v3
-    - name: Set up Ruby
-    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
-    # change this to (see https://github.com/ruby/setup-ruby#versioning):
-    # uses: ruby/setup-ruby@v1
-      uses: ruby/setup-ruby@2b019609e2b0f1ea1a2bc8ca11cb82ab46ada124
-      with:
-        ruby-version: ${{ matrix.ruby-version }}
-        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-    - name: Run tests
-      run: bundle exec rspec spec
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rspec spec
 
   lint:
-
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
       - name: Install Ruby and gems
-        uses: ruby/setup-ruby@8f312efe1262fb463d906e9bf040319394c18d3e # v1.92
+        uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true
       # Add or replace any other lints here

data/.ruby-version

@@ -1 +1 @@
-3.0.2
+3.2.5

data/.tool-versions

@@ -1 +1 @@
-ruby 3.2.2
+ruby 3.2.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    knockapi (0.4.12)
+    knockapi (0.5.1)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -26,7 +26,10 @@ Or, you may set the key yourself in an initializer:
 
 ```ruby
 # /config/initializers/knock.rb
-Knock.key = 'sk_12345'
+Knock.configure do |config|
+  config.key = '[your api key]'
+  config.timeout = 120
+end
 ```
 
 ## Usage
@@ -34,10 +37,6 @@ Knock.key = 'sk_12345'
 ### Identifying users
 
 ```ruby
-require "knock"
-
-Knock.key = "sk_12345"
-
 Knock::Users.identify(
   id: "jhammond",
   data: {
@@ -50,10 +49,6 @@ Knock::Users.identify(
 ### Sending notifies (triggering workflows)
 
 ```ruby
-require "knock"
-
-Knock.key = "sk_12345"
-
 # The key of the workflow (from Knock dashboard)
 Knock::Workflows.trigger(
   key: "dinosaurs-loose",
@@ -74,29 +69,18 @@ Knock::Workflows.trigger(
 ### Retrieving users
 
 ```ruby
-require "knock"
-
-Knock.key = "sk_12345"
-
 Knock::Users.get(id: "jhammond")
 ```
 
 ### Deleting users
 
 ```ruby
-require "knock"
-
-Knock.key = "sk_12345"
-
 Knock::Users.delete(id: "jhammond")
 ```
 
 ### Preferences
 
 ```ruby
-require "knock"
-Knock.key = "sk_12345"
-
 # Set an entire preference set
 Knock::Users.set_preferences(
   user_id: "jhammond",
@@ -115,9 +99,6 @@ Knock::Users.get_preferences(user_id: "jhammond")
 ### Getting and setting channel data
 
 ```ruby
-require "knock"
-Knock.key = "sk_12345"
-
 # Set channel data for an APNS
 Knock::Users.set_channel_data(
   id: "jhammond",
@@ -134,9 +115,6 @@ Knock::Users.get_channel_data(user_id: "jhammond", channel_id: KNOCK_APNS_CHANNE
 ### Cancelling workflows
 
 ```ruby
-require "knock"
-Knock.key = "sk_12345"
-
 Knock::Workflows.cancel(
   key: "dinosaurs-loose",
   cancellation_key: trigger_alert.id,

data/lib/knock/bulk_operations.rb

@@ -7,7 +7,6 @@ module Knock
   # Provides convienience methods for working with bulk operations
   module BulkOperations
     class << self
-      include Base
       include Client
 
       # Retrieves the given bulk operation

data/lib/knock/client.rb

@@ -2,20 +2,27 @@
 
 module Knock
   # A Net::HTTP based API client for interacting with the Knock API
+  # rubocop:disable Metrics/ModuleLength
   module Client
     include Kernel
 
     def client
-      return @client if defined?(@client)
-
-      @client = Net::HTTP.new(Knock::API_HOSTNAME, 443)
-      @client.use_ssl = true
-
-      @client
+      Net::HTTP.new(Knock.config.api_hostname, 443).tap do |http_client|
+        http_client.use_ssl = true
+        http_client.open_timeout = Knock.config.timeout
+        http_client.read_timeout = Knock.config.timeout
+        http_client.write_timeout = Knock.config.timeout if RUBY_VERSION >= '2.6.0'
+      end
     end
 
     def execute_request(request:)
-      response = client.request(request)
+      begin
+        response = client.request(request)
+      rescue Net::OpenTimeout, Net::ReadTimeout, Net::WriteTimeout
+        raise TimeoutError.new(
+          message: 'API Timeout Error'
+        )
+      end
 
       http_status = response.code.to_i
       handle_error_response(response: response) if http_status >= 400
@@ -32,7 +39,7 @@ module Knock
         'Content-Type' => 'application/json'
       )
 
-      request['Authorization'] = "Bearer #{access_token || Knock.key!}" if auth
+      request['Authorization'] = "Bearer #{access_token || Knock.config.key!}" if auth
       request['User-Agent'] = user_agent
       request
     end
@@ -40,7 +47,7 @@ module Knock
     def post_request(path:, auth: false, idempotency_key: nil, body: nil)
       request = Net::HTTP::Post.new(path, 'Content-Type' => 'application/json')
       request.body = body.to_json if body
-      request['Authorization'] = "Bearer #{Knock.key!}" if auth
+      request['Authorization'] = "Bearer #{Knock.config.key!}" if auth
       request['User-Agent'] = user_agent
       request['Idempotency-Key'] = idempotency_key if idempotency_key
       request
@@ -56,7 +63,7 @@ module Knock
       )
 
       request.body = body.to_json if body
-      request['Authorization'] = "Bearer #{Knock.key!}" if auth
+      request['Authorization'] = "Bearer #{Knock.config.key!}" if auth
       request['User-Agent'] = user_agent
       request
     end
@@ -64,7 +71,7 @@ module Knock
     def put_request(path:, auth: false, idempotency_key: nil, body: nil)
       request = Net::HTTP::Put.new(path, 'Content-Type' => 'application/json')
       request.body = body.to_json if body
-      request['Authorization'] = "Bearer #{Knock.key!}" if auth
+      request['Authorization'] = "Bearer #{Knock.config.key!}" if auth
       request['User-Agent'] = user_agent
       request['Idempotency-Key'] = idempotency_key if idempotency_key
       request
@@ -75,6 +82,8 @@ module Knock
     end
 
     # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/MethodLength
 
     def handle_error_response(response:)
       http_status = response.code.to_i
@@ -109,10 +118,18 @@ module Knock
           http_status: http_status,
           request_id: response['x-request-id']
         )
+      when 429
+        raise APIError.new(
+          message: json['message'],
+          http_status: http_status,
+          request_id: response['x-request-id']
+        )
       end
     end
 
     # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/MethodLength
 
     private
 
@@ -122,4 +139,5 @@ module Knock
       end.join('; ')
     end
   end
+  # rubocop:enable Metrics/ModuleLength
 end

data/lib/knock/configuration.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+# typed: true
+
+module Knock
+  # Configuration class sets config initializer
+  class Configuration
+    attr_accessor :api_hostname, :timeout, :key
+
+    def initialize
+      @timeout = 60
+    end
+
+    def key!
+      key or raise '`Knock.config.key` not set'
+    end
+  end
+end

data/lib/knock/errors.rb

@@ -42,4 +42,7 @@ module Knock
   # InvalidRequestError is raised when a request is initiated with invalid
   # parameters.
   class InvalidRequestError < KnockError; end
+
+  # TimeoutError is raised when the HTTP request to the API times out
+  class TimeoutError < KnockError; end
 end

data/lib/knock/messages.rb

@@ -8,7 +8,6 @@ module Knock
   # Methods for interacting with messages in Knock
   module Messages
     class << self
-      include Base
       include Client
 
       # Retrieves a paginated list of messages for the provided environment

data/lib/knock/objects.rb

@@ -9,7 +9,6 @@ module Knock
   # rubocop:disable Metrics/ModuleLength
   module Objects
     class << self
-      include Base
       include Client
 
       DEFAULT_PREFERENCE_SET_ID = 'default'

data/lib/knock/preferences.rb

@@ -7,7 +7,6 @@ module Knock
   # Provides convienience methods for working with preferences (deprecated)
   module Preferences
     class << self
-      include Base
       include Client
 
       # Returns all preference sets for the user

data/lib/knock/tenants.rb

@@ -7,7 +7,6 @@ module Knock
   # Methods for interacting with tenants in Knock
   module Tenants
     class << self
-      include Base
       include Client
 
       # Retrieves all Tenants in environment

data/lib/knock/users.rb

@@ -9,7 +9,6 @@ module Knock
   # rubocop:disable Metrics/ModuleLength
   module Users
     class << self
-      include Base
       include Client
 
       DEFAULT_PREFERENCE_SET_ID = 'default'

data/lib/knock/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Knock
-  VERSION = '0.4.12'
+  VERSION = '0.5.1'
 end

data/lib/knock/workflows.rb

@@ -7,7 +7,6 @@ module Knock
   # Methods for interacting with workflows in Knock
   module Workflows
     class << self
-      include Base
       include Client
 
       # Triggers the workflow with the given key

data/lib/knock.rb

@@ -2,25 +2,39 @@
 
 require 'knock/version'
 require 'json'
+require 'knock/configuration'
 
 # Setup for Knock client
 module Knock
-  API_HOSTNAME = ENV['KNOCK_API_HOSTNAME'] || 'api.knock.app'
+  def self.default_config
+    Configuration.new.tap do |config|
+      config.api_hostname = ENV['KNOCK_API_HOSTNAME'] || 'api.knock.app'
+      config.key = ENV['KNOCK_API_KEY']
+    end
+  end
 
-  def self.key=(value)
-    Base.key = value
+  def self.config
+    @config ||= default_config
   end
 
-  def self.key
-    Base.key
+  def self.configure
+    yield(config)
   end
 
-  def self.key!
-    key || raise('Knock.key not set')
+  def self.key=(value)
+    warn '`Knock.key=` is deprecated. Use `Knock.configure` instead.'
+
+    config.key = value
+  end
+
+  def self.key
+    warn '`Knock.key` is deprecated. Use `Knock.configure` instead.'
+    config.key
   end
 
   autoload :Base, 'knock/base'
   autoload :Client, 'knock/client'
+  autoload :Configuration, 'knock/configuration'
 
   # Resources
   autoload :Preferences, 'knock/preferences'
@@ -35,9 +49,7 @@ module Knock
   autoload :APIError, 'knock/errors'
   autoload :AuthenticationError, 'knock/errors'
   autoload :InvalidRequestError, 'knock/errors'
-
-  key = ENV['KNOCK_API_KEY']
-  Knock.key = key unless key.nil?
+  autoload :TimeoutError, 'knock/errors'
 
   # Triggers the workflow with the given key
   #

data/spec/configuration_spec.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+# typed: false
+require_relative '../lib/knock'
+
+describe Knock do
+  describe '.configure' do
+    context 'with key and no timeout' do
+      before do
+        Knock.configure do |config|
+          config.key = 'example_api_key'
+        end
+      end
+
+      it 'sets the key and default timeout configuration' do
+        expect(Knock.config.key).to eq('example_api_key')
+        expect(Knock.config.timeout).to eq(60)
+      end
+    end
+
+    context 'with key and timeout' do
+      before do
+        Knock.configure do |config|
+          config.key = 'example_api_key'
+          config.timeout = 120
+        end
+      end
+
+      it 'sets the key and timeout configuration' do
+        expect(Knock.config.key).to eq('example_api_key')
+        expect(Knock.config.timeout).to eq(120)
+      end
+    end
+  end
+end
+
+describe Knock::Configuration do
+  describe '.key!' do
+    context 'with key set' do
+      before do
+        Knock.config.key = 'example_api_key'
+      end
+
+      it 'returns the key' do
+        expect(Knock.config.key!).to eq('example_api_key')
+      end
+    end
+
+    context 'with key not set' do
+      before do
+        Knock.config.key = nil
+      end
+
+      it 'throws an error' do
+        expect do
+          Knock.config.key!
+        end.to raise_error(
+          '`Knock.config.key` not set'
+        )
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knockapi
 version: !ruby/object:Gem::Version
-  version: 0.4.12
+  version: 0.5.1
 platform: ruby
 authors:
 - Knock Labs, Inc.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-11 00:00:00.000000000 Z
+date: 2024-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -76,9 +76,9 @@ files:
 - bin/publish
 - knockapi.gemspec
 - lib/knock.rb
-- lib/knock/base.rb
 - lib/knock/bulk_operations.rb
 - lib/knock/client.rb
+- lib/knock/configuration.rb
 - lib/knock/errors.rb
 - lib/knock/messages.rb
 - lib/knock/objects.rb
@@ -87,6 +87,7 @@ files:
 - lib/knock/users.rb
 - lib/knock/version.rb
 - lib/knock/workflows.rb
+- spec/configuration_spec.rb
 - spec/tenants_spec.rb
 homepage: https://github.com/knocklabs/knock-ruby
 licenses:
@@ -108,9 +109,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: API client for Knock
 test_files:
+- spec/configuration_spec.rb
 - spec/tenants_spec.rb

data/lib/knock/base.rb

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-module Knock
-  ## The Base class handles setting and reading the Knock API Key for authentication
-  module Base
-    attr_accessor :key
-
-    class << self
-      attr_accessor :key
-    end
-  end
-end