knife 17.0.246 → 17.2.18

data/spec/unit/knife/cookbook_upload_spec.rb

@@ -0,0 +1,364 @@
+#
+# Author:: Matthew Kent (<mkent@magoazul.com>)
+# Author:: Steven Danna (<steve@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "knife_spec_helper"
+
+require "chef/cookbook_uploader"
+require "timeout"
+
+describe Chef::Knife::CookbookUpload do
+  let(:cookbook) do
+    cookbook = Chef::CookbookVersion.new("test_cookbook", "/tmp/blah")
+    allow(cookbook).to receive(:has_metadata_file?).and_return(true)
+    allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
+    cookbook
+  end
+
+  let(:cookbooks_by_name) do
+    { cookbook.name => cookbook }
+  end
+
+  let(:cookbook_loader) do
+    cookbook_loader = cookbooks_by_name.dup
+    allow(cookbook_loader).to receive(:merged_cookbooks).and_return([])
+    allow(cookbook_loader).to receive(:load_cookbooks).and_return(cookbook_loader)
+    allow(cookbook_loader).to receive(:compile_metadata).and_return(nil)
+    allow(cookbook_loader).to receive(:freeze_versions).and_return(nil)
+    cookbook_loader
+  end
+
+  let(:cookbook_uploader) { double(upload_cookbooks: nil) }
+
+  let(:output) { StringIO.new }
+
+  let(:name_args) { ["test_cookbook"] }
+
+  let(:knife) do
+    k = Chef::Knife::CookbookUpload.new
+    k.name_args = name_args
+    allow(k.ui).to receive(:stdout).and_return(output)
+    allow(k.ui).to receive(:stderr).and_return(output)
+    k
+  end
+
+  before(:each) do
+    allow(Chef::CookbookLoader).to receive(:new).and_return(cookbook_loader)
+    allow(Chef::CookbookLoader).to receive(:copy_to_tmp_dir_from_array).and_yield(cookbook_loader)
+  end
+
+  describe "with --concurrency" do
+    it "should upload cookbooks with predefined concurrency" do
+      allow(Chef::CookbookVersion).to receive(:list_all_versions).and_return({})
+      knife.config[:concurrency] = 3
+      test_cookbook = Chef::CookbookVersion.new("test_cookbook", "/tmp/blah")
+      allow(cookbook_loader).to receive(:each).and_yield("test_cookbook", test_cookbook)
+      allow(cookbook_loader).to receive(:cookbook_names).and_return(["test_cookbook"])
+      expect(Chef::CookbookUploader).to receive(:new)
+        .with( kind_of(Array), { force: nil, concurrency: 3 })
+        .and_return(double("Chef::CookbookUploader", upload_cookbooks: true))
+      knife.run
+    end
+  end
+
+  describe "run" do
+    before(:each) do
+      allow(Chef::CookbookUploader).to receive_messages(new: cookbook_uploader)
+      allow(Chef::CookbookVersion).to receive(:list_all_versions).and_return({})
+    end
+
+    it "should print usage and exit when a cookbook name is not provided" do
+      knife.name_args = []
+      expect(knife).to receive(:show_usage)
+      expect(knife.ui).to receive(:fatal)
+      expect { knife.run }.to raise_error(SystemExit)
+    end
+
+    describe "when specifying cookbook without metadata.rb or metadata.json" do
+      let(:name_args) { ["test_cookbook1"] }
+      let(:cookbook) do
+        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
+        allow(cookbook).to receive(:has_metadata_file?).and_return(false)
+        cookbook
+      end
+
+      it "should upload the cookbook" do
+        expect { knife.run }.to raise_error(Chef::Exceptions::MetadataNotFound)
+      end
+    end
+
+    describe "when name attribute in metadata not set" do
+      let(:name_args) { ["test_cookbook1"] }
+
+      let(:cookbook) do
+        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
+        allow(cookbook).to receive(:has_metadata_file?).and_return(true)
+        allow(cookbook.metadata).to receive(:name).and_return(nil)
+        cookbook
+      end
+
+      it "should upload the cookbook" do
+        expect { knife.run }.to raise_error(Chef::Exceptions::MetadataNotValid)
+      end
+    end
+
+    describe "when specifying a cookbook name" do
+      it "should upload the cookbook" do
+        expect(knife).to receive(:upload).once
+        knife.run
+      end
+
+      it "should report on success" do
+        expect(knife).to receive(:upload).once
+        expect(knife.ui).to receive(:info).with(/Uploaded 1 cookbook/)
+        knife.run
+      end
+    end
+
+    describe "when specifying the same cookbook name twice" do
+      it "should upload the cookbook only once" do
+        knife.name_args = %w{test_cookbook test_cookbook}
+        expect(knife).to receive(:upload).once
+        knife.run
+      end
+    end
+
+    describe "when specifying a cookbook name among many" do
+      let(:name_args) { ["test_cookbook1"] }
+
+      let(:cookbook) do
+        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
+        allow(cookbook).to receive(:has_metadata_file?).and_return(true)
+        allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
+        cookbook
+      end
+
+      let(:cookbooks_by_name) do
+        { cookbook.name => cookbook }
+      end
+
+      it "should read only one cookbook" do
+        expect(cookbook_loader).to receive(:[]).once.with("test_cookbook1").and_call_original
+        knife.run
+      end
+
+      it "should not read all cookbooks" do
+        expect(cookbook_loader).to receive(:load_cookbooks)
+        knife.run
+      end
+
+      it "should upload only one cookbook" do
+        expect(knife).to receive(:upload).exactly(1).times
+        knife.run
+      end
+    end
+
+    # This is testing too much.  We should break it up.
+    describe "when specifying a cookbook name with dependencies" do
+      let(:name_args) { ["test_cookbook2"] }
+
+      let(:test_cookbook1) do
+        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
+        allow(cookbook).to receive(:has_metadata_file?).and_return(true)
+        allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
+        cookbook
+      end
+
+      let(:test_cookbook2) do
+        c = Chef::CookbookVersion.new("test_cookbook2")
+        c.metadata.depends("test_cookbook3")
+        allow(c).to receive(:has_metadata_file?).and_return(true)
+        allow(c.metadata).to receive(:name).and_return(c.name)
+        c
+      end
+
+      let(:test_cookbook3) do
+        c = Chef::CookbookVersion.new("test_cookbook3")
+        c.metadata.depends("test_cookbook1")
+        c.metadata.depends("test_cookbook2")
+        allow(c).to receive(:has_metadata_file?).and_return(true)
+        allow(c.metadata).to receive(:name).and_return(c.name)
+        c
+      end
+
+      let(:cookbooks_by_name) do
+        { "test_cookbook1" => test_cookbook1,
+          "test_cookbook2" => test_cookbook2,
+          "test_cookbook3" => test_cookbook3 }
+      end
+
+      it "should upload all dependencies once" do
+        knife.config[:depends] = true
+        allow(knife).to receive(:cookbook_names).and_return(%w{test_cookbook1 test_cookbook2 test_cookbook3})
+        expect(knife).to receive(:upload).exactly(3).times
+        expect do
+          Timeout.timeout(5) do
+            knife.run
+          end
+        end.not_to raise_error
+      end
+    end
+
+    describe "when specifying a cookbook name with missing dependencies" do
+      let(:cookbook_dependency) { Chef::CookbookVersion.new("dependency", "/tmp/blah") }
+
+      before(:each) do
+        cookbook.metadata.depends("dependency")
+        allow(cookbook_loader).to receive(:[]) do |ckbk|
+          { "test_cookbook" => cookbook,
+            "dependency" => cookbook_dependency }[ckbk]
+        end
+        allow(knife).to receive(:cookbook_names).and_return(%w{cookbook_dependency test_cookbook})
+        @stdout, @stderr, @stdin = StringIO.new, StringIO.new, StringIO.new
+        knife.ui = Chef::Knife::UI.new(@stdout, @stderr, @stdin, {})
+      end
+
+      it "should exit and not upload the cookbook" do
+        expect(cookbook_loader).to receive(:[]).once.with("test_cookbook")
+        expect(cookbook_uploader).not_to receive(:upload_cookbooks)
+        expect { knife.run }.to raise_error(SystemExit)
+      end
+
+      it "should output a message for a single missing dependency" do
+        expect { knife.run }.to raise_error(SystemExit)
+        expect(@stderr.string).to include("Cookbook test_cookbook depends on cookbooks which are not currently")
+        expect(@stderr.string).to include("being uploaded and cannot be found on the server.")
+        expect(@stderr.string).to include("The missing cookbook(s) are: 'dependency' version '>= 0.0.0'")
+      end
+
+      it "should output a message for a multiple missing dependencies which are concatenated" do
+        cookbook_dependency2 = Chef::CookbookVersion.new("dependency2")
+        cookbook.metadata.depends("dependency2")
+        allow(cookbook_loader).to receive(:[]) do |ckbk|
+          { "test_cookbook" => cookbook,
+            "dependency" => cookbook_dependency,
+            "dependency2" => cookbook_dependency2 }[ckbk]
+        end
+        allow(knife).to receive(:cookbook_names).and_return(%w{dependency dependency2 test_cookbook})
+        expect { knife.run }.to raise_error(SystemExit)
+        expect(@stderr.string).to include("Cookbook test_cookbook depends on cookbooks which are not currently")
+        expect(@stderr.string).to include("being uploaded and cannot be found on the server.")
+        expect(@stderr.string).to include("The missing cookbook(s) are:")
+        expect(@stderr.string).to include("'dependency' version '>= 0.0.0'")
+        expect(@stderr.string).to include("'dependency2' version '>= 0.0.0'")
+      end
+    end
+
+    it "should freeze the version of the cookbooks if --freeze is specified" do
+      knife.config[:freeze] = true
+      expect(cookbook_loader).to receive(:freeze_versions).once
+      knife.run
+    end
+
+    describe "with -a or --all" do
+      before(:each) do
+        knife.config[:all] = true
+      end
+
+      context "when cookbooks exist in the cookbook path" do
+        let(:test_cookbook1) do
+          cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
+          allow(cookbook).to receive(:has_metadata_file?).and_return(true)
+          allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
+          cookbook
+        end
+
+        let(:test_cookbook2) do
+          cookbook = Chef::CookbookVersion.new("test_cookbook2", "/tmp/blah")
+          allow(cookbook).to receive(:has_metadata_file?).and_return(true)
+          allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
+          cookbook
+        end
+
+        before(:each) do
+          allow(cookbook_loader).to receive(:each).and_yield("test_cookbook1", test_cookbook1).and_yield("test_cookbook2", test_cookbook2)
+          allow(cookbook_loader).to receive(:cookbook_names).and_return(%w{test_cookbook1 test_cookbook2})
+        end
+
+        it "should upload all cookbooks" do
+          expect(knife).to receive(:upload).once
+          knife.run
+        end
+
+        it "should report on success" do
+          expect(knife).to receive(:upload).once
+          expect(knife.ui).to receive(:info).with(/Uploaded all cookbooks/)
+          knife.run
+        end
+
+        it "should update the version constraints for an environment" do
+          allow(knife).to receive(:assert_environment_valid!).and_return(true)
+          knife.config[:environment] = "production"
+          expect(knife).to receive(:update_version_constraints).once
+          knife.run
+        end
+      end
+
+      context "when no cookbooks exist in the cookbook path" do
+        before(:each) do
+          allow(cookbook_loader).to receive(:each)
+        end
+
+        it "should not upload any cookbooks" do
+          expect(knife).to_not receive(:upload)
+          knife.run
+        end
+
+        context "when cookbook path is an array" do
+          it "should warn users that no cookbooks exist" do
+            cookbook_path = windows? ? "C:/chef-repo/cookbooks" : "/chef-repo/cookbooks"
+            knife.config[:cookbook_path] = [cookbook_path, "/home/user/cookbooks"]
+            expect(knife.ui).to receive(:warn).with("Could not find any cookbooks in your cookbook path: '#{knife.config[:cookbook_path].join(", ")}'. Use --cookbook-path to specify the desired path.")
+            knife.run
+          end
+        end
+
+        context "when cookbook path is a string" do
+          it "should warn users that no cookbooks exist" do
+            knife.config[:cookbook_path] = windows? ? "C:/chef-repo/cookbooks" : "/chef-repo/cookbooks"
+            expect(knife.ui).to receive(:warn).with(
+              "Could not find any cookbooks in your cookbook path: '#{knife.config[:cookbook_path]}'. Use --cookbook-path to specify the desired path."
+            )
+            knife.run
+          end
+        end
+      end
+    end
+
+    describe "when a frozen cookbook exists on the server" do
+      it "should fail to replace it" do
+        exception = Chef::Exceptions::CookbookFrozen.new
+        expect(cookbook_uploader).to receive(:upload_cookbooks)
+          .and_raise(exception)
+        allow(knife.ui).to receive(:error)
+        expect(knife.ui).to receive(:error).with(exception)
+        expect { knife.run }.to raise_error(SystemExit)
+      end
+
+      it "should not update the version constraints for an environment" do
+        allow(knife).to receive(:assert_environment_valid!).and_return(true)
+        knife.config[:environment] = "production"
+        allow(knife).to receive(:upload).and_raise(Chef::Exceptions::CookbookFrozen)
+        expect(knife.ui).to receive(:error).with(/Failed to upload 1 cookbook/)
+        expect(knife.ui).to receive(:warn).with(/Not updating version constraints/)
+        expect(knife).not_to receive(:update_version_constraints)
+        expect { knife.run }.to raise_error(SystemExit)
+      end
+    end
+  end # run
+end

data/spec/unit/knife/core/bootstrap_context_spec.rb

@@ -0,0 +1,287 @@
+#
+# Author:: Daniel DeLeo (<dan@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "knife_spec_helper"
+require "chef/knife/core/bootstrap_context"
+
+describe Chef::Knife::Core::BootstrapContext do
+  let(:config) { { foo: :bar, color: true } }
+  let(:run_list) { Chef::RunList.new("recipe[tmux]", "role[base]") }
+  let(:chef_config) do
+    {
+      config_log_level: "info",
+      config_log_location: "/tmp/log",
+      validation_key: File.join(CHEF_SPEC_DATA, "ssl", "private_key.pem"),
+      chef_server_url: "http://chef.example.com:4444",
+      validation_client_name: "chef-validator-testing",
+    }
+  end
+
+  let(:secret) { nil }
+
+  subject(:bootstrap_context) { described_class.new(config, run_list, chef_config, secret) }
+
+  it "initializes with Chef 11 parameters" do
+    expect { described_class.new(config, run_list, chef_config) }.not_to raise_error
+  end
+
+  it "runs chef with the first-boot.json with no environment" do
+    expect(bootstrap_context.start_chef).to eq "chef-client -j /etc/chef/first-boot.json"
+  end
+
+  describe "when in verbosity mode" do
+    let(:config) { { verbosity: 2, color: true } }
+    it "adds '-l debug' when verbosity is >= 2" do
+      expect(bootstrap_context.start_chef).to eq "chef-client -j /etc/chef/first-boot.json -l debug"
+    end
+  end
+
+  describe "when no color value has been set in config" do
+    let(:config) { { color: false } }
+    it "adds '--no-color' when color is false" do
+      expect(bootstrap_context.start_chef).to eq "chef-client -j /etc/chef/first-boot.json --no-color"
+    end
+  end
+
+  it "reads the validation key" do
+    expect(bootstrap_context.validation_key).to eq IO.read(File.join(CHEF_SPEC_DATA, "ssl", "private_key.pem"))
+  end
+
+  it "generates the config file data" do
+    expected = <<~EXPECTED
+      chef_server_url  "http://chef.example.com:4444"
+      validation_client_name "chef-validator-testing"
+      log_level   :info
+      log_location   "/tmp/log"
+      # Using default node name (fqdn)
+    EXPECTED
+    expect(bootstrap_context.config_content).to eq expected
+  end
+
+  describe "when chef_license is set" do
+    let(:chef_config) { { chef_license: "accept-no-persist" } }
+    it "sets chef_license in the generated config file" do
+      expect(bootstrap_context.config_content).to include("chef_license \"accept-no-persist\"")
+    end
+  end
+
+  describe "when file_cache_path is set" do
+    let(:chef_config) { { file_cache_path: "/home/opscode/cache" } }
+    it "sets file_cache_path in the generated config file" do
+      expect(bootstrap_context.config_content).to include("file_cache_path \"/home/opscode/cache\"")
+    end
+  end
+
+  describe "when file_backup_path is set" do
+    let(:chef_config) { { file_backup_path: "/home/opscode/backup" } }
+    it "sets file_backup_path in the generated config file" do
+      expect(bootstrap_context.config_content).to include("file_backup_path \"/home/opscode/backup\"")
+    end
+  end
+
+  describe "alternate chef-client path" do
+    let(:chef_config) { { chef_client_path: "/usr/local/bin/chef-client" } }
+    it "runs chef-client from another path when specified" do
+      expect(bootstrap_context.start_chef).to eq "/usr/local/bin/chef-client -j /etc/chef/first-boot.json"
+    end
+  end
+
+  describe "validation key path that contains a ~" do
+    let(:chef_config) { { validation_key: "~/my.key" } }
+    it "reads the validation key when it contains a ~" do
+      expect(File).to receive(:exist?).with(File.expand_path("my.key", ENV["HOME"])).and_return(true)
+      expect(IO).to receive(:read).with(File.expand_path("my.key", ENV["HOME"]))
+      bootstrap_context.validation_key
+    end
+  end
+
+  describe "when an explicit node name is given" do
+    let(:config) { { chef_node_name: "foobar.example.com" } }
+    it "sets the node name in the client.rb" do
+      expect(bootstrap_context.config_content).to match(/node_name "foobar\.example\.com"/)
+    end
+  end
+
+  describe "when bootstrapping into a specific environment" do
+    let(:config) { { environment: "prodtastic", color: true } }
+    it "starts chef in the configured environment" do
+      expect(bootstrap_context.start_chef).to eq("chef-client -j /etc/chef/first-boot.json -E prodtastic")
+    end
+  end
+
+  describe "when tags are given" do
+    let(:config) { { tags: [ "unicorn" ] } }
+    it "adds the attributes to first_boot" do
+      expect(Chef::JSONCompat.to_json(bootstrap_context.first_boot)).to eq(Chef::JSONCompat.to_json({ run_list: run_list, tags: ["unicorn"] }))
+    end
+  end
+
+  describe "when JSON attributes are given" do
+    let(:config) { { first_boot_attributes: { baz: :quux } } }
+    it "adds the attributes to first_boot" do
+      expect(Chef::JSONCompat.to_json(bootstrap_context.first_boot)).to eq(Chef::JSONCompat.to_json({ baz: :quux, run_list: run_list }))
+    end
+  end
+
+  describe "when JSON attributes are NOT given" do
+    it "sets first_boot equal to run_list" do
+      expect(Chef::JSONCompat.to_json(bootstrap_context.first_boot)).to eq(Chef::JSONCompat.to_json({ run_list: run_list }))
+    end
+  end
+
+  describe "when policy_name and policy_group are present in config" do
+
+    let(:config) { { policy_name: "my_app_server", policy_group: "staging" } }
+
+    it "includes them in the first_boot data and excludes run_list" do
+      expect(Chef::JSONCompat.to_json(bootstrap_context.first_boot)).to eq(Chef::JSONCompat.to_json({ policy_name: "my_app_server", policy_group: "staging" }))
+    end
+
+  end
+
+  describe "when an encrypted_data_bag_secret is provided" do
+    let(:secret) { "supersekret" }
+    it "reads the encrypted_data_bag_secret" do
+      expect(bootstrap_context.encrypted_data_bag_secret).to eq "supersekret"
+    end
+  end
+
+  describe "to support compatibility with existing templates" do
+    it "sets the @config instance variable" do
+      expect(bootstrap_context.instance_variable_get(:@config)).to eq config
+    end
+
+    it "sets the @run_list instance variable" do
+      expect(bootstrap_context.instance_variable_get(:@run_list)).to eq run_list
+    end
+  end
+
+  describe "ssl_verify_mode" do
+    it "isn't set in the config_content by default" do
+      expect(bootstrap_context.config_content).not_to include("ssl_verify_mode")
+    end
+
+    describe "when configured via the config hash" do
+      let(:config) { { node_ssl_verify_mode: "none" } }
+
+      it "uses the config value" do
+        expect(bootstrap_context.config_content).to include("ssl_verify_mode :verify_none")
+      end
+    end
+  end
+
+  describe "fips mode" do
+    before do
+      chef_config[:fips] = true
+    end
+
+    it "sets fips mode in the client.rb" do
+      expect(bootstrap_context.config_content).to match(/fips true/)
+    end
+  end
+
+  describe "verify_api_cert" do
+    it "isn't set in the config_content by default" do
+      expect(bootstrap_context.config_content).not_to include("verify_api_cert")
+    end
+
+    describe "when configured via the config hash" do
+      let(:config) { { node_verify_api_cert: true } }
+
+      it "uses config value" do
+        expect(bootstrap_context.config_content).to include("verify_api_cert true")
+      end
+    end
+  end
+
+  describe "#config_log_location" do
+    context "when config_log_location is nil" do
+      let(:chef_config) { { config_log_location: nil } }
+      it "sets the default config_log_location  in the client.rb" do
+        expect(bootstrap_context.get_log_location).to eq "STDOUT"
+      end
+    end
+
+    context "when config_log_location is empty" do
+      let(:chef_config) { { config_log_location: "" } }
+      it "sets the default config_log_location  in the client.rb" do
+        expect(bootstrap_context.get_log_location).to eq "STDOUT"
+      end
+    end
+
+    context "when config_log_location is :win_evt" do
+      let(:chef_config) { { config_log_location: :win_evt } }
+      it "raise error when config_log_location is :win_evt " do
+        expect { bootstrap_context.get_log_location }.to raise_error("The value :win_evt is not supported for config_log_location on Linux Platforms \n")
+      end
+    end
+
+    context "when config_log_location is :syslog" do
+      let(:chef_config) { { config_log_location: :syslog } }
+      it "sets the config_log_location value as :syslog in the client.rb" do
+        expect(bootstrap_context.get_log_location).to eq ":syslog"
+      end
+    end
+
+    context "When config_log_location is STDOUT" do
+      let(:chef_config) { { config_log_location: STDOUT } }
+      it "Sets the config_log_location value as STDOUT in the client.rb" do
+        expect(bootstrap_context.get_log_location).to eq "STDOUT"
+      end
+    end
+
+    context "when config_log_location is STDERR" do
+      let(:chef_config) { { config_log_location: STDERR } }
+      it "sets the config_log_location value as STDERR  in the client.rb" do
+        expect(bootstrap_context.get_log_location).to eq "STDERR"
+      end
+    end
+
+    context "when config_log_location is a path" do
+      let(:chef_config) { { config_log_location: "/tmp/ChefLogFile" } }
+      it "sets the config_log_location path in the client.rb" do
+        expect(bootstrap_context.get_log_location).to eq "\"/tmp/ChefLogFile\""
+      end
+    end
+
+  end
+
+  describe "#version_to_install" do
+    context "when bootstrap_version is provided" do
+      let(:config) { { bootstrap_version: "awesome" } }
+
+      it "returns bootstrap_version" do
+        expect(bootstrap_context.version_to_install).to eq "awesome"
+      end
+    end
+
+    context "when bootstrap_version is not provided" do
+      let(:config) { { channel: "stable" } }
+      it "returns the currently running major version out of Chef::VERSION" do
+        expect(bootstrap_context.version_to_install).to eq Chef::VERSION.split(".").first
+      end
+    end
+
+    context "and channel is other than stable" do
+      let(:config) { { channel: "unstable" } }
+      it "returns the version string 'latest'" do
+        expect(bootstrap_context.version_to_install).to eq "latest"
+      end
+    end
+  end
+end