knife-tidy 1.2.0 → 2.0.0

data/lib/chef/knife/tidy_notify.rb

@@ -1,58 +1,58 @@
-require 'chef/knife/tidy_base'
+require "chef/knife/tidy_base"
 
 class Chef
   class Knife
     class TidyNotify < Knife
       deps do
-        require 'ffi_yajl'
-        require 'net/smtp'
+        require "ffi_yajl"
+        require "net/smtp"
       end
 
-      banner 'knife tidy notify (options)'
+      banner "knife tidy notify (options)"
 
       option :smtp_server,
-             short: '-s SERVER_NAME',
-             long: '--smtp_server SERVER_NAME',
-             default: 'localhost',
-             description: 'SMTP Server to be used for emailling reports to organization admins (defaults to localhost)'
+             short: "-s SERVER_NAME",
+             long: "--smtp_server SERVER_NAME",
+             default: "localhost",
+             description: "SMTP Server to be used for emailling reports to organization admins (defaults to localhost)"
 
       option :smtp_port,
-             short: '-p SMTP_PORT',
-             long: '--smtp_port SMTP_PORT',
+             short: "-p SMTP_PORT",
+             long: "--smtp_port SMTP_PORT",
              default: 25,
-             description: 'SMTP port to be used for emailling reports to organization admins (defaults to 25)'
+             description: "SMTP port to be used for emailling reports to organization admins (defaults to 25)"
 
       option :smtp_helo,
-             short: '-h SMTP_HELO',
-             long: '--smtp_helo SMTP_HELO',
-             default: 'localhost',
-             description: 'SMTP HELO to be used for emailling reports to organization admins (defaults to localhost)'
+             short: "-h SMTP_HELO",
+             long: "--smtp_helo SMTP_HELO",
+             default: "localhost",
+             description: "SMTP HELO to be used for emailling reports to organization admins (defaults to localhost)"
 
       option :smtp_username,
-             short: '-u SMTP_USERNAME',
-             long: '--smtp_username SMTP_USERNAME',
-             description: 'SMTP Username to be used for emailling reports to organization admins'
+             short: "-u SMTP_USERNAME",
+             long: "--smtp_username SMTP_USERNAME",
+             description: "SMTP Username to be used for emailling reports to organization admins"
 
       option :smtp_password,
-             long: '--smtp_password SMTP_PASSWORD',
-             description: 'SMTP Password to be used for emailling reports to organization admins'
+             long: "--smtp_password SMTP_PASSWORD",
+             description: "SMTP Password to be used for emailling reports to organization admins"
 
       option :smtp_from,
-             long: '--smtp_from SMTP_FROM',
-             description: 'SMTP From address to be used for emailling reports to organization admins'
+             long: "--smtp_from SMTP_FROM",
+             description: "SMTP From address to be used for emailling reports to organization admins"
 
       option :smtp_use_tls,
-             long: '--smtp_use_tls',
-             short: '-t',
+             long: "--smtp_use_tls",
+             short: "-t",
              default: false,
              boolean: true | false,
-             description: 'Whether TLS should be used for emailling reports to organization admins (defaults to false if omitted)'
+             description: "Whether TLS should be used for emailling reports to organization admins (defaults to false if omitted)"
 
       include Knife::TidyBase
 
       def run
         reports_dir = tidy.reports_dir
-        report_file_suffixes = ['_unused_cookbooks.json', '_cookbook_count.json', '_stale_nodes.json']
+        report_file_suffixes = ["_unused_cookbooks.json", "_cookbook_count.json", "_stale_nodes.json"]
         # Only grab the files matching the report_file_suffixes
         report_files = Dir["#{reports_dir}/*{#{report_file_suffixes.join(',')}}"]
 
@@ -62,11 +62,11 @@ class Chef
         begin
           org_names = report_files.map { |r_file| r_file.match("#{reports_dir}\/(.*)(#{report_file_suffixes.join('|')})").captures.first }.uniq
         rescue NoMethodError
-          ui.stderr.puts 'Failed to parse json reports files. Please ensure your reports are valid.'
+          ui.stderr.puts "Failed to parse json reports files. Please ensure your reports are valid."
           return
         end
         if config[:org_list]
-          filter_orgs = config[:org_list].split(',')
+          filter_orgs = config[:org_list].split(",")
           # Take the intersection of org_names and filter_orgs
           org_names &= filter_orgs
         end
@@ -76,7 +76,7 @@ class Chef
         # Iterate through list of collected organizations and parse any report files into JSON objects
 
         unless org_names
-          ui.std.puts 'No valid org reports found to send notifications. Exiting.'
+          ui.std.puts "No valid org reports found to send notifications. Exiting."
           return
         end
 
@@ -99,13 +99,13 @@ class Chef
           ui.info("Fetching admins users for organization #{org}")
           begin
             admins = org_admins(org)
-            reports[org]['admins'] = admins.map { |name, _data| org_user(org, name) unless name == 'pivotal' }
+            reports[org]["admins"] = admins.map { |name, _data| org_user(org, name) unless name == "pivotal" }
           rescue Net::HTTPServerException
             ui.info("  Cannot fetch admin users for organization #{org} as it does not exist on the server")
           end
 
           # Build list of email recipients from the collected admin users (display name and email address of each)
-          email_recipients = reports[org]['admins'].map { |admin| { name: admin['display_name'], email: admin['email'] } unless admin.nil? }.compact
+          email_recipients = reports[org]["admins"].map { |admin| { name: admin["display_name"], email: admin["email"] } unless admin.nil? }.compact
 
           # Send a report email to all admin users of the organization
           ui.info "Sending email reports for organization #{org}"
@@ -118,73 +118,73 @@ class Chef
 
       def generate_email(report_data, organization, recipients, report_file_suffixes)
         mime_boundary = "==Multipart_Boundary_x#{srand}x"
-        message = <<MESSAGE_END
-From: Knife Tidy <#{config[:smtp_from]}>
-To: #{recipients.map { |recipient| "#{recipient[:name]} <#{recipient[:email]}>" }.join(', ')}
-MIME-Version: 1.0
-Subject: Knife Tidy Cleanup Report for Organization "#{organization}"
-Content-Type: multipart/mixed; boundary="#{mime_boundary}";
---#{mime_boundary}
-Content-type: text/html
-Content-Transfer-Encoding: 7bit
-
-The following reports were generated by <a href="https://github.com/chef-customers/knife-tidy">knife-tidy</a>, and contain a list of unused cookbooks and stale nodes for the Chef server organization "#{organization}"
-#{generate_total_cookbooks_table(report_data, organization)}
-#{generate_unused_cookbooks_table(report_data, organization)}
-#{generate_node_table(report_data, organization)}
-MESSAGE_END
+        message = <<~MESSAGE_END
+          From: Knife Tidy <#{config[:smtp_from]}>
+          To: #{recipients.map { |recipient| "#{recipient[:name]} <#{recipient[:email]}>" }.join(', ')}
+          MIME-Version: 1.0
+          Subject: Knife Tidy Cleanup Report for Organization "#{organization}"
+          Content-Type: multipart/mixed; boundary="#{mime_boundary}";
+          --#{mime_boundary}
+          Content-type: text/html
+          Content-Transfer-Encoding: 7bit
+
+          The following reports were generated by <a href="https://github.com/chef-customers/knife-tidy">knife-tidy</a>, and contain a list of unused cookbooks and stale nodes for the Chef server organization "#{organization}"
+          #{generate_total_cookbooks_table(report_data, organization)}
+          #{generate_unused_cookbooks_table(report_data, organization)}
+          #{generate_node_table(report_data, organization)}
+        MESSAGE_END
 
         report_file_suffixes.each do |suffix|
-          message += <<MESSAGE_END
---#{mime_boundary}
-Content-Transfer-Encoding:7bit
-Content-Type: plain/text;name="#{organization}#{suffix}";charset="UTF-8"
-Content-Disposition: attachment;filename="#{organization}#{suffix}"
+          message += <<~MESSAGE_END
+            --#{mime_boundary}
+            Content-Transfer-Encoding:7bit
+            Content-Type: plain/text;name="#{organization}#{suffix}";charset="UTF-8"
+            Content-Disposition: attachment;filename="#{organization}#{suffix}"
 
-#{report_data[organization][suffix].to_json}
+            #{report_data[organization][suffix].to_json}
 
-MESSAGE_END
+          MESSAGE_END
         end
 
-        message += <<MESSAGE_END
---#{mime_boundary}--
-MESSAGE_END
+        message += <<~MESSAGE_END
+          --#{mime_boundary}--
+        MESSAGE_END
         puts message
         message
       end
 
       def generate_total_cookbooks_table(report_data, organization)
         table_start = "<h2>Total Versions by Cookbook</h2><p>This table contains the count of versions of each cookbook stored on the Chef Server.<p><table border='1' cellpadding='1' cellspacing='0'>"
-        table_end = '</table><br/>'
-        header_string = '<tr><th>Cookbook Name</th><th>Total Version Count</th></tr>'
-        table_body = if report_data[organization]['_cookbook_count.json'].empty?
+        table_end = "</table><br/>"
+        header_string = "<tr><th>Cookbook Name</th><th>Total Version Count</th></tr>"
+        table_body = if report_data[organization]["_cookbook_count.json"].empty?
                        "<tr><td colspan='2'>No cookbook versions</td></tr>"
                      else
-                       report_data[organization]['_cookbook_count.json'].map { |cookbook_name, cookbook_count| "<tr><td>#{cookbook_name}</td><td>#{cookbook_count}</td></tr>" }.join("\n")
+                       report_data[organization]["_cookbook_count.json"].map { |cookbook_name, cookbook_count| "<tr><td>#{cookbook_name}</td><td>#{cookbook_count}</td></tr>" }.join("\n")
                      end
         table_start + header_string + table_body + table_end
       end
 
       def generate_unused_cookbooks_table(report_data, organization)
         table_start = "<h2>Unused Cookbooks</h2><p>This table contains cookbook names and the count of their versions that are not currently in the runlists of any nodes.<p><table border='1' cellpadding='1' cellspacing='0'>"
-        table_end = '</table><br/>'
-        header_string = '<tr><th>Cookbook Name</th><th>Unused Versions</th></tr>'
-        table_body = if report_data[organization]['_unused_cookbooks.json'].empty?
+        table_end = "</table><br/>"
+        header_string = "<tr><th>Cookbook Name</th><th>Unused Versions</th></tr>"
+        table_body = if report_data[organization]["_unused_cookbooks.json"].empty?
                        "<tr><td colspan='2'>No unused cookbook versions</td></tr>"
                      else
-                       report_data[organization]['_unused_cookbooks.json'].map { |cookbook_name, cookbook_versions| "<tr><td>#{cookbook_name}</td><td>#{cookbook_versions.join('<br>')}</td></tr>" }.join("\n")
+                       report_data[organization]["_unused_cookbooks.json"].map { |cookbook_name, cookbook_versions| "<tr><td>#{cookbook_name}</td><td>#{cookbook_versions.join('<br>')}</td></tr>" }.join("\n")
                      end
         table_start + header_string + table_body + table_end
       end
 
       def generate_node_table(report_data, organization)
         table_start = "<h2>Stale Nodes</h2><p>This table contains nodes that have not checked in to the Chef Server in #{report_data[organization]['_stale_nodes.json']['threshold_days']} days.<p><table border='1' cellpadding='1' cellspacing='0'>"
-        table_end = '</table>'
-        header_string = '<tr><th>Node Name</th></tr>'
-        table_body = if report_data[organization]['_stale_nodes.json'].empty? || report_data[organization]['_stale_nodes.json']['count'] == 0
+        table_end = "</table>"
+        header_string = "<tr><th>Node Name</th></tr>"
+        table_body = if report_data[organization]["_stale_nodes.json"].empty? || report_data[organization]["_stale_nodes.json"]["count"] == 0
                        "<tr><td colspan='2'>No stale nodes</td></tr>"
                      else
-                       report_data[organization]['_stale_nodes.json']['list'].map { |node_name| "<tr><td>#{node_name}</td></tr>" }.join("\n")
+                       report_data[organization]["_stale_nodes.json"]["list"].map { |node_name| "<tr><td>#{node_name}</td></tr>" }.join("\n")
                      end
         table_start + header_string + table_body + table_end
       end
@@ -199,7 +199,7 @@ MESSAGE_END
 
       def org_admins(org)
         admins = {}
-        rest.get("/organizations/#{org}/groups/admins")['users'].each do |name|
+        rest.get("/organizations/#{org}/groups/admins")["users"].each do |name|
           admins[name] = {}
         end
         admins

data/lib/chef/knife/tidy_server_clean.rb

@@ -1,4 +1,4 @@
-require 'chef/knife/tidy_base'
+require "chef/knife/tidy_base"
 
 class Chef
   class Knife
@@ -6,32 +6,32 @@ class Chef
       include Knife::TidyBase
 
       deps do
-        require 'ffi_yajl'
-        require 'chef/util/threaded_job_queue'
+        require "ffi_yajl"
+        require "chef/util/threaded_job_queue"
       end
 
-      banner 'knife tidy server clean (options)'
+      banner "knife tidy server clean (options)"
 
       option :backup_path,
-        long: '--backup-path path/to/backup',
-        description: 'The path to the knife-ec-backup backup directory'
+        long: "--backup-path path/to/backup",
+        description: "The path to the knife-ec-backup backup directory"
 
       option :concurrency,
-        long: '--concurrency THREADS',
+        long: "--concurrency THREADS",
         default: 1,
-        description: 'Maximum number of simultaneous requests to send (default: 1)'
+        description: "Maximum number of simultaneous requests to send (default: 1)"
 
       option :only_cookbooks,
-        long: '--only-cookbooks',
-        description: 'Only delete unused cookbooks from Chef Server.'
+        long: "--only-cookbooks",
+        description: "Only delete unused cookbooks from Chef Server."
 
       option :only_nodes,
-        long: '--only-nodes',
-        description: 'Only delete stale nodes (and associated clients and ACLs) from Chef Server.'
+        long: "--only-nodes",
+        description: "Only delete stale nodes (and associated clients and ACLs) from Chef Server."
 
       option :dry_run,
-        long: '--dry-run',
-        description: 'Do not perform any actual deletion, only report on what would have been deleted.'
+        long: "--dry-run",
+        description: "Do not perform any actual deletion, only report on what would have been deleted."
 
       def run
         STDOUT.sync = true
@@ -41,37 +41,37 @@ class Chef
         configure_chef
 
         if config[:only_cookbooks] && config[:only_nodes]
-          ui.error 'Cannot use --only-cookbooks AND --only-nodes'
+          ui.error "Cannot use --only-cookbooks AND --only-nodes"
           exit 1
         end
 
         while config[:backup_path].nil?
           user_value = ui.ask_question("It is not recommended to run this command without specifying a current backup directory.\nPlease specify a backup directory:")
-          config[:backup_path] = user_value == '' ? nil : user_value
+          config[:backup_path] = user_value == "" ? nil : user_value
         end
 
         unless ::File.directory?(config[:backup_path])
-          ui.error 'Must specify valid --backup-path'
+          ui.error "Must specify valid --backup-path"
           exit 1
         end
 
         deletions = if config[:only_cookbooks]
-                      'cookbooks'
+                      "cookbooks"
                     elsif config[:only_nodes]
-                      'nodes (and associated clients and ACLs)'
+                      "nodes (and associated clients and ACLs)"
                     else
-                      'cookbooks and nodes (and associated clients and ACLs)'
+                      "cookbooks and nodes (and associated clients and ACLs)"
                     end
 
         orgs = if config[:org_list]
-                 config[:org_list].split(',')
+                 config[:org_list].split(",")
                else
                  all_orgs
                end
 
         ui.warn "This operation will affect the following Orgs on #{server.root_url}: #{orgs}"
         if ::File.exist?(server_warnings_file_path)
-          ::File.read(::File.expand_path('reports/knife-tidy-server-warnings.txt')).each_line do |line|
+          ::File.read(::File.expand_path("reports/knife-tidy-server-warnings.txt")).each_line do |line|
             ui.warn(line)
           end
         end
@@ -147,7 +147,7 @@ class Chef
       end
 
       def report_files
-        Dir[::File.join(tidy.reports_dir, '**.json')]
+        Dir[::File.join(tidy.reports_dir, "**.json")]
       end
 
       def all_orgs

data/lib/chef/knife/tidy_server_report.rb

@@ -1,4 +1,4 @@
-require 'chef/knife/tidy_base'
+require "chef/knife/tidy_base"
 
 class Chef
   class Knife
@@ -7,15 +7,15 @@ class Chef
       include Knife::TidyBase
 
       deps do
-        require 'ffi_yajl'
+        require "ffi_yajl"
       end
 
       banner "knife tidy server report (options)"
 
       option :node_threshold,
-        :long => '--node-threshold NUM_DAYS',
-        :default => 30,
-        :description => 'Maximum number of days since last checkin before node is considered stale (default: 30)'
+        long: "--node-threshold NUM_DAYS",
+        default: 30,
+        description: "Maximum number of days since last checkin before node is considered stale (default: 30)"
 
       def run
         ensure_reports_dir!
@@ -25,7 +25,7 @@ class Chef
         delete_existing_reports
 
         orgs = if config[:org_list]
-                 config[:org_list].split(',')
+                 config[:org_list].split(",")
                else
                  all_orgs
                end
@@ -51,23 +51,23 @@ class Chef
 
           nodes.each do |node|
             # If the node hasn't checked in.
-            if !node['chef_packages']
+            if !node["chef_packages"]
               # If the node is under an hour old.
-              if (Time.now.to_i - node['ohai_time'].to_i) < 3600
-                unconverged_recent_nodes << node['name']
+              if (Time.now.to_i - node["ohai_time"].to_i) < 3600
+                unconverged_recent_nodes << node["name"]
               end
               next
             end
-            chef_version = Gem::Version.new(node['chef_packages']['chef']['version'])
+            chef_version = Gem::Version.new(node["chef_packages"]["chef"]["version"])
             # If the node has checked in within the node_threshold with a client older than 12.3
-            if chef_version < Gem::Version.new("12.3") && (Time.now.to_i - node['ohai_time'].to_i) <= node_threshold * 86400
-              pre_12_3_nodes << node['name']
+            if chef_version < Gem::Version.new("12.3") && (Time.now.to_i - node["ohai_time"].to_i) <= node_threshold * 86400
+              pre_12_3_nodes << node["name"]
             end
           end
 
-          nodes.select{|node| !node['cookbooks'].nil?}.each do |node|
-            node['cookbooks'].each do |name, version_hash|
-              version = Gem::Version.new(version_hash['version']).to_s
+          nodes.select { |node| !node["cookbooks"].nil? }.each do |node|
+            node["cookbooks"].each do |name, version_hash|
+              version = Gem::Version.new(version_hash["version"]).to_s
               if used_cookbooks[name]
                 used_cookbooks[name].push(version) unless used_cookbooks[name].include?(version)
               else
@@ -81,17 +81,17 @@ class Chef
 
           stale_nodes = []
           nodes.each do |n|
-            if (Time.now.to_i - n['ohai_time'].to_i) >= node_threshold * 86400
-              stale_nodes.push(n['name'])
+            if (Time.now.to_i - n["ohai_time"].to_i) >= node_threshold * 86400
+              stale_nodes.push(n["name"])
             end
           end
 
-          stale_nodes_hash = {'threshold_days': node_threshold, 'org_total_node_count': nodes.count, 'count': stale_nodes.count, 'list': stale_nodes}
+          stale_nodes_hash = { 'threshold_days': node_threshold, 'org_total_node_count': nodes.count, 'count': stale_nodes.count, 'list': stale_nodes }
           stale_orgs.push(org) if stale_nodes.count == nodes.count
 
-          tidy.write_new_file(unused_cookbooks(used_cookbooks, cb_list), ::File.join(tidy.reports_dir, "#{org}_unused_cookbooks.json"), backup=false)
-          tidy.write_new_file(version_count, ::File.join(tidy.reports_dir, "#{org}_cookbook_count.json"), backup=false)
-          tidy.write_new_file(stale_nodes_hash, ::File.join(tidy.reports_dir, "#{org}_stale_nodes.json"), backup=false)
+          tidy.write_new_file(unused_cookbooks(used_cookbooks, cb_list), ::File.join(tidy.reports_dir, "#{org}_unused_cookbooks.json"), backup = false)
+          tidy.write_new_file(version_count, ::File.join(tidy.reports_dir, "#{org}_cookbook_count.json"), backup = false)
+          tidy.write_new_file(stale_nodes_hash, ::File.join(tidy.reports_dir, "#{org}_stale_nodes.json"), backup = false)
 
           if pre_12_3_nodes.length > 0
             pre_12_3_message = "#{pre_12_3_nodes.length} nodes in organization #{org} have converged in the last #{node_threshold} days with a chef-client < 12.3. These nodes' cookbook versions WILL NOT be factored in the stale cookbooks versions report. Continuing with the server cleanup will delete cookbooks in-use by these nodes."
@@ -113,24 +113,24 @@ class Chef
       end
 
       def delete_existing_reports
-        files = Dir[::File.join(tidy.reports_dir, '*.json')]
+        files = Dir[::File.join(tidy.reports_dir, "*.json")]
         unless files.empty?
           ui.confirm("You have existing reports in #{tidy.reports_dir}. Remove")
-          FileUtils.rm(files, :force => true)
+          FileUtils.rm(files, force: true)
         end
       end
 
-      # Need the block here to get the search method to invoke multiple searches and 
+      # Need the block here to get the search method to invoke multiple searches and
       # aggregate results for result sets over 1k.
       def nodes_list(org)
         node_results = []
         Chef::Search::Query.new("#{server.root_url}/organizations/#{org}").search(
-          :node, '*:*',
-          :filter_result => {
-            'name' => ['name'],
-            'cookbooks' => ['cookbooks'],
-            'ohai_time' => ['ohai_time'],
-            'chef_packages' => ['chef_packages']
+          :node, "*:*",
+          filter_result: {
+            "name" => ["name"],
+            "cookbooks" => ["cookbooks"],
+            "ohai_time" => ["ohai_time"],
+            "chef_packages" => ["chef_packages"],
           }
         ) do |node|
           node_results << node
@@ -141,8 +141,8 @@ class Chef
       def cookbook_list(org)
         cb_list = {}
         rest.get("/organizations/#{org}/cookbooks?num_versions=all").each do |name, data|
-          data['versions'].each do |version_hash|
-            version = Gem::Version.new(version_hash['version']).to_s
+          data["versions"].each do |version_hash|
+            version = Gem::Version.new(version_hash["version"]).to_s
             if cb_list[name] && !cb_list[name].include?(version)
               cb_list[name].push(version)
             else
@@ -164,11 +164,11 @@ class Chef
       def unused_cookbooks(used_list, cb_list)
         unused_list = {}
         cb_list.each do |name, versions|
-          versions.sort! {| a, b | Gem::Version.new(a) <=> Gem::Version.new(b) }
+          versions.sort! { |a, b| Gem::Version.new(a) <=> Gem::Version.new(b) }
           if used_list[name].nil? # Not in the used list at all (Remove all versions)
             unused_list[name] = versions
-          elsif used_list[name].sort != versions  # Is in the used cookbook list, but version arrays do not match (Find unused versions)
-            unused = versions - used_list[name] - [versions.last]  # Don't delete the most recent version as it might not be in a run_list yet.
+          elsif used_list[name].sort != versions # Is in the used cookbook list, but version arrays do not match (Find unused versions)
+            unused = versions - used_list[name] - [versions.last] # Don't delete the most recent version as it might not be in a run_list yet.
             unused_list[name] = unused unless unused.empty?
           end
         end
@@ -176,7 +176,7 @@ class Chef
       end
 
       def all_orgs
-        rest.get('organizations').keys
+        rest.get("organizations").keys
       end
 
       def all_environments(org)
@@ -187,7 +187,7 @@ class Chef
         constraints = {}
         all_environments(org).each do |env|
           e = rest.get(env)
-          e['cookbook_versions'].each do |cb, version|
+          e["cookbook_versions"].each do |cb, version|
             if constraints[cb]
               constraints[cb].push(version) unless constraints[cb].include?(version)
             else
@@ -202,7 +202,7 @@ class Chef
         if cb_list[cb]
           cb_list[cb].each do |v|
             versions_not_satisfied = []
-            if Gem::Dependency.new('', version).match?('', v)
+            if Gem::Dependency.new("", version).match?("", v)
               return [v]
             else
               versions_not_satisfied.push(v)
@@ -214,7 +214,7 @@ class Chef
         else
           ui.warn("Cookbook #{cb} #{version} is pinned in an environment, but does not exist on the server in this org.")
         end
-        return nil
+        nil
       end
 
       def check_environment_pins(used_cookbooks, pins, cb_list)
@@ -224,7 +224,7 @@ class Chef
             if used_cookbooks[cb]
               # This pinned cookbook is in the used list, now check for a matching version.
               used_cookbooks[cb].each do |v|
-                if Gem::Dependency.new('', version).match?('', v)
+                if Gem::Dependency.new("", version).match?("", v)
                   break
                 end
               end