knife-spork 1.3.4 → 1.4.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZmNkNDZiMDM3MzE5Nzk2NmU3NTcyOTcyM2Y0NjY5MGI3NjRkODA5Yw==
-  data.tar.gz: !binary |-
-    NDU3YmIxMDQ4YTJlN2E5MDNmYjcxMDU2YmRjM2ExYTcxNjhhMjg2Ng==
+SHA1:
+  metadata.gz: 14e3e1ec0e10a27b1e6b3fbed2a5265f20288a78
+  data.tar.gz: 31ec1a3d172014c1791e00d28e9a043612963cbb
 SHA512:
-  metadata.gz: !binary |-
-    ZDc0ZTVjMjQ4M2IyODhhNGMzYmVjZWY2NjY1ZTQ2ODdkNTliYjRlNTI0Y2I3
-    NTVhY2JkMjI3MzIzNTU2NGQ4OGQ4OTRkMzMxYWNmNjVjOWJhNTEzNzJlZmY5
-    NmY2YzY2MzlhYjkxYThiNmIyMzc4MWUwMWZmNTM4YTU2YWZmNDY=
-  data.tar.gz: !binary |-
-    NDQzYTgxYzY3MmYyNzhiZTEzZWFjNDdhYWMwYWM4OTUyN2Q1YjZjMTM3ZTE5
-    NTBkMDU1OTlhMGUzYTU3OTNkZDJlZjM5YmNhNjk1OGE3YzQ2YzE0ZTVlYmJm
-    ZjQxYmVlYjU5OTkyODEwOWU5MzBkNzkxZmI3NDc5Y2FhMmI2MmU=
+  metadata.gz: 8eae1fcab0dc4eaa6837ee97f5aae878ca384509d6056663c32841d249e993d5b0bed3e2727f0895b92f72be0c3bbc7db79cdba6943d41d4424b6d55e033bf4e
+  data.tar.gz: c3501970934ea59acfaabfa662e6186da5e25456713208ff057ae323be32163dfec7b048beaf8a16fc51a4cdfadb64f5f795ca467128017460448b258ed36b45

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 1.4.0 (Footh August, 2014)
+
+Bugfixes:
+
+    - Fix bug with preserve_constraint_operators functionality (https://github.com/jonlives/knife-spork/issues/131)
+    - Fix incorrect data bag banner message (Thanks to @jperry https://github.com/jonlives/knife-spork/pull/119)
+    - Fix error when calculating environment path when "cookbooks" occurs in cookbook_path outside of the last position (https://github.com/jonlives/knife-spork/issues/137)
+    - Fix spelling error in README (Thanks to @jrwesolo https://github.com/jonlives/knife-spork/pull/136)
+
+Features:
+    
+    - Hipchat plugin now supports custom server URL and API version (Thanks to @hrak https://github.com/jonlives/knife-spork/pull/135)
+    - Slack plugin (Thanks to @chrisferry https://github.com/jonlives/knife-spork/pull/134)
+    - Add skip_berkshelf flag to allow Berkshelf operations to be skipped even when Berkshelf is loaded (https://github.com/jonlives/knife-spork/issues/138)
+    
+    
 ## 1.3.4 (2nd June, 2014)
 
 Bugfixes:

data/README.md

@@ -52,6 +52,7 @@ environment_path: "/home/me/environments"
 role_path: "/home/me/roles"
 custom_plugin_path: "/home/me/spork-plugins"
 always_promote_remote: true
+skip_berkshelf: false
 json_options:
   indent: "    "
 plugins:
@@ -88,6 +89,18 @@ plugins:
     port: 2003
   eventinator:
     url: http://eventinator.mydomain.com/events/oneshot
+  slack:
+    api_token: abc123
+    channel: "#sysops"
+    teamname: myteam
+    username: knife
+  rubocop:
+    epic_fail: true
+    show_name: false
+    autocorrect: false
+    out_file: <file>
+    sev_level: <C|W|E>
+    lint: false
 ```
 
 #### Default Environments
@@ -105,6 +118,9 @@ The `preserve_constraint_operators` directive causes spork promote to preserve e
 #### Always Promote Remote
 The `always_promote_remote` directive allows you to tell spork promote to always act as if the --remote option had been specified. This will also have the same effect on spork omni. This option should only be used if you're sure you want all changes to be uploaded to the server as soon as you run promote.
 
+#### Skip Berkshelf
+The `skip_berkshelf` directive is a temporary flag added in [#138](https://github.com/jonlives/knife-spork/issues/138) to allow Berkshelf functionality to be optionally bypassed until Berkshelf 3 support has been added to knife-spork per [#85](https://github.com/jonlives/knife-spork/issues/85). It simply removed the :Berkshelf constant from the namespace used by knife-spork.
+
 #### JSON Options
 The `json_options` directive allows you to tell spork to pass options to [pretty_generate](http://www.ruby-doc.org/stdlib-1.9.3/libdoc/json/rdoc/JSON.html#method-i-pretty_generate) to control the format of the resulting json
 
@@ -137,7 +153,7 @@ knife spork info
 ```text
 $ knife spork info
 Config Hash:
-{"plugins"=>{"git"=>{"enabled"=>true}, "irccat"=>{"server"=>"irccat.mydomain.com", "port"=>12345, "gist"=>"usr/bin/gist", "channel"=>["#chef-announce"]}, "graphite"=>{"server"=>"graphite.mydomain.com", "port"=>2003}, "eventinator"=>{"url"=>"http://eventinator.mydomain.com/events/oneshot"}}, "default_environments"=>["development", "production"], "version_change_threshold"=>2, "pplugins"=>{"foodcritic"=>{"fail_tags"=>["style,correctness,test"], "tags"=>["~portability"], "include_rules"=>["config/rules.rb"]}}}
+{"plugins"=>{"git"=>{"enabled"=>true}, "irccat"=>{"server"=>"irccat.mydomain.com", "port"=>12345, "gist"=>"usr/bin/gist", "channel"=>["#chef-announce"]}, "graphite"=>{"server"=>"graphite.mydomain.com", "port"=>2003}, "slack"=>{"api_token"=>"abc123", "channel"=>"random", "teamname"=>"myteam"}, "eventinator"=>{"url"=>"http://eventinator.mydomain.com/events/oneshot"}}, "default_environments"=>["development", "production"], "version_change_threshold"=>2, "pplugins"=>{"foodcritic"=>{"fail_tags"=>["style,correctness,test"], "tags"=>["~portability"], "include_rules"=>["config/rules.rb"]}}}
 
 Plugins:
 KnifeSpork::Plugins::Campfire: disabled
@@ -146,6 +162,7 @@ KnifeSpork::Plugins::Foodcritic: disabled
 KnifeSpork::Plugins::Git: enabled
 KnifeSpork::Plugins::Graphite: enabled
 KnifeSpork::Plugins::HipChat: disabled
+KnifeSpork::Plugins::Slack: enabled
 KnifeSpork::Plugins::Irccat: enabled
 ```
 
@@ -373,7 +390,7 @@ Saving changes to development.json
 Promotion complete. Don't forget to upload your changed development.json to Chef Server
 ```
 
-Spork Environnent Check
+Spork Environment Check
 -------------
 Environment check provides the ability to validate a local chef environment file is locked to versions that actually exist on the chef server.  Running this check prior to uploading your environment files is recommended as it can prevent your chef server from becoming unresponsive due to a version constraint that will never be valid.
 

data/knife-spork.gemspec

@@ -2,7 +2,7 @@ $:.push File.expand_path('../lib', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.name          = 'knife-spork'
-  gem.version       = '1.3.4'
+  gem.version       = '1.4.0'
   gem.authors       = ["Jon Cowie"]
   gem.email         = 'jonlives@gmail.com'
   gem.homepage      = 'https://github.com/jonlives/knife-spork'
@@ -20,4 +20,4 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'git', '>= 1.2.5'
   gem.add_runtime_dependency 'app_conf', '>= 0.4.0'
   gem.add_runtime_dependency 'diffy', '>= 3.0.1'
-end
+end

data/lib/chef/knife/spork-bump.rb

@@ -42,6 +42,10 @@ module KnifeSpork
         exit 1
       end
 
+      # Temporary fix for #138 to allow Berkshelf functionality
+      # to be bypassed until #85 has been completed and Berkshelf 3 support added
+      unload_berkshelf_if_specified
+
       #First load so plugins etc know what to work with
       @cookbook = load_cookbook(name_args.first)
 

data/lib/chef/knife/spork-check.rb

@@ -48,6 +48,10 @@ module KnifeSpork
         exit(1)
       end
 
+      # Temporary fix for #138 to allow Berkshelf functionality
+      # to be bypassed until #85 has been completed and Berkshelf 3 support added
+      unload_berkshelf_if_specified
+
       #First load so plugins etc know what to work with
       initial_load
       

data/lib/chef/knife/spork-databag-create.rb

@@ -9,7 +9,7 @@ module KnifeSpork
       require 'chef/knife/data_bag_create'
     end
 
-    banner 'knife data bag create BAG [ITEM] (options)'
+    banner 'knife spork data bag create BAG [ITEM] (options)'
 
     option :secret,
            :short => "-s SECRET",

data/lib/chef/knife/spork-databag-delete.rb

@@ -9,7 +9,7 @@ module KnifeSpork
       require 'chef/knife/data_bag_delete'
     end
 
-    banner 'knife data bag delete BAG [ITEM] (options)'
+    banner 'knife spork data bag delete BAG [ITEM] (options)'
 
 
     def run

data/lib/chef/knife/spork-databag-fromfile.rb

@@ -9,7 +9,7 @@ module KnifeSpork
       require 'chef/knife/data_bag_from_file'
     end
 
-    banner 'knife data bag from file BAG FILE|FOLDER [FILE|FOLDER..] (options)'
+    banner 'knife spork data bag from file BAG FILE|FOLDER [FILE|FOLDER..] (options)'
 
     option :secret,
            :short => "-s SECRET",

data/lib/chef/knife/spork-omni.rb

@@ -1,13 +1,13 @@
 require 'chef/knife'
+begin
+  require 'berkshelf'
+rescue LoadError; end
 
 module KnifeSpork
   class SporkOmni < Chef::Knife
 
     deps do
       require 'knife-spork/runner'
-      begin
-        require 'berkshelf'
-      rescue LoadError; end
     end
 
     banner 'knife spork omni COOKBOOK (options)'
@@ -58,6 +58,10 @@ module KnifeSpork
         exit(1)
       end
 
+      # Temporary fix for #138 to allow Berkshelf functionality
+      # to be bypassed until #85 has been completed and Berkshelf 3 support added
+      unload_berkshelf_if_specified
+
       cookbook = name_args.first
 
       run_plugins(:before_omni)

data/lib/chef/knife/spork-promote.rb

@@ -1,4 +1,7 @@
 require 'chef/knife'
+begin
+  require 'berkshelf'
+rescue LoadError; end
 
 module KnifeSpork
   class SporkPromote < Chef::Knife
@@ -6,9 +9,6 @@ module KnifeSpork
     deps do
       require 'chef/exceptions'
       require 'knife-spork/runner'
-      begin
-        require 'berkshelf'
-      rescue LoadError; end
     end
 
     banner 'knife spork promote ENVIRONMENT COOKBOOK (options)'
@@ -42,6 +42,10 @@ module KnifeSpork
         exit 1
       end
 
+      # Temporary fix for #138 to allow Berkshelf functionality
+      # to be bypassed until #85 has been completed and Berkshelf 3 support added
+      unload_berkshelf_if_specified
+
       #First load so plugins etc know what to work with
       @environments, @cookbook = load_environments_and_cookbook
 
@@ -80,7 +84,13 @@ module KnifeSpork
     def update_version_constraints(environment, cookbook, new_version)
       validate_version!(new_version)
       if spork_config.preserve_constraint_operators
-        constraint_operator = environment.cookbook_versions[cookbook].split.first
+
+        cb_version = environment.cookbook_versions[cookbook]
+        if cb_version.length > 0
+          constraint_operator = cb_version.split.first
+        else
+          constraint_operator = "="
+        end
         ui.msg "Preserving existing version constraint operator: #{constraint_operator}"
       else
         constraint_operator = "="
@@ -138,7 +148,13 @@ module KnifeSpork
     end
 
     def save_environment_changes(environment, json)
-      environments_path = spork_config[:environment_path] || cookbook_path.gsub('cookbooks', 'environments')
+      if spork_config[:environment_path]
+        environments_path = spork_config[:environment_path]
+      else
+        split_cb_path = cookbook_path.split("/")
+        environments_path = (split_cb_path[0..-2] << split_cb_path[-1].gsub("cookbooks","environments")).join("/")
+      end
+
       environment_path = File.expand_path( File.join(environments_path, "#{environment}.json") )
 
       File.open(environment_path, 'w'){ |f| f.puts(json) }

data/lib/chef/knife/spork-upload.rb

@@ -51,6 +51,10 @@ module KnifeSpork
         exit 1
       end
 
+      # Temporary fix for #138 to allow Berkshelf functionality
+      # to be bypassed until #85 has been completed and Berkshelf 3 support added
+      unload_berkshelf_if_specified
+
       #First load so plugins etc know what to work with
       @cookbooks = load_cookbooks(name_args)
       include_dependencies if config[:depends]

data/lib/knife-spork/plugins/hipchat.rb

@@ -102,7 +102,7 @@ module KnifeSpork
 
         rooms.each do |room_name|
           begin
-            client = ::HipChat::Client.new(config.api_token)
+            client = ::HipChat::Client.new(config.api_token, :api_version => config.api_version ||= 'v1', :server_url => config.server_url ||= 'https://api.hipchat.com')
             client[room_name].send(nickname, message, :notify => notify, :color =>color)
           rescue Exception => e
             ui.error 'Something went wrong sending to HipChat.'

data/lib/knife-spork/plugins/rubocop.rb

@@ -0,0 +1,52 @@
+require 'knife-spork/plugins/plugin'
+
+module KnifeSpork
+  module Plugins
+    class Rubocop < Plugin
+      name :rubocop
+      hooks :after_check, :before_upload
+
+      def perform
+        safe_require 'rubocop'
+        safe_require 'rubocop/cli'
+        safe_require 'rubocop/config_store'
+
+        if Gem::Specification.find_all_by_name("rubocop").empty?
+          ui.fatal "The knife-spork rubocop plugin requires rubocop."
+          exit 1
+        end
+
+        base_options = []
+	base_options = base_options.concat([ "-D" ]) if config.show_name  # Lists the name of the offense along with the description
+	base_options = base_options.concat([ "--auto-correct" ]) if config.autocorrect
+	base_options = base_options.concat([ "--out", config.out_file ]) if config.out_file # Specify a file output rather than STDOUT for the specific errors
+	base_options = base_options.concat([ "--fail-level", config.sev_level ]) if config.sev_level # Specify a severity level for when rubocop should fail
+	base_options = base_options.concat([ "--lint"]) if config.lint  # Only run lint checks
+
+        cookbooks.each do |cookbook|
+          ui.info "Running rubocop against #{cookbook.name}@#{cookbook.version}..."
+
+          cookbook_path = cookbook.root_dir
+
+          ui.info cookbook_path
+
+          options = [ cookbook_path ]
+
+          cli = ::Rubocop::CLI.new
+          result = cli.run(options)
+
+          unless result  == 0
+            ui.error "Rubocop failed!"
+            exit(1) if config.epic_fail
+          else
+            ui.info "Passed!"
+          end
+        end
+      end
+
+      def epic_fail?
+        config.epic_fail.nil? ? 'true' : config.epic_fail
+      end
+    end
+  end
+end

data/lib/knife-spork/plugins/slack.rb

@@ -0,0 +1,121 @@
+require 'knife-spork/plugins/plugin'
+
+module KnifeSpork
+  module Plugins
+    class Slack < Plugin
+      name :slack
+
+      def perform; end
+
+      def after_upload
+        slack "#{organization}#{current_user} uploaded the following cookbooks:\n#{cookbooks.collect{ |c| "  #{c.name}@#{c.version}" }.join("\n")}"
+      end
+
+      def after_promote_remote
+        slack "#{organization}#{current_user} promoted the following cookbooks:\n#{cookbooks.collect{ |c| "  #{c.name}@#{c.version}" }.join("\n")} to #{environments.collect{ |e| "#{e.name}" }.join(", ")}"
+      end
+
+      def after_environmentfromfile
+        slack "#{organization}#{current_user} uploaded environment #{object_name}"
+      end
+
+      def after_environmentedit
+        slack "#{organization}#{current_user} edited environment #{object_name}"
+      end
+
+      def after_environmentcreate
+        slack "#{organization}#{current_user} created environment #{object_name}"
+      end
+
+      def after_environmentdelete
+        slack "#{organization}#{current_user} deleted environment #{object_name}"
+      end
+
+      def after_rolefromfile
+        slack "#{organization}#{current_user} uploaded role #{object_name}"
+      end
+
+      def after_roleedit
+        slack "#{organization}#{current_user} edited role #{object_name}"
+      end
+
+      def after_rolecreate
+        slack "#{organization}#{current_user} created role #{object_name}"
+      end
+
+      def after_roledelete
+        slack "#{organization}#{current_user} deleted role #{object_name}"
+      end
+
+      def after_databagedit
+        slack "#{organization}#{current_user} edited data bag item #{object_name}:#{object_secondary_name}"
+      end
+
+      def after_databagcreate
+        slack "#{organization}#{current_user} created data bag #{object_name}"
+      end
+
+      def after_databagdelete
+        slack "#{organization}#{current_user} deleted data bag item #{object_name}"
+      end
+
+      def after_databagitemdelete
+        slack "#{organization}#{current_user} deleted data bag item #{object_name}:#{object_secondary_name}"
+      end
+
+      def after_databagfromfile
+        slack "#{organization}#{current_user} uploaded data bag item #{object_name}:#{object_secondary_name}"
+      end
+
+      def after_nodeedit
+        slack "#{organization}#{current_user} edited node #{object_name}"
+      end
+
+      def after_nodedelete
+        slack "#{organization}#{current_user} deleted node #{object_name}"
+      end
+
+      def after_nodecreate
+        slack "#{organization}#{current_user} created node #{object_name}"
+      end
+
+      def after_nodefromfile
+        slack "#{organization}#{current_user} uploaded node #{object_name}"
+      end
+
+      def after_noderunlistadd
+        slack "#{organization}#{current_user} added run_list items to #{object_name}: #{object_secondary_name}"
+      end
+
+      def after_noderunlistremove
+        slack "#{organization}#{current_user} removed run_list items from #{object_name}: #{object_secondary_name}"
+      end
+
+      def after_noderunlistset
+        slack "#{organization}#{current_user} set the run_list for #{object_name} to #{object_secondary_name}"
+      end
+
+
+      private
+      def slack(message)
+        safe_require 'slack-notifier'
+        begin
+          notifier = ::Slack::Notifier.new( config.teamname, config.api_token, channel: channel, username: username)
+          notifier.ping message 
+        rescue Exception => e
+          ui.error 'Something went wrong sending to Slack.'
+          ui.error e.to_s
+        end
+      end
+
+      def channel
+        config.channel || '#random'
+      end
+
+      def username
+        config.username || 'KnifeSpork'
+      end
+
+    end
+  end
+end

data/lib/knife-spork/runner.rb

@@ -135,7 +135,19 @@ module KnifeSpork
       end
 
       def environment_path
-        spork_config[:environment_path] || Chef::Config.environment_path.first || cookbook_path.gsub("/cookbooks","/environments")
+        if spork_config[:environment_path]
+          if spork_config[:environment_path].kind_of?(Array)
+            spork_config[:environment_path].first
+          else
+            spork_config[:environment_path]
+          end
+        elsif Chef::Config.environment_path && Chef::Config.environment_path.kind_of?(Array)
+          Chef::Config.environment_path.first
+        elsif Chef::Config.environment_path && Chef::Config.environment_path.kind_of?(String)
+          Chef::Config.environment_path
+        else
+          cookbook_path.gsub("/cookbooks","/environments")
+        end
       end
 
       def role_path
@@ -271,12 +283,21 @@ module KnifeSpork
       end
 
       def ensure_cookbook_path!
-        if !config.has_key?(:cookbook_path)
+        if config[:cookbook_path].nil?
           ui.fatal "No default cookbook_path; Specify with -o or fix your knife.rb."
           show_usage
           exit(1)
         end
       end
+
+      def unload_berkshelf_if_specified
+        # Temporary fix for #138 to allow Berkshelf functionality
+        # to be bypassed until #85 has been completed and Berkshelf 3 support added
+        if spork_config.skip_berkshelf
+          ui.warn "Unloading Berkshelf as skip_berkshelf option found in config"
+          Object.send(:remove_const, :Berkshelf)
+        end
+      end
     end
 
     def self.included(receiver)

data/plugins/HipChat.md

@@ -20,7 +20,9 @@ Configuration
 ```yaml
 plugins:
   hipchat:
+    server_url: https://api.hipchat.com
     api_token: ABC123
+    api_version: v1
     rooms:
       - General
       - Web Operations
@@ -28,11 +30,21 @@ plugins:
     color: yellow
 ```
 
+#### server_url
+The URL of the HipChat API server. Default: 'https://api.hipchat.com'
+
+- Type: `String`
+
 #### api_token
 Your HipChat API token.
 
 - Type: `String`
 
+#### api_version
+Which version of the HipChat API to use. Default: 'v1'
+
+- Type: `String`
+
 #### rooms
 The list of rooms to post to.
 
@@ -44,7 +56,7 @@ Boolean value indicating whether the room should be notified.
 - Type: `Boolean`
 
 #### color
-THe color of the message.
+The color of the message.
 
 - Type: `String`
 - Acceptable Values: `[yellow, red, green, purple, random]`

data/plugins/Rubocop.md

@@ -0,0 +1,102 @@
+Rubocop
+==========
+Automatically runs rubocop against your cookbooks on check and upload.
+This is entirely based off of the Foodcritic plugin.
+
+Gem Requirements
+----------------
+This plugin requires the following gems:
+
+```ruby
+gem 'rubocop'
+```
+
+Hooks
+-----
+- `after_check`
+- `before_upload`
+
+Configuration
+-------------
+```yaml
+plugins:
+  rubocop:
+    epic_fail: true
+    show_name: false
+    autocorrect: false
+    out_file: <file>
+    sev_level: <C|W|E>
+    lint: false
+```
+
+#### epic_fail:
+If set to true, `epic_fail` will prevent you from uploading a cookbook or further checks from running until rubocop passes.
+- Type: `Boolean`
+- Default: `true`
+
+#### The following options are passing command line options to rubocop.  See rubocop --help for more details
+#### show_name:
+- Type: `Boolean`
+- Default: `false`
+- Rubocop command line equivilant: "-D"
+Shows the name of the offending rule as well as the decription and line reference.
+
+#### autocorrect:
+- Type: `Boolean`
+- Default: `false`
+- Rubocop command line equivilant: "--auto-correct"
+Automatically correct some offenses.
+
+#### out_file:
+- Type: `String` - file name
+- Default: nil
+- Rubocop command line equivilant: "--out <file>"
+Redirects the rubocop output to a file instead of STDOUT.
+
+#### sev_level:
+- Type: `String`
+- Default: nil
+- Rubocop command line equivilant: "--fail-level [C|W|E]"
+Set the severity level at which Rubocop will fail (see rubocop --help for more).
+
+#### lint:
+- Type: `Boolean`
+- Default: `false`
+- Rubocop command line equivilant: "--lint"
+Only run linting rules.
+
+#### Example
+``` ruby
+chef_workstation01$ knife spork check chef-client
+Checking versions for cookbook chef-client...
+
+Local Version:
+  3.3.3
+
+Remote Versions: (* indicates frozen)
+  3.3.3
+  3.2.0
+
+ERROR: The version 3.3.3 exists on the server and is not frozen. Uploading will overwrite!
+Running rubocop against chef-client@3.3.3...
+/home/chef-repo/cookbooks/chef-client
+Inspecting 25 files
+....CCCCC.CWCCCCCWCCCWCCC
+
+Offenses:
+
+chef-client/files/default/tests/minitest/config_test.rb:22:53: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+    file(File.join(node['chef_client']['conf_dir'], "client.rb")).must_exist
+                                                    ^^^^^^^^^^^
+chef-client/libraries/helpers.rb:35:72: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+          Chef::Log.debug("Node has Chef Server Recipe? #{node.recipe?("chef-server")}")
+                                                                       ^^^^^^^^^^^^^
+chef-client/libraries/helpers.rb:36:70: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+          Chef::Log.debug("Node has Chef Server Executable? #{system("which chef-server > /dev/null 2>&1")}")
+                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+chef-client/libraries/helpers.rb:37:74: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+          Chef::Log.debug("Node has Chef Server Ctl Executable? #{system("which chef-server-ctl > /dev/null 2>&1")}")
+                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+...
+
+```

data/plugins/Slack.md

@@ -0,0 +1,47 @@
+Slack
+=======
+Slack posts messages to your Slack client.
+
+Gem Requirements
+----------------
+This plugin requires the following gems:
+
+```ruby
+gem 'slack-notifier'
+```
+
+Hooks
+-----
+- `after_upload`
+- `after_promote`
+
+Configuration
+-------------
+```yaml
+plugins:
+  slack:
+    api_token: ABC123
+    channel: "#operations"
+    teamname: myteam
+    username: knife
+```
+
+#### api_token
+Your Slack API token.
+
+- Type: `String`
+
+#### channel
+The channel to post to.
+
+- Type: `String`
+
+#### teamname
+The teamname of the slack account. ex. https://TEAMNAME.slack.com
+
+- Type: `String`
+
+#### username
+The username to post as.
+
+- Type: `String`

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: knife-spork
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.4.0
 platform: ruby
 authors:
 - Jon Cowie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-02 00:00:00.000000000 Z
+date: 2014-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 11.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 11.0.0
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.2.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.2.5
 - !ruby/object:Gem::Dependency
   name: app_conf
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: diffy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.1
 description: KnifeSpork is a workflow plugin for Chef::Knife which helps multiple
@@ -122,6 +122,8 @@ files:
 - lib/knife-spork/plugins/irccat.rb
 - lib/knife-spork/plugins/jabber.rb
 - lib/knife-spork/plugins/plugin.rb
+- lib/knife-spork/plugins/rubocop.rb
+- lib/knife-spork/plugins/slack.rb
 - lib/knife-spork/plugins/statusnet.rb
 - lib/knife-spork/runner.rb
 - plugins/Campfire.md
@@ -134,6 +136,8 @@ files:
 - plugins/Irccat.md
 - plugins/Jabber.md
 - plugins/README.md
+- plugins/Rubocop.md
+- plugins/Slack.md
 - plugins/StatusNet.md
 - plugins/Template.md
 homepage: https://github.com/jonlives/knife-spork
@@ -146,17 +150,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: A workflow plugin to help many devs work with the same chef repo/server