knife-openstack 1.3.2.pre → 1.3.2.pre.1

data/spec/unit/openstack_server_delete_spec.rb

@@ -26,16 +26,16 @@ require 'support/shared_examples_for_serverdeletecommand'
 describe Chef::Knife::Cloud::OpenstackServerDelete do
   it_behaves_like Chef::Knife::Cloud::ServerDeleteCommand, Chef::Knife::Cloud::OpenstackServerDelete.new
 
-  include_context "#validate!", Chef::Knife::Cloud::OpenstackServerDelete.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackServerDelete.new
 
-  let (:instance) {Chef::Knife::Cloud::OpenstackServerDelete.new}
+  let (:instance) { Chef::Knife::Cloud::OpenstackServerDelete.new }
 
   before(:each) do
     allow(instance).to receive(:exit)
   end
 
-  describe "#create_service_instance" do
-    it "return OpenstackService instance" do
+  describe '#create_service_instance' do
+    it 'return OpenstackService instance' do
       expect(instance.create_service_instance).to be_an_instance_of(Chef::Knife::Cloud::OpenstackService)
     end
   end

data/spec/unit/openstack_server_list_spec.rb

@@ -25,7 +25,7 @@ require 'support/shared_examples_for_command'
 describe Chef::Knife::Cloud::OpenstackServerList do
   it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackServerList.new
 
-  include_context "#validate!", Chef::Knife::Cloud::OpenstackServerList.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackServerList.new
 
-  let (:instance) {Chef::Knife::Cloud::OpenstackServerList.new}
+  let (:instance) { Chef::Knife::Cloud::OpenstackServerList.new }
 end

data/spec/unit/openstack_server_show_spec.rb

@@ -23,18 +23,18 @@ require 'support/shared_examples_for_command'
 describe Chef::Knife::Cloud::OpenstackServerShow do
   it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackServerShow.new
 
-  include_context "#validate!", Chef::Knife::Cloud::OpenstackServerShow.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackServerShow.new
 
-  let (:instance) {Chef::Knife::Cloud::OpenstackServerShow.new}
+  let (:instance) { Chef::Knife::Cloud::OpenstackServerShow.new }
 
-  context "#validate_params!" do
+  context '#validate_params!' do
     before(:each) do
-      Chef::Config[:knife][:instance_id] = "instance_id"
+      Chef::Config[:knife][:instance_id] = 'instance_id'
     end
 
-    it "raise error on instance_id missing" do
+    it 'raise error on instance_id missing' do
       Chef::Config[:knife].delete(:instance_id)
-      expect(instance.ui).to receive(:error).with("You must provide a valid Instance Id")
+      expect(instance.ui).to receive(:error).with('You must provide a valid Instance Id')
       expect { instance.validate_params! }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError)
     end
   end

data/spec/unit/openstack_service_spec.rb

@@ -21,9 +21,9 @@ require 'spec_helper'
 require 'chef/knife/cloud/openstack_service'
 
 describe Chef::Knife::Cloud::OpenstackService do
-  describe "#add_api_endpoint" do
+  describe '#add_api_endpoint' do
     before(:each) do
-      @api_endpoint = "https://test_openstack_api_endpoint"
+      @api_endpoint = 'https://test_openstack_api_endpoint'
       Chef::Config[:knife][:api_endpoint] = @api_endpoint
       @instance = Chef::Knife::Cloud::OpenstackService.new
     end
@@ -32,56 +32,56 @@ describe Chef::Knife::Cloud::OpenstackService do
       Chef::Config[:knife].delete(:api_endpoint)
     end
 
-    it "sets the api_endpoint in auth params" do
-      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == nil
+    it 'sets the api_endpoint in auth params' do
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be.nil?
       @instance.add_api_endpoint
       expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == @api_endpoint
     end
 
-    it "does not set the endpoint when --api-endpoint option is missing" do
+    it 'does not set the endpoint when --api-endpoint option is missing' do
       Chef::Config[:knife][:api_endpoint] = nil
-      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == nil
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be.nil?
       @instance.add_api_endpoint
       expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to_not be == @api_endpoint
-      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == nil
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be.nil?
     end
 
     it "doesn't set an OpenStack endpoint type by default" do
-      expect(Chef::Config[:knife][:openstack_endpoint_type]).to be == nil
+      expect(Chef::Config[:knife][:openstack_endpoint_type]).to be.nil?
     end
   end
 
-  describe "#get_server" do
+  describe '#get_server' do
     before(:each) do
       @instance = Chef::Knife::Cloud::OpenstackService.new
-      allow(@instance).to receive_message_chain(:connection,:servers,:get)
+      allow(@instance).to receive_message_chain(:connection, :servers, :get)
     end
 
-    context "when instance_id given" do 
-      it "return server" do
-        server_id = "123f456-123-453e-9c0c-12345a6789"
+    context 'when instance_id given' do
+      it 'return server' do
+        server_id = '123f456-123-453e-9c0c-12345a6789'
         expect(@instance.connection.servers).to receive(:get).and_return(server_id)
         expect(@instance.connection.servers).to_not receive(:all)
         expect(@instance.get_server(server_id)).to be == server_id
       end
     end
 
-    context "when instance_name given" do
+    context 'when instance_name given' do
       before(:each) do
         expect(@instance.connection.servers).to receive(:get).and_return(nil)
       end
 
-      let (:server_name) { "testname" }
+      let (:server_name) { 'testname' }
 
-      it "return server" do
-        expect(@instance.connection.servers).to receive(:all).with({:name=>server_name}).and_return([server_name])
+      it 'return server' do
+        expect(@instance.connection.servers).to receive(:all).with(name: server_name).and_return([server_name])
         expect(@instance.get_server(server_name)).to be == server_name
       end
 
-      it "raise error if multiple server matches found for given instance name" do
+      it 'raise error if multiple server matches found for given instance name' do
         error_message = "Multiple server matches found for '#{server_name}', use an instance_id to be more specific."
-        expect(@instance.connection.servers).to receive(:all).with({:name=>server_name}).and_return([server_name,server_name])
-        allow(@instance).to receive_message_chain(:ui,:fatal)
+        expect(@instance.connection.servers).to receive(:all).with(name: server_name).and_return([server_name, server_name])
+        allow(@instance).to receive_message_chain(:ui, :fatal)
         expect { @instance.get_server(server_name) }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError, error_message)
       end
     end

data/spec/unit/openstack_volume_list_spec.rb

@@ -25,5 +25,5 @@ require 'support/shared_examples_for_command'
 describe Chef::Knife::Cloud::OpenstackVolumeList do
   it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackVolumeList.new
 
-  include_context "#validate!", Chef::Knife::Cloud::OpenstackVolumeList.new
+  include_context '#validate!', Chef::Knife::Cloud::OpenstackVolumeList.new
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knife-openstack
 version: !ruby/object:Gem::Version
-  version: 1.3.2.pre
+  version: 1.3.2.pre.1
 platform: ruby
 authors:
 - JJ Asghar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-04 00:00:00.000000000 Z
+date: 2015-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog
@@ -52,6 +52,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement