knife-openstack 0.10.0 → 1.0.0.rc1

data/spec/unit/openstack_server_delete_spec.rb

@@ -0,0 +1,43 @@
+#
+# Author:: Prabhu Das (<prabhu.das@clogeny.com>)
+# Author:: Mukta Aphale (<mukta.aphale@clogeny.com>)
+# Author:: Siddheshwar More (<siddheshwar.more@clogeny.com>)
+# Author:: Ameya Varade (<ameya.varade@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/openstack_server_delete'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_serverdeletecommand'
+require 'unit/validate_spec'
+
+describe Chef::Knife::Cloud::OpenstackServerDelete do
+  it_behaves_like Chef::Knife::Cloud::ServerDeleteCommand, Chef::Knife::Cloud::OpenstackServerDelete.new
+
+  include_context "#validate!", Chef::Knife::Cloud::OpenstackServerDelete.new
+
+  let (:instance) {Chef::Knife::Cloud::OpenstackServerDelete.new}
+
+  before(:each) do
+    allow(instance).to receive(:exit)
+  end
+
+  describe "#create_service_instance" do
+    it "return OpenstackService instance" do
+      expect(instance.create_service_instance).to be_an_instance_of(Chef::Knife::Cloud::OpenstackService)
+    end
+  end
+end

data/spec/unit/openstack_server_list_spec.rb

@@ -0,0 +1,32 @@
+#
+# Author:: Mukta Aphale (<mukta.aphale@clogeny.com>)
+# Author:: Siddheshwar More (<siddheshwar.more@clogeny.com>)
+# Author:: Ameya Varade (<ameya.varade@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/openstack_server_list'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+require 'unit/validate_spec'
+
+describe Chef::Knife::Cloud::OpenstackServerList do
+  it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackServerList.new
+
+  include_context "#validate!", Chef::Knife::Cloud::OpenstackServerList.new
+
+  let (:instance) {Chef::Knife::Cloud::OpenstackServerList.new}
+end

data/spec/unit/openstack_server_show_spec.rb

@@ -0,0 +1,42 @@
+#
+# Author:: Ameya Varade (<ameya.varade@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/openstack_server_show'
+require 'chef/knife/cloud/openstack_service'
+require 'support/shared_examples_for_command'
+require 'unit/validate_spec'
+
+describe Chef::Knife::Cloud::OpenstackServerShow do
+  it_behaves_like Chef::Knife::Cloud::Command, Chef::Knife::Cloud::OpenstackServerShow.new
+
+  include_context "#validate!", Chef::Knife::Cloud::OpenstackServerShow.new
+  
+  let (:instance) {Chef::Knife::Cloud::OpenstackServerShow.new}
+
+  context "#validate_params!" do
+    before(:each) do
+      Chef::Config[:knife][:instance_id] = "instance_id"
+    end
+
+    it "raise error on instance_id missing" do
+      Chef::Config[:knife].delete(:instance_id)
+      expect(instance.ui).to receive(:error).with("You must provide a valid Instance Id")
+      expect { instance.validate_params! }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError)
+    end
+  end
+end

data/spec/unit/openstack_service_spec.rb

@@ -0,0 +1,89 @@
+#
+# Author:: Mukta Aphale (<mukta.aphale@clogeny.com>)
+# Author:: Siddheshwar More (<siddheshwar.more@clogeny.com>)
+# Author:: Ameya Varade (<ameya.varade@clogeny.com>)
+# Copyright:: Copyright (c) 2013-2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'chef/knife/cloud/openstack_service'
+
+describe Chef::Knife::Cloud::OpenstackService do
+  describe "#add_api_endpoint" do
+    before(:each) do
+      @api_endpoint = "https://test_openstack_api_endpoint"
+      Chef::Config[:knife][:api_endpoint] = @api_endpoint
+      @instance = Chef::Knife::Cloud::OpenstackService.new
+    end
+
+    after(:each) do
+      Chef::Config[:knife].delete(:api_endpoint)
+    end
+
+    it "sets the api_endpoint in auth params" do
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == nil
+      @instance.add_api_endpoint
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == @api_endpoint
+    end
+
+    it "does not set the endpoint when --api-endpoint option is missing" do
+      Chef::Config[:knife][:api_endpoint] = nil
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == nil
+      @instance.add_api_endpoint
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to_not be == @api_endpoint
+      expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be == nil
+    end
+
+    it "doesn't set an OpenStack endpoint type by default" do
+      expect(Chef::Config[:knife][:openstack_endpoint_type]).to be == nil
+    end
+  end
+
+  describe "#get_server" do
+    before(:each) do
+      @instance = Chef::Knife::Cloud::OpenstackService.new
+      allow(@instance).to receive_message_chain(:connection,:servers,:get)
+    end
+
+    context "when instance_id given" do 
+      it "return server" do
+        server_id = "123f456-123-453e-9c0c-12345a6789"
+        expect(@instance.connection.servers).to receive(:get).and_return(server_id)
+        expect(@instance.connection.servers).to_not receive(:all)
+        expect(@instance.get_server(server_id)).to be == server_id
+      end
+    end
+
+    context "when instance_name given" do
+      before(:each) do
+        expect(@instance.connection.servers).to receive(:get).and_return(nil)
+      end
+
+      let (:server_name) { "testname" }
+
+      it "return server" do
+        expect(@instance.connection.servers).to receive(:all).with({:name=>server_name}).and_return([server_name])
+        expect(@instance.get_server(server_name)).to be == server_name
+      end
+
+      it "raise error if multiple server matches found for given instance name" do
+        error_message = "Multiple server matches found for '#{server_name}', use an instance_id to be more specific."
+        expect(@instance.connection.servers).to receive(:all).with({:name=>server_name}).and_return([server_name,server_name])
+        allow(@instance).to receive_message_chain(:ui,:fatal)
+        expect { @instance.get_server(server_name) }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError, error_message)
+      end
+    end
+  end
+end

data/spec/unit/validate_spec.rb

@@ -0,0 +1,55 @@
+#
+# Author:: Prabhu Das (<prabhu.das@clogeny.com>)
+# Copyright:: Copyright (c) 2014 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+
+shared_context  "#validate!" do |instance|
+  before(:each) do
+    Chef::Config[:knife][:openstack_username] = "testuser"
+    Chef::Config[:knife][:openstack_password] = "testpassword"
+    Chef::Config[:knife][:openstack_auth_url] = "tsturl"
+    allow(instance).to receive(:exit)
+  end
+
+  after(:all) do
+    Chef::Config[:knife].delete(:openstack_username)
+    Chef::Config[:knife].delete(:openstack_password)
+    Chef::Config[:knife].delete(:openstack_auth_url)
+  end
+
+  it "validate openstack mandatory options" do
+    expect {instance.validate!}.to_not raise_error
+  end
+
+  it "raise error on openstack_username missing" do
+    Chef::Config[:knife].delete(:openstack_username)
+    expect(instance.ui).to receive(:error).with("You did not provide a valid 'Openstack Username' value.")
+    expect { instance.validate! }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError)
+  end
+
+  it "raise error on openstack_password missing" do
+    Chef::Config[:knife].delete(:openstack_password)
+    expect(instance.ui).to receive(:error).with("You did not provide a valid 'Openstack Password' value.")
+    expect { instance.validate! }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError)
+  end
+
+  it "raise error on openstack_auth_url missing" do
+    Chef::Config[:knife].delete(:openstack_auth_url)
+    expect(instance.ui).to receive(:error).with("You did not provide a valid 'Openstack Auth Url' value.")
+    expect { instance.validate! }.to raise_error(Chef::Knife::Cloud::CloudExceptions::ValidationError)
+  end
+end

metadata

@@ -1,181 +1,225 @@
 --- !ruby/object:Gem::Specification
 name: knife-openstack
 version: !ruby/object:Gem::Version
-  version: 0.10.0
-  prerelease: 
+  version: 1.0.0.rc1
 platform: ruby
 authors:
-- Seth Chisamore
-- Matt Ray
+- Clogeny
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-09 00:00:00.000000000 Z
+date: 2014-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: '1.23'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: '1.23'
 - !ruby/object:Gem::Dependency
   name: chef
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.10
+        version: '11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.10
+        version: '11'
 - !ruby/object:Gem::Dependency
-  name: knife-windows
+  name: knife-cloud
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-core
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: OpenStack Compute Support for Chef's Knife Command
+description: OpenStack Compute Support for Chef's Knife Command using knife-cloud
+  gem
 email:
-- schisamo@getchef.com
-- matt@getchef.com
+- contact@clogeny.com
 executables: []
 extensions: []
 extra_rdoc_files:
 - README.md
 - LICENSE
 files:
-- .gitignore
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - knife-openstack.gemspec
-- lib/chef/knife/openstack_base.rb
+- lib/chef/knife/cloud/openstack_server_create_options.rb
+- lib/chef/knife/cloud/openstack_service.rb
+- lib/chef/knife/cloud/openstack_service_options.rb
 - lib/chef/knife/openstack_flavor_list.rb
 - lib/chef/knife/openstack_group_list.rb
+- lib/chef/knife/openstack_helpers.rb
 - lib/chef/knife/openstack_image_list.rb
 - lib/chef/knife/openstack_network_list.rb
 - lib/chef/knife/openstack_server_create.rb
 - lib/chef/knife/openstack_server_delete.rb
 - lib/chef/knife/openstack_server_list.rb
+- lib/chef/knife/openstack_server_show.rb
 - lib/knife-openstack/version.rb
+- spec/functional/flavor_list_func_spec.rb
+- spec/functional/group_list_func_spec.rb
+- spec/functional/image_list_func_spec.rb
+- spec/functional/network_list_func_spec.rb
+- spec/functional/server_create_func_spec.rb
+- spec/functional/server_delete_func_spec.rb
+- spec/functional/server_list_func_spec.rb
+- spec/functional/server_show_func_spec.rb
+- spec/integration/cleanup.rb
+- spec/integration/config/environment.yml.sample
+- spec/integration/config/incorrect_openstack.pem
+- spec/integration/openstack_spec.rb
 - spec/spec_helper.rb
+- spec/unit/openstack_flavor_list_spec.rb
+- spec/unit/openstack_group_list_spec.rb
+- spec/unit/openstack_image_list_spec.rb
+- spec/unit/openstack_network_list_spec.rb
 - spec/unit/openstack_server_create_spec.rb
+- spec/unit/openstack_server_delete_spec.rb
+- spec/unit/openstack_server_list_spec.rb
+- spec/unit/openstack_server_show_spec.rb
+- spec/unit/openstack_service_spec.rb
+- spec/unit/validate_spec.rb
 homepage: https://github.com/opscode/knife-openstack
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23.2
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: OpenStack Compute Support for Chef's Knife Command
 test_files:
+- spec/functional/flavor_list_func_spec.rb
+- spec/functional/group_list_func_spec.rb
+- spec/functional/image_list_func_spec.rb
+- spec/functional/network_list_func_spec.rb
+- spec/functional/server_create_func_spec.rb
+- spec/functional/server_delete_func_spec.rb
+- spec/functional/server_list_func_spec.rb
+- spec/functional/server_show_func_spec.rb
+- spec/integration/cleanup.rb
+- spec/integration/config/environment.yml.sample
+- spec/integration/config/incorrect_openstack.pem
+- spec/integration/openstack_spec.rb
 - spec/spec_helper.rb
+- spec/unit/openstack_flavor_list_spec.rb
+- spec/unit/openstack_group_list_spec.rb
+- spec/unit/openstack_image_list_spec.rb
+- spec/unit/openstack_network_list_spec.rb
 - spec/unit/openstack_server_create_spec.rb
+- spec/unit/openstack_server_delete_spec.rb
+- spec/unit/openstack_server_list_spec.rb
+- spec/unit/openstack_server_show_spec.rb
+- spec/unit/openstack_service_spec.rb
+- spec/unit/validate_spec.rb