knife-okta 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb9cdd9e808fa7dcb17c281979b026ee1fdc832e8dc5319aa56fc218ce7da02d
-  data.tar.gz: 253fe557465c1192638852f027b3e8224a10aa87e30cf8c0aa5501cf5a7972a5
+  metadata.gz: eb8ee4afdd314e77c758ca261ca131a6e89d928dbf3600f182d9a5378fd30084
+  data.tar.gz: f6deea10b5358356ea5e5d5f31cd85b1f7409c99a3a28df735dd6d3972adbe88
 SHA512:
-  metadata.gz: d8f6253e3095c2c7c8939bdfddb3166edf0e4dcfaa6d2b4d53bb33e31aedd16ac6b6a59bb8ad5bf694bb7164b86551332a7d000291294f1d35353bdb4ee5f311
-  data.tar.gz: 97dc236a24c5370679010db019d6d2b7319eb8f4d2490bafdd77028066bf8d8879b911dcff7d194a169b239f66642ca461a773c5fe32d1e4bfdf726463445a3f
+  metadata.gz: 1ae326dd1a0a77dba315d893c44e3657976faa23febe3ed2e9d33ea12e3173e60796a142122369f8ffb6a3f03aa44f63f0f70d9bc3098062116b99f8b550f503
+  data.tar.gz: 4a3671a147aa3bc960f8b4557656c0a204e51a7fb4c181241804e732cbb2919ecc36181b016f49725f714732c7e7f1479faa5f7667084dfd39db8ebe3bd8ab96

data/CHANGELOG.md

@@ -4,7 +4,16 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## 0.1.1 (2018-03-06)
+## 0.1.2 (2018-03-07)
+
+### Fixed
+
+* Fix returned group hash - previously the first group that matched the name was returned, now we only return groups with `:type => okta_group`
+* Fix how changes are displayed:
+  * New and old data bags will be correctly compared
+  * Now caching the data bag response to speed things up a bit
+
+## 0.1.1 (2018-02-06)
 
 ### Fixed
 

data/lib/chef/knife/data_bag_from_okta_group.rb

@@ -171,7 +171,8 @@ class Chef
       end
 
       def data_bag_item_data
-        rest.get("data/#{@data_bag_name}/#{@data_bag_item_name}")
+        return @data_bag_item_data if @data_bag_item_data
+        @data_bag_item_data = rest.get("data/#{@data_bag_name}/#{@data_bag_item_name}")
       rescue Net::HTTPServerException
         nil
       end
@@ -205,12 +206,12 @@ class Chef
 
       def data_bag_item_additions
         return attribute_key_values if data_bag_item_data.nil?
-        attribute_key_values - data_bag_item_data[config[:okta_attribute].to_sym]
+        attribute_key_values - data_bag_item_data[config[:okta_attribute]]
       end
 
       def data_bag_item_removals
         return [] if data_bag_item_data.nil?
-        data_bag_item_data[config[:okta_attribute].to_sym] - attribute_key_values
+        data_bag_item_data[config[:okta_attribute]] - attribute_key_values
       end
 
       def display_data_bag_item_additions
@@ -230,7 +231,7 @@ class Chef
 
         if data_bag_item_data.nil?
           display_data_bag_item_additions
-        elsif data_bag_item_data.keys.reject { |e| e == :id }.shift.to_s == config[:okta_attribute]
+        elsif data_bag_item_data.keys.reject { |e| e == "id" }.shift.to_s == config[:okta_attribute]
           display_data_bag_item_removals
           display_data_bag_item_additions
         else
@@ -266,7 +267,7 @@ class Chef
       end
 
       def group_hash(group_name)
-        group_hash = groups.select { |group| group[:profile][:name] =~ /^#{group_name}$/i }.shift
+        group_hash = groups.select { |group| group[:type] == "OKTA_GROUP" && group[:profile][:name] =~ /^#{group_name}$/i }.shift
         if group_hash.nil?
           ui.fatal("Cannot find a group with the name \"#{group_name}\" in the specified Okta tenant")
           exit(1)

data/lib/knife-okta.rb

@@ -16,5 +16,5 @@
 #
 
 module KnifeOkta
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knife-okta
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Stephen Hoekstra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-06 00:00:00.000000000 Z
+date: 2018-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef