knife-ionoscloud 6.1.0 → 6.2.0

data/spec/chef/knife/ionoscloud_dbaas_postgres_logs_get_spec.rb

@@ -12,20 +12,24 @@ describe Chef::Knife::IonoscloudDbaasPostgresLogsGet do
   end
 
   describe '#run' do
-    it 'should call LogsApi.cluster_logs_get' do
+    it 'should call LogsApi.cluster_logs_get and use start and end even if since and until are also provided' do
       cluster_logs = cluster_logs_mock
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
         cluster_id: 'cluster_id',
         limit: 3,
+        start: '2022-03-22T01:01:01Z',
+        end: '2022-03-22T09:01:01Z',
+        since: '2h',
+        until: '20m',
+        direction: 'FORWARD',
         yes: true,
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
 
-      cluster_logs.instances.each do
-        |instance|
+      cluster_logs.instances.each do |instance|
         expect(subject).to receive(:puts).with("Instance Name: #{instance.name}")
         expect(subject).to receive(:puts).with(instance.messages.map { |message| message.message })
       end
@@ -37,6 +41,12 @@ describe Chef::Knife::IonoscloudDbaasPostgresLogsGet do
             method: 'GET',
             path: "/clusters/#{subject_config[:cluster_id]}/logs",
             operation: :'LogsApi.cluster_logs_get',
+            options: {
+              limit: subject_config[:limit],
+              direction: subject_config[:direction],
+              start: subject_config[:start],
+              _end: subject_config[:end],
+            },
             return_type: 'ClusterLogs',
             result: cluster_logs,
           },
@@ -46,21 +56,85 @@ describe Chef::Knife::IonoscloudDbaasPostgresLogsGet do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
+    it 'should call LogsApi.cluster_logs_get using since and until' do
+      cluster_logs = cluster_logs_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        limit: 3,
+        since: '2h',
+        until: '20m',
+        direction: 'FORWARD',
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      cluster_logs.instances.each do |instance|
+        expect(subject).to receive(:puts).with("Instance Name: #{instance.name}")
+        expect(subject).to receive(:puts).with(instance.messages.map { |message| message.message })
+      end
+
+      mock_dbaas_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/clusters/#{subject_config[:cluster_id]}/logs",
+            operation: :'LogsApi.cluster_logs_get',
+            options: {
+              limit: subject_config[:limit],
+              direction: subject_config[:direction],
+              start: (Time.now - 2 * 60 * 60).iso8601,
+              _end: (Time.now - 20 * 60).iso8601,
+            },
+            return_type: 'ClusterLogs',
+            result: cluster_logs,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should call not LogsApi.cluster_logs_get when using something different from minutes and hours for delta' do
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        since: '2d',
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject.ui).to receive(:error).with('Time delta may only be specified in hours(h) or minutes(m)!')
+
+      expect(subject.api_client_dbaas).not_to receive(:call_api)
+
+      expect { subject.run }.to raise_error(SystemExit) do |error|
+        expect(error.status).to eq(1)
+      end
+    end
+
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client_dbaas).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_dbaas_postgres_version_list_spec.rb

@@ -9,7 +9,7 @@ describe Chef::Knife::IonoscloudDbaasPostgresVersionList do
 
     @postgres_versions = postgres_version_list_mock
 
-    @postgres_version_list = postgres_version_list = [
+    @postgres_version_list = [
       subject.ui.color('Version', :bold),
       @postgres_versions.data.first.name,
       @postgres_versions.data[1].name,
@@ -50,7 +50,7 @@ describe Chef::Knife::IonoscloudDbaasPostgresVersionList do
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
-        cluster_id: 'cluster_id'
+        cluster_id: 'cluster_id',
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
@@ -76,18 +76,20 @@ describe Chef::Knife::IonoscloudDbaasPostgresVersionList do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client_dbaas).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_firewall_create_spec.rb

@@ -74,18 +74,20 @@ describe Chef::Knife::IonoscloudFirewallCreate do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_firewall_delete_spec.rb

@@ -100,18 +100,20 @@ describe Chef::Knife::IonoscloudFirewallDelete do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_firewall_get_spec.rb

@@ -59,18 +59,20 @@ describe Chef::Knife::IonoscloudFirewallGet do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_firewall_list_spec.rb

@@ -74,18 +74,20 @@ describe Chef::Knife::IonoscloudFirewallList do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_firewall_update_spec.rb

@@ -24,8 +24,8 @@ describe Chef::Knife::IonoscloudFirewallUpdate do
         name: firewall.properties.name + '_edited',
         protocol: 'TCP',
         source_mac: '01:11:11:11:22:00',
-        source_ip: '1.2.3.4',
-        target_ip: '2.2.3.1',
+        source_ip: '127.0.0.3',
+        target_ip: '127.0.0.4',
         port_range_start: 100,
         port_range_end: 145,
         icmp_type: 15,
@@ -99,18 +99,20 @@ describe Chef::Knife::IonoscloudFirewallUpdate do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_flowlog_create_spec.rb

@@ -236,18 +236,20 @@ describe Chef::Knife::IonoscloudFlowlogCreate do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_flowlog_delete_spec.rb

@@ -342,18 +342,20 @@ describe Chef::Knife::IonoscloudFlowlogDelete do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_flowlog_get_spec.rb

@@ -126,7 +126,6 @@ describe Chef::Knife::IonoscloudFlowlogGet do
     end
 
     it 'should not call anything when the wrong type is given' do
-      flowlog = flowlog_mock
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
@@ -153,18 +152,20 @@ describe Chef::Knife::IonoscloudFlowlogGet do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_flowlog_list_spec.rb

@@ -246,18 +246,20 @@ describe Chef::Knife::IonoscloudFlowlogList do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_flowlog_update_spec.rb

@@ -199,7 +199,6 @@ describe Chef::Knife::IonoscloudFlowlogUpdate do
     end
 
     it 'should not call anything when the wrong type is given' do
-      flowlog = flowlog_mock
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
@@ -226,18 +225,20 @@ describe Chef::Knife::IonoscloudFlowlogUpdate do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_group_create_spec.rb

@@ -73,18 +73,20 @@ describe Chef::Knife::IonoscloudGroupCreate do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_group_delete_spec.rb

@@ -97,18 +97,20 @@ describe Chef::Knife::IonoscloudGroupDelete do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end

data/spec/chef/knife/ionoscloud_group_get_spec.rb

@@ -61,18 +61,20 @@ describe Chef::Knife::IonoscloudGroupGet do
     it 'should not make any call if any required option is missing' do
       required_options = subject.instance_variable_get(:@required_options)
 
-      arrays_without_one_element(required_options).each do |test_case|
+      if required_options.length > 0
+        arrays_without_one_element(required_options).each do |test_case|
+          subject.config[:ionoscloud_token] = 'token'
+          test_case[:array].each { |value| subject.config[value] = 'test' }
 
-        test_case[:array].each { |value| subject.config[value] = 'test' }
+          expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+          expect(subject.api_client).not_to receive(:call_api)
 
-        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
-        expect(subject.api_client).not_to receive(:call_api)
+          expect { subject.run }.to raise_error(SystemExit) do |error|
+            expect(error.status).to eq(1)
+          end
 
-        expect { subject.run }.to raise_error(SystemExit) do |error|
-          expect(error.status).to eq(1)
+          required_options.each { |value| subject.config[value] = nil }
         end
-
-        required_options.each { |value| subject.config[value] = nil }
       end
     end
   end