knife-ionoscloud 6.1.0 → 6.1.1

data/lib/chef/knife/ionoscloud_dbaas_postgres_logs_get.rb

@@ -19,11 +19,26 @@ class Chef
 
       option :start,
               long: '--start START',
-              description: 'The start time for the query in RFC3339 format.'
+              description: 'The start time for the query in RFC3339 format. If both start and since are set, start will be used.'
+
+      option :since,
+              long: '--since SINCE',
+              description: 'The start time for the query using a time delta since the current moment: 2h - 2 hours ago, 20m - 20 minutes ago. '\
+              'Only hours and minutes ar supported, and not at the same time. If both start and since are set, start will be used.'
 
       option :end,
               long: '--end END',
-              description: 'The end time for the query in RFC3339 format.'
+              description: 'The end time for the query in RFC3339 format. If both end and until are set, end will be used.'
+
+      option :until,
+              long: '--until UNTIL',
+              description: 'The end time for the query using a time delta since the current moment: 2h - 2 hours ago, 20m - 20 minutes ago. '\
+              'Only hours and minutes ar supported, and not at the same time. If both end and until are set, end will be used.'
+
+      option :direction,
+              long: '--direction DIRECTION',
+              description: 'The direction in which to scan through the logs. '\
+                           'The logs are returned in order of the direction. One of ["BACKWARD", "FORWARD"]'
 
       def initialize(args = [])
         super(args)
@@ -38,21 +53,37 @@ class Chef
         handle_extra_config
         validate_required_params(@required_options, config)
 
+        def delta_to_date(delta)
+          return nil if delta.nil?
+
+          unit = delta[-1]
+          unless ['h', 'm'].include? unit
+            ui.error('Time delta may only be specified in hours(h) or minutes(m)!')
+            exit(1)
+          end
+
+          minute_count = Integer(delta[0..-2])
+          minute_count *= 60 if unit == 'h'
+
+          (Time.now - minute_count * 60).iso8601
+        end
+
         logs = IonoscloudDbaasPostgres::LogsApi.new(api_client_dbaas).cluster_logs_get(
           config[:cluster_id],
           {
             limit: (config[:limit] != nil ? Integer(config[:limit]) : nil),
-            start: config[:start],
-            end: config[:end],
+            start: config[:start].nil? ? delta_to_date(config[:since]) : config[:start],
+            _end: config[:end].nil? ? delta_to_date(config[:until]) : config[:end],
+            direction: config[:direction],
           },
         )
 
-        logs.instances.each { |instance|
+        logs.instances.each do |instance|
           puts "Instance Name: #{instance.name}"
           print "\n"
           puts instance.messages.map { |message| message.message }
           puts "\n"
-        }
+        end
       end
     end
   end

data/lib/chef/knife/ionoscloud_dbaas_postgres_version_list.rb

@@ -15,8 +15,9 @@ class Chef
       def initialize(args = [])
         super(args)
         @description =
-        'If cluster_id is provided, retrieves a list of all PostgreSQL versions available for a cluster including the current version,
-        otherwise retrieves a list of all available PostgreSQL versions.'
+        'If cluster_id is provided, retrieves a list of all PostgreSQL versions '\
+        'available for a cluster including the current version, '\
+        'otherwise retrieves a list of all available PostgreSQL versions.'
         @directory = 'dbaas-postgres'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end

data/lib/chef/knife/ionoscloud_firewall_create.rb

@@ -99,7 +99,7 @@ class Chef
           port_range_end: config[:port_range_end],
           icmp_type: config[:icmp_type],
           icmp_code: config[:icmp_code],
-          type: config[:type]
+          type: config[:type],
         }
 
         firewallrules_api = Ionoscloud::FirewallRulesApi.new(api_client)

data/lib/chef/knife/ionoscloud_firewall_delete.rb

@@ -53,7 +53,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this firewall rule')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_firewall_list.rb

@@ -52,7 +52,7 @@ class Chef
         firewallrules_api = Ionoscloud::FirewallRulesApi.new(api_client)
 
         firewallrules_api.datacenters_servers_nics_firewallrules_get(
-          config[:datacenter_id], config[:server_id], config[:nic_id], { depth: 1 }
+          config[:datacenter_id], config[:server_id], config[:nic_id], { depth: 1 },
         ).items.each do |firewall|
           firewall_list << firewall.id
           firewall_list << firewall.properties.name

data/lib/chef/knife/ionoscloud_flowlog_delete.rb

@@ -50,8 +50,6 @@ class Chef
         handle_extra_config
         validate_required_params(@required_options, config)
 
-        flowlogs_api = Ionoscloud::FlowLogsApi.new(api_client)
-
         case config[:type]
         when 'nic'
           validate_required_params([:server_id, :nic_id], config)
@@ -89,7 +87,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Flow Log')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_flowlog_list.rb

@@ -64,27 +64,25 @@ class Chef
           validate_required_params([:server_id, :nic_id], config)
           flowlogs_api = Ionoscloud::FlowLogsApi.new(api_client)
           flowlogs = flowlogs_api.datacenters_servers_nics_flowlogs_get(
-            config[:datacenter_id], config[:server_id], config[:nic_id], { depth: 1 }
+            config[:datacenter_id], config[:server_id], config[:nic_id], { depth: 1 },
           )
         when 'natgateway'
           validate_required_params([:natgateway_id], config)
           flowlogs_api = Ionoscloud::NATGatewaysApi.new(api_client)
           flowlogs = flowlogs_api.datacenters_natgateways_flowlogs_get(
-            config[:datacenter_id], config[:natgateway_id], { depth: 1 }
+            config[:datacenter_id], config[:natgateway_id], { depth: 1 },
           )
         when 'networkloadbalancer'
           validate_required_params([:network_loadbalancer_id], config)
           flowlogs_api = Ionoscloud::NetworkLoadBalancersApi.new(api_client)
           flowlogs = flowlogs_api.datacenters_networkloadbalancers_flowlogs_get(
-            config[:datacenter_id], config[:network_loadbalancer_id], { depth: 1 }
+            config[:datacenter_id], config[:network_loadbalancer_id], { depth: 1 },
           )
         else
           ui.error "Flow log cannot belong to #{config[:type]}. Value must be one of ['nic', 'natgateway', 'networkloadbalancer']"
           exit(1)
         end
 
-        flowlogs_api = Ionoscloud::FlowLogsApi.new(api_client)
-
         flowlogs.items.each do |flowlog|
           flowlog_list << flowlog.id
           flowlog_list << flowlog.properties.name

data/lib/chef/knife/ionoscloud_group_delete.rb

@@ -38,7 +38,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Group')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_group_update.rb

@@ -96,7 +96,7 @@ class Chef
 
           existing_group = user_management_api.um_groups_find_by_id(config[:group_id], depth: 1)
 
-          group, _, headers = user_management_api.um_groups_put_with_http_info(
+          _, _, headers = user_management_api.um_groups_put_with_http_info(
             config[:group_id],
             Ionoscloud::Group.new(
               properties: Ionoscloud::GroupProperties.new(

data/lib/chef/knife/ionoscloud_ipblock_delete.rb

@@ -34,7 +34,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this IP block')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_k8s_create.rb

@@ -17,6 +17,11 @@ class Chef
               long: '--version VERSION',
               description: 'The version for the Kubernetes cluster.'
 
+      option :private,
+              long: '--private',
+              default: false,
+              description: 'The indicator if the cluster is public or private. Be aware that creating a private cluster is currently in beta phase.'
+
       option :maintenance_day,
               short: '-d MAINTENANCE_DAY',
               long: '--maintenance-day MAINTENANCE_DAY',
@@ -59,6 +64,7 @@ class Chef
 
         cluster_properties = {
           name: config[:name],
+          public: !config[:private],
           k8s_version: config[:version],
           api_subnet_allow_list: config[:api_subnet_allow_list],
           s3_buckets: (config[:s3_buckets].nil? ? config[:s3_buckets] : config[:s3_buckets].map { |el| Ionoscloud::S3Bucket.new(name: el) }),

data/lib/chef/knife/ionoscloud_k8s_delete.rb

@@ -34,7 +34,7 @@ class Chef
           unless ['ACTIVE', 'TERMINATED'].include? cluster.metadata.state
             ui.error(
               "K8s Cluster #{cluster_id} state must be one of ['ACTIVE', 'TERMINATED'], "\
-              "actual state is '#{cluster.metadata.state}'. Skipping."
+              "actual state is '#{cluster.metadata.state}'. Skipping.",
             )
             next
           end
@@ -49,7 +49,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this K8s Cluster')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_k8s_list.rb

@@ -23,6 +23,7 @@ class Chef
         cluster_list = [
           ui.color('ID', :bold),
           ui.color('Name', :bold),
+          ui.color('Public', :bold),
           ui.color('Version', :bold),
           ui.color('Maintenance Window', :bold),
           ui.color('State', :bold),
@@ -33,12 +34,13 @@ class Chef
         kubernetes_api.k8s_get({ depth: 1 }).items.each do |cluster|
           cluster_list << cluster.id
           cluster_list << cluster.properties.name
+          cluster_list << cluster.properties.public
           cluster_list << cluster.properties.k8s_version
           cluster_list << "#{cluster.properties.maintenance_window.day_of_the_week}, #{cluster.properties.maintenance_window.time}"
           cluster_list << cluster.metadata.state
         end
 
-        puts ui.list(cluster_list, :uneven_columns_across, 5)
+        puts ui.list(cluster_list, :uneven_columns_across, 6)
       end
     end
   end

data/lib/chef/knife/ionoscloud_k8s_update.rb

@@ -62,14 +62,10 @@ class Chef
         if @updatable_fields.map { |el| config[el] }.any?
           print "#{ui.color('Updating K8s Cluster...', :magenta)}"
 
-          if config[:api_subnet_allow_list] && config[:api_subnet_allow_list].instance_of?(String)
-            config[:api_subnet_allow_list] = config[:api_subnet_allow_list].split(',')
-          end
+          config[:api_subnet_allow_list] = config[:api_subnet_allow_list].split(',') if config[:api_subnet_allow_list] && config[:api_subnet_allow_list].instance_of?(String)
           config[:s3_buckets] = config[:s3_buckets].split(',') if config[:s3_buckets] && config[:s3_buckets].instance_of?(String)
 
-          if config.key?(:s3_buckets)
-            config[:s3_buckets] = config[:s3_buckets].map { |el| Ionoscloud::S3Bucket.new(name: el) }
-          end
+          config[:s3_buckets] = config[:s3_buckets].map { |el| Ionoscloud::S3Bucket.new(name: el) } if config.key?(:s3_buckets)
 
           cluster = kubernetes_api.k8s_find_by_cluster_id(config[:cluster_id])
 

data/lib/chef/knife/ionoscloud_label_list.rb

@@ -56,9 +56,7 @@ class Chef
           validate_required_params([:resource_id], config)
           labels = label_api.snapshots_labels_get(config[:resource_id], opts)
         else
-          if !config[:type].nil?
-            ui.warn("#{config[:type]} is not a valid Resource Type. Returning all available labels.")
-          end
+          ui.warn("#{config[:type]} is not a valid Resource Type. Returning all available labels.") if !config[:type].nil?
           labels = label_api.labels_get(opts)
         end
 

data/lib/chef/knife/ionoscloud_lan_delete.rb

@@ -40,7 +40,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this LAN')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_loadbalancer_delete.rb

@@ -45,7 +45,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Load balancer')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_natgateway_create.rb

@@ -43,7 +43,7 @@ class Chef
           properties: Ionoscloud::NatGatewayProperties.new(
             name: config[:name],
             public_ips: config[:ips],
-          )
+          ),
         )
 
         natgateway, _, headers = natgateways_api.datacenters_natgateways_post_with_http_info(config[:datacenter_id], natgateway)

data/lib/chef/knife/ionoscloud_natgateway_delete.rb

@@ -40,7 +40,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this NAT Gateway')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_natgateway_rule_add.rb

@@ -30,7 +30,7 @@ class Chef
       option :protocol,
               short: '-p PROTOCOL',
               long: '--protocol PROTOCOL',
-              description: "Protocol of the NAT gateway rule. Defaults to ALL. If protocol is "\
+              description: 'Protocol of the NAT gateway rule. Defaults to ALL. If protocol is '\
               "'ICMP' then target_port_range start and end cannot be set."
 
       option :source_subnet,

data/lib/chef/knife/ionoscloud_natgateway_rule_update.rb

@@ -35,7 +35,7 @@ class Chef
       option :protocol,
               short: '-p PROTOCOL',
               long: '--protocol PROTOCOL',
-              description: "Protocol of the NAT gateway rule. Defaults to ALL. If protocol is "\
+              description: 'Protocol of the NAT gateway rule. Defaults to ALL. If protocol is '\
               "'ICMP' then target_port_range start and end cannot be set."
 
       option :source_subnet,

data/lib/chef/knife/ionoscloud_natgateway_update.rb

@@ -49,8 +49,7 @@ class Chef
 
         config[:ips] = config[:ips].split(',') if config[:ips] && config[:ips].instance_of?(String)
         config[:lans] = JSON[config[:lans]] if config[:lans] && config[:lans].instance_of?(String)
-        config[:lans] = config[:lans].map do
-          |lan|
+        config[:lans] = config[:lans].map do |lan|
           Ionoscloud::NatGatewayLanProperties.new(
             id: lan['id'],
             gateway_ips: lan['gateway_ips'],

data/lib/chef/knife/ionoscloud_networkloadbalancer_delete.rb

@@ -45,7 +45,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Network Load balancer')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_networkloadbalancer_rule_add.rb

@@ -84,8 +84,7 @@ class Chef
         config[:gateway_ips] = config[:gateway_ips].split(',') if config[:gateway_ips] && config[:gateway_ips].instance_of?(String)
         config[:targets] = JSON[config[:targets]] if config[:targets] && config[:targets].instance_of?(String)
 
-        config[:targets] = config[:targets].map do
-          |condition|
+        config[:targets] = config[:targets].map do |condition|
           Ionoscloud::NetworkLoadBalancerForwardingRuleTarget.new(
             ip: condition['ip'],
             port: condition['port'],

data/lib/chef/knife/ionoscloud_networkloadbalancer_rule_target_remove.rb

@@ -56,8 +56,7 @@ class Chef
 
         initial_length = network_load_balancer_rule.properties.targets.length
 
-        network_load_balancer_rule.properties.targets = network_load_balancer_rule.properties.targets.reject do
-          |target|
+        network_load_balancer_rule.properties.targets = network_load_balancer_rule.properties.targets.reject do |target|
           target.ip == config[:ip] && target.port == Integer(config[:port])
         end
 

data/lib/chef/knife/ionoscloud_networkloadbalancer_rule_update.rb

@@ -93,8 +93,7 @@ class Chef
         config[:gateway_ips] = config[:gateway_ips].split(',') if config[:gateway_ips] && config[:gateway_ips].instance_of?(String)
         config[:targets] = JSON[config[:targets]] if config[:targets] && config[:targets].instance_of?(String)
 
-        config[:targets] = config[:targets].map do
-          |target|
+        config[:targets] = config[:targets].map do |target|
           Ionoscloud::NetworkLoadBalancerForwardingRuleTarget.new(
             ip: target['ip'],
             port: target['port'],

data/lib/chef/knife/ionoscloud_nic_create.rb

@@ -47,8 +47,8 @@ class Chef
       def initialize(args = [])
         super(args)
         @description =
-        "Creates a NIC on the specified server. The Ionoscloud platform supports adding multiple NICs to a server. These NICs "\
-        "can be used to create different, segmented networks on the platform."
+        'Creates a NIC on the specified server. The Ionoscloud platform supports adding multiple NICs to a server. These NICs '\
+        'can be used to create different, segmented networks on the platform.'
         @directory = 'compute-engine'
         @required_options = [:datacenter_id, :server_id, :lan, :ionoscloud_username, :ionoscloud_password]
       end
@@ -67,7 +67,7 @@ class Chef
           ips: config[:ips],
           dhcp: config[:dhcp],
           lan: config[:lan],
-          firewall_type: config[:firewall_type]
+          firewall_type: config[:firewall_type],
         }.compact
 
         nic_api = Ionoscloud::NetworkInterfacesApi.new(api_client)

data/lib/chef/knife/ionoscloud_nic_delete.rb

@@ -45,7 +45,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Nic')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_node_delete.rb

@@ -52,7 +52,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this K8s Node')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_node_replace.rb

@@ -23,9 +23,9 @@ class Chef
         @description =
         "You can recreate a single Kubernetes Node.\n\n"\
         "Managed Kubernetes starts a process which based on the nodepool\'s "\
-        "template creates & configures a new node, waits for status \"ACTIVE\", "\
-        "and migrates all the pods from the faulty node, deleting it once empty. "\
-        "While this operation occurs, the nodepool will have an extra billable \"ACTIVE\" node."
+        'template creates & configures a new node, waits for status "ACTIVE", '\
+        'and migrates all the pods from the faulty node, deleting it once empty. '\
+        'While this operation occurs, the nodepool will have an extra billable "ACTIVE" node.'
         @directory = 'kubernetes'
         @required_options = [:cluster_id, :nodepool_id, :ionoscloud_username, :ionoscloud_password]
       end

data/lib/chef/knife/ionoscloud_nodepool_create.rb

@@ -81,6 +81,10 @@ class Chef
               long: '--lans LAN_ID [LAN_ID]',
               description: 'An array of additional private LANs attached to worker nodes'
 
+      option :gateway_ip,
+              long: '--gateway GATEWAY_IP',
+              description: "Public IP address for the gateway performing source NAT for the node pool's nodes belonging to a private cluster. Required only if the node pool belongs to a private cluster."
+
       option :public_ips,
               long: '--ips PUBLIC_IP [PUBLIC_IP]',
               description: 'Optional array of reserved public IP addresses to be used by the nodes. '\
@@ -99,9 +103,9 @@ class Chef
       def initialize(args = [])
         super(args)
         @description =
-        "Creates a node pool into an existing Kubernetes cluster. "\
+        'Creates a node pool into an existing Kubernetes cluster. '\
         "The Kubernetes cluster must be in state \"ACTIVE\" before creating a node pool.\n\n"\
-        "The worker nodes within the node pools will be deployed into an existing data centers."
+        'The worker nodes within the node pools will be deployed into an existing data centers.'
         @directory = 'kubernetes'
         @required_options = [
           :datacenter_id, :cluster_id, :name, :version, :node_count, :cpu_family, :cores, :ram,
@@ -134,6 +138,7 @@ class Chef
           availability_zone: config[:availability_zone],
           storage_type: config[:storage_type],
           storage_size: config[:storage_size],
+          gateway_ip: config[:gateway_ip],
           public_ips: config[:public_ips],
           labels: config[:labels],
           annotations: config[:annotations],

data/lib/chef/knife/ionoscloud_nodepool_delete.rb

@@ -41,7 +41,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this K8s Nodepool')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_nodepool_list.rb

@@ -30,6 +30,7 @@ class Chef
           ui.color('Name', :bold),
           ui.color('K8s Version', :bold),
           ui.color('Datacenter ID', :bold),
+          ui.color('Gateway IP', :bold),
           ui.color('Node Count', :bold),
           ui.color('Lan Count', :bold),
           ui.color('State', :bold),
@@ -42,11 +43,12 @@ class Chef
           nodepool_list << nodepool.properties.name
           nodepool_list << nodepool.properties.k8s_version
           nodepool_list << nodepool.properties.datacenter_id
+          nodepool_list << nodepool.properties.gateway_ip
           nodepool_list << nodepool.properties.node_count.to_s
           nodepool_list << nodepool.properties.lans.length
           nodepool_list << nodepool.metadata.state
         end
-        puts ui.list(nodepool_list, :uneven_columns_across, 7)
+        puts ui.list(nodepool_list, :uneven_columns_across, 8)
       end
     end
   end

data/lib/chef/knife/ionoscloud_pcc_delete.rb

@@ -36,7 +36,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this PCC')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_pcc_update.rb

@@ -46,7 +46,7 @@ class Chef
             Ionoscloud::PrivateCrossConnectProperties.new(
               name: config[:name],
               description: config[:description],
-            )
+            ),
           )
 
           dot = ui.color('.', :magenta)

data/lib/chef/knife/ionoscloud_request_list.rb

@@ -56,18 +56,14 @@ class Chef
         begin
           config[:limit] = Integer(config[:limit])
         rescue *[ArgumentError, TypeError]
-          if config[:limit]
-            ui.warn('limit should be an Integer!')
-          end
+          ui.warn('limit should be an Integer!') if config[:limit]
           config[:limit] = 20
         end
 
         begin
           config[:offset] = Integer(config[:offset])
         rescue *[ArgumentError, TypeError]
-          if config[:offset]
-            ui.warn('offset should be an Integer!')
-          end
+          ui.warn('offset should be an Integer!') if config[:offset]
           config[:offset] = 0
         end
 
@@ -77,21 +73,13 @@ class Chef
           offset: config[:offset],
         }
 
-        if config[:status] && ['QUEUED', 'RUNNING', 'DONE', 'FAILED'].include?(config[:status])
-          opts[:filter_request_status] = config[:status]
-        end
+        opts[:filter_request_status] = config[:status] if config[:status] && ['QUEUED', 'RUNNING', 'DONE', 'FAILED'].include?(config[:status])
 
-        if config[:status] && !['QUEUED', 'RUNNING', 'DONE', 'FAILED'].include?(config[:status])
-          ui.warn('status should be one of [QUEUED, RUNNING, DONE, FAILED]')
-        end
+        ui.warn('status should be one of [QUEUED, RUNNING, DONE, FAILED]') if config[:status] && !['QUEUED', 'RUNNING', 'DONE', 'FAILED'].include?(config[:status])
 
-        if config[:method] && ['POST', 'PUT', 'PATCH', 'DELETE'].include?(config[:method])
-          opts[:filter_method] = config[:method]
-        end
+        opts[:filter_method] = config[:method] if config[:method] && ['POST', 'PUT', 'PATCH', 'DELETE'].include?(config[:method])
 
-        if config[:method] && !['POST', 'PUT', 'PATCH', 'DELETE'].include?(config[:method])
-          ui.warn('method should be one of [POST, PUT, PATCH, DELETE]')
-        end
+        ui.warn('method should be one of [POST, PUT, PATCH, DELETE]') if config[:method] && !['POST', 'PUT', 'PATCH', 'DELETE'].include?(config[:method])
 
         request_api.requests_get(opts).items.each do |request|
           request_list << request.id

data/lib/chef/knife/ionoscloud_resource_list.rb

@@ -20,13 +20,13 @@ class Chef
       def initialize(args = [])
         super(args)
         @description =
-        "No option: Retrieves a list of all resources and optionally their group associations. "\
-        "Please Note: This API call can take a significant amount of time to return when there "\
-        "are a large number of provisioned resources. You may wish to consult the next section "\
+        'No option: Retrieves a list of all resources and optionally their group associations. '\
+        'Please Note: This API call can take a significant amount of time to return when there '\
+        'are a large number of provisioned resources. You may wish to consult the next section '\
         "on how to list resources of a particular type.\n\n"
-        "resource_type specified: Lists all shareable resources of a specific type. Optionally include their "\
-        "association with groups, permissions that a group has for the resource, and "\
-        "users that are members of the group. Because you are scoping your request to "\
+        'resource_type specified: Lists all shareable resources of a specific type. Optionally include their '\
+        'association with groups, permissions that a group has for the resource, and '\
+        'users that are members of the group. Because you are scoping your request to '\
         "a specific resource type, this API will likely return faster than querying */um/resources*.\n\n"\
         "The values available for resourceType are listed in this table:\n\n"\
         "| ResourceType | Description |\n"\
@@ -35,9 +35,9 @@ class Chef
         "| snapshot | A snapshot of a storage volume. |\n"\
         "| ipblock | An IP block that has been reserved. |\n"\
         "| k8s | A Kubernetes cluster. |\n\n"\
-        "resource_type and resource_id specified: Retrieves a specific resource."\
-        "**NOTE:** if you pass the *resource_id* option it is necessary to also pass the "\
-        "*resource_type* option or a list of all resources will be returned."
+        'resource_type and resource_id specified: Retrieves a specific resource.'\
+        '**NOTE:** if you pass the *resource_id* option it is necessary to also pass the '\
+        '*resource_type* option or a list of all resources will be returned.'
         @directory = 'user'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end
@@ -55,9 +55,7 @@ class Chef
           ui.color('Name', :bold),
         ]
 
-        if config[:resource_id] && !config[:resource_type]
-          ui.warn('Ignoring resource_id because no resource_type was specified.')
-        end
+        ui.warn('Ignoring resource_id because no resource_type was specified.') if config[:resource_id] && !config[:resource_type]
 
         opts = { depth: 1 }