knife-ionoscloud 6.0.0.beta.2 → 6.1.1

data/lib/chef/knife/ionoscloud_server_resume.rb

@@ -12,12 +12,11 @@ class Chef
               long: '--datacenter-id DATACENTER_ID',
               description: 'ID of the data center'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'This will resume a suspended server. The operation can only be applied to suspended Cube servers. No billing event will be generated.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_server_start.rb

@@ -12,12 +12,11 @@ class Chef
               long: '--datacenter-id DATACENTER_ID',
               description: 'ID of the data center'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'This will start a server. If the server\'s public IP was deallocated then a new IP will be assigned.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_server_stop.rb

@@ -12,13 +12,12 @@ class Chef
               long: '--datacenter-id DATACENTER_ID',
               description: 'ID of the data center'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'This will stop a server. The machine will be forcefully powered off, '\
         'billing will cease, and the public IP, if one is allocated, will be deallocated.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_server_suspend.rb

@@ -12,13 +12,12 @@ class Chef
               long: '--datacenter-id DATACENTER_ID',
               description: 'ID of the data center'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'This will suspend a server. The operation can only be applied to Cube servers. '\
         'Note: The virtual machine will not be deleted, and the consumed resources will continue to be billed.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_server_token.rb

@@ -17,12 +17,11 @@ class Chef
               long: '--server-id SERVER_ID',
               description: 'The ID of the Server.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Returns the server json web token to be used for login operations (ex: accessing the server console).'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :server_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_server_update.rb

@@ -50,12 +50,11 @@ class Chef
               long: '--boot-cdrom CDROM_ID',
               description: 'Reference to a CD-ROM used for booting'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Updates information about a Ionoscloud Server.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :server_id, :ionoscloud_username, :ionoscloud_password]
         @updatable_fields = [:name, :cores, :cpu_family, :ram, :availability_zone, :boot_volume, :boot_cdrom]
       end

data/lib/chef/knife/ionoscloud_server_upgrade.rb

@@ -17,13 +17,12 @@ class Chef
               long: '--server-id SERVER_ID',
               description: 'The ID of the Server.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
-        "This will upgrade the version of the server, if needed. To verify if there is an upgrade available for a server, "\
+        'This will upgrade the version of the server, if needed. To verify if there is an upgrade available for a server, '\
         "call '/datacenters/{datacenterId}/servers?upgradeNeeded=true'."
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :server_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_share_create.rb

@@ -27,14 +27,13 @@ class Chef
               long: '--share',
               description: 'The group has permission to share this resource.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Adds a specific resource share to a group and optionally allows the setting of permissions '\
         'for that resource. As an example, you might use this to grant permissions to use an image '\
         'or snapshot to a specific group.'
+        @directory = 'user'
         @required_options = [:group_id, :resource_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_share_delete.rb

@@ -12,12 +12,11 @@ class Chef
               long: '--group-id GROUP_ID',
               description: 'ID of the group.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Removes a resource share from a specified group.'
+        @directory = 'user'
         @required_options = [:group_id, :ionoscloud_username, :ionoscloud_password]
       end
 
@@ -42,7 +41,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Resource Share')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_share_get.rb

@@ -17,12 +17,11 @@ class Chef
               long: '--resource-id RESOURCE_ID',
               description: 'The ID of the resource.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieves the attributes of a given Group Share.'
+        @directory = 'user'
         @required_options = [:group_id, :resource_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_share_list.rb

@@ -12,13 +12,12 @@ class Chef
               long: '--group-id GROUP_ID',
               description: 'ID of the group.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieves a full list of all the resources that are shared through this '\
         'group and lists the permissions granted to the group members for each shared resource.'
+        @directory = 'user'
         @required_options = [:group_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_share_update.rb

@@ -26,12 +26,11 @@ class Chef
               long: '--share SHARE_PRIVILEGE',
               description: 'The group has permission to share this resource.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Updates information about a Ionoscloud Group Share.'
+        @directory = 'user'
         @required_options = [:group_id, :resource_id, :ionoscloud_username, :ionoscloud_password]
         @updatable_fields = [:edit_privilege, :share_privilege]
       end

data/lib/chef/knife/ionoscloud_snapshot_create.rb

@@ -35,13 +35,12 @@ class Chef
               long: '--licence LICENCE_TYPE',
               description: 'The OS type of this Snapshot'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Creates a snapshot of a volume within the virtual data center. '\
         'You can use a snapshot to create a new storage volume or to restore a storage volume.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :volume_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_snapshot_delete.rb

@@ -7,12 +7,11 @@ class Chef
 
       banner 'knife ionoscloud snapshot delete SNAPSHOT_ID [SNAPSHOT_ID]'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Deletes the specified snapshot.'
+        @directory = 'compute-engine'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end
 
@@ -37,7 +36,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this Snapshot')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_snapshot_get.rb

@@ -12,12 +12,11 @@ class Chef
               long: '--snapshot-id SNAPSHOT_ID',
               description: 'ID of the group.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieves the attributes of a given Snapshot.'
+        @directory = 'compute-engine'
         @required_options = [:snapshot_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_snapshot_list.rb

@@ -7,12 +7,11 @@ class Chef
 
       banner 'knife ionoscloud snapshot list'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieve a list of snapshots.'
+        @directory = 'compute-engine'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end
 
@@ -26,7 +25,7 @@ class Chef
           ui.color('Name', :bold),
           ui.color('Description', :bold),
           ui.color('Location', :bold),
-          ui.color('Size', :bold)
+          ui.color('Size', :bold),
         ]
 
         snapshot_api = Ionoscloud::SnapshotsApi.new(api_client)

data/lib/chef/knife/ionoscloud_snapshot_restore.rb

@@ -22,13 +22,12 @@ class Chef
               long: '--snapshot SNAPSHOT_ID',
               description: 'ID of the Snapshot'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'This will restore a snapshot onto a volume. A snapshot is created as just another image that '\
         'can be used to create new volumes or to restore an existing volume.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :volume_id, :snapshot_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_snapshot_update.rb

@@ -70,12 +70,11 @@ class Chef
               long: '--disc-scsi-hot-unplug DISC_SCSI_HOT_UNPLUG',
               description: 'The licence type of the snapshot (LINUX, WINDOWS, UNKNOWN, OTHER)'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Updates information about a Ionoscloud Snapshot.'
+        @directory = 'compute-engine'
         @required_options = [:snapshot_id, :ionoscloud_username, :ionoscloud_password]
         @updatable_fields = [
           :name, :description, :sec_auth_protection, :licence_type, :cpu_hot_plug, :cpu_hot_unplug, :ram_hot_plug, :ram_hot_unplug,

data/lib/chef/knife/ionoscloud_template_list.rb

@@ -7,12 +7,11 @@ class Chef
 
       banner 'knife ionoscloud template list'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieve a list of available templates. Templates can be used on specific server types only (CUBE at the moment)'
+        @directory = 'compute-engine'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_user_create.rb

@@ -36,14 +36,13 @@ class Chef
               long: '--sec-auth',
               description: 'Indicates if secure (two-factor) authentication should be forced for the user.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Creates a new user under a particular contract. **Please Note**: The password set '\
         'here cannot be updated through the API currently. It is recommended that a new user '\
         'log into the DCD and change their password.'
+        @directory = 'user'
         @required_options = [:firstname, :lastname, :email, :password, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_user_delete.rb

@@ -7,14 +7,13 @@ class Chef
 
       banner 'knife ionoscloud user delete USER_ID [USER_ID]'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Blacklists the user, disabling them. The user is not completely purged, '\
         'therefore if you anticipate needing to create a user with the same name '\
         'in the future, we suggest renaming the user before you delete it.'
+        @directory = 'user'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end
 
@@ -39,7 +38,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this User')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_user_get.rb

@@ -12,12 +12,11 @@ class Chef
               long: '--user-id USER_ID',
               description: 'ID of the group.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieves the attributes of a given Ionoscloud User.'
+        @directory = 'user'
         @required_options = [:user_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_user_list.rb

@@ -12,14 +12,13 @@ class Chef
               long: '--group-id GROUP_ID',
               description: 'ID of the group.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieve a list of all the users that have been created under a contract. '\
         'You can retrieve a list of users who are members of the group by passing the '\
         '_group\_id_ option.'
+        @directory = 'user'
         @required_options = [:ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_user_ssourl.rb

@@ -12,12 +12,11 @@ class Chef
               long: '--user-id USER_ID',
               description: 'The ID of the Backup unit.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieve S3 object storage single signon URL for the given user.'
+        @directory = 'user'
         @required_options = [:user_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_user_update.rb

@@ -43,12 +43,11 @@ class Chef
               long: '--active ACTIVE',
               description: 'Indicates if the user is active.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Updates information about a Ionoscloud User.'
+        @directory = 'user'
         @required_options = [:user_id, :ionoscloud_username, :ionoscloud_password]
         @updatable_fields = [:firstname, :lastname, :email, :administrator, :force_sec_auth, :sec_auth_active, :active]
       end

data/lib/chef/knife/ionoscloud_volume_attach.rb

@@ -17,12 +17,11 @@ class Chef
               long: '--server-id SERVER_ID',
               description: 'The ID of the server'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'This will attach a pre-existing storage volume to the server.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :server_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_volume_create.rb

@@ -71,13 +71,12 @@ class Chef
               'immutable and is only allowed to be set on a new volume creation. It is mandatory to provide either \'public image\' '\
               'or \'imageAlias\' that has cloud-init compatibility in conjunction with this property.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Creates a volume within the data center. This will NOT attach the volume to a server. '\
         'Please see the Servers section for details on how to attach storage volumes.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :name, :type, :size, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_volume_delete.rb

@@ -12,13 +12,12 @@ class Chef
               long: '--datacenter-id DATACENTER_ID',
               description: 'Name of the data center'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Deletes the specified volume. This will result in the volume being '\
         'removed from your virtual data center. Please use this with caution!'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :ionoscloud_username, :ionoscloud_password]
       end
 
@@ -46,7 +45,7 @@ class Chef
 
           begin
             confirm('Do you really want to delete this volume')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_volume_detach.rb

@@ -17,15 +17,14 @@ class Chef
               long: '--server-id SERVER_ID',
               description: 'The ID of the server'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
-        "This will detach the volume from the server. Depending on the volume "\
+        'This will detach the volume from the server. Depending on the volume '\
         "HotUnplug settings, this may result in the server being rebooted.\n\n"\
-        "This will NOT delete the volume from your virtual data center. You will "\
-        "need to make a separate request to delete a volume."
+        'This will NOT delete the volume from your virtual data center. You will '\
+        'need to make a separate request to delete a volume.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :server_id, :ionoscloud_username, :ionoscloud_password]
       end
 
@@ -60,7 +59,7 @@ class Chef
 
           begin
             confirm('Do you really want to detach this volume')
-          rescue SystemExit => exc
+          rescue SystemExit
             next
           end
 

data/lib/chef/knife/ionoscloud_volume_get.rb

@@ -16,12 +16,11 @@ class Chef
               long: '--volume VOLUME_ID',
               description: 'ID of the volume.'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Retrieves the attributes of a given Volume.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :volume_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_volume_list.rb

@@ -17,13 +17,12 @@ class Chef
               long: '--server-id SERVER_ID',
               description: 'The ID of the server'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'List all available volumes under a data center. '\
         'You can also list all volumes attached to a specific server.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :ionoscloud_username, :ionoscloud_password]
       end
 

data/lib/chef/knife/ionoscloud_volume_update.rb

@@ -55,12 +55,11 @@ class Chef
               long: '--disc-virtio-hot_unplug DISC_VIRTIO_HOT_UNPLUG',
               description: 'The licence type of the volume (LINUX, WINDOWS, UNKNOWN, OTHER)'
 
-      attr_reader :description, :required_options
-
       def initialize(args = [])
         super(args)
         @description =
         'Updates information about a Ionoscloud Volume.'
+        @directory = 'compute-engine'
         @required_options = [:datacenter_id, :volume_id, :ionoscloud_username, :ionoscloud_password]
         @updatable_fields = [
           :name, :size, :bus, :cpu_hot_plug, :ram_hot_plug, :nic_hot_plug, :nic_hot_unplug, :disc_virtio_hot_plug, :disc_virtio_hot_unplug,

data/lib/knife-ionoscloud/version.rb

@@ -1,6 +1,6 @@
 module Knife
   module Ionoscloud
-    VERSION = '6.0.0.beta.2'
+    VERSION = '6.1.1'
     MAJOR, MINOR, TINY = VERSION.split('.')
   end
 end

data/sonar-project.properties

@@ -1,6 +1,9 @@
 sonar.projectKey=knife-plugin
 sonar.organization=ionos-cloud
 
+sonar.ruby.coverage.reportPaths=coverage/coverage.json
+sonar.cpd.exclusions=spec/chef/knife/*.rb
+
 # This is the name and version displayed in the SonarCloud UI.
 #sonar.projectName=knife-plugin
 #sonar.projectVersion=1.0

data/spec/chef/knife/ionoscloud_backupunit_create_spec.rb

@@ -14,7 +14,7 @@ describe Chef::Knife::IonoscloudBackupunitCreate do
   describe '#run' do
     it 'should call BackupUnitsApi.backupunits_post with the expected arguments and output based on what it receives' do
       backupunit = backupunit_mock
-      subject_config = {
+      {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
         name: backupunit.properties.name,
@@ -48,7 +48,6 @@ describe Chef::Knife::IonoscloudBackupunitCreate do
       required_options = subject.instance_variable_get(:@required_options)
 
       arrays_without_one_element(required_options).each do |test_case|
-
         test_case[:array].each { |value| subject.config[value] = 'test' }
 
         expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")

data/spec/chef/knife/ionoscloud_backupunit_delete_spec.rb

@@ -84,7 +84,6 @@ describe Chef::Knife::IonoscloudBackupunitDelete do
       required_options = subject.instance_variable_get(:@required_options)
 
       arrays_without_one_element(required_options).each do |test_case|
-
         test_case[:array].each { |value| subject.config[value] = 'test' }
 
         expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")

data/spec/chef/knife/ionoscloud_backupunit_get_spec.rb

@@ -48,7 +48,6 @@ describe Chef::Knife::IonoscloudBackupunitGet do
       required_options = subject.instance_variable_get(:@required_options)
 
       arrays_without_one_element(required_options).each do |test_case|
-
         test_case[:array].each { |value| subject.config[value] = 'test' }
 
         expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")

data/spec/chef/knife/ionoscloud_backupunit_list_spec.rb

@@ -55,7 +55,6 @@ describe Chef::Knife::IonoscloudBackupunitList do
       required_options = subject.instance_variable_get(:@required_options)
 
       arrays_without_one_element(required_options).each do |test_case|
-
         test_case[:array].each { |value| subject.config[value] = 'test' }
 
         expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")

data/spec/chef/knife/ionoscloud_backupunit_ssourl_spec.rb

@@ -74,9 +74,7 @@ describe Chef::Knife::IonoscloudBackupunitSsourl do
       allow(subject).to receive(:puts)
       allow(subject).to receive(:print)
 
-      arrays_without_one_element(required_options).each {
-        |test_case|
-
+      arrays_without_one_element(required_options).each do |test_case|
         test_case[:array].each { |value| subject.config[value] = 'test' }
 
         expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
@@ -87,7 +85,7 @@ describe Chef::Knife::IonoscloudBackupunitSsourl do
         end
 
         required_options.each { |value| subject.config[value] = nil }
-      }
+      end
     end
   end
 end

data/spec/chef/knife/ionoscloud_backupunit_update_spec.rb

@@ -61,7 +61,6 @@ describe Chef::Knife::IonoscloudBackupunitUpdate do
       required_options = subject.instance_variable_get(:@required_options)
 
       arrays_without_one_element(required_options).each do |test_case|
-
         test_case[:array].each { |value| subject.config[value] = 'test' }
 
         expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")