knife-ionoscloud 6.0.0.alpha.1 → 6.1.0

data/spec/chef/knife/ionoscloud_node_get_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'ionoscloud_node_get'
+
+Chef::Knife::IonoscloudNodeGet.load_deps
+
+describe Chef::Knife::IonoscloudNodeGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudNodeGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call KubernetesApi.k8s_nodepools_nodes_find_by_id' do
+      k8s_node = k8s_node_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        nodepool_id: 'nodepool_id',
+        node_id: k8s_node.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{k8s_node.id}")
+      expect(subject).to receive(:puts).with("Name: #{k8s_node.properties.name}")
+      expect(subject).to receive(:puts).with("Public IP: #{k8s_node.properties.public_ip}")
+      expect(subject).to receive(:puts).with("Private IP: #{k8s_node.properties.private_ip}")
+      expect(subject).to receive(:puts).with("K8s Version: #{k8s_node.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("State: #{k8s_node.metadata.state}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}/nodes/#{subject_config[:node_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_nodes_find_by_id',
+            return_type: 'KubernetesNode',
+            result: k8s_node,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_nodepool_create_spec.rb

@@ -32,19 +32,21 @@ describe Chef::Knife::IonoscloudNodepoolCreate do
         storage_size: nodepool.properties.storage_size,
         min_node_count: nodepool.properties.auto_scaling.min_node_count,
         max_node_count: nodepool.properties.auto_scaling.max_node_count,
+        labels: nodepool.properties.labels,
+        annotations: nodepool.properties.annotations,
         lans: nodepool.properties.lans.map { |lan| lan.id }.join(','),
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
 
-      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
-      maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
-
       expected_body = nodepool.properties.to_hash
       expected_body[:lans].map! { |lan| lan.delete(:dhcp); lan.delete(:routes); lan[:id] = Integer(lan[:id]); lan }
       expected_body.delete(:publicIps)
       expected_body.delete(:availableUpgradeVersions)
 
+      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
+      maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+
       expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
@@ -55,20 +57,9 @@ describe Chef::Knife::IonoscloudNodepoolCreate do
       expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
       expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
       expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
-      expect(subject).to receive(:puts).with("Lans: #{nodepool.properties.lans.map do
-        |lan|
-        {
-          id: lan.id,
-          dhcp: lan.dhcp,
-          routes: lan.routes ? lan.routes.map do
-            |route|
-            {
-              network: route.network,
-              gateway_ip: route.gateway_ip,
-            }
-          end : []
-        }
-      end}")
+      expect(subject).to receive(:puts).with("Labels: #{nodepool.properties.labels}")
+      expect(subject).to receive(:puts).with("Annotations: #{nodepool.properties.annotations}")
+      expect(subject).to receive(:puts).with("LANs: #{nodepool.properties.lans.map { |lan| lan.to_hash }}")
       expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
       expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
       expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")

data/spec/chef/knife/ionoscloud_nodepool_delete_spec.rb

@@ -24,11 +24,25 @@ describe Chef::Knife::IonoscloudNodepoolDelete do
       subject_config.each { |key, value| subject.config[key] = value }
       subject.name_args = [k8s_nodepool.id]
 
+      auto_scaling = "Min node count: #{k8s_nodepool.properties.auto_scaling.min_node_count}, Max node count:#{k8s_nodepool.properties.auto_scaling.max_node_count}"
+      maintenance_window = "#{k8s_nodepool.properties.maintenance_window.day_of_the_week}, #{k8s_nodepool.properties.maintenance_window.time}"
+
       expect(subject).to receive(:puts).with("ID: #{k8s_nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{k8s_nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{k8s_nodepool.properties.k8s_version}")
       expect(subject).to receive(:puts).with("Datacenter ID: #{k8s_nodepool.properties.datacenter_id}")
       expect(subject).to receive(:puts).with("Node Count: #{k8s_nodepool.properties.node_count}")
+      expect(subject).to receive(:puts).with("CPU Family: #{k8s_nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{k8s_nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{k8s_nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{k8s_nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{k8s_nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Labels: #{k8s_nodepool.properties.labels}")
+      expect(subject).to receive(:puts).with("Annotations: #{k8s_nodepool.properties.annotations}")
+      expect(subject).to receive(:puts).with("LANs: #{k8s_nodepool.properties.lans.map { |lan| lan.to_hash }}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{k8s_nodepool.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
+      expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
       expect(subject).to receive(:puts).with("State: #{k8s_nodepool.metadata.state}")
       expect(subject.ui).to receive(:warn).with("Deleted K8s Nodepool #{k8s_nodepool.id}.")
 

data/spec/chef/knife/ionoscloud_nodepool_get_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+require 'ionoscloud_nodepool_get'
+
+Chef::Knife::IonoscloudNodepoolGet.load_deps
+
+describe Chef::Knife::IonoscloudNodepoolGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudNodepoolGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call KubernetesApi.k8s_nodepools_nodes_find_by_id' do
+      nodepool = k8s_nodepool_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        nodepool_id: nodepool.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
+      maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+      lans = nodepool.properties.lans.map { |lan| lan.to_hash }
+
+      expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
+      expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
+      expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("Datacenter ID: #{nodepool.properties.datacenter_id}")
+      expect(subject).to receive(:puts).with("Node Count: #{nodepool.properties.node_count}")
+      expect(subject).to receive(:puts).with("CPU Family: #{nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Public IPs: #{nodepool.properties.public_ips}")
+      expect(subject).to receive(:puts).with("LANs: #{lans}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
+      expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
+      expect(subject).to receive(:puts).with("State: #{nodepool.metadata.state}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_find_by_id',
+            return_type: 'KubernetesNodePool',
+            result: nodepool,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_nodepool_lan_add_spec.rb

@@ -30,29 +30,25 @@ describe Chef::Knife::IonoscloudNodepoolLanAdd do
 
       auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
       maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+      lans = (nodepool.properties.lans + [nodepool_lan]).map { |lan| lan.to_hash }
 
-      expect(subject.ui).to receive(:info).with("Adding Lan #{subject_config[:lan_id]} to the Nodepoool.")
       expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("Datacenter ID: #{nodepool.properties.datacenter_id}")
       expect(subject).to receive(:puts).with("Node Count: #{nodepool.properties.node_count}")
-      expect(subject).to receive(:puts).with("Lans: #{(nodepool.properties.lans + [nodepool_lan]).map do
-        |lan|
-        {
-          id: lan.id,
-          dhcp: lan.dhcp,
-          routes: lan.routes ? lan.routes.map do
-            |route|
-            {
-              network: route.network,
-              gateway_ip: route.gateway_ip,
-            }
-          end : []
-        }
-      end}")
+      expect(subject).to receive(:puts).with("CPU Family: #{nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Public IPs: #{nodepool.properties.public_ips}")
+      expect(subject).to receive(:puts).with("LANs: #{lans}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
       expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
       expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
       expect(subject).to receive(:puts).with("State: #{nodepool.metadata.state}")
+      expect(subject.ui).to receive(:info).with("Adding Lan #{subject_config[:lan_id]} to the Nodepoool.")
 
 
       expected_body = nodepool.properties.to_hash
@@ -66,6 +62,8 @@ describe Chef::Knife::IonoscloudNodepoolLanAdd do
       expected_body.delete(:storageType)
       expected_body.delete(:availabilityZone)
       expected_body.delete(:availableUpgradeVersions)
+      expected_body.delete(:labels)
+      expected_body.delete(:annotations)
 
       mock_call_api(
         subject,
@@ -82,7 +80,7 @@ describe Chef::Knife::IonoscloudNodepoolLanAdd do
             path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
             operation: :'KubernetesApi.k8s_nodepools_put',
             body: { properties: expected_body },
-            return_type: 'KubernetesNodePoolForPut',
+            return_type: 'KubernetesNodePool',
             result: nodepool,
           },
         ],
@@ -108,32 +106,28 @@ describe Chef::Knife::IonoscloudNodepoolLanAdd do
 
       subject_config.each { |key, value| subject.config[key] = value }
 
+
       auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
       maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+      lans = [nodepool.properties.lans[1], nodepool_lan].map { |lan| lan.to_hash }
 
-      expect(subject.ui).to receive(:info).with("Updating Lan #{subject_config[:lan_id]} in the Nodepoool.")
       expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("Datacenter ID: #{nodepool.properties.datacenter_id}")
       expect(subject).to receive(:puts).with("Node Count: #{nodepool.properties.node_count}")
-      expect(subject).to receive(:puts).with("Lans: #{[nodepool.properties.lans[1], nodepool_lan].map do
-        |lan|
-        {
-          id: lan.id,
-          dhcp: lan.dhcp,
-          routes: lan.routes ? lan.routes.map do
-            |route|
-            {
-              network: route.network,
-              gateway_ip: route.gateway_ip,
-            }
-          end : []
-        }
-      end}")
+      expect(subject).to receive(:puts).with("CPU Family: #{nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Public IPs: #{nodepool.properties.public_ips}")
+      expect(subject).to receive(:puts).with("LANs: #{lans}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
       expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
       expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
       expect(subject).to receive(:puts).with("State: #{nodepool.metadata.state}")
-
+      expect(subject.ui).to receive(:info).with("Updating Lan #{subject_config[:lan_id]} in the Nodepoool.")
 
       expected_body = nodepool.properties.to_hash
       expected_body[:lans] = [expected_body[:lans][1], nodepool_lan.to_hash]
@@ -146,6 +140,8 @@ describe Chef::Knife::IonoscloudNodepoolLanAdd do
       expected_body.delete(:storageType)
       expected_body.delete(:availabilityZone)
       expected_body.delete(:availableUpgradeVersions)
+      expected_body.delete(:labels)
+      expected_body.delete(:annotations)
 
       mock_call_api(
         subject,
@@ -162,7 +158,7 @@ describe Chef::Knife::IonoscloudNodepoolLanAdd do
             path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
             operation: :'KubernetesApi.k8s_nodepools_put',
             body: { properties: expected_body },
-            return_type: 'KubernetesNodePoolForPut',
+            return_type: 'KubernetesNodePool',
             result: nodepool,
           },
         ],

data/spec/chef/knife/ionoscloud_nodepool_lan_remove.rb

@@ -27,30 +27,25 @@ describe Chef::Knife::IonoscloudNodepoolLanRemove do
 
       auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
       maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+      lans = [nodepool.properties.lans[1]].map { |lan| lan.to_hash }
 
-      expect(subject.ui).to receive(:info).with("Removing Lans #{subject.name_args} from the Nodepoool.")
       expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("Datacenter ID: #{nodepool.properties.datacenter_id}")
       expect(subject).to receive(:puts).with("Node Count: #{nodepool.properties.node_count}")
-      expect(subject).to receive(:puts).with("Lans: #{[nodepool.properties.lans[1]].map do
-        |lan|
-        {
-          id: lan.id,
-          dhcp: lan.dhcp,
-          routes: lan.routes ? lan.routes.map do
-            |route|
-            {
-              network: route.network,
-              gateway_ip: route.gateway_ip,
-            }
-          end : []
-        }
-      end}")
+      expect(subject).to receive(:puts).with("CPU Family: #{nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Public IPs: #{nodepool.properties.public_ips}")
+      expect(subject).to receive(:puts).with("LANs: #{lans}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
       expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
       expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
       expect(subject).to receive(:puts).with("State: #{nodepool.metadata.state}")
-
+      expect(subject.ui).to receive(:info).with("Removing Lans #{subject.name_args} from the Nodepoool.")
 
       expected_body = nodepool.properties.to_hash
       expected_body[:lans] = [expected_body[:lans][1]]
@@ -63,6 +58,8 @@ describe Chef::Knife::IonoscloudNodepoolLanRemove do
       expected_body.delete(:storageType)
       expected_body.delete(:availabilityZone)
       expected_body.delete(:availableUpgradeVersions)
+      expected_body.delete(:labels)
+      expected_body.delete(:annotations)
 
       mock_call_api(
         subject,
@@ -79,7 +76,7 @@ describe Chef::Knife::IonoscloudNodepoolLanRemove do
             path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
             operation: :'KubernetesApi.k8s_nodepools_put',
             body: { properties: expected_body },
-            return_type: 'KubernetesNodePoolForPut',
+            return_type: 'KubernetesNodePool',
             result: nodepool,
           },
         ],

data/spec/chef/knife/ionoscloud_nodepool_update_spec.rb

@@ -0,0 +1,134 @@
+require 'spec_helper'
+require 'ionoscloud_nodepool_update'
+
+Chef::Knife::IonoscloudNodepoolUpdate.load_deps
+
+describe Chef::Knife::IonoscloudNodepoolUpdate do
+  before :each do
+    subject { Chef::Knife::IonoscloudNodepoolUpdate.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call KubernetesApi.k8s_nodepools_put' do
+      nodepool = k8s_nodepool_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        nodepool_id: nodepool.id,
+        k8s_version: '18.18.18',
+        node_count: nodepool.properties.node_count + 1,
+        public_ips: '1.1.1.1,2.2.2.2,3.3.3.3',
+        labels: { "new_test": "new_test", "new_test2": "new_test2" },
+        lans: '13',
+        maintenance_day: 'Tuesday',
+        maintenance_time: '03:48:30Z',
+        max_node_count: nodepool.properties.auto_scaling.max_node_count + 1,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{subject_config[:max_node_count]}"
+      maintenance_window = "#{subject_config[:maintenance_day]}, #{subject_config[:maintenance_time]}"
+      lans = subject_config[:lans].split(',').map { |lan| { id: lan } }
+
+      expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
+      expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
+      expect(subject).to receive(:puts).with("K8s Version: #{subject_config[:k8s_version]}")
+      expect(subject).to receive(:puts).with("Datacenter ID: #{nodepool.properties.datacenter_id}")
+      expect(subject).to receive(:puts).with("Node Count: #{subject_config[:node_count]}")
+      expect(subject).to receive(:puts).with("CPU Family: #{nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Public IPs: #{subject_config[:public_ips].split(',')}")
+      expect(subject).to receive(:puts).with("Labels: #{subject_config[:labels]}")
+      expect(subject).to receive(:puts).with("Annotations: #{nodepool.properties.annotations}")
+      expect(subject).to receive(:puts).with("LANs: #{lans}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
+      expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
+      expect(subject).to receive(:puts).with("State: #{nodepool.metadata.state}")
+
+      nodepool.properties.k8s_version = subject_config[:k8s_version]
+      nodepool.properties.node_count = subject_config[:node_count]
+      nodepool.properties.public_ips = subject_config[:public_ips].split(',')
+      nodepool.properties.labels = subject_config[:labels]
+      nodepool.properties.lans = subject_config[:lans].split(',').map { |lan| Ionoscloud::KubernetesNodePoolLan.new(id: lan) }
+      nodepool.properties.maintenance_window.day_of_the_week = subject_config[:maintenance_day]
+      nodepool.properties.maintenance_window.time = subject_config[:maintenance_time]
+      nodepool.properties.auto_scaling.max_node_count = subject_config[:max_node_count]
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_find_by_id',
+            return_type: 'KubernetesNodePool',
+            result: nodepool,
+          },
+          {
+            method: 'PUT',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_put',
+            return_type: 'KubernetesNodePool',
+            body: {
+              properties: {
+                k8sVersion: subject_config[:k8s_version],
+                nodeCount: subject_config[:node_count],
+                publicIps: subject_config[:public_ips].split(','),
+                labels: subject_config[:labels],
+                annotations: nodepool.properties.annotations,
+                lans: subject_config[:lans].split(',').map { |lan| { id: Integer(lan) } },
+                maintenanceWindow: {
+                  dayOfTheWeek: subject_config[:maintenance_day],
+                  time: subject_config[:maintenance_time],
+                },
+                autoScaling: {
+                  minNodeCount: nodepool.properties.auto_scaling.min_node_count,
+                  maxNodeCount: subject_config[:max_node_count],
+                },
+              },
+            },
+            result: nodepool,
+          },
+          {
+            method: 'GET',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_find_by_id',
+            return_type: 'KubernetesNodePool',
+            result: nodepool,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_pcc_create_spec.rb

@@ -26,11 +26,14 @@ describe Chef::Knife::IonoscloudPccCreate do
 
       subject_config.each { |key, value| subject.config[key] = value }
 
+      peers = pcc.properties.peers.map { |peer| peer.id }
+      datacenters = pcc.properties.connectable_datacenters.map { |pcc| pcc.id }
+
       expect(subject).to receive(:puts).with("ID: #{pcc.id}")
       expect(subject).to receive(:puts).with("Name: #{pcc.properties.name}")
       expect(subject).to receive(:puts).with("Description: #{pcc.properties.description}")
-      expect(subject).to receive(:puts).with("Peers: #{pcc.properties.peers.to_s}")
-      expect(subject).to receive(:puts).with("Datacenters: #{pcc.properties.connectable_datacenters.to_s}")
+      expect(subject).to receive(:puts).with("Peers: #{peers.to_s}")
+      expect(subject).to receive(:puts).with("Connectable Datacenters: #{datacenters.to_s}")
 
       3.times { mock_wait_for(subject) }
       mock_call_api(
@@ -54,7 +57,7 @@ describe Chef::Knife::IonoscloudPccCreate do
           {
             method: 'PATCH',
             path: "/datacenters/#{pcc.properties.connectable_datacenters[0].id}/lans/#{pcc.properties.peers[0].id}",
-            operation: :'LansApi.datacenters_lans_patch',
+            operation: :'LANsApi.datacenters_lans_patch',
             return_type: 'Lan',
             body: { pcc: pcc.id },
             result: pcc.properties.peers[0],
@@ -62,7 +65,7 @@ describe Chef::Knife::IonoscloudPccCreate do
           {
             method: 'PATCH',
             path: "/datacenters/#{pcc.properties.connectable_datacenters[1].id}/lans/#{pcc.properties.peers[1].id}",
-            operation: :'LansApi.datacenters_lans_patch',
+            operation: :'LANsApi.datacenters_lans_patch',
             return_type: 'Lan',
             body: { pcc: pcc.id },
             result: pcc.properties.peers[1],

data/spec/chef/knife/ionoscloud_pcc_delete_spec.rb

@@ -24,13 +24,13 @@ describe Chef::Knife::IonoscloudPccDelete do
       subject.name_args = [pcc.id]
 
       peers = pcc.properties.peers.map { |peer| peer.id }
-      datacenters = pcc.properties.connectable_datacenters.map { |datacenter| datacenter.id }
+      datacenters = pcc.properties.connectable_datacenters.map { |pcc| pcc.id }
 
       expect(subject).to receive(:puts).with("ID: #{pcc.id}")
       expect(subject).to receive(:puts).with("Name: #{pcc.properties.name}")
       expect(subject).to receive(:puts).with("Description: #{pcc.properties.description}")
       expect(subject).to receive(:puts).with("Peers: #{peers.to_s}")
-      expect(subject).to receive(:puts).with("Datacenters: #{datacenters.to_s}")
+      expect(subject).to receive(:puts).with("Connectable Datacenters: #{datacenters.to_s}")
       expect(subject.ui).to receive(:warn).with("Deleted PCC #{pcc.id}. Request ID: ")
 
       expect(subject.api_client).not_to receive(:wait_for)