knife-ionoscloud 5.1.1 → 6.0.0.beta.2

data/spec/chef/knife/ionoscloud_networkloadbalancer_update_spec.rb

@@ -0,0 +1,107 @@
+require 'spec_helper'
+require 'ionoscloud_networkloadbalancer_update'
+
+Chef::Knife::IonoscloudNetworkloadbalancerUpdate.load_deps
+
+describe Chef::Knife::IonoscloudNetworkloadbalancerUpdate do
+  before :each do
+    subject { Chef::Knife::IonoscloudNetworkloadbalancerUpdate.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call NetworkLoadBalancersApi.datacenters_networkloadbalancers_patch' do
+      network_loadbalancer = network_loadbalancer_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        network_loadbalancer_id: network_loadbalancer.id,
+        name: network_loadbalancer.properties.name + '_edited',
+        listener_lan: Integer(network_loadbalancer.properties.listener_lan) + 1,
+        target_lan: Integer(network_loadbalancer.properties.target_lan) + 1,
+        ips: (network_loadbalancer.properties.ips + ['3.3.3.3']).join(','),
+        lb_private_ips: (network_loadbalancer.properties.lb_private_ips + ['22.231.2.5/24']).join(','),
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{network_loadbalancer.id}")
+      expect(subject).to receive(:puts).with("Name: #{subject_config[:name]}")
+      expect(subject).to receive(:puts).with("Listener LAN: #{subject_config[:listener_lan]}")
+      expect(subject).to receive(:puts).with("IPS: #{subject_config[:ips].split(',')}")
+      expect(subject).to receive(:puts).with("Target LAN: #{subject_config[:target_lan]}")
+      expect(subject).to receive(:puts).with("Private IPS: #{subject_config[:lb_private_ips].split(',')}")
+      expect(subject).to receive(:puts).with("Forwarding Rules: #{network_loadbalancer.entities.forwardingrules.items.map do |rule|
+        {
+          id: rule.id,
+          name: rule.properties.name,
+          algorithm: rule.properties.algorithm,
+          protocol: rule.properties.protocol,
+          listener_ip: rule.properties.listener_ip,
+          listener_port: rule.properties.listener_port,
+          health_check: rule.properties.health_check.nil? ? nil : rule.properties.health_check.to_hash,
+          targets: (rule.properties.targets.nil? ? [] : rule.properties.targets.map { |target| target.to_hash }),
+        }
+      end}")
+      expect(subject).to receive(:puts).with("Flowlogs: #{network_loadbalancer.entities.flowlogs.items.map { |flowlog| flowlog.id }}")
+
+      network_loadbalancer.properties.name = subject_config[:name]
+      network_loadbalancer.properties.ips = subject_config[:ips].split(',')
+      network_loadbalancer.properties.lb_private_ips = subject_config[:lb_private_ips].split(',')
+      network_loadbalancer.properties.listener_lan = subject_config[:listener_lan]
+      network_loadbalancer.properties.target_lan = subject_config[:target_lan]
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_patch',
+            return_type: 'NetworkLoadBalancer',
+            body: {
+              name: subject_config[:name],
+              ips: subject_config[:ips].split(','),
+              lbPrivateIps: subject_config[:lb_private_ips].split(','),
+              listenerLan: subject_config[:listener_lan],
+              targetLan: subject_config[:target_lan],
+            },
+            result: network_loadbalancer,
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_find_by_network_load_balancer_id',
+            return_type: 'NetworkLoadBalancer',
+            result: network_loadbalancer,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_nic_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudNicCreate do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_post with the expected arguments and output based on what it receives' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_post with the expected arguments and output based on what it receives' do
       nic = nic_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -23,7 +23,7 @@ describe Chef::Knife::IonoscloudNicCreate do
         name: nic.properties.name,
         dhcp: nic.properties.dhcp,
         ips: nic.properties.ips.join(','),
-        nat: nic.properties.nat,
+        firewall_type: 'INGRESS',
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
@@ -31,13 +31,17 @@ describe Chef::Knife::IonoscloudNicCreate do
       expected_body = nic.properties.to_hash
       expected_body.delete(:firewallActive)
       expected_body.delete(:mac)
+      expected_body.delete(:deviceNumber)
+      expected_body.delete(:pciSlot)
 
       expect(subject).to receive(:puts).with("ID: #{nic.id}")
       expect(subject).to receive(:puts).with("Name: #{nic.properties.name}")
       expect(subject).to receive(:puts).with("IPs: #{nic.properties.ips.to_s}")
       expect(subject).to receive(:puts).with("DHCP: #{nic.properties.dhcp}")
       expect(subject).to receive(:puts).with("LAN: #{nic.properties.lan}")
-      expect(subject).to receive(:puts).with("NAT: #{nic.properties.nat}")
+      expect(subject).to receive(:puts).with("Firewall Type: #{nic.properties.firewall_type}")
+      expect(subject).to receive(:puts).with("Device Number: #{nic.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{nic.properties.pci_slot}")
 
       mock_wait_for(subject)
       mock_call_api(
@@ -46,7 +50,7 @@ describe Chef::Knife::IonoscloudNicCreate do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics",
-            operation: :'NicApi.datacenters_servers_nics_post',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_post',
             return_type: 'Nic',
             body: { properties: expected_body },
             result: nic,
@@ -54,7 +58,7 @@ describe Chef::Knife::IonoscloudNicCreate do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic.id}",
-            operation: :'NicApi.datacenters_servers_nics_find_by_id',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
             return_type: 'Nic',
             result: nic,
           },

data/spec/chef/knife/ionoscloud_nic_delete_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudNicDelete do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_delete when the ID is valid' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_delete when the ID is valid' do
       nic = nic_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -30,7 +30,9 @@ describe Chef::Knife::IonoscloudNicDelete do
       expect(subject).to receive(:puts).with("IPs: #{nic.properties.ips.to_s}")
       expect(subject).to receive(:puts).with("DHCP: #{nic.properties.dhcp}")
       expect(subject).to receive(:puts).with("LAN: #{nic.properties.lan}")
-      expect(subject).to receive(:puts).with("NAT: #{nic.properties.nat}")
+      expect(subject).to receive(:puts).with("Firewall Type: #{nic.properties.firewall_type}")
+      expect(subject).to receive(:puts).with("Device Number: #{nic.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{nic.properties.pci_slot}")
       expect(subject.ui).to receive(:warn).with("Deleted Nic #{nic.id}. Request ID: ")
 
       expect(subject.api_client).not_to receive(:wait_for)
@@ -41,14 +43,14 @@ describe Chef::Knife::IonoscloudNicDelete do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic.id}",
-            operation: :'NicApi.datacenters_servers_nics_find_by_id',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
             return_type: 'Nic',
             result: nic,
           },
           {
             method: 'DELETE',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic.id}",
-            operation: :'NicApi.datacenters_servers_nics_delete',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_delete',
           },
         ],
       )
@@ -56,7 +58,7 @@ describe Chef::Knife::IonoscloudNicDelete do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call NicApi.datacenters_servers_nics_delete when the user ID is not valid' do
+    it 'should not call NetworkInterfacesApi.datacenters_servers_nics_delete when the user ID is not valid' do
       nic_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -77,7 +79,7 @@ describe Chef::Knife::IonoscloudNicDelete do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic_id}",
-            operation: :'NicApi.datacenters_servers_nics_find_by_id',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
             return_type: 'Nic',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_nic_get_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+require 'ionoscloud_nic_get'
+
+Chef::Knife::IonoscloudNicGet.load_deps
+
+describe Chef::Knife::IonoscloudNicGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudNicGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_find_by_id' do
+      nic = nic_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        server_id: 'server_id',
+        nic_id: nic.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{nic.id}")
+      expect(subject).to receive(:puts).with("Name: #{nic.properties.name}")
+      expect(subject).to receive(:puts).with("IPs: #{nic.properties.ips.to_s}")
+      expect(subject).to receive(:puts).with("DHCP: #{nic.properties.dhcp}")
+      expect(subject).to receive(:puts).with("LAN: #{nic.properties.lan}")
+      expect(subject).to receive(:puts).with("Firewall Type: #{nic.properties.firewall_type}")
+      expect(subject).to receive(:puts).with("Device Number: #{nic.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{nic.properties.pci_slot}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{subject_config[:nic_id]}",
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
+            return_type: 'Nic',
+            result: nic,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_nic_list_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudNicList do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_get' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_get' do
       nics = nics_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -28,23 +28,29 @@ describe Chef::Knife::IonoscloudNicList do
         subject.ui.color('Name', :bold),
         subject.ui.color('IPs', :bold),
         subject.ui.color('DHCP', :bold),
-        subject.ui.color('NAT', :bold),
         subject.ui.color('LAN', :bold),
+        subject.ui.color('Firewall Type', :bold),
+        subject.ui.color('Device Number', :bold),
+        subject.ui.color('PCI Slot', :bold),
         nics.items.first.id,
         nics.items.first.properties.name,
         nics.items.first.properties.ips.to_s,
         nics.items.first.properties.dhcp.to_s,
-        nics.items.first.properties.nat.to_s,
         nics.items.first.properties.lan.to_s,
+        nics.items.first.properties.firewall_type.to_s,
+        nics.items.first.properties.device_number.to_s,
+        nics.items.first.properties.pci_slot.to_s,
         nics.items[1].id,
         nics.items[1].properties.name,
         nics.items[1].properties.ips.to_s,
         nics.items[1].properties.dhcp.to_s,
-        nics.items[1].properties.nat.to_s,
         nics.items[1].properties.lan.to_s,
+        nics.items[1].properties.firewall_type.to_s,
+        nics.items[1].properties.device_number.to_s,
+        nics.items[1].properties.pci_slot.to_s,
       ]
 
-      expect(subject.ui).to receive(:list).with(nic_list, :uneven_columns_across, 6)
+      expect(subject.ui).to receive(:list).with(nic_list, :uneven_columns_across, 8)
 
       mock_call_api(
         subject,
@@ -52,7 +58,7 @@ describe Chef::Knife::IonoscloudNicList do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics",
-            operation: :'NicApi.datacenters_servers_nics_get',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_get',
             return_type: 'Nics',
             result: nics,
           },

data/spec/chef/knife/ionoscloud_nic_update_spec.rb

@@ -0,0 +1,97 @@
+require 'spec_helper'
+require 'ionoscloud_nic_update'
+
+Chef::Knife::IonoscloudNicUpdate.load_deps
+
+describe Chef::Knife::IonoscloudNicUpdate do
+  before :each do
+    subject { Chef::Knife::IonoscloudNicUpdate.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_patch' do
+      nic = nic_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        server_id: 'server_id',
+        nic_id: nic.id,
+        lan: 13,
+        name: nic.properties.name + '_edited',
+        dhcp: (!nic.properties.dhcp).to_s,
+        ips: (nic.properties.ips + ['3.3.3.3']).join(','),
+        firewall_type: 'EGRESS',
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{nic.id}")
+      expect(subject).to receive(:puts).with("Name: #{subject_config[:name]}")
+      expect(subject).to receive(:puts).with("IPs: #{subject_config[:ips].split(',')}")
+      expect(subject).to receive(:puts).with("DHCP: #{subject_config[:dhcp]}")
+      expect(subject).to receive(:puts).with("LAN: #{subject_config[:lan]}")
+      expect(subject).to receive(:puts).with("Firewall Type: #{subject_config[:firewall_type]}")
+      expect(subject).to receive(:puts).with("Device Number: #{nic.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{nic.properties.pci_slot}")
+
+      nic.properties.name = subject_config[:name]
+      nic.properties.dhcp = subject_config[:dhcp].to_s.downcase == 'true'
+      nic.properties.ips = subject_config[:ips].split(',')
+      nic.properties.lan = subject_config[:lan]
+      nic.properties.firewall_type = subject_config[:firewall_type]
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{subject_config[:nic_id]}",
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_patch',
+            return_type: 'Nic',
+            body: {
+              name: subject_config[:name],
+              dhcp: subject_config[:dhcp].to_s.downcase == 'true',
+              ips: subject_config[:ips].split(','),
+              lan: subject_config[:lan],
+              firewallType: subject_config[:firewall_type],
+            },
+            result: nic,
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{subject_config[:nic_id]}",
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
+            return_type: 'Nic',
+            result: nic,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_node_get_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'ionoscloud_node_get'
+
+Chef::Knife::IonoscloudNodeGet.load_deps
+
+describe Chef::Knife::IonoscloudNodeGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudNodeGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call KubernetesApi.k8s_nodepools_nodes_find_by_id' do
+      k8s_node = k8s_node_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        nodepool_id: 'nodepool_id',
+        node_id: k8s_node.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{k8s_node.id}")
+      expect(subject).to receive(:puts).with("Name: #{k8s_node.properties.name}")
+      expect(subject).to receive(:puts).with("Public IP: #{k8s_node.properties.public_ip}")
+      expect(subject).to receive(:puts).with("Private IP: #{k8s_node.properties.private_ip}")
+      expect(subject).to receive(:puts).with("K8s Version: #{k8s_node.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("State: #{k8s_node.metadata.state}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}/nodes/#{subject_config[:node_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_nodes_find_by_id',
+            return_type: 'KubernetesNode',
+            result: k8s_node,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_nodepool_create_spec.rb

@@ -32,19 +32,21 @@ describe Chef::Knife::IonoscloudNodepoolCreate do
         storage_size: nodepool.properties.storage_size,
         min_node_count: nodepool.properties.auto_scaling.min_node_count,
         max_node_count: nodepool.properties.auto_scaling.max_node_count,
+        labels: nodepool.properties.labels,
+        annotations: nodepool.properties.annotations,
         lans: nodepool.properties.lans.map { |lan| lan.id }.join(','),
-        public_ips: nodepool.properties.public_ips.join(','),
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
 
-      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
-      maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
-
       expected_body = nodepool.properties.to_hash
-      expected_body[:lans].map! { |lan| lan.delete(:properties); lan[:id] = Integer(lan[:id]); lan }
+      expected_body[:lans].map! { |lan| lan.delete(:dhcp); lan.delete(:routes); lan[:id] = Integer(lan[:id]); lan }
+      expected_body.delete(:publicIps)
       expected_body.delete(:availableUpgradeVersions)
 
+      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
+      maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+
       expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
@@ -55,6 +57,9 @@ describe Chef::Knife::IonoscloudNodepoolCreate do
       expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
       expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
       expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Labels: #{nodepool.properties.labels}")
+      expect(subject).to receive(:puts).with("Annotations: #{nodepool.properties.annotations}")
+      expect(subject).to receive(:puts).with("LANs: #{nodepool.properties.lans.map { |lan| lan.to_hash }}")
       expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
       expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
       expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")

data/spec/chef/knife/ionoscloud_nodepool_delete_spec.rb

@@ -24,11 +24,25 @@ describe Chef::Knife::IonoscloudNodepoolDelete do
       subject_config.each { |key, value| subject.config[key] = value }
       subject.name_args = [k8s_nodepool.id]
 
+      auto_scaling = "Min node count: #{k8s_nodepool.properties.auto_scaling.min_node_count}, Max node count:#{k8s_nodepool.properties.auto_scaling.max_node_count}"
+      maintenance_window = "#{k8s_nodepool.properties.maintenance_window.day_of_the_week}, #{k8s_nodepool.properties.maintenance_window.time}"
+
       expect(subject).to receive(:puts).with("ID: #{k8s_nodepool.id}")
       expect(subject).to receive(:puts).with("Name: #{k8s_nodepool.properties.name}")
       expect(subject).to receive(:puts).with("K8s Version: #{k8s_nodepool.properties.k8s_version}")
       expect(subject).to receive(:puts).with("Datacenter ID: #{k8s_nodepool.properties.datacenter_id}")
       expect(subject).to receive(:puts).with("Node Count: #{k8s_nodepool.properties.node_count}")
+      expect(subject).to receive(:puts).with("CPU Family: #{k8s_nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{k8s_nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{k8s_nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{k8s_nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{k8s_nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Labels: #{k8s_nodepool.properties.labels}")
+      expect(subject).to receive(:puts).with("Annotations: #{k8s_nodepool.properties.annotations}")
+      expect(subject).to receive(:puts).with("LANs: #{k8s_nodepool.properties.lans.map { |lan| lan.to_hash }}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{k8s_nodepool.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
+      expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
       expect(subject).to receive(:puts).with("State: #{k8s_nodepool.metadata.state}")
       expect(subject.ui).to receive(:warn).with("Deleted K8s Nodepool #{k8s_nodepool.id}.")
 

data/spec/chef/knife/ionoscloud_nodepool_get_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+require 'ionoscloud_nodepool_get'
+
+Chef::Knife::IonoscloudNodepoolGet.load_deps
+
+describe Chef::Knife::IonoscloudNodepoolGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudNodepoolGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call KubernetesApi.k8s_nodepools_nodes_find_by_id' do
+      nodepool = k8s_nodepool_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        cluster_id: 'cluster_id',
+        nodepool_id: nodepool.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      auto_scaling = "Min node count: #{nodepool.properties.auto_scaling.min_node_count}, Max node count:#{nodepool.properties.auto_scaling.max_node_count}"
+      maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
+      lans = nodepool.properties.lans.map { |lan| lan.to_hash }
+
+      expect(subject).to receive(:puts).with("ID: #{nodepool.id}")
+      expect(subject).to receive(:puts).with("Name: #{nodepool.properties.name}")
+      expect(subject).to receive(:puts).with("K8s Version: #{nodepool.properties.k8s_version}")
+      expect(subject).to receive(:puts).with("Datacenter ID: #{nodepool.properties.datacenter_id}")
+      expect(subject).to receive(:puts).with("Node Count: #{nodepool.properties.node_count}")
+      expect(subject).to receive(:puts).with("CPU Family: #{nodepool.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Cores Count: #{nodepool.properties.cores_count}")
+      expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
+      expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
+      expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Public IPs: #{nodepool.properties.public_ips}")
+      expect(subject).to receive(:puts).with("LANs: #{lans}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
+      expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")
+      expect(subject).to receive(:puts).with("State: #{nodepool.metadata.state}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/k8s/#{subject_config[:cluster_id]}/nodepools/#{subject_config[:nodepool_id]}",
+            operation: :'KubernetesApi.k8s_nodepools_find_by_id',
+            return_type: 'KubernetesNodePool',
+            result: nodepool,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end