knife-ionoscloud 5.1.0 → 6.0.0.alpha.1

data/spec/chef/knife/ionoscloud_networkloadbalancer_rule_target_remove_spec.rb

@@ -0,0 +1,263 @@
+require 'spec_helper'
+require 'ionoscloud_networkloadbalancer_rule_target_remove'
+
+Chef::Knife::IonoscloudNetworkloadbalancerRuleTargetRemove.load_deps
+
+describe Chef::Knife::IonoscloudNetworkloadbalancerRuleTargetRemove do
+  before :each do
+    subject { Chef::Knife::IonoscloudNetworkloadbalancerRuleTargetRemove.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_patch_with_http_info' do
+      network_loadbalancer = network_loadbalancer_mock
+      network_loadbalancer_rule = network_loadbalancer_rule_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        network_loadbalancer_id: network_loadbalancer.id,
+        forwarding_rule_id: network_loadbalancer_rule.id,
+        ip: network_loadbalancer_rule.properties.targets.first.ip,
+        port: network_loadbalancer_rule.properties.targets.first.port,
+        yes: true,
+      }
+
+      remaining_targets = network_loadbalancer_rule.properties.targets.reject do
+        |target|
+        target.ip == subject_config[:ip] && target.port == subject_config[:port]
+      end
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{network_loadbalancer_rule.id}")
+      expect(subject).to receive(:puts).with("Name: #{network_loadbalancer_rule.properties.name}")
+      expect(subject).to receive(:puts).with("Algorithm: #{network_loadbalancer_rule.properties.algorithm}")
+      expect(subject).to receive(:puts).with("Protocol: #{network_loadbalancer_rule.properties.protocol}")
+      expect(subject).to receive(:puts).with("Listener IP: #{network_loadbalancer_rule.properties.listener_ip}")
+      expect(subject).to receive(:puts).with("Listener Port: #{network_loadbalancer_rule.properties.listener_port}")
+      expect(subject).to receive(:puts).with("Health Check: #{network_loadbalancer_rule.properties.health_check}")
+      expect(subject).to receive(:puts).with("Targets: #{remaining_targets.map do |target|
+        {
+          ip: target.ip,
+          port: target.port,
+          weight: target.weight,
+          check: target.health_check.check,
+          check_interval: target.health_check.check_interval,
+          maintenance: target.health_check.maintenance,
+        }
+      end}")
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_find_by_forwarding_rule_id',
+            return_type: 'NetworkLoadBalancerForwardingRule',
+            result: network_loadbalancer_rule,
+          },
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_patch',
+            body: { targets: remaining_targets.map { |target| target.to_hash } },
+            return_type: 'NetworkLoadBalancerForwardingRule',
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_find_by_forwarding_rule_id',
+            return_type: 'NetworkLoadBalancerForwardingRule',
+            result: network_loadbalancer_rule,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should call NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_patch_with_http_info 2' do
+      network_loadbalancer = network_loadbalancer_mock
+      network_loadbalancer_rule = network_loadbalancer_rule_mock(
+        targets: [
+          network_loadbalancer_rule_target_mock(
+            port: 123, ip: '1.1.1.1', check_interval: 2345, maintenance: true, check: true, weight: 13,
+          ),
+          network_loadbalancer_rule_target_mock(
+            port: 1234, ip: '1.1.122.1', check_interval: 1231, maintenance: true, check: false, weight: 456,
+          ),
+          network_loadbalancer_rule_target_mock(
+            port: 112, ip: '1.133.1.1', check_interval: 2525, maintenance: true, check: true, weight: 425,
+          ),
+          network_loadbalancer_rule_target_mock(
+            port: 123, ip: '1.133.1.1', check_interval: 36346, maintenance: false, check: false, weight: 4,
+          ),
+          network_loadbalancer_rule_target_mock(
+            port: 164, ip: '1.1.1.1', check_interval: 243, maintenance: true, check: false, weight: 123,
+          ),
+        ]
+      )
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        network_loadbalancer_id: network_loadbalancer.id,
+        forwarding_rule_id: network_loadbalancer_rule.id,
+        ip: network_loadbalancer_rule.properties.targets.first.ip,
+        port: network_loadbalancer_rule.properties.targets.first.port,
+        yes: true,
+      }
+
+      remaining_targets = network_loadbalancer_rule.properties.targets.reject do
+        |target|
+        target.ip == subject_config[:ip] && target.port == subject_config[:port]
+      end
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{network_loadbalancer_rule.id}")
+      expect(subject).to receive(:puts).with("Name: #{network_loadbalancer_rule.properties.name}")
+      expect(subject).to receive(:puts).with("Algorithm: #{network_loadbalancer_rule.properties.algorithm}")
+      expect(subject).to receive(:puts).with("Protocol: #{network_loadbalancer_rule.properties.protocol}")
+      expect(subject).to receive(:puts).with("Listener IP: #{network_loadbalancer_rule.properties.listener_ip}")
+      expect(subject).to receive(:puts).with("Listener Port: #{network_loadbalancer_rule.properties.listener_port}")
+      expect(subject).to receive(:puts).with("Health Check: #{network_loadbalancer_rule.properties.health_check}")
+      expect(subject).to receive(:puts).with("Targets: #{remaining_targets.map do |target|
+        {
+          ip: target.ip,
+          port: target.port,
+          weight: target.weight,
+          check: target.health_check.check,
+          check_interval: target.health_check.check_interval,
+          maintenance: target.health_check.maintenance,
+        }
+      end}")
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_find_by_forwarding_rule_id',
+            return_type: 'NetworkLoadBalancerForwardingRule',
+            result: network_loadbalancer_rule,
+          },
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_patch',
+            body: { targets: remaining_targets.map { |target| target.to_hash } },
+            return_type: 'NetworkLoadBalancerForwardingRule',
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_find_by_forwarding_rule_id',
+            return_type: 'NetworkLoadBalancerForwardingRule',
+            result: network_loadbalancer_rule,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not call NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_patch_with_http_info when no target exists' do
+      network_loadbalancer = network_loadbalancer_mock
+      network_loadbalancer_rule = network_loadbalancer_rule_mock(
+        targets: [
+          network_loadbalancer_rule_target_mock(
+            port: 123, ip: '1.1.1.1', check_interval: 2345, maintenance: true, check: true, weight: 13,
+          ),
+        ]
+      )
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        network_loadbalancer_id: network_loadbalancer.id,
+        forwarding_rule_id: network_loadbalancer_rule.id,
+        ip: '1.1.1.2',
+        port: 123,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{network_loadbalancer_rule.id}")
+      expect(subject).to receive(:puts).with("Name: #{network_loadbalancer_rule.properties.name}")
+      expect(subject).to receive(:puts).with("Algorithm: #{network_loadbalancer_rule.properties.algorithm}")
+      expect(subject).to receive(:puts).with("Protocol: #{network_loadbalancer_rule.properties.protocol}")
+      expect(subject).to receive(:puts).with("Listener IP: #{network_loadbalancer_rule.properties.listener_ip}")
+      expect(subject).to receive(:puts).with("Listener Port: #{network_loadbalancer_rule.properties.listener_port}")
+      expect(subject).to receive(:puts).with("Health Check: #{network_loadbalancer_rule.properties.health_check}")
+      expect(subject).to receive(:puts).with("Targets: #{network_loadbalancer_rule.properties.targets.map do |target|
+        {
+          ip: target.ip,
+          port: target.port,
+          weight: target.weight,
+          check: target.health_check.check,
+          check_interval: target.health_check.check_interval,
+          maintenance: target.health_check.maintenance,
+        }
+      end}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_find_by_forwarding_rule_id',
+            return_type: 'NetworkLoadBalancerForwardingRule',
+            result: network_loadbalancer_rule,
+          },
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/networkloadbalancers/#{subject_config[:network_loadbalancer_id]}"\
+            "/forwardingrules/#{subject_config[:forwarding_rule_id]}",
+            operation: :'NetworkLoadBalancersApi.datacenters_networkloadbalancers_forwardingrules_find_by_forwarding_rule_id',
+            return_type: 'NetworkLoadBalancerForwardingRule',
+            result: network_loadbalancer_rule,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_nic_create_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudNicCreate do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_post with the expected arguments and output based on what it receives' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_post with the expected arguments and output based on what it receives' do
       nic = nic_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -23,7 +23,7 @@ describe Chef::Knife::IonoscloudNicCreate do
         name: nic.properties.name,
         dhcp: nic.properties.dhcp,
         ips: nic.properties.ips.join(','),
-        nat: nic.properties.nat,
+        firewall_type: 'INGRESS',
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
@@ -31,13 +31,17 @@ describe Chef::Knife::IonoscloudNicCreate do
       expected_body = nic.properties.to_hash
       expected_body.delete(:firewallActive)
       expected_body.delete(:mac)
+      expected_body.delete(:deviceNumber)
+      expected_body.delete(:pciSlot)
 
       expect(subject).to receive(:puts).with("ID: #{nic.id}")
       expect(subject).to receive(:puts).with("Name: #{nic.properties.name}")
       expect(subject).to receive(:puts).with("IPs: #{nic.properties.ips.to_s}")
       expect(subject).to receive(:puts).with("DHCP: #{nic.properties.dhcp}")
       expect(subject).to receive(:puts).with("LAN: #{nic.properties.lan}")
-      expect(subject).to receive(:puts).with("NAT: #{nic.properties.nat}")
+      expect(subject).to receive(:puts).with("Firewall Type: #{nic.properties.firewall_type}")
+      expect(subject).to receive(:puts).with("Device Number: #{nic.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{nic.properties.pci_slot}")
 
       mock_wait_for(subject)
       mock_call_api(
@@ -46,7 +50,7 @@ describe Chef::Knife::IonoscloudNicCreate do
           {
             method: 'POST',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics",
-            operation: :'NicApi.datacenters_servers_nics_post',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_post',
             return_type: 'Nic',
             body: { properties: expected_body },
             result: nic,
@@ -54,7 +58,7 @@ describe Chef::Knife::IonoscloudNicCreate do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic.id}",
-            operation: :'NicApi.datacenters_servers_nics_find_by_id',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
             return_type: 'Nic',
             result: nic,
           },

data/spec/chef/knife/ionoscloud_nic_delete_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudNicDelete do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_delete when the ID is valid' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_delete when the ID is valid' do
       nic = nic_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -30,7 +30,9 @@ describe Chef::Knife::IonoscloudNicDelete do
       expect(subject).to receive(:puts).with("IPs: #{nic.properties.ips.to_s}")
       expect(subject).to receive(:puts).with("DHCP: #{nic.properties.dhcp}")
       expect(subject).to receive(:puts).with("LAN: #{nic.properties.lan}")
-      expect(subject).to receive(:puts).with("NAT: #{nic.properties.nat}")
+      expect(subject).to receive(:puts).with("Firewall Type: #{nic.properties.firewall_type}")
+      expect(subject).to receive(:puts).with("Device Number: #{nic.properties.device_number}")
+      expect(subject).to receive(:puts).with("PCI Slot: #{nic.properties.pci_slot}")
       expect(subject.ui).to receive(:warn).with("Deleted Nic #{nic.id}. Request ID: ")
 
       expect(subject.api_client).not_to receive(:wait_for)
@@ -41,14 +43,14 @@ describe Chef::Knife::IonoscloudNicDelete do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic.id}",
-            operation: :'NicApi.datacenters_servers_nics_find_by_id',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
             return_type: 'Nic',
             result: nic,
           },
           {
             method: 'DELETE',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic.id}",
-            operation: :'NicApi.datacenters_servers_nics_delete',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_delete',
           },
         ],
       )
@@ -56,7 +58,7 @@ describe Chef::Knife::IonoscloudNicDelete do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should not call NicApi.datacenters_servers_nics_delete when the user ID is not valid' do
+    it 'should not call NetworkInterfacesApi.datacenters_servers_nics_delete when the user ID is not valid' do
       nic_id = 'invalid_id'
       subject_config = {
         ionoscloud_username: 'email',
@@ -77,7 +79,7 @@ describe Chef::Knife::IonoscloudNicDelete do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics/#{nic_id}",
-            operation: :'NicApi.datacenters_servers_nics_find_by_id',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_find_by_id',
             return_type: 'Nic',
             exception: Ionoscloud::ApiError.new(code: 404),
           },

data/spec/chef/knife/ionoscloud_nic_list_spec.rb

@@ -12,7 +12,7 @@ describe Chef::Knife::IonoscloudNicList do
   end
 
   describe '#run' do
-    it 'should call NicApi.datacenters_servers_nics_get' do
+    it 'should call NetworkInterfacesApi.datacenters_servers_nics_get' do
       nics = nics_mock
       subject_config = {
         ionoscloud_username: 'email',
@@ -28,23 +28,29 @@ describe Chef::Knife::IonoscloudNicList do
         subject.ui.color('Name', :bold),
         subject.ui.color('IPs', :bold),
         subject.ui.color('DHCP', :bold),
-        subject.ui.color('NAT', :bold),
         subject.ui.color('LAN', :bold),
+        subject.ui.color('Firewall Type', :bold),
+        subject.ui.color('Device Number', :bold),
+        subject.ui.color('PCI Slot', :bold),
         nics.items.first.id,
         nics.items.first.properties.name,
         nics.items.first.properties.ips.to_s,
         nics.items.first.properties.dhcp.to_s,
-        nics.items.first.properties.nat.to_s,
         nics.items.first.properties.lan.to_s,
+        nics.items.first.properties.firewall_type.to_s,
+        nics.items.first.properties.device_number.to_s,
+        nics.items.first.properties.pci_slot.to_s,
         nics.items[1].id,
         nics.items[1].properties.name,
         nics.items[1].properties.ips.to_s,
         nics.items[1].properties.dhcp.to_s,
-        nics.items[1].properties.nat.to_s,
         nics.items[1].properties.lan.to_s,
+        nics.items[1].properties.firewall_type.to_s,
+        nics.items[1].properties.device_number.to_s,
+        nics.items[1].properties.pci_slot.to_s,
       ]
 
-      expect(subject.ui).to receive(:list).with(nic_list, :uneven_columns_across, 6)
+      expect(subject.ui).to receive(:list).with(nic_list, :uneven_columns_across, 8)
 
       mock_call_api(
         subject,
@@ -52,7 +58,7 @@ describe Chef::Knife::IonoscloudNicList do
           {
             method: 'GET',
             path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}/nics",
-            operation: :'NicApi.datacenters_servers_nics_get',
+            operation: :'NetworkInterfacesApi.datacenters_servers_nics_get',
             return_type: 'Nics',
             result: nics,
           },

data/spec/chef/knife/ionoscloud_nodepool_create_spec.rb

@@ -41,7 +41,7 @@ describe Chef::Knife::IonoscloudNodepoolCreate do
       maintenance_window = "#{nodepool.properties.maintenance_window.day_of_the_week}, #{nodepool.properties.maintenance_window.time}"
 
       expected_body = nodepool.properties.to_hash
-      expected_body[:lans].map! { |lan| lan.delete(:properties); lan[:id] = Integer(lan[:id]); lan }
+      expected_body[:lans].map! { |lan| lan.delete(:dhcp); lan.delete(:routes); lan[:id] = Integer(lan[:id]); lan }
       expected_body.delete(:publicIps)
       expected_body.delete(:availableUpgradeVersions)
 
@@ -55,6 +55,20 @@ describe Chef::Knife::IonoscloudNodepoolCreate do
       expect(subject).to receive(:puts).with("RAM: #{nodepool.properties.ram_size}")
       expect(subject).to receive(:puts).with("Storage Type: #{nodepool.properties.storage_type}")
       expect(subject).to receive(:puts).with("Storage Size: #{nodepool.properties.storage_size}")
+      expect(subject).to receive(:puts).with("Lans: #{nodepool.properties.lans.map do
+        |lan|
+        {
+          id: lan.id,
+          dhcp: lan.dhcp,
+          routes: lan.routes ? lan.routes.map do
+            |route|
+            {
+              network: route.network,
+              gateway_ip: route.gateway_ip,
+            }
+          end : []
+        }
+      end}")
       expect(subject).to receive(:puts).with("Availability Zone: #{nodepool.properties.availability_zone}")
       expect(subject).to receive(:puts).with("Auto Scaling: #{auto_scaling}")
       expect(subject).to receive(:puts).with("Maintenance Window: #{maintenance_window}")