knife-ionoscloud 5.0.0.beta.1 → 5.1.2

data/spec/chef/knife/ionoscloud_pcc_create_spec.rb

@@ -14,24 +14,28 @@ describe Chef::Knife::IonoscloudPccCreate do
   describe '#run' do
     it 'should call PrivateCrossConnectApi.pccs_post with the expected arguments and output based on what it receives' do
       pcc = pcc_mock
+      datacenter_ids = pcc.properties.connectable_datacenters.map { |datacenter| datacenter.id }
+      lan_ids = pcc.properties.peers.map { |peer| peer.id }
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
         name: pcc.properties.name,
         description: pcc.properties.description,
-        peers: pcc.properties.peers.join(','),
-        datacenters: pcc.properties.connectable_datacenters.join(','),
+        peers: datacenter_ids.zip(lan_ids).flatten.compact.join(','),
       }
 
       subject_config.each { |key, value| subject.config[key] = value }
 
+      peers = pcc.properties.peers.map { |peer| peer.id }
+      datacenters = pcc.properties.connectable_datacenters.map { |datacenter| datacenter.id }
+
       expect(subject).to receive(:puts).with("ID: #{pcc.id}")
       expect(subject).to receive(:puts).with("Name: #{pcc.properties.name}")
       expect(subject).to receive(:puts).with("Description: #{pcc.properties.description}")
-      expect(subject).to receive(:puts).with("Peers: #{pcc.properties.peers.to_s}")
-      expect(subject).to receive(:puts).with("Datacenters: #{pcc.properties.connectable_datacenters.to_s}")
+      expect(subject).to receive(:puts).with("Peers: #{peers.to_s}")
+      expect(subject).to receive(:puts).with("Connectable Datacenters: #{datacenters.to_s}")
 
-      mock_wait_for(subject)
+      3.times { mock_wait_for(subject) }
       mock_call_api(
         subject,
         [
@@ -43,6 +47,36 @@ describe Chef::Knife::IonoscloudPccCreate do
             body: { properties: { name: pcc.properties.name, description: pcc.properties.description } },
             result: pcc,
           },
+          {
+            method: 'GET',
+            path: "/pccs/#{pcc.id}",
+            operation: :'PrivateCrossConnectApi.pccs_find_by_id',
+            return_type: 'PrivateCrossConnect',
+            result: pcc,
+          },
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{pcc.properties.connectable_datacenters[0].id}/lans/#{pcc.properties.peers[0].id}",
+            operation: :'LanApi.datacenters_lans_patch',
+            return_type: 'Lan',
+            body: { pcc: pcc.id },
+            result: pcc.properties.peers[0],
+          },
+          {
+            method: 'PATCH',
+            path: "/datacenters/#{pcc.properties.connectable_datacenters[1].id}/lans/#{pcc.properties.peers[1].id}",
+            operation: :'LanApi.datacenters_lans_patch',
+            return_type: 'Lan',
+            body: { pcc: pcc.id },
+            result: pcc.properties.peers[1],
+          },
+          {
+            method: 'GET',
+            path: "/pccs/#{pcc.id}",
+            operation: :'PrivateCrossConnectApi.pccs_find_by_id',
+            return_type: 'PrivateCrossConnect',
+            result: pcc,
+          },
         ],
       )
 

data/spec/chef/knife/ionoscloud_pcc_delete_spec.rb

@@ -30,7 +30,7 @@ describe Chef::Knife::IonoscloudPccDelete do
       expect(subject).to receive(:puts).with("Name: #{pcc.properties.name}")
       expect(subject).to receive(:puts).with("Description: #{pcc.properties.description}")
       expect(subject).to receive(:puts).with("Peers: #{peers.to_s}")
-      expect(subject).to receive(:puts).with("Datacenters: #{datacenters.to_s}")
+      expect(subject).to receive(:puts).with("Connectable Datacenters: #{datacenters.to_s}")
       expect(subject.ui).to receive(:warn).with("Deleted PCC #{pcc.id}. Request ID: ")
 
       expect(subject.api_client).not_to receive(:wait_for)

data/spec/chef/knife/ionoscloud_pcc_get_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+require 'ionoscloud_pcc_get'
+
+Chef::Knife::IonoscloudPccGet.load_deps
+
+describe Chef::Knife::IonoscloudPccGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudPccGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call PrivateCrossConnectApi.pccs_find_by_id' do
+      pcc = pcc_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        pcc_id: pcc.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+
+      peers = pcc.properties.peers.map { |peer| peer.id }
+      datacenters = pcc.properties.connectable_datacenters.map { |pcc| pcc.id }
+
+      expect(subject).to receive(:puts).with("ID: #{pcc.id}")
+      expect(subject).to receive(:puts).with("Name: #{pcc.properties.name}")
+      expect(subject).to receive(:puts).with("Description: #{pcc.properties.description}")
+      expect(subject).to receive(:puts).with("Peers: #{peers.to_s}")
+      expect(subject).to receive(:puts).with("Connectable Datacenters: #{datacenters.to_s}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/pccs/#{pcc.id}",
+            operation: :'PrivateCrossConnectApi.pccs_find_by_id',
+            return_type: 'PrivateCrossConnect',
+            result: pcc,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_pcc_update_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+require 'ionoscloud_pcc_update'
+
+Chef::Knife::IonoscloudPccUpdate.load_deps
+
+describe Chef::Knife::IonoscloudPccUpdate do
+  before :each do
+    subject { Chef::Knife::IonoscloudPccUpdate.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call PrivateCrossConnectApi.pccs_patch' do
+      pcc = pcc_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        pcc_id: pcc.id,
+        name: pcc.properties.name + '_edited',
+        description: pcc.properties.description + '_edited',
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      peers = pcc.properties.peers.map { |peer| peer.id }
+      datacenters = pcc.properties.connectable_datacenters.map { |pcc| pcc.id }
+
+      expect(subject).to receive(:puts).with("ID: #{pcc.id}")
+      expect(subject).to receive(:puts).with("Name: #{subject_config[:name]}")
+      expect(subject).to receive(:puts).with("Description: #{subject_config[:description]}")
+      expect(subject).to receive(:puts).with("Peers: #{peers.to_s}")
+      expect(subject).to receive(:puts).with("Connectable Datacenters: #{datacenters.to_s}")
+
+      pcc.properties.name = subject_config[:name]
+      pcc.properties.description = subject_config[:description]
+
+      mock_wait_for(subject)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'PATCH',
+            path: "/pccs/#{pcc.id}",
+            operation: :'PrivateCrossConnectApi.pccs_patch',
+            return_type: 'PrivateCrossConnect',
+            body: { name: subject_config[:name], description: subject_config[:description] },
+            result: pcc,
+          },
+          {
+            method: 'GET',
+            path: "/pccs/#{pcc.id}",
+            operation: :'PrivateCrossConnectApi.pccs_find_by_id',
+            return_type: 'PrivateCrossConnect',
+            result: pcc,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_request_get_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+require 'ionoscloud_request_get'
+
+Chef::Knife::IonoscloudRequestGet.load_deps
+
+describe Chef::Knife::IonoscloudRequestGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudRequestGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call RequestApi.requests_find_by_id' do
+      request = request_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        request_id: request.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{request.id}")
+      expect(subject).to receive(:puts).with("Status: #{request.metadata.request_status.metadata.status}")
+      expect(subject).to receive(:puts).with("Method: #{request.properties.method}")
+      expect(subject).to receive(:puts).with("URL: #{request.properties.url}")
+      expect(subject).to receive(:puts).with("Targets: #{request.metadata.request_status.metadata.targets.map { |target| [target.target.id, target.target.type] }.to_s}")
+      expect(subject).to receive(:puts).with("Body: #{request.properties.body}")
+      expect(subject).to receive(:puts).with("Headers: #{request.properties.headers}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/requests/#{request.id}",
+            operation: :'RequestApi.requests_find_by_id',
+            return_type: 'Request',
+            result: request,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_request_list_spec.rb

@@ -7,6 +7,7 @@ describe Chef::Knife::IonoscloudRequestList do
   before :each do
     subject { Chef::Knife::IonoscloudRequestList.new }
 
+    @request_path = '/requests'
     @requests = requests_mock
     @request_list = request_list = [
       subject.ui.color('ID', :bold),
@@ -43,7 +44,7 @@ describe Chef::Knife::IonoscloudRequestList do
         [
           {
             method: 'GET',
-            path: '/requests',
+            path: @request_path,
             operation: :'RequestApi.requests_get',
             options: { depth: 2, limit: 20, offset: 0 },
             return_type: 'Requests',
@@ -72,7 +73,7 @@ describe Chef::Knife::IonoscloudRequestList do
         [
           {
             method: 'GET',
-            path: '/requests',
+            path: @request_path,
             operation: :'RequestApi.requests_get',
             options: { depth: 2, limit: subject_config[:limit], offset: subject_config[:offset] },
             return_type: 'Requests',
@@ -84,7 +85,7 @@ describe Chef::Knife::IonoscloudRequestList do
       expect { subject.run }.not_to raise_error(Exception)
     end
 
-    it 'should call RequestApi.resources_get with default limit if it is not an Integers' do
+    it 'should call RequestApi.resources_get with default limit if it is not an Integer' do
       subject_config = {
         ionoscloud_username: 'email',
         ionoscloud_password: 'password',
@@ -102,7 +103,7 @@ describe Chef::Knife::IonoscloudRequestList do
         [
           {
             method: 'GET',
-            path: '/requests',
+            path: @request_path,
             operation: :'RequestApi.requests_get',
             options: { depth: 2, limit: 20, offset: subject_config[:offset] },
             return_type: 'Requests',
@@ -132,7 +133,126 @@ describe Chef::Knife::IonoscloudRequestList do
         [
           {
             method: 'GET',
-            path: '/requests',
+            path: @request_path,
+            operation: :'RequestApi.requests_get',
+            options: { depth: 2, limit: subject_config[:limit], offset: 0 },
+            return_type: 'Requests',
+            result: @requests,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should call RequestApi.resources_get with the expected status when set' do
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        status: 'FAILED',
+        limit: 12,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject.ui).to receive(:list).with(@request_list, :uneven_columns_across, 4)
+
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: @request_path,
+            operation: :'RequestApi.requests_get',
+            options: { depth: 2, limit: subject_config[:limit], offset: 0, filter_request_status: subject_config[:status] },
+            return_type: 'Requests',
+            result: @requests,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should call RequestApi.resources_get with no status when set wrong' do
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        status: 'invalid',
+        limit: 12,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject.ui).to receive(:list).with(@request_list, :uneven_columns_across, 4)
+      expect(subject.ui).to receive(:warn).with('status should be one of [QUEUED, RUNNING, DONE, FAILED]')
+
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: @request_path,
+            operation: :'RequestApi.requests_get',
+            options: { depth: 2, limit: subject_config[:limit], offset: 0 },
+            return_type: 'Requests',
+            result: @requests,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+
+    it 'should call RequestApi.resources_get with the expected method when set' do
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        method: 'DELETE',
+        limit: 12,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject.ui).to receive(:list).with(@request_list, :uneven_columns_across, 4)
+
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: @request_path,
+            operation: :'RequestApi.requests_get',
+            options: { depth: 2, limit: subject_config[:limit], offset: 0, filter_method: subject_config[:method] },
+            return_type: 'Requests',
+            result: @requests,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should call RequestApi.resources_get with no method when set wrong' do
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        method: 'invalid',
+        limit: 12,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject.ui).to receive(:list).with(@request_list, :uneven_columns_across, 4)
+      expect(subject.ui).to receive(:warn).with('method should be one of [POST, PUT, PATCH, DELETE]')
+
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: @request_path,
             operation: :'RequestApi.requests_get',
             options: { depth: 2, limit: subject_config[:limit], offset: 0 },
             return_type: 'Requests',

data/spec/chef/knife/ionoscloud_s3key_get_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+require 'ionoscloud_s3key_get'
+
+Chef::Knife::IonoscloudS3keyGet.load_deps
+
+describe Chef::Knife::IonoscloudS3keyGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudS3keyGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call UserManagementApi.um_users_s3keys_find_by_key_id' do
+      s3_key = s3_key_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        user_id: 'user_id',
+        s3_key_id: s3_key.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{s3_key.id}")
+      expect(subject).to receive(:puts).with("Secret Key: #{s3_key.properties.secret_key}")
+      expect(subject).to receive(:puts).with("Active: #{s3_key.properties.active}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/um/users/#{subject_config[:user_id]}/s3keys/#{s3_key.id}",
+            operation: :'UserManagementApi.um_users_s3keys_find_by_key_id',
+            return_type: 'S3Key',
+            result: s3_key,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_server_get_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+require 'ionoscloud_server_get'
+
+Chef::Knife::IonoscloudServerGet.load_deps
+
+describe Chef::Knife::IonoscloudServerGet do
+  before :each do
+    subject { Chef::Knife::IonoscloudServerGet.new }
+
+    allow(subject).to receive(:puts)
+    allow(subject).to receive(:print)
+  end
+
+  describe '#run' do
+    it 'should call ServerApi.datacenters_servers_find_by_id' do
+      server = server_mock
+      subject_config = {
+        ionoscloud_username: 'email',
+        ionoscloud_password: 'password',
+        datacenter_id: 'datacenter_id',
+        server_id: server.id,
+        yes: true,
+      }
+
+      subject_config.each { |key, value| subject.config[key] = value }
+
+      expect(subject).to receive(:puts).with("ID: #{server.id}")
+      expect(subject).to receive(:puts).with("Name: #{server.properties.name}")
+      expect(subject).to receive(:puts).with("Cores: #{server.properties.cores}")
+      expect(subject).to receive(:puts).with("CPU Family: #{server.properties.cpu_family}")
+      expect(subject).to receive(:puts).with("Ram: #{server.properties.ram}")
+      expect(subject).to receive(:puts).with("Availability Zone: #{server.properties.availability_zone}")
+      expect(subject).to receive(:puts).with("Boot Volume: #{server.properties.boot_volume.id}")
+      expect(subject).to receive(:puts).with("Boot CDROM: #{server.properties.boot_cdrom.id}")
+
+      expect(subject.api_client).not_to receive(:wait_for)
+      mock_call_api(
+        subject,
+        [
+          {
+            method: 'GET',
+            path: "/datacenters/#{subject_config[:datacenter_id]}/servers/#{subject_config[:server_id]}",
+            operation: :'ServerApi.datacenters_servers_find_by_id',
+            return_type: 'Server',
+            result: server,
+          },
+        ],
+      )
+
+      expect { subject.run }.not_to raise_error(Exception)
+    end
+
+    it 'should not make any call if any required option is missing' do
+      required_options = subject.instance_variable_get(:@required_options)
+
+      arrays_without_one_element(required_options).each do |test_case|
+
+        test_case[:array].each { |value| subject.config[value] = 'test' }
+
+        expect(subject).to receive(:puts).with("Missing required parameters #{test_case[:removed]}")
+        expect(subject.api_client).not_to receive(:call_api)
+
+        expect { subject.run }.to raise_error(SystemExit) do |error|
+          expect(error.status).to eq(1)
+        end
+
+        required_options.each { |value| subject.config[value] = nil }
+      end
+    end
+  end
+end

data/spec/chef/knife/ionoscloud_server_list_spec.rb

@@ -42,8 +42,8 @@ describe Chef::Knife::IonoscloudServerList do
         server_list << server.properties.ram.to_s
         server_list << server.properties.availability_zone
         server_list << server.properties.vm_state
-        server_list << server.properties.boot_volume || ''
-        server_list << server.properties.boot_cdrom || ''
+        server_list << (server.properties.boot_volume.nil? ? '' : server.properties.boot_volume.id)
+        server_list << (server.properties.boot_cdrom.nil? ? '' : server.properties.boot_cdrom.id)
       end
 
       expect(subject.ui).to receive(:list).with(server_list, :uneven_columns_across, 9)