knife-inspect 0.9.2 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89c00f0b6f41512ce3384854fc731746e997aa8b
-  data.tar.gz: 5f348ee2a2957d74e67a2d526695227046678f9f
+  metadata.gz: 5e648a13d315a3c1c9da0ec48d1560d7c4a4dabd
+  data.tar.gz: 9ef1e150143ffff406ba9d667b01791215d91bb8
 SHA512:
-  metadata.gz: 9cf8232cabde6f90c15d65e78b5d8f826cc30767e68b589406dd4d2478334c5747101af5403bf57a56c2be1f2d2d3a86540a3839f7915b361343e54e89e02caa
-  data.tar.gz: c18f0c00b0b9687c2309037c0f8cdb6ebf2c5e988106b8daf5fa3fa046563993bb90b538d9c5bca982989e393531a14256fe1b80b7f1f1177c882da614da7ef1
+  metadata.gz: 0db7de2d55926ada9f92bc65571f8fa31310389d88abee342bec923f8b4545324a5b4a8b80ca997cb2ff96993259ecc7a5e60dda06a45369d6d912edf8ec248d
+  data.tar.gz: 8c9a7d1fe7166a465b741e729c740da9bb4c761fcd2fb0dd681b2da2b7120ce9402c41984f41a4f4036226a8ee6a0d9b4b2fbf5bce77f9e69e2ba3653733fead

data/.travis.yml

@@ -7,3 +7,5 @@ env:
   - CHEF_VERSION=11.14.2
 before_script:
   - chef-client --version
+notifications:
+  email: false

data/HISTORY.md

@@ -1,3 +1,9 @@
+## 0.10.0 ( 2014-10-13 )
+
+* Feature: Support cookbooks that only have a `metadata.json` file but no
+  `metadata.rb` (Berkshelf does that) ([#5][#5])
+* Feature: Use parallel lib to speed up REST API operations ([#27][#27])
+
 ## 0.9.2 ( 2014-08-11 )
 
 * Bug fix: Fixed regression in the regression fix for Chef 10 that broke
@@ -149,3 +155,5 @@ instead.
 [#22]: https://github.com/bmarini/knife-inspect/issues/22
 [#7]: https://github.com/bmarini/knife-inspect/issues/7
 [#25]: https://github.com/bmarini/knife-inspect/issues/25
+[#5]: https://github.com/bmarini/knife-inspect/issues/5
+[#27]: https://github.com/bmarini/knife-inspect/issues/27

data/README.md

@@ -66,6 +66,7 @@ when everything is in sync or 1 if it's not.
 * Dan Buch ([@meatballhat](@https://github.com/meatballhat))
 * Kirt Fitzpatrick ([@kirtfitzpatrick](https://github.com/kirtfitzpatrick))
 * Ben Hughes ([@barn](https://github.com/barn))
+* Grégoire Seux ([@kamaradclimber](https://github.com/kamaradclimber))
 
 ## Contributing
 

data/knife-inspect.gemspec

@@ -30,4 +30,5 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency 'chef',      chef_version
   s.add_runtime_dependency 'yajl-ruby', '~> 1.2'
+  s.add_runtime_dependency 'parallel', '~> 1.3'
 end

data/lib/health_inspector/checklists/base.rb

@@ -1,5 +1,6 @@
 # encoding: UTF-8
 require 'pathname'
+require 'parallel'
 
 module HealthInspector
   module Checklists
@@ -38,19 +39,16 @@ module HealthInspector
         (server_items + local_items).uniq.sort
       end
 
-      def each_item
-        all_item_names.each do |name|
-          yield load_item(name)
-        end
+      def load_validate(name)
+        item = load_item(name)
+        validate_item(item)
       end
 
       def run
         banner "Inspecting #{self.class.title}"
 
-        results = []
-
-        each_item do |item|
-          results << validate_item(item)
+        results = Parallel.map(all_item_names) do |name|
+          load_validate(name)
         end
 
         !results.include?(false)

data/lib/health_inspector/checklists/cookbooks.rb

@@ -1,5 +1,6 @@
 require 'chef/version'
 require 'chef/cookbook_version'
+require 'chef/cookbook_loader'
 require 'chef/checksum_cache' if Chef::Version.new(Chef::VERSION) < Chef::Version.new('11.0.0')
 
 module HealthInspector
@@ -104,18 +105,14 @@ module HealthInspector
       end
 
       def local_items
-        @context.cookbook_path
-          .map { |path| Dir["#{path}/*"] }
-          .flatten
-          .select { |path| File.exist?("#{path}/metadata.rb") }
-          .reduce({}) do |hsh, path|
+        cl = Chef::CookbookLoader.new(@context.cookbook_path)
+        cl.load_cookbooks
 
-            name    = File.basename(path)
-            version = (`grep '^version' #{path}/metadata.rb`).split.last[1...-1]
+        cl.inject({}) do |hash, (name, cookbook_version)|
+          hash[name] = Chef::Version.new(cookbook_version.version)
 
-            hsh[name] = Chef::Version.new(version)
-            hsh
-          end
+          hash
+        end
       end
 
       def all_item_names

data/lib/health_inspector/version.rb

@@ -1,3 +1,3 @@
 module HealthInspector
-  VERSION = '0.9.2'
+  VERSION = '0.10.0'
 end

data/spec/chef-repo/cookbooks/cookbook_two/metadata.json

@@ -0,0 +1,4 @@
+{
+ "name": "cookbook_two",
+ "version": "0.0.1"
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: knife-inspect
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.10.0
 platform: ruby
 authors:
 - Greg Karékinian
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-11 00:00:00.000000000 Z
+date: 2014-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -101,6 +101,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 description: knife-inspect is a knife plugin to compare the content of your Chef repository
   and Chef server
 email:
@@ -136,7 +150,7 @@ files:
 - lib/health_inspector/runner.rb
 - lib/health_inspector/version.rb
 - spec/chef-repo/cookbooks/cookbook_one/metadata.rb
-- spec/chef-repo/cookbooks/cookbook_two/metadata.rb
+- spec/chef-repo/cookbooks/cookbook_two/metadata.json
 - spec/chef-repo/data_bags/data_bag_one/one.json
 - spec/chef-repo/data_bags/data_bag_two/two.json
 - spec/chef-repo/data_bags/subdir/data_bag_from_subdir/three.json
@@ -188,7 +202,7 @@ specification_version: 4
 summary: Inspect your chef repo as it is compared to what is on your chef server
 test_files:
 - spec/chef-repo/cookbooks/cookbook_one/metadata.rb
-- spec/chef-repo/cookbooks/cookbook_two/metadata.rb
+- spec/chef-repo/cookbooks/cookbook_two/metadata.json
 - spec/chef-repo/data_bags/data_bag_one/one.json
 - spec/chef-repo/data_bags/data_bag_two/two.json
 - spec/chef-repo/data_bags/subdir/data_bag_from_subdir/three.json
@@ -214,4 +228,3 @@ test_files:
 - spec/health_inspector/checklists/role_spec.rb
 - spec/health_inspector/checklists/roles_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/spec/chef-repo/cookbooks/cookbook_two/metadata.rb

@@ -1,2 +0,0 @@
-name    "cookbook_two"
-version "0.0.1"