knife-inspect 0.8.0 → 0.9.0

data/spec/health_inspector/checklists/role_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe HealthInspector::Checklists::Role do
-  it_behaves_like "a chef model"
-  it_behaves_like "a chef model that can be represented in json"
+RSpec.describe HealthInspector::Checklists::Role do
+  it_behaves_like 'a chef model'
+  it_behaves_like 'a chef model that can be represented in json'
 end

data/spec/health_inspector/checklists/roles_spec.rb

@@ -1,33 +1,31 @@
 require 'spec_helper'
 
-describe HealthInspector::Checklists::Roles do
+RSpec.describe HealthInspector::Checklists::Roles do
   let :checklist do
     described_class.new(nil)
   end
 
   before do
-    expect(HealthInspector::Context).to receive(:new).with(nil).
-      and_return health_inspector_context
+    expect(HealthInspector::Context).to receive(:new).with(nil)
+      .and_return health_inspector_context
   end
 
   describe '#server_items' do
     it 'returns a list of roles from the chef server' do
-      expect(Chef::Role).to receive(:list).and_return({
+      expect(Chef::Role).to receive(:list).and_return(
         'role_one'         => 'url',
         'role_two'         => 'url',
         'role_from_subdir' => 'url'
-      })
-      expect(checklist.server_items.sort).to eq [
-        'role_from_subdir', 'role_one', 'role_two'
-      ]
+      )
+      expect(checklist.server_items.sort)
+        .to eq %w(role_from_subdir role_one role_two)
     end
   end
 
   describe '#local_items' do
     it 'returns a list of roles from the chef repo' do
-      expect(checklist.local_items.sort).to eq [
-        'role_from_subdir', 'role_one', 'role_two'
-      ]
+      expect(checklist.local_items.sort)
+        .to eq %w(role_from_subdir role_one role_two)
     end
   end
 end

data/spec/spec_helper.rb

@@ -6,7 +6,7 @@ if RUBY_VERSION > '1.9'
     Coveralls::SimpleCov::Formatter
   ]
   SimpleCov.start do
-    add_filter "/spec/"
+    add_filter '/spec/'
   end
 end
 
@@ -14,118 +14,184 @@ require 'rubygems'
 require 'bundler/setup'
 require 'health_inspector'
 
-module HealthInspector::SpecHelpers
-  def repo_path
-    @repo_path ||= File.expand_path("../chef-repo", __FILE__)
-  end
-
-  def health_inspector_context
-    @health_inspector_context ||= double(
-      :repo_path => repo_path,
-      :cookbook_path => ["#{repo_path}/cookbooks"]
-    )
+module HealthInspector
+  module SpecHelpers
+    def repo_path
+      @repo_path ||= File.expand_path('../chef-repo', __FILE__)
+    end
+
+    def health_inspector_context
+      @health_inspector_context ||= double(
+        :repo_path => repo_path,
+        :cookbook_path => ["#{repo_path}/cookbooks"]
+      )
+    end
   end
 end
 
 RSpec.configure do |c|
+  c.disable_monkey_patching!
+  c.expose_dsl_globally = false
   c.include HealthInspector::SpecHelpers
 end
 
-shared_examples "a chef model" do
-  let(:pairing) { described_class.new(health_inspector_context, :name => "dummy") }
+RSpec.shared_examples 'a chef model' do
+  let(:pairing) do
+    described_class.new(health_inspector_context, :name => 'dummy')
+  end
 
-  it "should detect if an item does not exist locally" do
+  it 'detects if an item does not exist locally' do
     pairing.server = {}
     pairing.local  = nil
     pairing.validate
 
-    pairing.errors.should_not be_empty
-    pairing.errors.first.should == "exists on server but not locally"
+    expect(pairing.errors).not_to be_empty
+    expect(pairing.errors.first).to eq('exists on server but not locally')
   end
 
-  it "should detect if an item does not exist on server" do
+  it 'detects if an item does not exist on server' do
     pairing.server = nil
     pairing.local  = {}
     pairing.validate
 
-    pairing.errors.should_not be_empty
-    pairing.errors.first.should == "exists locally but not on server"
+    expect(pairing.errors).not_to be_empty
+    expect(pairing.errors.first).to eq('exists locally but not on server')
   end
 
-  it "should detect if an item does not exist locally or on server" do
+  it 'detects if an item does not exist locally or on server' do
     pairing.server = nil
     pairing.local  = nil
     pairing.validate
 
-    pairing.errors.to_a.should == ["does not exist locally or on server"]
+    expect(pairing.errors.to_a).to eq(['does not exist locally or on server'])
   end
 end
 
-shared_examples "a chef model that can be represented in json" do
-  let(:pairing) { described_class.new(health_inspector_context, :name => "dummy") }
+RSpec.shared_examples 'a chef model that can be represented in json' do
+  let(:pairing) do
+    described_class.new(health_inspector_context, :name => 'dummy')
+  end
 
-  it "should detect if an item is different" do
-    pairing.server = {"foo" => "bar"}
-    pairing.local  = {"foo" => "baz"}
+  it 'detects if an item is different' do
+    pairing.server = { 'foo' => 'bar' }
+    pairing.local  = { 'foo' => 'baz' }
     pairing.validate
 
-    pairing.errors.should_not be_empty
-    pairing.errors.first.should == {"foo"=>{"server"=>"bar", "local"=>"baz"}}
+    expect(pairing.errors).not_to be_empty
+    expected_errors = { 'foo' => { 'server' => 'bar', 'local' => 'baz' } }
+    expect(pairing.errors.first).to eq(expected_errors)
   end
 
-  it "should detect if an item is the same" do
-    pairing.server = {"foo" => "bar"}
-    pairing.local  = {"foo" => "bar"}
+  it 'detects if a nested hash is different' do
+    pairing.server = { 'foo' => { 'bar' => { 'fizz' => 'buzz' } } }
+    pairing.local  = { 'foo' => { 'baz' => { 'fizz' => 'buzz' } } }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).not_to be_empty
+    expected_errors = {
+      'foo' => {
+        'bar' => { 'server' => { 'fizz' => 'buzz' }, 'local' => nil },
+        'baz' => { 'server' => nil, 'local' => { 'fizz' => 'buzz' } }
+      }
+    }
+    expect(pairing.errors.first).to eq(expected_errors)
   end
 
-  it "should detect if an string and symbol keys convert to the same values" do
-    pairing.server = {"foo" => "bar"}
-    pairing.local  = {:foo => "bar"}
+  it 'detects if an item is the same' do
+    pairing.server = { 'foo' => 'bar' }
+    pairing.local  = { 'foo' => 'bar' }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).to be_empty
   end
 
-  it "should detect if matching hashes are the same" do
-    pairing.server = {"foo" => {"bar" => "fizz"}}
-    pairing.local  = {"foo" => {"bar" => "fizz"}}
+  it 'detects if an string and symbol keys convert to the same values' do
+    pairing.server = { 'foo' => 'bar' }
+    pairing.local  = { :foo => 'bar' }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).to be_empty
   end
 
-  it "should detect if matching hashes with mismatched symbols and keys are the same" do
-    pairing.server = {"foo" => {"bar" => "fizz"}}
-    pairing.local  = {:foo => {:bar => "fizz"}}
+  it 'detects if matching hashes are the same' do
+    pairing.server = { 'foo' => { 'bar' => 'fizz' } }
+    pairing.local  = { 'foo' => { 'bar' => 'fizz' } }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).to be_empty
   end
 
-  it "should detect if matching arrays are the same" do
-    pairing.server = {"foo" => ["bar", "fizz"]}
-    pairing.local  = {"foo" => ["bar", "fizz"]}
+  it 'detects if matching hashes with mismatched symbols and keys are the same' do
+    pairing.server = { 'foo' => { 'bar' => 'fizz' } }
+    pairing.local  = { :foo => { :bar => 'fizz' } }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).to be_empty
   end
 
-  it "should detect if matching arrays with hashes are the same" do
-    pairing.server = {"foo" => ["bar", {"fizz" => "buzz"}]}
-    pairing.local  = {"foo" => ["bar", {"fizz" => "buzz"}]}
+  it 'detects if matching arrays are the same' do
+    pairing.server = { 'foo' => ['bar', 'fizz'] }
+    pairing.local  = { 'foo' => ['bar', 'fizz'] }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).to be_empty
   end
 
-  it "should detect if matching arrays with hashes containing symbols/strings are the same" do
-    pairing.server = {"foo" => ["bar", {"fizz" => "buzz"}]}
-    pairing.local  = {"foo" => ["bar", {:fizz => "buzz"}]}
+  it 'detects if matching arrays with hashes are the same' do
+    pairing.server = { 'foo' => ['bar', { 'fizz' => 'buzz' }] }
+    pairing.local  = { 'foo' => ['bar', { 'fizz' => 'buzz' }] }
     pairing.validate
 
-    pairing.errors.should be_empty
+    expect(pairing.errors).to be_empty
+  end
+
+  it 'detects if matching arrays with hashes containing symbols/strings are the same' do
+    pairing.server = { 'foo' => ['bar', { 'fizz' => 'buzz' }] }
+    pairing.local  = { 'foo' => ['bar', { :fizz => 'buzz' }] }
+    pairing.validate
+
+    expect(pairing.errors).to be_empty
+  end
+end
+
+RSpec.shared_examples 'a knife inspect runner' do
+  describe '#run' do
+    context 'when passing an item as an argument' do
+      let :inspect_runner do
+        described_class.new ['some_item']
+      end
+
+      let :validator do
+        double
+      end
+
+      let :item do
+        double
+      end
+
+      it 'inspects this item' do
+        expect(checklist).to receive(:new)
+          .with(inspect_runner).and_return validator
+        expect(validator).to receive(:load_item)
+          .with('some_item').and_return item
+        expect(validator).to receive(:validate_item).with(item).and_return true
+        expect(inspect_runner).to receive(:exit).with true
+
+        inspect_runner.run
+      end
+    end
+
+    context 'when not passing arguments' do
+      let :inspect_runner do
+        described_class.new
+      end
+
+      it 'inspects all the items' do
+        expect(checklist).to receive(:run).with(inspect_runner).and_return true
+        expect(inspect_runner).to receive(:exit).with true
+
+        inspect_runner.run
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: knife-inspect
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Greg Karékinian
@@ -9,98 +9,98 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-10 00:00:00.000000000 Z
+date: 2014-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: chef
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10'
-    - - <=
+    - - "<="
       - !ruby/object:Gem::Version
         version: '12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10'
-    - - <=
+    - - "<="
       - !ruby/object:Gem::Version
         version: '12'
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
 description: knife-inspect is a knife plugin to compare the content of your Chef repository
   and Chef server
 email:
@@ -109,9 +109,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .coveralls.yml
-- .gitignore
-- .travis.yml
+- ".coveralls.yml"
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - HISTORY.md
 - MIT-LICENSE
@@ -133,6 +133,7 @@ files:
 - lib/health_inspector/color.rb
 - lib/health_inspector/context.rb
 - lib/health_inspector/pairing.rb
+- lib/health_inspector/runner.rb
 - lib/health_inspector/version.rb
 - spec/chef-repo/cookbooks/cookbook_one/metadata.rb
 - spec/chef-repo/cookbooks/cookbook_two/metadata.rb
@@ -145,6 +146,11 @@ files:
 - spec/chef-repo/roles/role_one.json
 - spec/chef-repo/roles/role_two.json
 - spec/chef-repo/roles/subdir/role_from_subdir.json
+- spec/chef/knife/cookbook_inspect_spec.rb
+- spec/chef/knife/data_bag_inspect_spec.rb
+- spec/chef/knife/environment_inspect_spec.rb
+- spec/chef/knife/inspect_spec.rb
+- spec/chef/knife/role_inspect_spec.rb
 - spec/health_inspector/checklists/cookbook_spec.rb
 - spec/health_inspector/checklists/cookbooks_spec.rb
 - spec/health_inspector/checklists/data_bag_item_spec.rb
@@ -166,17 +172,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Inspect your chef repo as it is compared to what is on your chef server
@@ -192,6 +198,11 @@ test_files:
 - spec/chef-repo/roles/role_one.json
 - spec/chef-repo/roles/role_two.json
 - spec/chef-repo/roles/subdir/role_from_subdir.json
+- spec/chef/knife/cookbook_inspect_spec.rb
+- spec/chef/knife/data_bag_inspect_spec.rb
+- spec/chef/knife/environment_inspect_spec.rb
+- spec/chef/knife/inspect_spec.rb
+- spec/chef/knife/role_inspect_spec.rb
 - spec/health_inspector/checklists/cookbook_spec.rb
 - spec/health_inspector/checklists/cookbooks_spec.rb
 - spec/health_inspector/checklists/data_bag_item_spec.rb