knife-essentials 0.8.3 → 0.8.4

data/spec/integration/chefignore_spec.rb

@@ -0,0 +1,258 @@
+require 'support/integration_helper'
+require 'chef/knife/list_essentials'
+require 'chef/knife/show_essentials'
+
+describe 'chefignore tests' do
+  extend IntegrationSupport
+  include KnifeSupport
+
+  when_the_repository "has lots of stuff in it" do
+    file 'roles/x.json', {}
+    file 'environments/x.json', {}
+    file 'data_bags/bag1/x.json', {}
+    file 'cookbooks/cookbook1/x.json', {}
+
+    context "and has a chefignore everywhere except cookbooks" do
+      chefignore = "x.json\nroles/x.json\nenvironments/x.json\ndata_bags/bag1/x.json\nbag1/x.json\ncookbooks/cookbook1/x.json\ncookbook1/x.json\n"
+      file 'chefignore', chefignore
+      file 'roles/chefignore', chefignore
+      file 'environments/chefignore', chefignore
+      file 'data_bags/chefignore', chefignore
+      file 'data_bags/bag1/chefignore', chefignore
+      file 'cookbooks/cookbook1/chefignore', chefignore
+
+      it 'nothing is ignored' do
+        # NOTE: many of the "chefignore" files should probably not show up
+        # themselves, but we have other tests that talk about that
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/chefignore
+/cookbooks/cookbook1/x.json
+/data_bags/
+/data_bags/bag1/
+/data_bags/bag1/chefignore
+/data_bags/bag1/x.json
+/data_bags/chefignore
+/environments/
+/environments/chefignore
+/environments/x.json
+/roles/
+/roles/chefignore
+/roles/x.json
+EOM
+      end
+    end
+  end
+
+  when_the_repository 'has a cookbook with only chefignored files' do
+    file 'cookbooks/cookbook1/templates/default/x.rb', ''
+    file 'cookbooks/cookbook1/libraries/x.rb', ''
+    file 'cookbooks/chefignore', "libraries/x.rb\ntemplates/default/x.rb\n"
+
+    it 'the cookbook is not listed' do
+      knife('list --local -Rfp /').should_succeed(<<EOM, :stderr => "WARN: Cookbook 'cookbook1' is empty or entirely chefignored at #{Chef::Config.chef_repo_path}/cookbooks/cookbook1\n")
+/cookbooks/
+EOM
+    end
+  end
+
+  when_the_repository "has multiple cookbooks" do
+    file 'cookbooks/cookbook1/x.json', {}
+    file 'cookbooks/cookbook1/y.json', {}
+    file 'cookbooks/cookbook2/x.json', {}
+    file 'cookbooks/cookbook2/y.json', {}
+
+    context 'and has a chefignore with filenames' do
+      file 'cookbooks/chefignore', "x.json\n"
+
+      it 'matching files and directories get ignored in all cookbooks' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+
+    context "and has a chefignore with wildcards" do
+      file 'cookbooks/chefignore', "x.*\n"
+      file 'cookbooks/cookbook1/x.rb', ''
+
+      it 'matching files and directories get ignored in all cookbooks' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+
+    context "and has a chefignore with relative paths" do
+      file 'cookbooks/cookbook1/recipes/x.rb', ''
+      file 'cookbooks/cookbook2/recipes/y.rb', ''
+      file 'cookbooks/chefignore', "recipes/x.rb\n"
+
+      it 'matching directories get ignored' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/x.json
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/recipes/
+/cookbooks/cookbook2/recipes/y.rb
+/cookbooks/cookbook2/x.json
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+
+    context "and has a chefignore with subdirectories" do
+      file 'cookbooks/cookbook1/recipes/y.rb', ''
+      file 'cookbooks/chefignore', "recipes\nrecipes/\n"
+
+      it 'matching directories do NOT get ignored' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/recipes/
+/cookbooks/cookbook1/recipes/y.rb
+/cookbooks/cookbook1/x.json
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/x.json
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+
+    context "and has a chefignore that ignores all files in a subdirectory" do
+      file 'cookbooks/cookbook1/templates/default/x.rb', ''
+      file 'cookbooks/cookbook1/libraries/x.rb', ''
+      file 'cookbooks/chefignore', "libraries/x.rb\ntemplates/default/x.rb\n"
+
+      it 'ignores the subdirectory entirely' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/x.json
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/x.json
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+
+    context "and has an empty chefignore" do
+      file 'cookbooks/chefignore', "\n"
+
+      it 'nothing is ignored' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/x.json
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/x.json
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+
+    context "and has a chefignore with comments and empty lines" do
+      file 'cookbooks/chefignore', "\n\n # blah\n#\nx.json\n\n"
+
+      it 'matching files and directories get ignored in all cookbooks' do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/cookbook1/
+/cookbooks/cookbook1/y.json
+/cookbooks/cookbook2/
+/cookbooks/cookbook2/y.json
+EOM
+      end
+    end
+  end
+
+  when_the_repository "has multiple cookbook paths" do
+    before :each do
+      Chef::Config.cookbook_path = [
+        File.join(Chef::Config.chef_repo_path, 'cookbooks1'),
+        File.join(Chef::Config.chef_repo_path, 'cookbooks2')
+      ]
+    end
+
+    file 'cookbooks1/mycookbook/metadata.rb', ''
+    file 'cookbooks1/mycookbook/x.json', {}
+    file 'cookbooks2/yourcookbook/metadata.rb', ''
+    file 'cookbooks2/yourcookbook/x.json', ''
+
+    context "and multiple chefignores" do
+      file 'cookbooks1/chefignore', "metadata.rb\n"
+      file 'cookbooks2/chefignore', "x.json\n"
+      it "chefignores apply only to the directories they are in" do
+        knife('list --local -Rfp /').should_succeed <<EOM
+/cookbooks/
+/cookbooks/mycookbook/
+/cookbooks/mycookbook/x.json
+/cookbooks/yourcookbook/
+/cookbooks/yourcookbook/metadata.rb
+EOM
+      end
+
+      context "and conflicting cookbooks" do
+        file 'cookbooks1/yourcookbook/metadata.rb', ''
+        file 'cookbooks1/yourcookbook/x.json', ''
+        file 'cookbooks1/yourcookbook/onlyincookbooks1.rb', ''
+        file 'cookbooks2/yourcookbook/onlyincookbooks2.rb', ''
+
+        it "chefignores apply only to the winning cookbook" do
+          knife('list --local -Rfp /').should_succeed(<<EOM, :stderr => "WARN: Child with name 'yourcookbook' found in multiple directories: #{Chef::Config.chef_repo_path}/cookbooks1/yourcookbook and #{Chef::Config.chef_repo_path}/cookbooks2/yourcookbook\n")
+/cookbooks/
+/cookbooks/mycookbook/
+/cookbooks/mycookbook/x.json
+/cookbooks/yourcookbook/
+/cookbooks/yourcookbook/onlyincookbooks1.rb
+/cookbooks/yourcookbook/x.json
+EOM
+        end
+      end
+    end
+  end
+
+  when_the_repository 'has a cookbook named chefignore' do
+    file 'cookbooks/chefignore/metadata.rb', {}
+    it 'knife list -Rfp /cookbooks shows it' do
+      knife('list --local -Rfp /cookbooks').should_succeed <<EOM
+/cookbooks/chefignore/
+/cookbooks/chefignore/metadata.rb
+EOM
+    end
+  end
+
+  when_the_repository 'has multiple cookbook paths, one with a chefignore file and the other with a cookbook named chefignore' do
+    file 'cookbooks1/chefignore', ''
+    file 'cookbooks1/blah/metadata.rb', ''
+    file 'cookbooks2/chefignore/metadata.rb', ''
+    before :each do
+      Chef::Config.cookbook_path = [
+        File.join(Chef::Config.chef_repo_path, 'cookbooks1'),
+        File.join(Chef::Config.chef_repo_path, 'cookbooks2')
+      ]
+    end
+    it 'knife list -Rfp /cookbooks shows the chefignore cookbook' do
+      knife('list --local -Rfp /cookbooks').should_succeed <<EOM
+/cookbooks/blah/
+/cookbooks/blah/metadata.rb
+/cookbooks/chefignore/
+/cookbooks/chefignore/metadata.rb
+EOM
+    end
+  end
+end

data/spec/integration/diff_spec.rb

@@ -0,0 +1,151 @@
+require 'support/integration_helper'
+require 'chef/knife/diff_essentials'
+
+describe 'knife diff' do
+  extend IntegrationSupport
+  include KnifeSupport
+
+  when_the_chef_server "has one of each thing" do
+    client 'x', '{}'
+    cookbook 'x', '1.0.0', { 'metadata.rb' => 'version "1.0.0"' }
+    data_bag 'x', { 'y' => '{}' }
+    environment 'x', '{}'
+    node 'x', '{}'
+    role 'x', '{}'
+    user 'x', '{}'
+
+    when_the_repository 'has only top-level directories' do
+      directory 'clients'
+      directory 'cookbooks'
+      directory 'data_bags'
+      directory 'environments'
+      directory 'nodes'
+      directory 'roles'
+      directory 'users'
+
+      it 'knife diff reports everything as deleted' do
+        knife('diff --name-status /').should_succeed <<EOM
+D\t/cookbooks/x
+D\t/data_bags/x
+D\t/environments/_default.json
+D\t/environments/x.json
+D\t/roles/x.json
+EOM
+      end
+    end
+
+    when_the_repository 'has an identical copy of each thing' do
+      file 'clients/x.json', <<EOM
+{}
+EOM
+      file 'cookbooks/x/metadata.rb', 'version "1.0.0"'
+      file 'data_bags/x/y.json', <<EOM
+{
+  "id": "y"
+}
+EOM
+      file 'environments/_default.json', <<EOM
+{
+  "name": "_default",
+  "description": "The default Chef environment",
+  "cookbook_versions": {
+  },
+  "json_class": "Chef::Environment",
+  "chef_type": "environment",
+  "default_attributes": {
+  },
+  "override_attributes": {
+  }
+}
+EOM
+      file 'environments/x.json', <<EOM
+{
+  "chef_type": "environment",
+  "cookbook_versions": {
+  },
+  "default_attributes": {
+  },
+  "description": "",
+  "json_class": "Chef::Environment",
+  "name": "x",
+  "override_attributes": {
+  }
+}
+EOM
+      file 'nodes/x.json', <<EOM
+{}
+EOM
+      file 'roles/x.json', <<EOM
+{
+  "chef_type": "role",
+  "default_attributes": {
+  },
+  "description": "",
+  "env_run_lists": {
+  },
+  "json_class": "Chef::Role",
+  "name": "x",
+  "override_attributes": {
+  },
+  "run_list": [
+
+  ]
+}
+EOM
+      file 'users/x.json', <<EOM
+{}
+EOM
+
+      it 'knife diff reports no differences' do
+        knife('diff /').should_succeed :stdout => ''
+      end
+
+      context 'except the role file' do
+        file 'roles/x.json', <<EOM
+{
+  "foo": "bar"
+}
+EOM
+        it 'knife diff reports the role as different' do
+          knife('diff --name-status /').should_succeed <<EOM
+M\t/roles/x.json
+EOM
+        end
+      end
+
+      context 'as well as one extra copy of each thing' do
+        file 'clients/y.json', {}
+        file 'cookbooks/x/blah.rb', ''
+        file 'cookbooks/y/metadata.rb', 'version "1.0.0"'
+        file 'data_bags/x/z.json', {}
+        file 'data_bags/y/zz.json', {}
+        file 'environments/y.json', {}
+        file 'nodes/y.json', {}
+        file 'roles/y.json', {}
+        file 'users/y.json', {}
+
+        it 'knife diff reports the new files as added' do
+          knife('diff --name-status /').should_succeed <<EOM
+A\t/cookbooks/x/blah.rb
+A\t/cookbooks/y
+A\t/data_bags/x/z.json
+A\t/data_bags/y
+A\t/environments/y.json
+A\t/roles/y.json
+EOM
+        end
+      end
+    end
+
+    when_the_repository 'is empty' do
+      it 'knife diff reports everything as deleted' do
+        knife('diff --name-status /').should_succeed <<EOM
+D\t/cookbooks
+D\t/data_bags
+D\t/environments
+D\t/roles
+EOM
+      end
+    end
+  end
+end

data/spec/integration/download_spec.rb

@@ -0,0 +1,403 @@
+require 'support/integration_helper'
+require 'chef/knife/download_essentials'
+require 'chef/knife/diff_essentials'
+
+describe 'knife download' do
+  extend IntegrationSupport
+  include KnifeSupport
+
+  when_the_chef_server "has one of each thing" do
+    client 'x', '{}'
+    cookbook 'x', '1.0.0', { 'metadata.rb' => 'version "1.0.0"' }
+    data_bag 'x', { 'y' => '{}' }
+    environment 'x', '{}'
+    node 'x', '{}'
+    role 'x', '{}'
+    user 'x', '{}'
+
+    when_the_repository 'has only top-level directories' do
+      directory 'clients'
+      directory 'cookbooks'
+      directory 'data_bags'
+      directory 'environments'
+      directory 'nodes'
+      directory 'roles'
+      directory 'users'
+
+      it 'knife download downloads everything' do
+        knife('download /').should_succeed <<EOM
+Created /cookbooks/x
+Created /cookbooks/x/metadata.rb
+Created /data_bags/x
+Created /data_bags/x/y.json
+Created /environments/_default.json
+Created /environments/x.json
+Created /roles/x.json
+EOM
+        knife('diff --name-status /').should_succeed ''
+      end
+    end
+
+    when_the_repository 'has an identical copy of each thing' do
+      file 'clients/x.json', <<EOM
+{}
+EOM
+      file 'cookbooks/x/metadata.rb', 'version "1.0.0"'
+      file 'data_bags/x/y.json', <<EOM
+{
+  "id": "y"
+}
+EOM
+      file 'environments/_default.json', <<EOM
+{
+  "name": "_default",
+  "description": "The default Chef environment",
+  "cookbook_versions": {
+  },
+  "json_class": "Chef::Environment",
+  "chef_type": "environment",
+  "default_attributes": {
+  },
+  "override_attributes": {
+  }
+}
+EOM
+      file 'environments/x.json', <<EOM
+{
+  "chef_type": "environment",
+  "cookbook_versions": {
+  },
+  "default_attributes": {
+  },
+  "description": "",
+  "json_class": "Chef::Environment",
+  "name": "x",
+  "override_attributes": {
+  }
+}
+EOM
+      file 'nodes/x.json', <<EOM
+{}
+EOM
+      file 'roles/x.json', <<EOM
+{
+  "chef_type": "role",
+  "default_attributes": {
+  },
+  "description": "",
+  "env_run_lists": {
+  },
+  "json_class": "Chef::Role",
+  "name": "x",
+  "override_attributes": {
+  },
+  "run_list": [
+
+  ]
+}
+EOM
+      file 'users/x.json', <<EOM
+{}
+EOM
+
+      it 'knife download makes no changes' do
+        knife('download /').should_succeed ''
+        knife('diff --name-status /').should_succeed ''
+      end
+
+      it 'knife download --purge makes no changes' do
+        knife('download --purge /').should_succeed ''
+        knife('diff --name-status /').should_succeed ''
+      end
+
+      context 'except the role file' do
+        file 'roles/x.json', <<EOM
+{
+  "chef_type": "role",
+  "default_attributes": {
+  },
+  "description": "blarghle",
+  "env_run_lists": {
+  },
+  "json_class": "Chef::Role",
+  "name": "x",
+  "override_attributes": {
+  },
+  "run_list": [
+
+  ]
+}
+EOM
+        it 'knife download changes the role' do
+          knife('download /').should_succeed "Updated /roles/x.json\n"
+          knife('diff --name-status /').should_succeed ''
+        end
+      end
+
+      context 'as well as one extra copy of each thing' do
+        file 'clients/y.json', { 'name' => 'y' }
+        file 'cookbooks/x/blah.rb', ''
+        file 'cookbooks/y/metadata.rb', 'version "1.0.0"'
+        file 'data_bags/x/z.json', <<EOM
+{
+  "id": "z"
+}
+EOM
+        file 'data_bags/y/zz.json', <<EOM
+{
+  "id": "zz"
+}
+EOM
+        file 'environments/y.json', <<EOM
+{
+  "chef_type": "environment",
+  "cookbook_versions": {
+  },
+  "default_attributes": {
+  },
+  "description": "",
+  "json_class": "Chef::Environment",
+  "name": "y",
+  "override_attributes": {
+  }
+}
+EOM
+        file 'nodes/y.json', { 'name' => 'y' }
+        file 'roles/y.json', <<EOM
+{
+  "chef_type": "role",
+  "default_attributes": {
+  },
+  "description": "",
+  "env_run_lists": {
+  },
+  "json_class": "Chef::Role",
+  "name": "y",
+  "override_attributes": {
+  },
+  "run_list": [
+
+  ]
+}
+EOM
+        file 'users/y.json', { 'name' => 'y' }
+
+        it 'knife download does nothing' do
+          knife('download /').should_succeed ''
+          knife('diff --name-status /').should_succeed <<EOM
+A\t/cookbooks/x/blah.rb
+A\t/cookbooks/y
+A\t/data_bags/x/z.json
+A\t/data_bags/y
+A\t/environments/y.json
+A\t/roles/y.json
+EOM
+        end
+
+        it 'knife download --purge deletes the extra files' do
+          knife('download --purge /').should_succeed <<EOM
+Deleted extra entry /cookbooks/x/blah.rb (purge is on)
+Deleted extra entry /cookbooks/y (purge is on)
+Deleted extra entry /data_bags/x/z.json (purge is on)
+Deleted extra entry /data_bags/y (purge is on)
+Deleted extra entry /environments/y.json (purge is on)
+Deleted extra entry /roles/y.json (purge is on)
+EOM
+          knife('diff --name-status /').should_succeed ''
+        end
+      end
+    end
+
+    when_the_repository 'is empty' do
+      it 'knife download creates the extra files' do
+        knife('download /').should_succeed <<EOM
+Created /cookbooks
+Created /cookbooks/x
+Created /cookbooks/x/metadata.rb
+Created /data_bags
+Created /data_bags/x
+Created /data_bags/x/y.json
+Created /environments
+Created /environments/_default.json
+Created /environments/x.json
+Created /roles
+Created /roles/x.json
+EOM
+        knife('diff --name-status /').should_succeed ''
+      end
+
+      context 'when current directory is top level' do
+        cwd '.'
+        it 'knife download with no parameters reports an error' do
+          knife('download').should_fail "FATAL: Must specify at least one argument.  If you want to download everything in this directory, type \"knife download .\"\n", :stdout => /USAGE/
+        end
+      end
+    end
+  end
+
+  # Test download of an item when the other end doesn't even have the container
+  when_the_repository 'is empty' do
+    when_the_chef_server 'has two data bag items' do
+      data_bag 'x', { 'y' => {}, 'z' => {} }
+
+      it 'knife download of one data bag item itself succeeds' do
+        knife('download /data_bags/x/y.json').should_succeed <<EOM
+Created /data_bags
+Created /data_bags/x
+Created /data_bags/x/y.json
+EOM
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+D\t/data_bags/x/z.json
+EOM
+      end
+    end
+  end
+
+  when_the_repository 'has three data bag items' do
+      file 'data_bags/x/deleted.json', <<EOM
+{
+  "id": "deleted"
+}
+EOM
+      file 'data_bags/x/modified.json', <<EOM
+{
+  "id": "modified"
+}
+EOM
+      file 'data_bags/x/unmodified.json', <<EOM
+{
+  "id": "unmodified"
+}
+EOM
+
+    when_the_chef_server 'has a modified, unmodified, added and deleted data bag item' do
+      data_bag 'x', {
+        'added' => {},
+        'modified' => { 'foo' => 'bar' },
+        'unmodified' => {}
+      }
+
+      it 'knife download of the modified file succeeds' do
+        knife('download /data_bags/x/modified.json').should_succeed <<EOM
+Updated /data_bags/x/modified.json
+EOM
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+D\t/data_bags/x/added.json
+A\t/data_bags/x/deleted.json
+EOM
+      end
+      it 'knife download of the unmodified file does nothing' do
+        knife('download /data_bags/x/unmodified.json').should_succeed ''
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+D\t/data_bags/x/added.json
+M\t/data_bags/x/modified.json
+A\t/data_bags/x/deleted.json
+EOM
+      end
+      it 'knife download of the added file succeeds' do
+        knife('download /data_bags/x/added.json').should_succeed <<EOM
+Created /data_bags/x/added.json
+EOM
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+M\t/data_bags/x/modified.json
+A\t/data_bags/x/deleted.json
+EOM
+      end
+      it 'knife download of the deleted file does nothing' do
+        knife('download /data_bags/x/deleted.json').should_succeed ''
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+D\t/data_bags/x/added.json
+M\t/data_bags/x/modified.json
+A\t/data_bags/x/deleted.json
+EOM
+      end
+      it 'knife download --purge of the deleted file deletes it' do
+        knife('download --purge /data_bags/x/deleted.json').should_succeed <<EOM
+Deleted extra entry /data_bags/x/deleted.json (purge is on)
+EOM
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+D\t/data_bags/x/added.json
+M\t/data_bags/x/modified.json
+EOM
+      end
+      it 'knife download of the entire data bag downloads everything' do
+        knife('download /data_bags/x').should_succeed <<EOM
+Created /data_bags/x/added.json
+Updated /data_bags/x/modified.json
+EOM
+        knife('diff --name-status /data_bags').should_succeed <<EOM
+A\t/data_bags/x/deleted.json
+EOM
+      end
+      it 'knife download --purge of the entire data bag downloads everything' do
+        knife('download --purge /data_bags/x').should_succeed <<EOM
+Created /data_bags/x/added.json
+Updated /data_bags/x/modified.json
+Deleted extra entry /data_bags/x/deleted.json (purge is on)
+EOM
+        knife('diff --name-status /data_bags').should_succeed ''
+      end
+    end
+  end
+
+  when_the_repository 'has a cookbook' do
+    file 'cookbooks/x/metadata.rb', 'version "1.0.0"'
+    file 'cookbooks/x/z.rb', ''
+
+    when_the_chef_server 'has a modified, added and deleted file for the cookbook' do
+      cookbook 'x', '1.0.0', { 'metadata.rb' => 'version  "1.0.0"', 'y.rb' => 'hi' }
+
+      it 'knife download of a modified file succeeds' do
+        knife('download /cookbooks/x/metadata.rb').should_succeed "Updated /cookbooks/x/metadata.rb\n"
+        knife('diff --name-status /cookbooks').should_succeed <<EOM
+D\t/cookbooks/x/y.rb
+A\t/cookbooks/x/z.rb
+EOM
+      end
+      it 'knife download of a deleted file does nothing' do
+        knife('download /cookbooks/x/z.rb').should_succeed ''
+        knife('diff --name-status /cookbooks').should_succeed <<EOM
+M\t/cookbooks/x/metadata.rb
+D\t/cookbooks/x/y.rb
+A\t/cookbooks/x/z.rb
+EOM
+      end
+      it 'knife download --purge of a deleted file succeeds' do
+        knife('download --purge /cookbooks/x/z.rb').should_succeed "Deleted extra entry /cookbooks/x/z.rb (purge is on)\n"
+        knife('diff --name-status /cookbooks').should_succeed <<EOM
+M\t/cookbooks/x/metadata.rb
+D\t/cookbooks/x/y.rb
+EOM
+      end
+      it 'knife download of an added file succeeds' do
+        knife('download /cookbooks/x/y.rb').should_succeed "Created /cookbooks/x/y.rb\n"
+        knife('diff --name-status /cookbooks').should_succeed <<EOM
+M\t/cookbooks/x/metadata.rb
+A\t/cookbooks/x/z.rb
+EOM
+      end
+      it 'knife download of the cookbook itself succeeds' do
+        knife('download /cookbooks/x').should_succeed <<EOM
+Updated /cookbooks/x/metadata.rb
+Created /cookbooks/x/y.rb
+EOM
+        knife('diff --name-status /cookbooks').should_succeed <<EOM
+A\t/cookbooks/x/z.rb
+EOM
+      end
+      it 'knife download --purge of the cookbook itself succeeds' do
+        knife('download --purge /cookbooks/x').should_succeed <<EOM
+Updated /cookbooks/x/metadata.rb
+Created /cookbooks/x/y.rb
+Deleted extra entry /cookbooks/x/z.rb (purge is on)
+EOM
+        knife('diff --name-status /cookbooks').should_succeed ''
+      end
+    end
+  end
+
+  # download from a cwd
+  # download with *'s
+  # download with JSON that isn't *really* modified
+  # Multiple cookbook versions!!!
+end