knife-essentials 0.1.1 → 0.2

data/lib/chef_fs/file_system/rest_list_entry.rb

@@ -1,5 +1,5 @@
 require 'chef_fs/file_system/base_fs_object'
-require 'chef_fs/file_system/not_found_exception'
+require 'chef_fs/file_system/not_found_error'
 # TODO: these are needed for rest.get_rest() to work.  This seems strange.
 require 'chef/role'
 require 'chef/node'
@@ -37,7 +37,7 @@ module ChefFS
           rest.delete_rest(api_path)
         rescue Net::HTTPServerException
           if $!.response.code == "404"
-            raise ChefFS::FileSystem::NotFoundException, $!
+            raise ChefFS::FileSystem::NotFoundError.new($!), "#{path_for_printing} not found"
           else
             raise
           end
@@ -49,7 +49,7 @@ module ChefFS
           Chef::JSONCompat.to_json_pretty(rest.get_rest(api_path).to_hash)
         rescue Net::HTTPServerException
           if $!.response.code == "404"
-            raise ChefFS::FileSystem::NotFoundException, $!
+            raise ChefFS::FileSystem::NotFoundError.new($!), "#{path_for_printing} not found"
           else
             raise
           end

data/lib/chef_fs/knife.rb

@@ -1,5 +1,5 @@
 require 'chef_fs/file_system/chef_server_root_dir'
-require 'chef_fs/file_system/file_system_root_dir'
+require 'chef_fs/file_system/chef_repository_file_system_root_dir'
 require 'chef_fs/file_pattern'
 require 'chef_fs/path_utils'
 require 'chef/config'
@@ -32,7 +32,7 @@ module ChefFS
     end
 
     def local_fs
-      @local_fs ||= ChefFS::FileSystem::FileSystemRootDir.new(chef_repo)
+      @local_fs ||= ChefFS::FileSystem::ChefRepositoryFileSystemRootDir.new(chef_repo)
     end
 
     def pattern_args

data/lib/chef_fs/version.rb

@@ -1,4 +1,4 @@
 module ChefFS
-  VERSION = "0.1.1"
+  VERSION = "0.2"
 end
 

data/spec/chef_fs/diff_spec.rb

@@ -26,11 +26,13 @@ describe ChefFS::Diff do
         :both_dirs_empty => {},
         :dirs_empty_in_a_filled_in_b => {},
         :dirs_empty_in_b_filled_in_a => { :subsub => nil },
+        :dirs_in_a_cannot_be_in_b => {},
+        :file_in_a_cannot_be_in_b => nil,
 				:a_only_dir => { :subsub => nil },
 				:a_only_file => nil,
 				:dir_in_a_file_in_b => {},
 				:file_in_a_dir_in_b => nil
-			})
+			}, /cannot_be_in_a/)
 		}
 		let(:b) {
 			memory_fs('b', {
@@ -51,11 +53,13 @@ describe ChefFS::Diff do
 				:both_dirs_empty => {},
         :dirs_empty_in_a_filled_in_b => { :subsub => nil },
         :dirs_empty_in_b_filled_in_a => {},
+        :dirs_in_b_cannot_be_in_a => {},
+        :file_in_b_cannot_be_in_a => nil,
 				:b_only_dir => { :subsub => nil },
 				:b_only_file => nil,
 				:dir_in_a_file_in_b => nil,
 				:file_in_a_dir_in_b => {}
-			})
+			}, /cannot_be_in_b/)
 		}
 		it 'diffable_leaves' do
 			diffable_leaves_should_yield_paths(a, b, nil,
@@ -75,6 +79,10 @@ describe ChefFS::Diff do
           /both_files_different
           /dirs_empty_in_b_filled_in_a/subsub
           /dirs_empty_in_a_filled_in_b/subsub
+          /dirs_in_a_cannot_be_in_b
+          /dirs_in_b_cannot_be_in_a
+          /file_in_a_cannot_be_in_b
+          /file_in_b_cannot_be_in_a
           /a_only_dir
           /a_only_file
           /b_only_dir
@@ -94,6 +102,8 @@ describe ChefFS::Diff do
           /both_dirs/sub_file_in_a_dir_in_b
           /both_files
           /both_files_different
+          /file_in_a_cannot_be_in_b
+          /file_in_b_cannot_be_in_a
           /a_only_file
           /b_only_file
           /dir_in_a_file_in_b
@@ -116,6 +126,8 @@ describe ChefFS::Diff do
           /both_dirs/sub_file_in_a_dir_in_b
           /dirs_empty_in_b_filled_in_a/subsub
           /dirs_empty_in_a_filled_in_b/subsub
+          /dirs_in_a_cannot_be_in_b
+          /dirs_in_b_cannot_be_in_a
           /a_only_dir
           /b_only_dir
           /dir_in_a_file_in_b

data/spec/chef_fs/file_system/chef_server_root_dir_spec.rb

@@ -0,0 +1,212 @@
+require 'chef_fs/file_system/chef_server_root_dir'
+
+describe ChefFS::FileSystem::ChefServerRootDir do
+  shared_examples 'a json endpoint dir leaf' do
+    it 'parent is endpoint' do
+      endpoint_leaf.parent.should == endpoint
+    end
+    it 'name is correct' do
+      endpoint_leaf.name.should == "#{endpoint_leaf_name}.json"
+    end
+    it 'path is correct' do
+      endpoint_leaf.path.should == "/#{endpoint_name}/#{endpoint_leaf_name}.json"
+    end
+    it 'path_for_printing is correct' do
+      endpoint_leaf.path_for_printing.should == "remote/#{endpoint_name}/#{endpoint_leaf_name}.json"
+    end
+    it 'is not a directory' do
+      endpoint_leaf.dir?.should be_false
+    end
+    it 'exists' do
+      should_receive_children
+      endpoint_leaf.exists?.should be_true
+    end
+    it 'read returns content' do
+      @rest.should_receive(:get_rest).with("#{endpoint_name}/#{endpoint_leaf_name}/environments/env").once.and_return(
+        {
+          'a' => 'b'
+        })
+      endpoint_leaf.read.should == '{
+  "a": "b"
+}'
+    end
+  end
+
+  shared_examples 'a json rest endpoint dir' do
+    it 'parent is root' do
+      endpoint.parent.should == root_dir
+    end
+    it 'has correct name' do
+      endpoint.name.should == endpoint_name
+    end
+    it 'has correct path' do
+      endpoint.path.should == "/#{endpoint_name}"
+    end
+    it 'has correct path_for_printing' do
+      endpoint.path_for_printing.should == "remote/#{endpoint_name}"
+    end
+    it 'is a directory' do
+      endpoint.dir?.should be_true
+    end
+    it 'exists' do
+      endpoint.exists?.should be_true
+    end
+    it 'can have json files as children' do
+      endpoint.can_have_child?('blah.json', false).should be_true
+    end
+    it 'cannot have non-json files as children' do
+      endpoint.can_have_child?('blah', false).should be_false
+    end
+    it 'cannot have directories as children' do
+      endpoint.can_have_child?('blah', true).should be_false
+      endpoint.can_have_child?('blah.json', true).should be_false
+    end
+    let(:should_receive_children) {
+      @rest.should_receive(:get_rest).with(endpoint_name).once.and_return(
+        {
+          "achild" => "http://opscode.com/achild",
+          "bchild" => "http://opscode.com/bchild"
+        })
+    }
+    it 'has correct children' do
+      should_receive_children
+      endpoint.children.map { |child| child.name }.should =~ %w(achild.json bchild.json)
+    end
+    context 'achild in endpoint.children' do
+      let(:endpoint_leaf_name) { 'achild' }
+      let(:endpoint_leaf) do
+        should_receive_children
+        endpoint.children.select { |child| child.name == 'achild.json' }.first
+      end
+      it_behaves_like 'a json endpoint dir leaf'
+    end
+    context 'endpoint.child(achild)' do
+      let(:endpoint_leaf_name) { 'achild' }
+      let(:endpoint_leaf) { endpoint.child('achild.json') }
+      it_behaves_like 'a json endpoint dir leaf'
+    end
+    context 'nonexistent child()' do
+      let(:nonexistent_child) { endpoint.child('blah.json') }
+      it 'has correct parent, name, path and path_for_printing' do
+        nonexistent_child.parent.should == endpoint
+        nonexistent_child.name.should == "blah.json"
+        nonexistent_child.path.should == "#{endpoint.path}/blah.json"
+        nonexistent_child.path_for_printing.should == "#{endpoint.path_for_printing}/blah.json"
+      end
+      it 'does not exist' do
+        should_receive_children
+        nonexistent_child.exists?.should be_false
+      end
+      it 'is not a directory' do
+        nonexistent_child.dir?.should be_false
+      end
+      it 'read returns NotFoundError' do
+        @rest.should_receive(:get_rest).with("#{endpoint_name}/blah/environments/env").once.and_raise(Net::HTTPServerException.new(nil,Net::HTTPResponse.new(nil,'404',nil)))
+        expect { nonexistent_child.read }.to raise_error(ChefFS::FileSystem::NotFoundError)
+      end
+    end
+  end
+
+  let(:root_dir) {
+    ChefFS::FileSystem::ChefServerRootDir.new('remote',
+    {
+      :chef_server_url => 'url',
+      :node_name => 'username',
+      :client_key => 'key',
+      :environment => 'env'
+    })
+  }
+  before(:each) do
+    @rest = double("rest")
+    Chef::REST.stub(:new).with('url','username','key') { @rest }
+  end
+  context 'the root directory' do
+    it 'has no parent' do
+      root_dir.parent.should == nil
+    end
+    it 'is a directory' do
+      root_dir.dir?.should be_true
+    end
+    it 'exists' do
+      root_dir.exists?.should be_true
+    end
+    it 'has name ""' do
+      root_dir.name.should == ""
+    end
+    it 'has path /' do
+      root_dir.path.should == '/'
+    end
+    it 'has path_for_printing remote/' do
+      root_dir.path_for_printing.should == 'remote/'
+    end
+    it 'has correct children' do
+      root_dir.children.map { |child| child.name }.should =~ %w(clients cookbooks data_bags environments nodes roles)
+    end
+    it 'can have children with the known names' do
+      %w(clients cookbooks data_bags environments nodes roles).each { |child| root_dir.can_have_child?(child, true).should be_true }
+    end
+    it 'cannot have files as children' do
+      %w(clients cookbooks data_bags environments nodes roles).each { |child| root_dir.can_have_child?(child, false).should be_false }
+      root_dir.can_have_child?('blah', false).should be_false
+    end
+    it 'cannot have other child directories than the known names' do
+      root_dir.can_have_child?('blah', true).should be_false
+    end
+    it 'child() responds to children' do
+      %w(clients cookbooks data_bags environments nodes roles).each { |child| root_dir.child(child).exists?.should be_true }
+    end
+    context 'nonexistent child()' do
+      let(:nonexistent_child) { root_dir.child('blah') }
+      it 'has correct parent, name, path and path_for_printing' do
+        nonexistent_child.parent.should == root_dir
+        nonexistent_child.name.should == "blah"
+        nonexistent_child.path.should == "/blah"
+        nonexistent_child.path_for_printing.should == "remote/blah"
+      end
+      it 'does not exist' do
+        nonexistent_child.exists?.should be_false
+      end
+      it 'is not a directory' do
+        nonexistent_child.dir?.should be_false
+      end
+      it 'read returns NotFoundError' do
+        expect { nonexistent_child.read }.to raise_error(ChefFS::FileSystem::NotFoundError)
+      end
+    end
+  end
+
+  context 'clients in children' do
+    let(:endpoint_name) { 'clients' }
+    let(:endpoint) { root_dir.children.select { |child| child.name == 'clients' }.first }
+
+    it_behaves_like 'a json rest endpoint dir'
+  end
+
+  context 'root.child(clients)' do
+    let(:endpoint_name) { 'clients' }
+    let(:endpoint) { root_dir.child('clients') }
+
+    it_behaves_like 'a json rest endpoint dir'
+  end
+
+  context 'root.child(environments)' do
+    let(:endpoint_name) { 'environments' }
+    let(:endpoint) { root_dir.child('environments') }
+
+    it_behaves_like 'a json rest endpoint dir'
+  end
+
+  context 'root.child(nodes)' do
+    let(:endpoint_name) { 'nodes' }
+    let(:endpoint) { root_dir.child('nodes') }
+
+    it_behaves_like 'a json rest endpoint dir'
+  end
+
+  context 'root.child(roles)' do
+    let(:endpoint_name) { 'roles' }
+    let(:endpoint) { root_dir.child('roles') }
+
+    it_behaves_like 'a json rest endpoint dir'
+  end
+end

data/spec/chef_fs/file_system/cookbooks_dir_spec.rb

@@ -0,0 +1,549 @@
+require 'chef_fs/file_system/chef_server_root_dir'
+require 'chef_fs/file_system'
+
+describe ChefFS::FileSystem::CookbooksDir do
+  let(:root_dir) {
+    ChefFS::FileSystem::ChefServerRootDir.new('remote',
+    {
+      :chef_server_url => 'url',
+      :node_name => 'username',
+      :client_key => 'key',
+      :environment => 'env'
+    })
+  }
+  let(:cookbooks_dir) { root_dir.child('cookbooks') }
+  let(:should_list_cookbooks) do
+    @rest.should_receive(:get_rest).with('cookbooks').once.and_return(
+      {
+        "achild" => "http://opscode.com/achild",
+        "bchild" => "http://opscode.com/bchild"
+      })
+  end
+  before(:each) do
+    @rest = double("rest")
+    Chef::REST.stub(:new).with('url','username','key') { @rest }
+  end
+
+  it 'has / as parent' do
+    cookbooks_dir.parent.should == root_dir
+  end
+  it 'is a directory' do
+    cookbooks_dir.dir?.should be_true
+  end
+  it 'exists' do
+    cookbooks_dir.exists?.should be_true
+  end
+  it 'has name cookbooks' do
+    cookbooks_dir.name.should == 'cookbooks'
+  end
+  it 'has path /cookbooks' do
+    cookbooks_dir.path.should == '/cookbooks'
+  end
+  it 'has path_for_printing remote/cookbooks' do
+    cookbooks_dir.path_for_printing.should == 'remote/cookbooks'
+  end
+  it 'has correct children' do
+    should_list_cookbooks
+    cookbooks_dir.children.map { |child| child.name }.should =~ %w(achild bchild)
+  end
+  it 'can have directories as children' do
+    cookbooks_dir.can_have_child?('blah', true).should be_true
+  end
+  it 'cannot have files as children' do
+    cookbooks_dir.can_have_child?('blah', false).should be_false
+  end
+
+  #
+  # Cookbook dir (/cookbooks/<blah>)
+  #
+  shared_examples_for 'a segment directory' do
+    it 'has cookbook as parent' do
+      segment_dir.parent.should == cookbook_dir
+    end
+    it 'exists' do
+      segment_dir.exists?.should be_true
+    end
+    it 'is a directory' do
+      segment_dir.dir?.should be_true
+    end
+    it 'name is correct' do
+      segment_dir.name.should == segment_dir_name
+    end
+    it 'path is correct' do
+      segment_dir.path.should == "/cookbooks/#{cookbook_dir_name}/#{segment_dir_name}"
+    end
+    it 'path_for_printing is correct' do
+      segment_dir.path_for_printing.should == "remote/cookbooks/#{cookbook_dir_name}/#{segment_dir_name}"
+    end
+    it 'has the right children' do
+      segment_dir.children =~ %w(a.rb b.txt subdir)
+    end
+    it 'children are identical to child()' do
+      segment_dir.child('a.rb').should == segment_dir.children.select { |child| child.name == 'a.rb' }.first
+      segment_dir.child('b.txt').should == segment_dir.children.select { |child| child.name == 'b.txt' }.first
+      segment_dir.child('subdir').should == segment_dir.children.select { |child| child.name == 'subdir' }.first
+    end
+    context 'subdirectory' do
+      it 'has segment as a parent' do
+        segment_dir.child('subdir').parent.should == segment_dir
+      end
+      it 'exists' do
+        segment_dir.child('subdir').exists?.should be_true
+      end
+      it 'is a directory' do
+        segment_dir.child('subdir').dir?.should be_true
+      end
+      it 'name is subdir' do
+        segment_dir.child('subdir').name.should == 'subdir'
+      end
+      it 'path is correct' do
+        segment_dir.child('subdir').path.should == "/cookbooks/#{cookbook_dir_name}/#{segment_dir_name}/subdir"
+      end
+      it 'path_for_printing is correct' do
+        segment_dir.child('subdir').path_for_printing.should == "remote/cookbooks/#{cookbook_dir_name}/#{segment_dir_name}/subdir"
+      end
+      it 'has the right children' do
+        segment_dir.child('subdir').children =~ %w(a.rb b.txt)
+      end
+      it 'children are identical to child()' do
+        segment_dir.child('subdir').child('a.rb').should == segment_dir.child('subdir').children.select { |child| child.name == 'a.rb' }.first
+        segment_dir.child('subdir').child('b.txt').should == segment_dir.child('subdir').children.select { |child| child.name == 'b.txt' }.first
+      end
+    end
+  end
+
+  shared_examples_for 'a cookbook' do
+    it 'has cookbooks as parent' do
+      cookbook_dir.parent == cookbooks_dir
+    end
+    it 'is a directory' do
+      should_list_cookbooks
+      cookbook_dir.dir?.should be_true
+    end
+    it 'exists' do
+      should_list_cookbooks
+      cookbook_dir.exists?.should be_true
+    end
+    it 'has name <cookbook name>' do
+      cookbook_dir.name.should == cookbook_dir_name
+    end
+    it 'has path /cookbooks/<cookbook name>' do
+      cookbook_dir.path.should == "/cookbooks/#{cookbook_dir_name}"
+    end
+    it 'has path_for_printing remote/cookbooks/<cookbook name>' do
+      cookbook_dir.path_for_printing.should == "remote/cookbooks/#{cookbook_dir_name}"
+    end
+    it 'can have segment directories as children' do
+      cookbook_dir.can_have_child?('attributes', true).should be_true
+      cookbook_dir.can_have_child?('definitions', true).should be_true
+      cookbook_dir.can_have_child?('recipes', true).should be_true
+      cookbook_dir.can_have_child?('libraries', true).should be_true
+      cookbook_dir.can_have_child?('templates', true).should be_true
+      cookbook_dir.can_have_child?('files', true).should be_true
+      cookbook_dir.can_have_child?('resources', true).should be_true
+      cookbook_dir.can_have_child?('providers', true).should be_true
+    end
+    it 'cannot have arbitrary directories as children' do
+      cookbook_dir.can_have_child?('blah', true).should be_false
+      cookbook_dir.can_have_child?('root_files', true).should be_false
+    end
+    it 'can have files as children' do
+      cookbook_dir.can_have_child?('blah', false).should be_true
+      cookbook_dir.can_have_child?('root_files', false).should be_true
+      cookbook_dir.can_have_child?('attributes', false).should be_true
+      cookbook_dir.can_have_child?('definitions', false).should be_true
+      cookbook_dir.can_have_child?('recipes', false).should be_true
+      cookbook_dir.can_have_child?('libraries', false).should be_true
+      cookbook_dir.can_have_child?('templates', false).should be_true
+      cookbook_dir.can_have_child?('files', false).should be_true
+      cookbook_dir.can_have_child?('resources', false).should be_true
+      cookbook_dir.can_have_child?('providers', false).should be_true
+    end
+    # TODO test empty parts, cross-contamination (root_files named templates/x.txt, libraries named recipes/blah.txt)
+    context 'with a full directory structure' do
+      def json_file(path, checksum)
+        filename = ChefFS::PathUtils.split(path)[-1]
+        {
+          :name => filename,
+          :url => "cookbook_file:#{path}",
+          :checksum => checksum,
+          :path => path,
+          :specificity => "default"
+        }
+      end
+      def json_files(cookbook_dir)
+        result = []
+        files.each do |filename|
+          if filename =~ /^#{cookbook_dir}\//
+            result << json_file(filename, file_checksums[filename])
+          end
+        end
+        result
+      end
+      let(:files) {
+        result = []
+        %w(attributes definitions files libraries providers recipes resources templates).each do |segment|
+          result << "#{segment}/a.rb"
+          result << "#{segment}/b.txt"
+          result << "#{segment}/subdir/a.rb"
+          result << "#{segment}/subdir/b.txt"
+        end
+        result << 'a.rb'
+        result << 'b.txt'
+        result << 'subdir/a.rb'
+        result << 'subdir/b.txt'
+        result << 'root_files'
+        result
+      }
+      let(:file_checksums) {
+        result = {}
+        files.each_with_index do |file, i|
+          result[file] = i.to_s(16)
+        end
+        result
+      }
+      let(:should_get_cookbook) do
+        cookbook = double('cookbook')
+        cookbook.should_receive(:manifest).and_return({
+          :attributes => json_files('attributes'),
+          :definitions => json_files('definitions'),
+          :files => json_files('files'),
+          :libraries => json_files('libraries'),
+          :providers => json_files('providers'),
+          :recipes => json_files('recipes'),
+          :resources => json_files('resources'),
+          :templates => json_files('templates'),
+          :root_files => [
+            json_file('a.rb', file_checksums['a.rb']),
+            json_file('b.txt', file_checksums['b.txt']),
+            json_file('subdir/a.rb', file_checksums['subdir/a.rb']),
+            json_file('subdir/b.txt', file_checksums['subdir/b.txt']),
+            json_file('root_files', file_checksums['root_files'])
+          ]
+        })
+        @rest.should_receive(:get_rest).with("cookbooks/#{cookbook_dir_name}/_latest").once.and_return(cookbook)
+      end
+
+      it 'has correct children' do
+        should_get_cookbook
+        cookbook_dir.children.map { |child| child.name }.should =~ %w(attributes definitions files libraries providers recipes resources templates a.rb b.txt subdir root_files)
+      end
+      it 'children and child() yield the exact same objects' do
+        should_get_cookbook
+        cookbook_dir.children.each { |child| child.should == cookbook_dir.child(child.name) }
+      end
+      it 'all files exist (recursive) and have correct parent, path, path_for_printing, checksum and type' do
+        should_get_cookbook
+        file_checksums.each do |path, checksum|
+          file = ChefFS::FileSystem.resolve_path(cookbook_dir, path)
+          file_parts = path.split('/')
+          if file_parts.length == 3
+            file.parent.parent.parent.should == cookbook_dir
+          elsif file_parts.length == 2
+            file.parent.parent.should == cookbook_dir
+          else
+            file.parent.should == cookbook_dir
+          end
+          file.exists?.should be_true
+          file.dir?.should be_false
+          file.name.should == file_parts[-1]
+          file.path.should == "/cookbooks/#{cookbook_dir_name}/#{path}"
+          file.path_for_printing.should == "remote/cookbooks/#{cookbook_dir_name}/#{path}"
+          file.checksum.should == checksum
+        end
+      end
+      it 'all files can be read' do
+        should_get_cookbook
+        files.each do |path|
+          @rest.should_receive(:get_rest).with("cookbook_file:#{path}").once.and_return("This is #{path}'s content")
+          @rest.should_receive(:sign_on_redirect).with(no_args()).once.and_return(true)
+          @rest.should_receive(:sign_on_redirect=).with(false).once
+          @rest.should_receive(:sign_on_redirect=).with(true).once
+          file = ChefFS::FileSystem.resolve_path(cookbook_dir, path)
+          file.read.should == "This is #{path}'s content"
+        end
+      end
+
+      context 'the attributes segment' do
+        let(:segment_dir) { cookbook_dir.child('attributes') }
+        let(:segment_dir_name) { 'attributes' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          should_get_cookbook
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'cannot have non-ruby files' do
+          should_get_cookbook
+          segment_dir.can_have_child?('blah.txt', false).should be_false
+          segment_dir.can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'cannot have subdirectories' do
+          should_get_cookbook
+          segment_dir.can_have_child?('blah', true).should be_false
+        end
+      end
+
+      context 'the definitions segment' do
+        let(:segment_dir) { cookbook_dir.child('definitions') }
+        let(:segment_dir_name) { 'definitions' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'cannot have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_false
+          segment_dir.can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'cannot have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_false
+        end
+      end
+
+      context 'the files segment' do
+        let(:segment_dir) { cookbook_dir.child('files') }
+        let(:segment_dir_name) { 'files' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'can have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_true
+          segment_dir.can_have_child?('.blah.txt', false).should be_true
+        end
+        it 'can have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_true
+        end
+        it 'subdirectories can have ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.rb', false).should be_true
+          segment_dir.child('subdir').can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'subdirectories can have non-ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.txt', false).should be_true
+          segment_dir.child('subdir').can_have_child?('.blah.txt', false).should be_true
+        end
+        it 'subdirectories can have subdirectories' do
+          segment_dir.child('subdir').can_have_child?('blah', true).should be_true
+        end
+      end
+
+      context 'the libraries segment' do
+        let(:segment_dir) { cookbook_dir.child('libraries') }
+        let(:segment_dir_name) { 'libraries' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'cannot have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_false
+          segment_dir.can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'cannot have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_false
+        end
+      end
+
+      context 'the providers segment' do
+        let(:segment_dir) { cookbook_dir.child('providers') }
+        let(:segment_dir_name) { 'providers' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'cannot have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_false
+          segment_dir.can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'can have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_true
+        end
+        it 'subdirectories can have ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.rb', false).should be_true
+          segment_dir.child('subdir').can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'subdirectories cannot have non-ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.txt', false).should be_false
+          segment_dir.child('subdir').can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'subdirectories can have subdirectories' do
+          segment_dir.child('subdir').can_have_child?('blah', true).should be_true
+        end
+      end
+
+      context 'the recipes segment' do
+        let(:segment_dir) { cookbook_dir.child('recipes') }
+        let(:segment_dir_name) { 'recipes' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'cannot have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_false
+          segment_dir.can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'cannot have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_false
+        end
+      end
+
+      context 'the resources segment' do
+        let(:segment_dir) { cookbook_dir.child('resources') }
+        let(:segment_dir_name) { 'resources' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'cannot have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_false
+          segment_dir.can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'can have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_true
+        end
+        it 'subdirectories can have ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.rb', false).should be_true
+          segment_dir.child('subdir').can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'subdirectories cannot have non-ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.txt', false).should be_false
+          segment_dir.child('subdir').can_have_child?('.blah.txt', false).should be_false
+        end
+        it 'subdirectories can have subdirectories' do
+          segment_dir.child('subdir').can_have_child?('blah', true).should be_true
+        end
+      end
+
+      context 'the templates segment' do
+        let(:segment_dir) { cookbook_dir.child('templates') }
+        let(:segment_dir_name) { 'templates' }
+        it_behaves_like 'a segment directory'
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        it 'can have ruby files' do
+          segment_dir.can_have_child?('blah.rb', false).should be_true
+          segment_dir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'can have non-ruby files' do
+          segment_dir.can_have_child?('blah.txt', false).should be_true
+          segment_dir.can_have_child?('.blah.txt', false).should be_true
+        end
+        it 'can have subdirectories' do
+          segment_dir.can_have_child?('blah', true).should be_true
+        end
+        it 'subdirectories can have ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.rb', false).should be_true
+          segment_dir.child('subdir').can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'subdirectories can have non-ruby files' do
+          segment_dir.child('subdir').can_have_child?('blah.txt', false).should be_true
+          segment_dir.child('subdir').can_have_child?('.blah.txt', false).should be_true
+        end
+        it 'subdirectories can have subdirectories' do
+          segment_dir.child('subdir').can_have_child?('blah', true).should be_true
+        end
+      end
+
+      context 'root subdirectories' do
+        let(:root_subdir) { cookbook_dir.child('subdir') }
+
+        before(:each) do
+          should_get_cookbook
+        end
+
+        # Really, since these shouldn't exist in the first place,
+        # it doesn't matter; but these REALLY shouldn't be able to
+        # have any files in them at all.
+        it 'can have ruby files' do
+          root_subdir.can_have_child?('blah.rb', false).should be_true
+          root_subdir.can_have_child?('.blah.rb', false).should be_true
+        end
+        it 'can have non-ruby files' do
+          root_subdir.can_have_child?('blah.txt', false).should be_true
+          root_subdir.can_have_child?('.blah.txt', false).should be_true
+        end
+        it 'cannot have subdirectories' do
+          root_subdir.can_have_child?('blah', true).should be_false
+        end
+      end
+    end
+  end
+
+  context 'achild from cookbooks_dir.children' do
+    let(:cookbook_dir_name) { 'achild' }
+    let(:cookbook_dir) do
+      should_list_cookbooks
+      cookbooks_dir.children.select { |child| child.name == 'achild' }.first
+    end
+    it_behaves_like 'a cookbook'
+  end
+  context 'cookbooks_dir.child(achild)' do
+    let(:cookbook_dir_name) { 'achild' }
+    let(:cookbook_dir) { cookbooks_dir.child('achild') }
+    it_behaves_like 'a cookbook'
+  end
+  context 'nonexistent cookbooks_dir.child()' do
+    let(:nonexistent_child) { cookbooks_dir.child('blah') }
+    it 'has correct parent, name, path and path_for_printing' do
+      nonexistent_child.parent.should == cookbooks_dir
+      nonexistent_child.name.should == "blah"
+      nonexistent_child.path.should == "/cookbooks/blah"
+      nonexistent_child.path_for_printing.should == "remote/cookbooks/blah"
+    end
+    it 'does not exist' do
+      should_list_cookbooks
+      nonexistent_child.exists?.should be_false
+    end
+    it 'is a directory' do
+      should_list_cookbooks
+      nonexistent_child.dir?.should be_false
+    end
+    it 'read returns NotFoundError' do
+      expect { nonexistent_child.read }.to raise_error(ChefFS::FileSystem::NotFoundError)
+    end
+  end
+
+end