knife-azure 1.8.7 → 1.9.0

data/lib/azure/service_management/storageaccount.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Barry Davis (barryd@jetstreamsoftware.com)
-# Copyright:: Copyright (c) 2010-2011 Opscode, Inc.
+# Copyright:: Copyright 2010-2018 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -20,16 +20,17 @@ module Azure
   class StorageAccounts
     include AzureUtility
     def initialize(connection)
-      @connection=connection
+      @connection = connection
     end
+
     # force_load should be true when there is something in local cache and we want to reload
     # first call is always load.
     def load(force_load = false)
       if not @azure_storage_accounts || force_load
         @azure_storage_accounts = begin
           azure_storage_accounts = Hash.new
-          responseXML = @connection.query_azure('storageservices')
-          servicesXML = responseXML.css('StorageServices StorageService')
+          responseXML = @connection.query_azure("storageservices")
+          servicesXML = responseXML.css("StorageServices StorageService")
           servicesXML.each do |serviceXML|
             storage = StorageAccount.new(@connection).parse(serviceXML)
             azure_storage_accounts[storage.name] = storage
@@ -41,13 +42,13 @@ module Azure
     end
 
     def all
-      self.load.values
+      load.values
     end
 
     # first look up local cache if we have already loaded list.
     def exists?(name)
       return @azure_storage_accounts.key?(name) if @azure_storage_accounts
-      self.exists_on_cloud?(name)
+      exists_on_cloud?(name)
     end
 
     # Look up on cloud and not local cache
@@ -55,7 +56,7 @@ module Azure
       ret_val = @connection.query_azure("storageservices/#{name}")
       error_code, error_message = error_from_response_xml(ret_val) if ret_val
       if ret_val.nil? || error_code.length > 0
-        Chef::Log.warn 'Unable to find storage account:' + error_message + ' : ' + error_message if ret_val
+        Chef::Log.warn "Unable to find storage account:" + error_message + " : " + error_message if ret_val
         false
       else
         true
@@ -66,17 +67,18 @@ module Azure
       storage = StorageAccount.new(@connection)
       storage.create(params)
     end
+
     def clear_unattached
-      self.all.each do |storage|
+      all.each do |storage|
         next unless storage.attached == false
-        @connection.query_azure('storageaccounts/' + storage.name, 'delete')
+        @connection.query_azure("storageaccounts/" + storage.name, "delete")
       end
     end
 
     def delete(name)
-      if self.exists?(name)
-          servicecall = "storageservices/" + name
-        @connection.query_azure(servicecall, "delete") 
+      if exists?(name)
+        servicecall = "storageservices/" + name
+        @connection.query_azure(servicecall, "delete")
       end
     end
   end
@@ -90,30 +92,32 @@ module Azure
     def initialize(connection)
       @connection = connection
     end
+
     def parse(serviceXML)
-      @name = xml_content(serviceXML, 'ServiceName')
-      @description = xml_content(serviceXML, 'Description')
-      @label = xml_content(serviceXML, 'Label')
-      @affinitygroup = xml_content(serviceXML, 'AffinityGroup')
-      @location = xml_content(serviceXML, 'Location')
-      @georeplicationenabled = xml_content(serviceXML, 'GeoReplicationEnabled')
-      @extendpropertyname = xml_content(serviceXML, 'ExtendedProperties ExtendedProperty Name')
-      @extendpropertyvalue = xml_content(serviceXML, 'ExtendedProperties ExtendedProperty Value')
+      @name = xml_content(serviceXML, "ServiceName")
+      @description = xml_content(serviceXML, "Description")
+      @label = xml_content(serviceXML, "Label")
+      @affinitygroup = xml_content(serviceXML, "AffinityGroup")
+      @location = xml_content(serviceXML, "Location")
+      @georeplicationenabled = xml_content(serviceXML, "GeoReplicationEnabled")
+      @extendpropertyname = xml_content(serviceXML, "ExtendedProperties ExtendedProperty Name")
+      @extendpropertyvalue = xml_content(serviceXML, "ExtendedProperties ExtendedProperty Value")
       self
     end
+
     def create(params)
       builder = Nokogiri::XML::Builder.new do |xml|
-        xml.CreateStorageServiceInput('xmlns'=>'http://schemas.microsoft.com/windowsazure') {
+        xml.CreateStorageServiceInput("xmlns" => "http://schemas.microsoft.com/windowsazure") do
           xml.ServiceName params[:azure_storage_account]
           xml.Label Base64.encode64(params[:azure_storage_account])
-          xml.Description params[:azure_storage_account_description] || 'Explicitly created storage service'
+          xml.Description params[:azure_storage_account_description] || "Explicitly created storage service"
           # Location defaults to 'West US'
           if params[:azure_affinity_group]
             xml.AffinityGroup params[:azure_affinity_group]
-          else 
-            xml.Location params[:azure_service_location] || 'West US'
+          else
+            xml.Location params[:azure_service_location] || "West US"
           end
-        }
+        end
       end
       @connection.query_azure("storageservices", "post", builder.to_xml)
     end

data/lib/azure/service_management/utility.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Barry Davis (barryd@jetstreamsoftware.com)
-# Copyright:: Copyright (c) 2010-2011 Opscode, Inc.
+# Copyright:: Copyright 2010-2018 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,7 +17,7 @@
 #
 
 module AzureUtility
-  def xml_content(xml, key, default='')
+  def xml_content(xml, key, default = "")
     content = default
     node = xml.at_css(key)
     if node
@@ -27,15 +27,14 @@ module AzureUtility
   end
 
   def error_from_response_xml(response_xml)
-    error_code_and_message = ['','']
-    error_node = response_xml.at_css('Error')
+    error_code_and_message = ["", ""]
+    error_node = response_xml.at_css("Error")
 
     if error_node
-      error_code_and_message[0] = xml_content(error_node, 'Code')
-      error_code_and_message[1] = xml_content(error_node, 'Message')
+      error_code_and_message[0] = xml_content(error_node, "Code")
+      error_code_and_message[1] = xml_content(error_node, "Message")
     end
 
     error_code_and_message
   end
 end
-

data/lib/azure/service_management/vnet.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Jeff Mendoza (jeffmendoza@live.com)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Copyright:: Copyright 2013-2018 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -25,8 +25,8 @@ module Azure
     def load
       @vnets ||= begin
         @vnets = {}
-        response = @connection.query_azure('networking/virtualnetwork')
-        response.css('VirtualNetworkSite').each do |vnet|
+        response = @connection.query_azure("networking/virtualnetwork")
+        response.css("VirtualNetworkSite").each do |vnet|
           item = Vnet.new(@connection).parse(vnet)
           @vnets[item.name] = item
         end
@@ -62,73 +62,73 @@ module Azure
     end
 
     def parse(image)
-      @name = image.at_css('Name').content
-      @affinity_group = image.at_css('AffinityGroup') ? image.at_css('AffinityGroup').content : ""
-      @state = image.at_css('State').content
+      @name = image.at_css("Name").content
+      @affinity_group = image.at_css("AffinityGroup") ? image.at_css("AffinityGroup").content : ""
+      @state = image.at_css("State").content
       self
     end
 
     def create(params)
-      response = @connection.query_azure('networking/media')
-      if response.at_css("Error") && response.at_css('Code').text == "ResourceNotFound"
+      response = @connection.query_azure("networking/media")
+      if response.at_css("Error") && response.at_css("Code").text == "ResourceNotFound"
         builder = Nokogiri::XML::Builder.new do |xml|
           xml.NetworkConfiguration(
-            'xmlns'=>'http://schemas.microsoft.com/ServiceHosting/2011/07/NetworkConfiguration'
-          ) {
+            "xmlns" => "http://schemas.microsoft.com/ServiceHosting/2011/07/NetworkConfiguration"
+          ) do
 
-            xml.VirtualNetworkConfiguration {
-              xml.VirtualNetworkSites {
-                xml.VirtualNetworkSite('name' => params[:azure_vnet_name], 'AffinityGroup' => params[:azure_ag_name]) {
+            xml.VirtualNetworkConfiguration do
+              xml.VirtualNetworkSites do
+                xml.VirtualNetworkSite("name" => params[:azure_vnet_name], "AffinityGroup" => params[:azure_ag_name]) do
                   if params[:azure_address_space]
-                    xml.AddressSpace {
+                    xml.AddressSpace do
                       xml.AddressPrefix params[:azure_address_space]
-                    }
+                    end
                   end
-                  xml.Subnets{
-                    xml.Subnet('name' => params[:azure_subnet_name]) {
+                  xml.Subnets do
+                    xml.Subnet("name" => params[:azure_subnet_name]) do
                       xml.AddressPrefix params[:azure_address_space]
-                    }
-                  }
-                }
-              }
-            }
-          }
+                    end
+                  end
+                end
+              end
+            end
+          end
         end
         puts("Creating New Virtual Network: #{params[:azure_vnet_name]}...")
         response = builder
       else
-        vnets = response.css('VirtualNetworkSite')
+        vnets = response.css("VirtualNetworkSite")
         vnet = nil
-        vnets.each { |vn| vnet = vn if vn['name'] == params[:azure_vnet_name] }
+        vnets.each { |vn| vnet = vn if vn["name"] == params[:azure_vnet_name] }
         add = vnet.nil?
-        vnet = Nokogiri::XML::Node.new('VirtualNetworkSite', response) if add
-        vnet['name'] = params[:azure_vnet_name]
-        vnet['AffinityGroup'] = params[:azure_ag_name]
-        if add || !vnet.at_css('AddressSpace')    ## create a new AddressSpace block in XML if VNet or AddressSpace block does not already exist
-          addr_space = Nokogiri::XML::Node.new('AddressSpace', response)
-        else    ## retrieve object of existing AddressSpace if VNet or AddressSpace already exist
-          addr_space = vnet.at_css('AddressSpace')
+        vnet = Nokogiri::XML::Node.new("VirtualNetworkSite", response) if add
+        vnet["name"] = params[:azure_vnet_name]
+        vnet["AffinityGroup"] = params[:azure_ag_name]
+        if add || !vnet.at_css("AddressSpace") ## create a new AddressSpace block in XML if VNet or AddressSpace block does not already exist
+          addr_space = Nokogiri::XML::Node.new("AddressSpace", response)
+        else ## retrieve object of existing AddressSpace if VNet or AddressSpace already exist
+          addr_space = vnet.at_css("AddressSpace")
         end
-        addr_prefix = Nokogiri::XML::Node.new('AddressPrefix', response)
+        addr_prefix = Nokogiri::XML::Node.new("AddressPrefix", response)
         addr_prefix.content = params[:azure_address_space]
-        if add || !vnet.at_css('Subnets')   ## create a new Subnets block in XML if VNet or Subnets block does not already exist
-          subnets = Nokogiri::XML::Node.new('Subnets', response)
-        else    ## retrieve object of existing Subnets if VNet or Subnets already exist
-          subnets = vnet.at_css('Subnets')
+        if add || !vnet.at_css("Subnets") ## create a new Subnets block in XML if VNet or Subnets block does not already exist
+          subnets = Nokogiri::XML::Node.new("Subnets", response)
+        else ## retrieve object of existing Subnets if VNet or Subnets already exist
+          subnets = vnet.at_css("Subnets")
         end
-        saddr_prefix = Nokogiri::XML::Node.new('AddressPrefix', response)
+        saddr_prefix = Nokogiri::XML::Node.new("AddressPrefix", response)
         saddr_prefix.content = params[:azure_address_space]
-        subnet = Nokogiri::XML::Node.new('Subnet', response)
-        subnet['name'] = params[:azure_subnet_name]
+        subnet = Nokogiri::XML::Node.new("Subnet", response)
+        subnet["name"] = params[:azure_subnet_name]
         subnet.children = saddr_prefix
         subnets.children = subnet
-        vnet.add_child(subnets) if add || !vnet.at_css('Subnets')
+        vnet.add_child(subnets) if add || !vnet.at_css("Subnets")
         addr_space.children = addr_prefix
-        vnet.add_child(addr_space) if add || !vnet.at_css('AddressSpace')
+        vnet.add_child(addr_space) if add || !vnet.at_css("AddressSpace")
         vnets.last.add_next_sibling(vnet) if add
         puts("Updating existing Virtual Network: #{params[:azure_vnet_name]}...")
       end
-      @connection.query_azure('networking/media', 'put', response.to_xml)
+      @connection.query_azure("networking/media", "put", response.to_xml)
     end
   end
-end
+end

data/lib/chef/knife/azure_ag_create.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Jeff Mendoza (jeffmendoza@live.com)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Copyright:: Copyright 2013-2018 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,36 +16,36 @@
 # limitations under the License.
 #
 
-require File.expand_path('../azure_base', __FILE__)
+require File.expand_path("../azure_base", __FILE__)
 
 class Chef
   class Knife
     class AzureAgCreate < Knife
       include Knife::AzureBase
 
-      banner 'knife azure ag create (options)'
+      banner "knife azure ag create (options)"
 
       option :azure_affinity_group,
-        :short => '-a GROUP',
-        :long => '--azure-affinity-group GROUP',
-        :description => 'Specifies new affinity group name.'
+        :short => "-a GROUP",
+        :long => "--azure-affinity-group GROUP",
+        :description => "Specifies new affinity group name."
 
       option :azure_ag_desc,
-        :long => '--azure-ag-desc DESC',
-        :description => 'Optional. Description for new affinity group.'
+        :long => "--azure-ag-desc DESC",
+        :description => "Optional. Description for new affinity group."
 
       option :azure_service_location,
-        :short => '-m LOCATION',
-        :long => '--azure-service-location LOCATION',
-        :description => 'Specifies the geographic location - the name of '\
-                        'the data center location that is valid for your '\
-                        'subscription. Eg: West US, East US, '\
-                        'East Asia, Southeast Asia, North Europe, West Europe'
+        :short => "-m LOCATION",
+        :long => "--azure-service-location LOCATION",
+        :description => "Specifies the geographic location - the name of "\
+                        "the data center location that is valid for your "\
+                        "subscription. Eg: West US, East US, "\
+                        "East Asia, Southeast Asia, North Europe, West Europe"
 
       def run
         $stdout.sync = true
 
-        Chef::Log.info('validating...')
+        Chef::Log.info("validating...")
         validate_asm_keys!(:azure_affinity_group,
                    :azure_service_location)
 
@@ -57,9 +57,9 @@ class Chef
 
         rsp = service.create_affinity_group(params)
         print "\n"
-        if rsp.at_css('Status').nil?
-          if rsp.at_css('Code').nil? || rsp.at_css('Message').nil?
-            puts 'Unknown Error. try -VV'
+        if rsp.at_css("Status").nil?
+          if rsp.at_css("Code").nil? || rsp.at_css("Message").nil?
+            puts "Unknown Error. try -VV"
           else
             puts "#{rsp.at_css('Code').content}: "\
                  "#{rsp.at_css('Message').content}"

data/lib/chef/knife/azure_ag_list.rb

@@ -1,6 +1,6 @@
 #
 # Author:: Jeff Mendoza (jeffmendoza@live.com)
-# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# Copyright:: Copyright 2013-2018 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,14 +16,14 @@
 # limitations under the License.
 #
 
-require File.expand_path('../azure_base', __FILE__)
+require File.expand_path("../azure_base", __FILE__)
 
 class Chef
   class Knife
     class AzureAgList < Knife
       include Knife::AzureBase
 
-      banner 'knife azure ag list (options)'
+      banner "knife azure ag list (options)"
 
       def run
         $stdout.sync = true

data/lib/chef/knife/azure_base.rb

@@ -1,7 +1,7 @@
 
 # Author:: Barry Davis (barryd@jetstreamsoftware.com)
-# Author:: Seth Chisamore (<schisamo@opscode.com>)
-# Copyright:: Copyright (c) 2011 Opscode, Inc.
+# Author:: Seth Chisamore (<schisamo@chef.io>)
+# Copyright:: Copyright 2011-2018 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,8 +17,8 @@
 # limitations under the License.
 #
 
-require 'chef/knife'
-require 'azure/service_management/ASM_interface'
+require "chef/knife"
+require "azure/service_management/ASM_interface"
 
 class Chef
   class Knife
@@ -31,8 +31,8 @@ class Chef
         includer.class_eval do
 
           deps do
-            require 'readline'
-            require 'chef/json_compat'
+            require "readline"
+            require "chef/json_compat"
           end
 
           option :azure_subscription_id,
@@ -70,7 +70,7 @@ class Chef
         images = service.list_images
         target_image = images.select { |i| i.name == locate_config_value(:azure_source_image) }
         unless target_image[0].nil?
-          return target_image[0].os == 'Windows'
+          return target_image[0].os == "Windows"
         else
           ui.error("Invalid image. Use the command \"knife azure image list\" to verify the image name")
           exit 1
@@ -95,7 +95,7 @@ class Chef
         config[key] || Chef::Config[:knife][key]
       end
 
-      def msg_pair(label, value, color=:cyan)
+      def msg_pair(label, value, color = :cyan)
         if value && !value.to_s.empty?
           puts "#{ui.color(label, color)}: #{value}"
         end
@@ -103,24 +103,24 @@ class Chef
 
       def msg_server_summary(server)
         puts "\n"
-        msg_pair('DNS Name', server.hostedservicename + ".cloudapp.net")
-        msg_pair('VM Name', server.name)
-        msg_pair('Size', server.size)
-        msg_pair('Azure Source Image', locate_config_value(:azure_source_image))
-        msg_pair('Azure Service Location', locate_config_value(:azure_service_location))
-        msg_pair('Public Ip Address', server.publicipaddress)
-        msg_pair('Private Ip Address', server.ipaddress)
-        msg_pair('SSH Port', server.sshport) unless server.sshport.nil?
-        msg_pair('WinRM Port', server.winrmport) unless server.winrmport.nil?
-        msg_pair('TCP Ports', server.tcpports) unless server.tcpports.nil? or server.tcpports.empty?
-        msg_pair('UDP Ports', server.udpports) unless server.udpports.nil? or server.udpports.empty?
-        msg_pair('Environment', locate_config_value(:environment) || '_default')
-        msg_pair('Runlist', locate_config_value(:run_list)) unless locate_config_value(:run_list).empty?
+        msg_pair("DNS Name", server.hostedservicename + ".cloudapp.net")
+        msg_pair("VM Name", server.name)
+        msg_pair("Size", server.size)
+        msg_pair("Azure Source Image", locate_config_value(:azure_source_image))
+        msg_pair("Azure Service Location", locate_config_value(:azure_service_location))
+        msg_pair("Public Ip Address", server.publicipaddress)
+        msg_pair("Private Ip Address", server.ipaddress)
+        msg_pair("SSH Port", server.sshport) unless server.sshport.nil?
+        msg_pair("WinRM Port", server.winrmport) unless server.winrmport.nil?
+        msg_pair("TCP Ports", server.tcpports) unless server.tcpports.nil? || server.tcpports.empty?
+        msg_pair("UDP Ports", server.udpports) unless server.udpports.nil? || server.udpports.empty?
+        msg_pair("Environment", locate_config_value(:environment) || "_default")
+        msg_pair("Runlist", locate_config_value(:run_list)) unless locate_config_value(:run_list).empty?
         puts "\n"
       end
 
       def pretty_key(key)
-        key.to_s.gsub(/_/, ' ').gsub(/\w+/){ |w| (w =~ /(ssh)|(aws)/i) ? w.upcase  : w.capitalize }
+        key.to_s.tr("_", " ").gsub(/\w+/) { |w| (w =~ /(ssh)|(aws)/i) ? w.upcase : w.capitalize }
       end
 
       # validate command pre-requisites (cli options)
@@ -172,12 +172,12 @@ class Chef
           exit 1
         end
 
-        if locate_config_value(:extended_logs) && locate_config_value(:bootstrap_protocol) != 'cloud-api'
+        if locate_config_value(:extended_logs) && locate_config_value(:bootstrap_protocol) != "cloud-api"
           ui.error("--extended-logs option only works with --bootstrap-protocol cloud-api")
           exit 1
         end
 
-        if locate_config_value(:bootstrap_protocol) == 'cloud-api' && locate_config_value(:azure_vm_name).nil? && locate_config_value(:azure_dns_name).nil?
+        if locate_config_value(:bootstrap_protocol) == "cloud-api" && locate_config_value(:azure_vm_name).nil? && locate_config_value(:azure_dns_name).nil?
           ui.error("Specifying the DNS name using --azure-dns-name or VM name using --azure-vm-name option is required with --bootstrap-protocol cloud-api")
           exit 1
         end
@@ -187,7 +187,7 @@ class Chef
             raise ArgumentError, "The daemon option is only supported for Windows nodes."
           end
 
-          unless  locate_config_value(:bootstrap_protocol) == 'cloud-api'
+          unless  locate_config_value(:bootstrap_protocol) == "cloud-api"
             raise ArgumentError, "The --daemon option requires the use of --bootstrap-protocol cloud-api"
           end
 
@@ -205,7 +205,7 @@ class Chef
             errors << "You did not provide a valid '#{pretty_key(k)}' value. Please set knife[:#{k}] in your knife.rb or pass as an option."
           end
         end
-        if errors.each{|e| ui.error(e)}.any?
+        if errors.each { |e| ui.error(e) }.any?
           exit 1
         end
       end
@@ -215,11 +215,11 @@ class Chef
         mandatory_keys = [:azure_subscription_id, :azure_mgmt_cert, :azure_api_host_name]
         keys.concat(mandatory_keys)
 
-        if(locate_config_value(:azure_mgmt_cert) != nil)
+        if !locate_config_value(:azure_mgmt_cert).nil?
           config[:azure_mgmt_cert] = File.read find_file(locate_config_value(:azure_mgmt_cert))
         end
 
-        if(locate_config_value(:azure_publish_settings_file) != nil)
+        if !locate_config_value(:azure_publish_settings_file).nil?
           parse_publish_settings_file(locate_config_value(:azure_publish_settings_file))
         elsif locate_config_value(:azure_subscription_id).nil? && locate_config_value(:azure_mgmt_cert).nil? && locate_config_value(:azure_api_host_name).nil?
           azureprofile_file = get_azure_profile_file_path
@@ -231,10 +231,10 @@ class Chef
       end
 
       def parse_publish_settings_file(filename)
-        require 'nokogiri'
-        require 'base64'
-        require 'openssl'
-        require 'uri'
+        require "nokogiri"
+        require "base64"
+        require "openssl"
+        require "uri"
         begin
           doc = Nokogiri::XML(File.open(find_file(filename)))
           profile = doc.at_css("PublishProfile")
@@ -258,23 +258,23 @@ class Chef
       end
 
       def get_azure_profile_file_path
-        '~/.azure/azureProfile.json'
+        "~/.azure/azureProfile.json"
       end
 
       def parse_azure_profile(filename, errors)
-        require 'openssl'
-        require 'uri'
+        require "openssl"
+        require "uri"
         errors = [] if errors.nil?
         azure_profile = File.read(File.expand_path(filename))
         azure_profile = JSON.parse(azure_profile)
         default_subscription = get_default_subscription(azure_profile)
-        if default_subscription.has_key?('id') && default_subscription.has_key?('managementCertificate') && default_subscription.has_key?('managementEndpointUrl')
+        if default_subscription.has_key?("id") && default_subscription.has_key?("managementCertificate") && default_subscription.has_key?("managementEndpointUrl")
 
-          Chef::Config[:knife][:azure_subscription_id] = default_subscription['id']
-          mgmt_key = OpenSSL::PKey::RSA.new(default_subscription['managementCertificate']['key']).to_pem
-          mgmt_cert = OpenSSL::X509::Certificate.new(default_subscription['managementCertificate']['cert']).to_pem
+          Chef::Config[:knife][:azure_subscription_id] = default_subscription["id"]
+          mgmt_key = OpenSSL::PKey::RSA.new(default_subscription["managementCertificate"]["key"]).to_pem
+          mgmt_cert = OpenSSL::X509::Certificate.new(default_subscription["managementCertificate"]["cert"]).to_pem
           Chef::Config[:knife][:azure_mgmt_cert] = mgmt_key + mgmt_cert
-          Chef::Config[:knife][:azure_api_host_name] = URI(default_subscription['managementEndpointUrl']).host
+          Chef::Config[:knife][:azure_api_host_name] = URI(default_subscription["managementEndpointUrl"]).host
         else
           errors << "Check if values set for 'id', 'managementCertificate', 'managementEndpointUrl' in -> #{filename} for 'defaultSubscription'. \n  OR "
         end
@@ -283,8 +283,8 @@ class Chef
 
       def get_default_subscription(azure_profile)
         first_subscription_as_default = nil
-        azure_profile['subscriptions'].each do |subscription|
-          if subscription['isDefault']
+        azure_profile["subscriptions"].each do |subscription|
+          if subscription["isDefault"]
             Chef::Log.info("Default subscription \'#{subscription['name']}\'' selected.")
             return subscription
           end
@@ -295,7 +295,7 @@ class Chef
         if first_subscription_as_default
           Chef::Log.info("First subscription \'#{subscription['name']}\' selected as default.")
         else
-          Chef::Log.info('No subscriptions found.')
+          Chef::Log.info("No subscriptions found.")
           exit 1
         end
         first_subscription_as_default
@@ -308,10 +308,10 @@ class Chef
           file = name
         elsif config_dir && File.exist?(File.join(config_dir, name))
           file = File.join(config_dir, name)
-        elsif File.exist?(File.join(ENV['HOME'], '.chef', name))
-          file = File.join(ENV['HOME'], '.chef', name)
+        elsif File.exist?(File.join(ENV["HOME"], ".chef", name))
+          file = File.join(ENV["HOME"], ".chef", name)
         else
-          ui.error('Unable to find file - ' + name)
+          ui.error("Unable to find file - " + name)
           exit 1
         end
         file
@@ -327,15 +327,15 @@ class Chef
       def fetch_role
         deployment = fetch_deployment
 
-        if deployment.at_css('Deployment Name') != nil
-          role_list_xml =  deployment.css('RoleInstanceList RoleInstance')
+        if deployment.at_css("Deployment Name") != nil
+          role_list_xml = deployment.css("RoleInstanceList RoleInstance")
           role_list_xml.each do |role|
             if role.at_css("RoleName").text == (locate_config_value(:azure_vm_name) || @name_args[0])
               return role
             end
           end
         end
-        return nil
+        nil
       end
 
       def fetch_extension(role)
@@ -347,7 +347,7 @@ class Chef
             return ext
           end
         end
-        return nil
+        nil
       end
 
       def fetch_substatus(extension)
@@ -358,19 +358,19 @@ class Chef
             return substatus
           end
         end
-        return nil
+        nil
       end
 
       def fetch_chef_client_logs(fetch_process_start_time, fetch_process_wait_timeout)
         ## fetch server details ##
         role = fetch_role
-        if role != nil
+        if !role.nil?
           ## fetch Chef Extension details deployed on the server ##
           ext = fetch_extension(role)
-          if ext != nil
+          if !ext.nil?
             ## fetch substatus field which contains the chef-client run logs ##
             substatus = fetch_substatus(ext)
-            if substatus != nil
+            if !substatus.nil?
               ## chef-client run logs becomes available ##
               name = substatus.at_css("Name").text
               status = substatus.at_css("Status").text
@@ -393,11 +393,11 @@ class Chef
               end
               puts "#{ui.color(status, color, :bold)}"
               puts "----> chef-client run logs: "
-              puts "\n#{message}\n"  ## message field of substatus contains the chef-client run logs ##
+              puts "\n#{message}\n" ## message field of substatus contains the chef-client run logs ##
             else
               ## unavailability of the substatus field indicates that chef-client run is not completed yet on the server ##
               fetch_process_wait_time = ((Time.now - fetch_process_start_time) / 60).round
-              if fetch_process_wait_time <= fetch_process_wait_timeout  ## wait for maximum 30 minutes until chef-client run logs becomes available ##
+              if fetch_process_wait_time <= fetch_process_wait_timeout ## wait for maximum 30 minutes until chef-client run logs becomes available ##
                 print "#{ui.color('.', :bold)}"
                 sleep 30
                 fetch_chef_client_logs(fetch_process_start_time, fetch_process_wait_timeout)