knapsack_pro 8.0.0 → 8.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c531fc28ddde021a2417447b60d2feaec8924994bb5575cf1f3cd63484d2fa2b
-  data.tar.gz: 28eb5e92aff6522f1dfb31b2c2c076bb54f6e50daec25985a09286fb337fec90
+  metadata.gz: cc4bed2e7600e26f350d8f1847550aaea7be38b032a029a589e6082dbb31b31c
+  data.tar.gz: 2a66e48a7ccb7be83a553a2746611ce5addeac2114aa469c75f6a6faa3ee70a3
 SHA512:
-  metadata.gz: 5b66568ea07f6ab6ef881e61d3f3affa5d9ba0c0201c64c2292573fc11afc8e212e4d848e63c22b2596b9e4ea36780ad4f5b72a25f729370e463f865aed324c4
-  data.tar.gz: '0021619b437b7815807667549ee8a49ffcfca23358b3456e3cbbc5331f2a03a535f271c9cdbf5c83db632709c47ec82e50f3806aab30a0660763011efe9e7800'
+  metadata.gz: cca2870484c23ce7aed1ab44b43a8ba4c862d37c2c9a29ec54b627433fef05cb43f0126a611e888ffb0a5cbc8fe13e01f7b97dd7c61b64404771a0a2c190db70
+  data.tar.gz: 6db4e20ea3aaa81b1467971435688667004576402bb9f686a0287f3c54d82dab84c1271ef78605e46d5d4050e634cc3d8e229dffd81a3d8646e3eb81b68eebad

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+### 8.0.1
+
+* Fix detection of id paths for Turnip, which resulted in sending to the API both file and id paths timings
+    * Example:
+      * turnip/acceptance/foo.feature[1:1:1] 0 seconds
+      * turnip/acceptance/foo.feature[1:1:2] 0 seconds
+      * turnip/acceptance/foo.feature 30 milliseconds (time recorded for [1:1:1] or [1:1:2])
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/290
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v8.0.0...v8.0.1
+
 ### 8.0.0
 
 * Enable [`KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES`](https://docs.knapsackpro.com/ruby/split-by-test-examples/) by default

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -6,7 +6,8 @@ module KnapsackPro
   module Adapters
     class RSpecAdapter < BaseAdapter
       TEST_DIR_PATTERN = 'spec/**{,/*/**}/*_spec.rb'
-      ID_PATH_REGEX = /.+_spec\.rb\[.+\]$/
+      # https://github.com/rspec/rspec/blob/86b5e4218eece4c1913fe9aad24c0a96d8bc9f40/rspec-core/lib/rspec/core/example.rb#L122
+      REGEX = /^(.*?)(?:\[([\d\s:,]+)\])?$/.freeze
 
       def self.split_by_test_cases_enabled?
         return false unless KnapsackPro::Config::Env.rspec_split_by_test_examples?
@@ -81,7 +82,8 @@ module KnapsackPro
       end
 
       def self.id_path?(path)
-        ID_PATH_REGEX.match?(path)
+        _file, id = path.match(REGEX).captures
+        !id.nil?
       end
 
       def self.rails_helper_exists?(test_dir)

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '8.0.0'
+  VERSION = '8.0.1'
 end

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -148,23 +148,41 @@ describe KnapsackPro::Adapters::RSpecAdapter do
   describe '.id_path?' do
     subject { described_class.id_path?(path) }
 
-    context 'when the path resembles the RSpec path with id' do
+    context 'when the path is an RSpec path with id' do
       let(:path) { 'spec/features/a_spec.rb[1:1:7:1]' }
 
       it { is_expected.to be true }
     end
 
-    context 'when the path resembles the RSpec path with multiple ids' do
+    context 'when the path is an RSpec path with multiple ids' do
       let(:path) { 'spec/features/a_spec.rb[1:1:7:1, 1:2]' }
 
       it { is_expected.to be true }
     end
 
-    context "when the path doesn't resemble the RSpec path with id" do
+    context 'when the path is an RSpec path with no id' do
       let(:path) { 'spec/features/a_spec.rb' }
 
       it { is_expected.to be false }
     end
+
+    context 'when the path is a Turnip path with id' do
+      let(:path) { 'spec/acceptance/a.feature[1:1:7:1]' }
+
+      it { is_expected.to be true }
+    end
+
+    context 'when the path is a Turnip path with multiple ids' do
+      let(:path) { 'spec/acceptance/a.feature[1:1:7:1,1:2]' }
+
+      it { is_expected.to be true }
+    end
+
+    context 'when the path is a Turnip path with no id' do
+      let(:path) { 'spec/acceptance/a.feature' }
+
+      it { is_expected.to be false }
+    end
   end
 
   describe '.rails_helper_exists?' do

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 8.0.0
+  version: 8.0.1
 platform: ruby
 authors:
 - ArturT
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-25 00:00:00.000000000 Z
+date: 2025-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -418,7 +417,6 @@ metadata:
   documentation_uri: https://docs.knapsackpro.com/knapsack_pro-ruby/guide/
   homepage_uri: https://knapsackpro.com
   source_code_uri: https://github.com/KnapsackPro/knapsack_pro-ruby
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -433,8 +431,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel
   job finish work at a similar time.