knapsack_pro 7.9.0 → 7.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d625a03b86be895a8b0250cc4bc19e9a3a53065f99d05266e1a2a3a09c8e115
-  data.tar.gz: b89c5d69fd4330ff4bec30c5a44a37d4bc6a6622743e75044aafcfaae13b5a4f
+  metadata.gz: 173300dc2ec82a1b5a15005c91ac3ceb942c40acbb14fd2ba57e64d2a32b67d8
+  data.tar.gz: c0c856044ce6773dce0968ebd620f4c49e1fea170c30d880af90ace2e1fb66c1
 SHA512:
-  metadata.gz: f30db8ff8c5f391814991fc565036b35c416f2c2015d48e9385ad2bd8b2dbd242867817df03fcd053b152c31b2e142da07f50069251b0a586dc6ef572833b05a
-  data.tar.gz: 285de6eab1d7fb36c457ca3361748208064bcbfe6cf937a37cc6997b2c1334e121545072ffab7cfc2096ef877837faa0f5c70930d35dca29c80a880add04c5d7
+  metadata.gz: e078dce53b72374ef499087c9675eea34272769a46154997e55dc06ab23e4da7fa016206297eed8b3cc660c5238a99b16177abb6f45c191e3bd38dc60c9cee6f
+  data.tar.gz: 5a80b8cbc3dc3273e297693263a9223fab250d1ee6adbd2c6c909f904d35430f3403a1f9da92dc2709adc3f30f8311b8d05d34b6292e8952e1aae42c88f8f977

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+### 7.10.0
+
+* Improve the RSpec split by examples feature. Use test file execution times for existing test files on the disk to determine slow test files. This fixes issue with detecting slow test files when API token is shared between multiple test suites.
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/277
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.9.0...v7.10.0
+
 ### 7.9.0
 
 * A more readable error message for the RSpec split by examples JSON report (remove ANSI codes that are not human-readable)

data/lib/knapsack_pro/slow_test_file_determiner.rb

@@ -5,9 +5,9 @@ module KnapsackPro
     TIME_THRESHOLD_PER_CI_NODE = 0.7 # 70%
 
     # test_files: { 'path' => 'a_spec.rb', 'time_execution' => 0.0 }
-    # time_execution: of build distribution (total time of CI build run)
-    def self.call(test_files, time_execution)
-      time_threshold = (time_execution / KnapsackPro::Config::Env.ci_node_total) * TIME_THRESHOLD_PER_CI_NODE
+    def self.call(test_files)
+      total_execution_time = test_files.sum { |test_file| test_file.fetch('time_execution') }
+      time_threshold = (total_execution_time / KnapsackPro::Config::Env.ci_node_total) * TIME_THRESHOLD_PER_CI_NODE
 
       test_files.select do |test_file|
         time_execution = test_file.fetch('time_execution')

data/lib/knapsack_pro/slow_test_file_finder.rb

@@ -19,7 +19,7 @@ module KnapsackPro
 
       test_files_existing_on_disk = KnapsackPro::TestFileFinder.select_test_files_that_can_be_run(adapter_class, merged_test_files_from_api)
 
-      slow_test_files = KnapsackPro::SlowTestFileDeterminer.call(test_files_existing_on_disk, build_distribution_entity.time_execution)
+      slow_test_files = KnapsackPro::SlowTestFileDeterminer.call(test_files_existing_on_disk)
 
       KnapsackPro::SlowTestFileDeterminer.save_to_json_report(slow_test_files)
 

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '7.9.0'
+  VERSION = '7.10.0'
 end

data/spec/knapsack_pro/slow_test_file_determiner_spec.rb

@@ -6,7 +6,7 @@ describe KnapsackPro::SlowTestFileDeterminer do
       expect(KnapsackPro::Config::Env).to receive(:ci_node_total).and_return(node_total)
     end
 
-    subject { described_class.call(test_files, time_execution) }
+    subject { described_class.call(test_files) }
 
     context 'when test files have recorded time execution' do
       let(:time_execution) { 20.0 }
@@ -14,22 +14,20 @@ describe KnapsackPro::SlowTestFileDeterminer do
         [
           { 'path' => 'a_spec.rb', 'time_execution' => 1.0 },
           { 'path' => 'b_spec.rb', 'time_execution' => 3.4 },
-          # slow tests are above 3.5s threshold (20.0 / 4 * 0.7 = 3.5)
           { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
-          { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
+          { 'path' => 'd_spec.rb', 'time_execution' => 12.1 },
         ]
       end
 
-      it do
+      it 'detects slow tests above 3.5s threshold (20.0 / 4 nodes * 70% threshold = 3.5)' do
         expect(subject).to eq([
           { 'path' => 'c_spec.rb', 'time_execution' => 3.5 },
-          { 'path' => 'd_spec.rb', 'time_execution' => 5.9 },
+          { 'path' => 'd_spec.rb', 'time_execution' => 12.1 },
         ])
       end
     end
 
     context 'when test files have no recorded time execution' do
-      let(:time_execution) { 0.0 }
       let(:test_files) do
         [
           { 'path' => 'a_spec.rb', 'time_execution' => 0.0 },
@@ -41,6 +39,14 @@ describe KnapsackPro::SlowTestFileDeterminer do
         expect(subject).to eq([])
       end
     end
+
+    context 'when there are no test files' do
+      let(:test_files) { [] }
+
+      it do
+        expect(subject).to eq([])
+      end
+    end
   end
 
   describe '.save_to_json_report', :clear_tmp do

data/spec/knapsack_pro/slow_test_file_finder_spec.rb

@@ -13,8 +13,7 @@ describe KnapsackPro::SlowTestFileFinder do
 
       it do
         test_files_from_api = double
-        time_execution = double
-        build_distribution_entity = instance_double(KnapsackPro::BuildDistributionFetcher::BuildDistributionEntity, test_files: test_files_from_api, time_execution: time_execution)
+        build_distribution_entity = instance_double(KnapsackPro::BuildDistributionFetcher::BuildDistributionEntity, test_files: test_files_from_api)
         expect(KnapsackPro::BuildDistributionFetcher).to receive(:call).and_return(build_distribution_entity)
 
         merged_test_files_from_api = double
@@ -24,7 +23,7 @@ describe KnapsackPro::SlowTestFileFinder do
         expect(KnapsackPro::TestFileFinder).to receive(:select_test_files_that_can_be_run).with(adapter_class, merged_test_files_from_api).and_return(test_files_existing_on_disk)
 
         slow_test_files = double
-        expect(KnapsackPro::SlowTestFileDeterminer).to receive(:call).with(test_files_existing_on_disk, time_execution).and_return(slow_test_files)
+        expect(KnapsackPro::SlowTestFileDeterminer).to receive(:call).with(test_files_existing_on_disk).and_return(slow_test_files)
 
         expect(KnapsackPro::SlowTestFileDeterminer).to receive(:save_to_json_report).with(slow_test_files)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.9.0
+  version: 7.10.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-22 00:00:00.000000000 Z
+date: 2024-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake