knapsack_pro 7.4.0 → 7.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 965d1d9b1d138cf0db8abe0fb44fc1672d5992d9f40f014c0f1f72c370d82585
-  data.tar.gz: 9570a9c2ffd20d1324451106f7a6144a298b6efb02981eabdc1f354d5c289940
+  metadata.gz: cea03959b8de66cd8cbb686deb3ac76129f9cce7ee24b1da2a0ef9e57dd790df
+  data.tar.gz: ec12a1f99f57207e967846df739a5dfea4a1423e6823431ee9cf26f1d2f9a473
 SHA512:
-  metadata.gz: e7b335edb2e4107b44b0bf69b7cffdf0af110e316ad3d1f07190d919e23fe7172cae3081c5f97450174f1e0597f9d71387dafd8a0861aca604531a9cb1b1c26c
-  data.tar.gz: 269bc36e25e5a2048f2105f973523bc00dfba73b38ebf7eac482b121a8cd22a129f72c671579bd230830bcb3aa600428d2f7a5a3410ce1515c7ee4353fc36dde
+  metadata.gz: cd53605f0d47ce2a3bc83410eb56d459a65aa1b75b169c420f5a11e3693b2aa7abee8e5b984eff35ab876de53809a2c113abb38b253e1e1b42726c817bccae6b
+  data.tar.gz: 93eaec09e20ba573cfb69b0f1ad2e8a04f5db2ab95637767a1abed0d8640cf131447b1adae67196998d73165232ea1a23e2c1fe547ab01b14436ace7d422edc5

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+### 7.5.0
+* Raise when `KNAPSACK_PRO_CI_NODE_TOTAL` or `KNAPSACK_PRO_CI_NODE_INDEX` is missing and can't be determined from supported CI environments, instead of defaulting to arbitrary numbers.
+
+  https://github.com/KnapsackPro/knapsack_pro-ruby/pull/256
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.4.0...v7.5.0
+
 ### 7.4.0
 * Warn when `KNAPSACK_PRO_*` environment variables are set manually if their values could be automatically determined from supported CI environments.
 

data/lib/knapsack_pro/config/env.rb

@@ -13,11 +13,17 @@ module KnapsackPro
 
       class << self
         def ci_node_total
-          (env_for('KNAPSACK_PRO_CI_NODE_TOTAL', :node_total) || 1).to_i
+          env_name = 'KNAPSACK_PRO_CI_NODE_TOTAL'
+          env_value = env_for(env_name, :node_total)
+
+          env_value ? env_value.to_i : raise_missing_env_for(env_name)
         end
 
         def ci_node_index
-          (env_for('KNAPSACK_PRO_CI_NODE_INDEX', :node_index) || 0).to_i
+          env_name = 'KNAPSACK_PRO_CI_NODE_INDEX'
+          env_value = env_for(env_name, :node_index)
+
+          env_value ? env_value.to_i : raise_missing_env_for(env_name)
         end
 
         def ci_node_build_id
@@ -274,7 +280,7 @@ module KnapsackPro
         private
 
         def required_env(env_name)
-          ENV[env_name] || raise("Missing environment variable #{env_name}")
+          ENV[env_name] || raise_missing_env_for(env_name)
         end
 
         def env_for(knapsack_env_name, ci_env_method)
@@ -291,6 +297,10 @@ module KnapsackPro
         def ci_env_for(env_name)
           detected_ci.new.send(env_name)
         end
+
+        def raise_missing_env_for(env_name)
+          raise("Missing environment variable #{env_name}")
+        end
       end
     end
   end

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '7.4.0'
+  VERSION = '7.5.0'
 end

data/spec/knapsack_pro/config/env_spec.rb

@@ -54,7 +54,9 @@ describe KnapsackPro::Config::Env do
     end
 
     context "when ENV doesn't exist" do
-      it { should eq 1 }
+      it 'raises' do
+        expect { subject }.to raise_error(/Missing environment variable KNAPSACK_PRO_CI_NODE_TOTAL/)
+      end
     end
   end
 
@@ -118,7 +120,9 @@ describe KnapsackPro::Config::Env do
     end
 
     context "when ENV doesn't exist" do
-      it { should eq 0 }
+      it 'raises' do
+        expect { subject }.to raise_error(/Missing environment variable KNAPSACK_PRO_CI_NODE_INDEX/)
+      end
     end
   end
 

data/spec/knapsack_pro_spec.rb

@@ -36,13 +36,11 @@ describe KnapsackPro do
           stub_const('ENV', {
             'KNAPSACK_PRO_LOG_DIR' => 'log',
           })
-
-          expect(Logger).to receive(:new).with('log/knapsack_pro_node_0.log').and_return(logger)
-          expect(logger).to receive(:level=).with(Logger::INFO)
-          expect(KnapsackPro::LoggerWrapper).to receive(:new).with(logger).and_return(logger_wrapper)
         end
 
-        it { should eql logger_wrapper }
+        it 'raises' do
+          expect { subject }.to raise_error(/Missing environment variable KNAPSACK_PRO_CI_NODE_INDEX/)
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.4.0
+  version: 7.5.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-23 00:00:00.000000000 Z
+date: 2024-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -415,7 +415,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel