knapsack_pro 7.14.0 → 8.0.0

data/spec/knapsack_pro/formatters/time_tracker_fetcher_spec.rb

@@ -2,11 +2,9 @@ require(KnapsackPro.root + '/lib/knapsack_pro/formatters/time_tracker')
 
 describe KnapsackPro::Formatters::TimeTrackerFetcher do
   describe '.unexecuted_test_files' do
-    subject { described_class.unexecuted_test_files(scheduled_paths) }
+    subject { described_class.unexecuted_test_files }
 
     context 'when the time tracker formatter not found' do
-      let(:scheduled_paths) { ['a_spec.rb'] }
-
       it do
         expect(subject).to eq []
       end
@@ -14,12 +12,11 @@ describe KnapsackPro::Formatters::TimeTrackerFetcher do
 
     context 'when the time tracker formatter is found' do
       let(:time_tracker) { instance_double(KnapsackPro::Formatters::TimeTracker) }
-      let(:scheduled_paths) { ['a_spec.rb', 'b_spec.rb'] }
       let(:unexecuted_test_files) { double(:unexecuted_test_files) }
 
       before do
         expect(described_class).to receive(:call).and_return(time_tracker)
-        expect(time_tracker).to receive(:unexecuted_test_files).with(scheduled_paths).and_return(unexecuted_test_files)
+        expect(time_tracker).to receive(:unexecuted_test_files).and_return(unexecuted_test_files)
       end
 
       it do

data/spec/knapsack_pro/formatters/time_tracker_specs.rb

@@ -343,8 +343,9 @@ class TestTimeTracker
     run_specs(spec) do |spec_paths, _, time_tracker|
       unexecuted_test_files = ["foo_spec.rb", "bar_spec.rb"]
       # Need to filter because RSpec keeps accumulating state.
+      time_tracker.scheduled_paths = spec_paths + unexecuted_test_files
       files = time_tracker
-        .unexecuted_test_files(spec_paths + unexecuted_test_files)
+        .unexecuted_test_files
         .filter { |file| spec_paths.include?(file) || unexecuted_test_files.include?(file) }
 
       raise unless files.size == 3
@@ -399,8 +400,9 @@ class TestTimeTracker
 
     time_tracker = runner.configuration.formatters.find { |f| f.class.to_s == KnapsackPro::Formatters::TimeTracker.to_s }
     # Need to filter because RSpec keeps accumulating state.
+    time_tracker.scheduled_paths = paths
     times = time_tracker
-      .queue(paths)
+      .queue
       .sort_by { |time| time["path"] }
       .filter do |time|
         paths.any? { |path| time["path"].start_with?(path) }

data/spec/knapsack_pro/runners/cucumber_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::CucumberRunner do
       expect(KnapsackPro::Config::Env).to receive(:test_suite_token_cucumber).and_return(test_suite_token_cucumber)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_cucumber)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_REGULAR_MODE_ENABLED', 'true')
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::CucumberAdapter)
 

data/spec/knapsack_pro/runners/minitest_runner_spec.rb

@@ -39,7 +39,7 @@ describe KnapsackPro::Runners::MinitestRunner do
         expect(Rake::Task.task_defined?(task_name)).to be true
 
         expect(ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']).to eq 'minitest-token'
-        expect(ENV['KNAPSACK_PRO_RECORDING_ENABLED']).to eq 'true'
+        expect(ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED']).to eq 'true'
       end
     end
 

data/spec/knapsack_pro/runners/queue/cucumber_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::Queue::CucumberRunner do
       expect(KnapsackPro::Config::EnvGenerator).to receive(:set_queue_id).and_return(queue_id)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_cucumber)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_MODE_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::CucumberAdapter)

data/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
       expect(KnapsackPro::Config::EnvGenerator).to receive(:set_queue_id).and_return(queue_id)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_minitest)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_MODE_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::MinitestAdapter)

data/spec/knapsack_pro/runners/rspec_runner_spec.rb

@@ -16,7 +16,8 @@ describe KnapsackPro::Runners::RSpecRunner do
       expect(KnapsackPro::Config::Env).to receive(:test_suite_token_rspec).and_return(test_suite_token_rspec)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_rspec)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_REGULAR_MODE_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RSPEC_OPTIONS', args)
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::RSpecAdapter)
 
@@ -40,7 +41,6 @@ describe KnapsackPro::Runners::RSpecRunner do
 
       before do
         expect(KnapsackPro::Adapters::RSpecAdapter).to receive(:verify_bind_method_called).ordered
-        expect(KnapsackPro::Adapters::RSpecAdapter).to receive(:ensure_no_tag_option_when_rspec_split_by_test_examples_enabled!).with(['--profile', '--color']).ordered
 
         expect(Rake::Task).to receive(:[]).with('knapsack_pro:rspec_run').at_least(1).and_return(task)
 

data/spec/knapsack_pro/runners/spinach_runner_spec.rb

@@ -37,7 +37,7 @@ describe KnapsackPro::Runners::SpinachRunner do
         expect(KnapsackPro).to receive(:tracker).and_return(tracker)
         expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
 
-        expect(Kernel).to receive(:system).with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg --features_path fake-test-dir -- features/a.feature features/b.feature')
+        expect(Kernel).to receive(:system).with('KNAPSACK_PRO_REGULAR_MODE_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg --features_path fake-test-dir -- features/a.feature features/b.feature')
 
         allow(described_class).to receive(:child_status).and_return(child_status)
       end

data/spec/knapsack_pro/runners/test_unit_runner_spec.rb

@@ -44,7 +44,7 @@ describe KnapsackPro::Runners::TestUnitRunner do
         subject
 
         expect(ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']).to eq 'test-unit-token'
-        expect(ENV['KNAPSACK_PRO_RECORDING_ENABLED']).to eq 'true'
+        expect(ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED']).to eq 'true'
       end
     end
 

data/spec/knapsack_pro/test_case_detectors/rspec_test_example_detector_spec.rb

@@ -4,21 +4,21 @@ describe KnapsackPro::TestCaseDetectors::RSpecTestExampleDetector do
   let(:rspec_test_example_detector) { described_class.new }
 
   describe '#generate_json_report' do
-    subject { rspec_test_example_detector.generate_json_report }
+    subject { rspec_test_example_detector.generate_json_report(rspec_args) }
 
-    before do
-      expect(KnapsackPro::Config::TempFiles).to receive(:ensure_temp_directory_exists!)
+    shared_examples 'generate_json_report runs RSpec::Core::Runner' do
+      before do
+        expect(KnapsackPro::Config::TempFiles).to receive(:ensure_temp_directory_exists!)
 
-      expect(FileUtils).to receive(:mkdir_p).with(report_dir)
+        expect(FileUtils).to receive(:mkdir_p).with(report_dir)
 
-      allow(File).to receive(:exist?)
-      expect(File).to receive(:exist?).at_least(:once).with(report_path).and_return(true)
-      expect(File).to receive(:delete).with(report_path)
+        allow(File).to receive(:exist?)
+        expect(File).to receive(:exist?).at_least(:once).with(report_path).and_return(true)
+        expect(File).to receive(:delete).with(report_path)
 
-      expect(rspec_test_example_detector).to receive(:slow_test_files).and_return(test_file_entities)
-    end
+        expect(rspec_test_example_detector).to receive(:slow_test_files).and_return(test_file_entities)
+      end
 
-    shared_examples 'generate_json_report runs RSpec::Core::Runner' do
       context 'when there are no slow test files' do
         let(:test_file_entities) { [] }
 
@@ -45,7 +45,7 @@ describe KnapsackPro::TestCaseDetectors::RSpecTestExampleDetector do
           expect(KnapsackPro::TestFilePattern).to receive(:test_dir).with(KnapsackPro::Adapters::RSpecAdapter).and_return(test_dir)
 
           options = double
-          expect(RSpec::Core::ConfigurationOptions).to receive(:new).with([
+          expect(RSpec::Core::ConfigurationOptions).to receive(:new).with(expected_args + [
             '--format', expected_format,
             '--dry-run',
             '--no-color',
@@ -85,12 +85,16 @@ describe KnapsackPro::TestCaseDetectors::RSpecTestExampleDetector do
     end
 
     context 'when RSpec >= 3.6.0' do
+      let(:rspec_args) { '' }
+      let(:expected_args) { [] }
       let(:expected_format) { 'json' }
 
       it_behaves_like 'generate_json_report runs RSpec::Core::Runner'
     end
 
     context 'when RSpec < 3.6.0' do
+      let(:rspec_args) { '' }
+      let(:expected_args) { [] }
       let(:expected_format) { 'KnapsackPro::Formatters::RSpecJsonFormatter' }
 
       before do
@@ -99,6 +103,26 @@ describe KnapsackPro::TestCaseDetectors::RSpecTestExampleDetector do
 
       it_behaves_like 'generate_json_report runs RSpec::Core::Runner'
     end
+
+    context 'when RSpec CLI args are present including format option' do
+      let(:rspec_args) { '-t mytag --format documentation --out /tmp/documentation.txt --tag ~@skip --example-matches regexp --example string' }
+      let(:expected_args) { ['-t', 'mytag', '--tag', '~@skip', '--example-matches', 'regexp', '--example', 'string'] }
+      let(:expected_format) { 'json' }
+
+      describe 'removes formatters from RSpec CLI args' do
+        it_behaves_like 'generate_json_report runs RSpec::Core::Runner'
+      end
+    end
+
+    context 'when RSpec CLI args are not set' do
+      let(:rspec_args) { nil }
+      let(:expected_args) { [] }
+      let(:expected_format) { 'json' }
+
+      it do
+        expect { subject }.to raise_error("The internal KNAPSACK_PRO_RSPEC_OPTIONS environment variable is unset. Ensure it is not overridden accidentally. Otherwise, please report this as a bug: https://knapsackpro.com/perma/ruby/support")
+      end
+    end
   end
 
   describe '#test_file_example_paths' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.14.0
+  version: 8.0.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-23 00:00:00.000000000 Z
+date: 2025-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -39,159 +39,159 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 5.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
-  name: cucumber
+  name: ostruct
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
-  name: spinach
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: test-unit
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: spinach
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: 0.9.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: 0.9.9
 - !ruby/object:Gem::Dependency
-  name: timecop
+  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.9
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.9
+        version: '6.0'
 - !ruby/object:Gem::Dependency
-  name: ostruct
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '3.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '3.13'
 description: Knapsack Pro wraps your current test runner(s) and works with your existing
   CI infrastructure to parallelize tests optimally. It dynamically splits your tests
   based on up-to-date test execution data. It's designed from the ground up for CI
@@ -433,7 +433,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel