knapsack_pro 7.14.0 → 7.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 113e9ca31d058ab9623d6a0bb278768ad0a864db8bb8776440d00ceb2a648b37
-  data.tar.gz: '084be6d88bf072c8ece112b3de2a6707b240816e993f039701cd68e7920f7988'
+  metadata.gz: 74a234f9f6948aef8fb2f4c5aff8b2f56077c4cf227b78e76957c470681dc8e7
+  data.tar.gz: 980e6ebff8f7d49dfa4b1e7296f8d507600a052e49845e0ffde27ffa68d57272
 SHA512:
-  metadata.gz: 97015f7b3db931f3a9f68e7ef59aecb99f0befa5202b148d5aa56736d256048c842c00babc265c47c583534f2a0dafc488c49b748b4b3084f93a2d42f6013d84
-  data.tar.gz: 62fd8be74b14f402840ea4b9b6866a9ac008daa09d279e2cee21bd3f513d8f746f635c770c83e65db36139aa6e9ebb362301794e6aad70a9d59796dd86167d90
+  metadata.gz: '09abbaa277b6593990984ab0a0052b8ca7955366e3460971adb52656e5fb8298e5040af857cd14d87eb3d514127f8dbf388c7470880c86d129a409f30d55f2eb'
+  data.tar.gz: eef211470c7a006428b346eff52063e491461134ee7c82d02b9ebe6cd829ae2b1091e0432d8c0037f0aaafdc624f7b7707fc8e3b88dd5720721ceb6840514730

data/.circleci/config.yml

@@ -62,6 +62,8 @@ jobs:
       - setup_knapsack_pro_ruby
       - run: gem install rubocop
       - run: rubocop --fail-level A --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment lib/
+      - run: bundle update rspec
+      - run: bundle exec rspec --version
       - run: bundle exec rspec spec
       - run: bundle exec ruby spec/knapsack_pro/formatters/time_tracker_specs.rb
 

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+### 7.14.1
+
+* Improve execution time tracking for RSpec individual test examples
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/289
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.14.0...v7.14.1
+
 ### 7.14.0
 
 * Improve debugging for hanging CI nodes: show hanging spec files in the RSpec output and a command to reproduce the current batch of tests.

data/lib/knapsack_pro/adapters/base_adapter.rb

@@ -59,13 +59,13 @@ module KnapsackPro
         KnapsackPro::Config::TempFiles.ensure_temp_directory_exists!
         File.write(self.class.adapter_bind_method_called_file, nil)
 
-        if KnapsackPro::Config::Env.recording_enabled?
+        if KnapsackPro::Config::Env.regular_mode?
           KnapsackPro.logger.debug('Regular Mode enabled.')
           bind_time_tracker
           bind_save_report
         end
 
-        if KnapsackPro::Config::Env.queue_recording_enabled?
+        if KnapsackPro::Config::Env.queue_mode?
           KnapsackPro.logger.debug('Queue Mode enabled.')
           bind_queue_mode
         end

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -6,6 +6,7 @@ module KnapsackPro
   module Adapters
     class RSpecAdapter < BaseAdapter
       TEST_DIR_PATTERN = 'spec/**{,/*/**}/*_spec.rb'
+      ID_PATH_REGEX = /.+_spec\.rb\[.+\]$/
 
       def self.split_by_test_cases_enabled?
         return false unless KnapsackPro::Config::Env.rspec_split_by_test_examples?
@@ -80,6 +81,10 @@ module KnapsackPro
         id.match(/\A(.*?)(?:\[([\d\s:,]+)\])?\z/).captures.first
       end
 
+      def self.id_path?(path)
+        ID_PATH_REGEX.match?(path)
+      end
+
       def self.rails_helper_exists?(test_dir)
         File.exist?("#{test_dir}/rails_helper.rb")
       end
@@ -95,6 +100,7 @@ module KnapsackPro
 
       def bind_time_tracker
         ensure_no_focus!
+        bind_regular_mode_time_tracker
         log_tests_duration
       end
 
@@ -117,10 +123,19 @@ module KnapsackPro
         ::RSpec.configure do |config|
           config.append_after(:suite) do
             time_tracker = KnapsackPro::Formatters::TimeTrackerFetcher.call
-            if time_tracker
-              formatted = KnapsackPro::Presenter.global_time(time_tracker.duration)
-              KnapsackPro.logger.debug(formatted)
-            end
+            formatted = KnapsackPro::Presenter.global_time(time_tracker.duration)
+            KnapsackPro.logger.debug(formatted)
+          end
+        end
+      end
+
+      def bind_regular_mode_time_tracker
+        return unless KnapsackPro::Config::Env.regular_mode?
+
+        ::RSpec.configure do |config|
+          config.append_before(:suite) do
+            time_tracker = KnapsackPro::Formatters::TimeTrackerFetcher.call
+            time_tracker.scheduled_paths = KnapsackPro::Adapters::RSpecAdapter.scheduled_paths
           end
         end
       end
@@ -158,6 +173,10 @@ module KnapsackPro
         ::RSpec.configuration
       end
 
+      def self.scheduled_paths
+        rspec_configuration.instance_variable_get(:@files_or_directories_to_run) || []
+      end
+
       def self.parsed_options(cli_args)
         ::RSpec::Core::Parser.parse(cli_args)
       rescue SystemExit

data/lib/knapsack_pro/config/env.rb

@@ -87,24 +87,12 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_REPOSITORY_ADAPTER']
         end
 
-        def recording_enabled
-          ENV['KNAPSACK_PRO_RECORDING_ENABLED']
-        end
-
-        def recording_enabled?
-          recording_enabled == 'true'
-        end
-
         def regular_mode?
-          recording_enabled?
-        end
-
-        def queue_recording_enabled
-          ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED']
+          ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED'] == 'true'
         end
 
-        def queue_recording_enabled?
-          queue_recording_enabled == 'true'
+        def queue_mode?
+          ENV['KNAPSACK_PRO_QUEUE_MODE_ENABLED'] == 'true'
         end
 
         def queue_id

data/lib/knapsack_pro/formatters/time_tracker.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'stringio'
+require 'set'
 require_relative '../utils'
 
 module KnapsackPro
@@ -22,6 +23,18 @@ module KnapsackPro
         @group = {}
         @paths = {}
         @suite_started = now
+        @scheduled_paths = []
+        @split_by_test_example_file_paths = Set.new
+      end
+
+      def scheduled_paths=(scheduled_paths)
+        @scheduled_paths = scheduled_paths
+        @scheduled_paths.each do |path|
+          if KnapsackPro::Adapters::RSpecAdapter.id_path?(path)
+            file_path = KnapsackPro::Adapters::RSpecAdapter.parse_file_path(path)
+            @split_by_test_example_file_paths << file_path
+          end
+        end
       end
 
       def example_group_started(notification)
@@ -49,12 +62,12 @@ module KnapsackPro
         @group = {}
       end
 
-      def queue(scheduled_paths)
+      def queue
         recorded_paths = @paths.values.map do |example|
           KnapsackPro::Adapters::RSpecAdapter.parse_file_path(example[:path])
         end
 
-        missing = (scheduled_paths - recorded_paths).each_with_object({}) do |path, object|
+        missing = (@scheduled_paths - recorded_paths).each_with_object({}) do |path, object|
           object[path] = { path: path, time_execution: 0.0 }
         end
 
@@ -73,12 +86,12 @@ module KnapsackPro
         now - @suite_started
       end
 
-      def unexecuted_test_files(scheduled_paths)
+      def unexecuted_test_files
         pending_paths = @paths.values
           .filter { |example| example[:time_execution] == 0.0 }
           .map { |example| example[:path] }
 
-        not_run_paths = scheduled_paths -
+        not_run_paths = @scheduled_paths -
           @paths.values
           .map { |example| example[:path] }
 
@@ -111,21 +124,22 @@ module KnapsackPro
       end
 
       def path_for(example)
-        file = file_path_for(example)
-        return nil if file == ""
+        file_path = file_path_for(example)
+        return nil if file_path == ""
 
-        path = rspec_split_by_test_example?(file) ? example.id : file
-        KnapsackPro::TestFileCleaner.clean(path)
+        if rspec_split_by_test_example?(file_path)
+          KnapsackPro::TestFileCleaner.clean(example.id)
+        else
+          file_path
+        end
       end
 
-      def rspec_split_by_test_example?(file)
-        return false unless KnapsackPro::Config::Env.rspec_split_by_test_examples?
-        return false unless KnapsackPro::Adapters::RSpecAdapter.slow_test_file?(KnapsackPro::Adapters::RSpecAdapter, file)
-        true
+      def rspec_split_by_test_example?(file_path)
+        @split_by_test_example_file_paths.include?(file_path)
       end
 
       def file_path_for(example)
-        KnapsackPro::Adapters::RSpecAdapter.file_path_for(example)
+        KnapsackPro::TestFileCleaner.clean(KnapsackPro::Adapters::RSpecAdapter.file_path_for(example))
       end
 
       def time_execution_for(example, started_at)

data/lib/knapsack_pro/formatters/time_tracker_fetcher.rb

@@ -10,10 +10,10 @@ module KnapsackPro
           .find { |f| f.class.to_s == "KnapsackPro::Formatters::TimeTracker" }
       end
 
-      def self.unexecuted_test_files(scheduled_paths)
+      def self.unexecuted_test_files
         time_tracker = call
         return [] unless time_tracker
-        time_tracker.unexecuted_test_files(scheduled_paths)
+        time_tracker.unexecuted_test_files
       end
     end
   end

data/lib/knapsack_pro/runners/cucumber_runner.rb

@@ -5,7 +5,7 @@ module KnapsackPro
     class CucumberRunner < BaseRunner
       def self.run(args)
         ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_cucumber
-        ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
+        ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::CucumberAdapter
         KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)

data/lib/knapsack_pro/runners/minitest_runner.rb

@@ -5,7 +5,7 @@ module KnapsackPro
     class MinitestRunner < BaseRunner
       def self.run(args)
         ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_minitest
-        ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
+        ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::MinitestAdapter
         KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)

data/lib/knapsack_pro/runners/queue/cucumber_runner.rb

@@ -8,7 +8,7 @@ module KnapsackPro
           require 'cucumber/rake/task'
 
           ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_cucumber
-          ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED'] = 'true'
+          ENV['KNAPSACK_PRO_QUEUE_MODE_ENABLED'] = 'true'
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id
 
           adapter_class = KnapsackPro::Adapters::CucumberAdapter

data/lib/knapsack_pro/runners/queue/minitest_runner.rb

@@ -12,7 +12,7 @@ module KnapsackPro
           ::Minitest.class_variable_set('@@installed_at_exit', true)
 
           ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_minitest
-          ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED'] = 'true'
+          ENV['KNAPSACK_PRO_QUEUE_MODE_ENABLED'] = 'true'
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id
 
           adapter_class = KnapsackPro::Adapters::MinitestAdapter

data/lib/knapsack_pro/runners/queue/rspec_runner.rb

@@ -143,7 +143,7 @@ module KnapsackPro
         end
 
         def pre_run_setup
-          ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED'] = 'true'
+          ENV['KNAPSACK_PRO_QUEUE_MODE_ENABLED'] = 'true'
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id
 
           KnapsackPro::Config::Env.set_test_runner_adapter(@adapter_class)
@@ -164,7 +164,7 @@ module KnapsackPro
           log_rspec_queue_command
 
           time_tracker = KnapsackPro::Formatters::TimeTrackerFetcher.call
-          KnapsackPro::Report.save_node_queue_to_api(time_tracker&.queue(@node_test_file_paths))
+          KnapsackPro::Report.save_node_queue_to_api(time_tracker&.queue)
 
           Kernel.exit(exit_code)
         end
@@ -183,6 +183,10 @@ module KnapsackPro
             executed_test_files: @node_test_file_paths
           )
           @node_test_file_paths += test_file_paths
+
+          time_tracker = KnapsackPro::Formatters::TimeTrackerFetcher.call
+          time_tracker.scheduled_paths = @node_test_file_paths
+
           test_file_paths
         end
 
@@ -222,7 +226,7 @@ module KnapsackPro
         end
 
         def unexecuted_test_files
-          KnapsackPro::Formatters::TimeTrackerFetcher.unexecuted_test_files(@node_test_file_paths)
+          KnapsackPro::Formatters::TimeTrackerFetcher.unexecuted_test_files
         end
       end
     end

data/lib/knapsack_pro/runners/rspec_runner.rb

@@ -7,7 +7,7 @@ module KnapsackPro
         require 'rspec/core'
 
         ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_rspec
-        ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
+        ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::RSpecAdapter
         KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)

data/lib/knapsack_pro/runners/spinach_runner.rb

@@ -15,7 +15,7 @@ module KnapsackPro
 
           KnapsackPro.tracker.set_prerun_tests(runner.test_file_paths)
 
-          cmd = %Q[KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=#{ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']} bundle exec spinach #{args} --features_path #{runner.test_dir} -- #{runner.stringify_test_file_paths}]
+          cmd = %Q[KNAPSACK_PRO_REGULAR_MODE_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=#{ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']} bundle exec spinach #{args} --features_path #{runner.test_dir} -- #{runner.stringify_test_file_paths}]
 
           Kernel.system(cmd)
           Kernel.exit(child_status.exitstatus) unless child_status.exitstatus.zero?

data/lib/knapsack_pro/runners/test_unit_runner.rb

@@ -5,7 +5,7 @@ module KnapsackPro
     class TestUnitRunner < BaseRunner
       def self.run(args)
         ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN'] = KnapsackPro::Config::Env.test_suite_token_test_unit
-        ENV['KNAPSACK_PRO_RECORDING_ENABLED'] = 'true'
+        ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED'] = 'true'
 
         adapter_class = KnapsackPro::Adapters::TestUnitAdapter
         KnapsackPro::Config::Env.set_test_runner_adapter(adapter_class)

data/lib/knapsack_pro/test_case_mergers/rspec_merger.rb

@@ -11,7 +11,7 @@ module KnapsackPro
           path = test_file.fetch('path')
           test_file_path = extract_test_file_path(path)
 
-          if rspec_id_path?(path)
+          if KnapsackPro::Adapters::RSpecAdapter.id_path?(path)
             merged_test_file_examples_hash[test_file_path] ||= 0.0
             merged_test_file_examples_hash[test_file_path] += test_file.fetch('time_execution')
           else
@@ -41,12 +41,6 @@ module KnapsackPro
       def extract_test_file_path(path)
         path.gsub(/\.rb\[.+\]$/, '.rb')
       end
-
-      def rspec_id_path?(path)
-        path_with_id_regex = /.+_spec\.rb\[.+\]$/
-
-        path&.match?(path_with_id_regex)
-      end
     end
   end
 end

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '7.14.0'
+  VERSION = '7.14.1'
 end

data/spec/integration/runners/queue/rspec_runner_spec.rb

@@ -1959,7 +1959,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
-  context 'when the RSpec split by examples is enabled' do
+  context 'when the RSpec split by test examples is enabled' do
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
@@ -1975,7 +1975,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
       ENV.delete('KNAPSACK_PRO_CI_NODE_TOTAL')
     end
 
-    it 'splits slow test files by examples AND ensures the test examples are executed only once' do
+    it 'splits slow test files by test examples AND ensures the test examples are executed only once' do
       rspec_options = '--format d'
 
       spec_a = Spec.new('a_spec.rb', <<~SPEC)
@@ -2058,7 +2058,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
-  context 'when the RSpec split by examples is enabled AND --tag is set' do
+  context 'when the RSpec split by test examples is enabled AND --tag is set' do
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
@@ -2137,7 +2137,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
-  context 'when the RSpec split by examples is enabled AND JSON formatter is used' do
+  context 'when the RSpec split by test examples is enabled AND JSON formatter is used' do
     let(:json_file) { "#{SPEC_DIRECTORY}/rspec.json" }
 
     before do
@@ -2239,7 +2239,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
-  context 'when the RSpec split by examples is enabled AND JUnit XML formatter is used' do
+  context 'when the RSpec split by test examples is enabled AND JUnit XML formatter is used' do
     let(:xml_file) { "#{SPEC_DIRECTORY}/rspec.xml" }
 
     before do
@@ -2338,7 +2338,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
-  context 'when the RSpec split by examples is enabled AND simplecov is used' do
+  context 'when the RSpec split by test examples is enabled AND simplecov is used' do
     let(:coverage_dir) { "#{KNAPSACK_PRO_TMP_DIR}/coverage" }
     let(:coverage_file) { "#{coverage_dir}/index.html" }
 
@@ -2427,6 +2427,104 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
+  context 'when the RSpec split by test examples is enabled AND test files are split by test examples AND slow test files are not detected (for example, the user could have passed test examples like a_spec.rb[1:1] directly using KNAPSACK_PRO_TEST_FILE_LIST_SOURCE_FILE or KNAPSACK_PRO_TEST_FILE_LIST)' do
+    before do
+      ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
+      ENV['KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN'] = ""
+      ENV['KNAPSACK_PRO_CI_NODE_TOTAL'] = '2'
+    end
+    after do
+      ENV.delete('KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES')
+      ENV.delete('KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN')
+      ENV.delete('KNAPSACK_PRO_CI_NODE_TOTAL')
+    end
+
+    it 'detects test execution times correctly for individual test examples even though they are not considered slow test files' do
+      ENV['TEST__LOG_EXECUTION_TIMES'] = 'true'
+      rspec_options = '--format d'
+
+      spec_a = Spec.new('a_spec.rb', <<~SPEC)
+        describe 'A_describe' do
+          it 'A1 test example' do
+            expect(1).to eq 1
+          end
+          it 'A2 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_b = Spec.new('b_spec.rb', <<~SPEC)
+        describe 'B_describe' do
+          it 'B1 test example' do
+            expect(1).to eq 1
+          end
+          it 'B2 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_c = Spec.new('c_spec.rb', <<~SPEC)
+        describe 'C_describe' do
+          it 'C1 test example' do
+            expect(1).to eq 1
+          end
+          it 'C2 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      generate_specs(spec_helper_with_knapsack, rspec_options, [
+        [spec_a, spec_b, spec_c]
+      ])
+      stub_test_cases_for_slow_test_files([
+        "#{spec_a.path}[1:1]",
+        "#{spec_a.path}[1:2]",
+      ])
+      stub_spec_batches([
+        ["#{spec_a.path}[1:1]", spec_b.path],
+        ["#{spec_a.path}[1:2]", spec_c.path],
+      ])
+
+      actual = subject
+
+      expect(actual.stdout).to include('DEBUG -- : [knapsack_pro] Detected 0 slow test files: []')
+
+      expect(actual.stdout).to include(
+        <<~OUTPUT
+        A_describe
+          A1 test example
+
+        B_describe
+          B1 test example
+          B2 test example
+        OUTPUT
+      )
+
+      expect(actual.stdout).to include(
+        <<~OUTPUT
+        A_describe
+          A2 test example
+
+        C_describe
+          C1 test example
+          C2 test example
+        OUTPUT
+      )
+
+      expect(actual.stdout.scan(/A1 test example/).size).to eq 1
+      expect(actual.stdout.scan(/A2 test example/).size).to eq 1
+
+      expect(actual.stdout).to include('6 examples, 0 failures')
+
+      expect(actual.stdout).to include('[INTEGRATION TEST] test_files: 4, test files have execution time: true')
+
+      expect(actual.exit_code).to eq 0
+    end
+  end
+
   context 'when the example_status_persistence_file_path option is used and multiple batches of tests are fetched from the Queue API and some tests are pending and failing' do
     let(:examples_file_path) { "#{SPEC_DIRECTORY}/examples.txt" }
 

data/spec/knapsack_pro/adapters/base_adapter_spec.rb

@@ -135,21 +135,21 @@ describe KnapsackPro::Adapters::BaseAdapter do
 
   describe '#bind' do
     let(:temp_directory_path) { '.knapsack_pro' }
-    let(:recording_enabled?) { false }
-    let(:queue_recording_enabled?) { false }
+    let(:regular_mode?) { false }
+    let(:queue_mode?) { false }
 
     before do
       expect(KnapsackPro::Config::TempFiles).to receive(:ensure_temp_directory_exists!)
       expect(File).to receive(:write).with('.knapsack_pro/KnapsackPro-Adapters-BaseAdapter-bind_method_called_for_node_0.txt', nil)
 
-      expect(KnapsackPro::Config::Env).to receive(:recording_enabled?).and_return(recording_enabled?)
-      expect(KnapsackPro::Config::Env).to receive(:queue_recording_enabled?).and_return(queue_recording_enabled?)
+      expect(KnapsackPro::Config::Env).to receive(:regular_mode?).and_return(regular_mode?)
+      expect(KnapsackPro::Config::Env).to receive(:queue_mode?).and_return(queue_mode?)
     end
 
     after { subject.bind }
 
-    context 'when recording enabled' do
-      let(:recording_enabled?) { true }
+    context 'when regular mode enabled' do
+      let(:regular_mode?) { true }
 
       before do
         allow(subject).to receive(:bind_time_tracker)
@@ -165,8 +165,8 @@ describe KnapsackPro::Adapters::BaseAdapter do
       it { expect(subject).to receive(:bind_save_report) }
     end
 
-    context 'when queue recording enabled' do
-      let(:queue_recording_enabled?) { true }
+    context 'when queue mode enabled' do
+      let(:queue_mode?) { true }
 
       it 'calls queue hooks in proper order before binding time tracker' do
         logger = instance_double(Logger)
@@ -179,7 +179,7 @@ describe KnapsackPro::Adapters::BaseAdapter do
       end
     end
 
-    context 'when recording disabled' do
+    context 'when regular mode and queue mode disabled' do
       it { expect(subject).not_to receive(:bind_save_report) }
       it { expect(subject).not_to receive(:bind_before_queue_hook) }
       it { expect(subject).not_to receive(:bind_after_queue_hook) }

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -215,6 +215,28 @@ describe KnapsackPro::Adapters::RSpecAdapter do
     end
   end
 
+  describe '.id_path?' do
+    subject { described_class.id_path?(path) }
+
+    context 'when the path resembles the RSpec path with id' do
+      let(:path) { 'spec/features/a_spec.rb[1:1:7:1]' }
+
+      it { is_expected.to be true }
+    end
+
+    context 'when the path resembles the RSpec path with multiple ids' do
+      let(:path) { 'spec/features/a_spec.rb[1:1:7:1, 1:2]' }
+
+      it { is_expected.to be true }
+    end
+
+    context "when the path doesn't resemble the RSpec path with id" do
+      let(:path) { 'spec/features/a_spec.rb' }
+
+      it { is_expected.to be false }
+    end
+  end
+
   describe '.rails_helper_exists?' do
     subject { described_class.rails_helper_exists?(test_dir) }
 
@@ -370,6 +392,26 @@ describe KnapsackPro::Adapters::RSpecAdapter do
     end
   end
 
+  describe 'private .scheduled_paths' do
+    subject { described_class.send(:scheduled_paths) }
+
+    context 'when the RSpec configuration has files or directories to run' do
+      it 'returns list of test files passed to RSpec (if this fails then the internal RSpec API changed and we must start supporting a new RSpec version as well)' do
+        expect(subject).not_to be_empty
+      end
+    end
+
+    context "when the RSpec configuration has no files or directories to run (when the internal RSpec API changed and we don't support the new RSpec version yet)" do
+      before do
+        expect(described_class).to receive(:rspec_configuration).and_return(double(:object_with_no_instance_variables))
+      end
+
+      it 'fallbacks to an empty array to not blow up Knapsack Pro' do
+        expect(subject).to eq([])
+      end
+    end
+  end
+
   describe 'bind methods' do
     let(:config) { double }
 

data/spec/knapsack_pro/config/env_spec.rb

@@ -603,89 +603,43 @@ describe KnapsackPro::Config::Env do
     end
   end
 
-  describe '.recording_enabled' do
-    subject { described_class.recording_enabled }
-
-    context 'when ENV exists' do
-      let(:recording_enabled) { 'true' }
-      before { stub_const("ENV", { 'KNAPSACK_PRO_RECORDING_ENABLED' => recording_enabled }) }
-      it { should eq recording_enabled }
-    end
-
-    context "when ENV doesn't exist" do
-      it { should be_nil }
-    end
-  end
-
   describe '.regular_mode?' do
     subject { described_class.regular_mode? }
 
-    before do
-      expect(described_class).to receive(:recording_enabled?).and_return(recording_enabled)
+    context 'when regular mode is enabled' do
+      let(:regular_mode_enabled) { 'true' }
+      before { stub_const("ENV", { 'KNAPSACK_PRO_REGULAR_MODE_ENABLED' => regular_mode_enabled }) }
+      it { should eq true }
     end
 
-    context 'when recording is enabled' do
-      let(:recording_enabled) { true }
-      it { should be true }
-    end
-
-    context 'when recording is not enabled' do
-      let(:recording_enabled) { false }
-      it { should be false }
-    end
-  end
-
-  describe '.recording_enabled?' do
-    subject { described_class.recording_enabled? }
-
-    before do
-      expect(described_class).to receive(:recording_enabled).and_return(recording_enabled)
-    end
-
-    context 'when enabled' do
-      let(:recording_enabled) { 'true' }
-
-      it { should be true }
-    end
-
-    context 'when disabled' do
-      let(:recording_enabled) { nil }
-
-      it { should be false }
-    end
-  end
-
-  describe '.queue_recording_enabled' do
-    subject { described_class.queue_recording_enabled }
-
-    context 'when ENV exists' do
-      let(:queue_recording_enabled) { 'true' }
-      before { stub_const("ENV", { 'KNAPSACK_PRO_QUEUE_RECORDING_ENABLED' => queue_recording_enabled }) }
-      it { should eq queue_recording_enabled }
+    context 'when regular mode is disabled' do
+      let(:regular_mode_enabled) { 'false' }
+      before { stub_const("ENV", { 'KNAPSACK_PRO_REGULAR_MODE_ENABLED' => regular_mode_enabled }) }
+      it { should eq false }
     end
 
     context "when ENV doesn't exist" do
-      it { should be_nil }
+      it { should false }
     end
   end
 
-  describe '.queue_recording_enabled?' do
-    subject { described_class.queue_recording_enabled? }
+  describe '.queue_mode?' do
+    subject { described_class.queue_mode? }
 
-    before do
-      expect(described_class).to receive(:queue_recording_enabled).and_return(queue_recording_enabled)
+    context 'when queue mode is enabled' do
+      let(:queue_mode_enabled) { 'true' }
+      before { stub_const("ENV", { 'KNAPSACK_PRO_QUEUE_MODE_ENABLED' => queue_mode_enabled }) }
+      it { should eq true }
     end
 
-    context 'when enabled' do
-      let(:queue_recording_enabled) { 'true' }
-
-      it { should be true }
+    context 'when queue mode is disabled' do
+      let(:queue_mode_enabled) { 'false' }
+      before { stub_const("ENV", { 'KNAPSACK_PRO_QUEUE_MODE_ENABLED' => queue_mode_enabled }) }
+      it { should eq false }
     end
 
-    context 'when disabled' do
-      let(:queue_recording_enabled) { nil }
-
-      it { should be false }
+    context "when ENV doesn't exist" do
+      it { should false }
     end
   end
 
@@ -1016,7 +970,10 @@ describe KnapsackPro::Config::Env do
   describe '.rspec_split_by_test_examples?' do
     subject { described_class.rspec_split_by_test_examples? }
 
-    after(:each) do
+    before do
+      described_class.remove_instance_variable(:@rspec_split_by_test_examples) if described_class.instance_variable_defined?(:@rspec_split_by_test_examples)
+    end
+    after do
       described_class.remove_instance_variable(:@rspec_split_by_test_examples)
     end
 

data/spec/knapsack_pro/formatters/time_tracker_fetcher_spec.rb

@@ -2,11 +2,9 @@ require(KnapsackPro.root + '/lib/knapsack_pro/formatters/time_tracker')
 
 describe KnapsackPro::Formatters::TimeTrackerFetcher do
   describe '.unexecuted_test_files' do
-    subject { described_class.unexecuted_test_files(scheduled_paths) }
+    subject { described_class.unexecuted_test_files }
 
     context 'when the time tracker formatter not found' do
-      let(:scheduled_paths) { ['a_spec.rb'] }
-
       it do
         expect(subject).to eq []
       end
@@ -14,12 +12,11 @@ describe KnapsackPro::Formatters::TimeTrackerFetcher do
 
     context 'when the time tracker formatter is found' do
       let(:time_tracker) { instance_double(KnapsackPro::Formatters::TimeTracker) }
-      let(:scheduled_paths) { ['a_spec.rb', 'b_spec.rb'] }
       let(:unexecuted_test_files) { double(:unexecuted_test_files) }
 
       before do
         expect(described_class).to receive(:call).and_return(time_tracker)
-        expect(time_tracker).to receive(:unexecuted_test_files).with(scheduled_paths).and_return(unexecuted_test_files)
+        expect(time_tracker).to receive(:unexecuted_test_files).and_return(unexecuted_test_files)
       end
 
       it do

data/spec/knapsack_pro/formatters/time_tracker_specs.rb

@@ -343,8 +343,9 @@ class TestTimeTracker
     run_specs(spec) do |spec_paths, _, time_tracker|
       unexecuted_test_files = ["foo_spec.rb", "bar_spec.rb"]
       # Need to filter because RSpec keeps accumulating state.
+      time_tracker.scheduled_paths = spec_paths + unexecuted_test_files
       files = time_tracker
-        .unexecuted_test_files(spec_paths + unexecuted_test_files)
+        .unexecuted_test_files
         .filter { |file| spec_paths.include?(file) || unexecuted_test_files.include?(file) }
 
       raise unless files.size == 3
@@ -399,8 +400,9 @@ class TestTimeTracker
 
     time_tracker = runner.configuration.formatters.find { |f| f.class.to_s == KnapsackPro::Formatters::TimeTracker.to_s }
     # Need to filter because RSpec keeps accumulating state.
+    time_tracker.scheduled_paths = paths
     times = time_tracker
-      .queue(paths)
+      .queue
       .sort_by { |time| time["path"] }
       .filter do |time|
         paths.any? { |path| time["path"].start_with?(path) }

data/spec/knapsack_pro/runners/cucumber_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::CucumberRunner do
       expect(KnapsackPro::Config::Env).to receive(:test_suite_token_cucumber).and_return(test_suite_token_cucumber)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_cucumber)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_REGULAR_MODE_ENABLED', 'true')
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::CucumberAdapter)
 

data/spec/knapsack_pro/runners/minitest_runner_spec.rb

@@ -39,7 +39,7 @@ describe KnapsackPro::Runners::MinitestRunner do
         expect(Rake::Task.task_defined?(task_name)).to be true
 
         expect(ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']).to eq 'minitest-token'
-        expect(ENV['KNAPSACK_PRO_RECORDING_ENABLED']).to eq 'true'
+        expect(ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED']).to eq 'true'
       end
     end
 

data/spec/knapsack_pro/runners/queue/cucumber_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::Queue::CucumberRunner do
       expect(KnapsackPro::Config::EnvGenerator).to receive(:set_queue_id).and_return(queue_id)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_cucumber)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_MODE_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::CucumberAdapter)

data/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
       expect(KnapsackPro::Config::EnvGenerator).to receive(:set_queue_id).and_return(queue_id)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_minitest)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_MODE_ENABLED', 'true')
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_QUEUE_ID', queue_id)
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::MinitestAdapter)

data/spec/knapsack_pro/runners/rspec_runner_spec.rb

@@ -16,7 +16,7 @@ describe KnapsackPro::Runners::RSpecRunner do
       expect(KnapsackPro::Config::Env).to receive(:test_suite_token_rspec).and_return(test_suite_token_rspec)
 
       expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_TEST_SUITE_TOKEN', test_suite_token_rspec)
-      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_RECORDING_ENABLED', 'true')
+      expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_REGULAR_MODE_ENABLED', 'true')
 
       expect(KnapsackPro::Config::Env).to receive(:set_test_runner_adapter).with(KnapsackPro::Adapters::RSpecAdapter)
 

data/spec/knapsack_pro/runners/spinach_runner_spec.rb

@@ -37,7 +37,7 @@ describe KnapsackPro::Runners::SpinachRunner do
         expect(KnapsackPro).to receive(:tracker).and_return(tracker)
         expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
 
-        expect(Kernel).to receive(:system).with('KNAPSACK_PRO_RECORDING_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg --features_path fake-test-dir -- features/a.feature features/b.feature')
+        expect(Kernel).to receive(:system).with('KNAPSACK_PRO_REGULAR_MODE_ENABLED=true KNAPSACK_PRO_TEST_SUITE_TOKEN=spinach-token bundle exec spinach --custom-arg --features_path fake-test-dir -- features/a.feature features/b.feature')
 
         allow(described_class).to receive(:child_status).and_return(child_status)
       end

data/spec/knapsack_pro/runners/test_unit_runner_spec.rb

@@ -44,7 +44,7 @@ describe KnapsackPro::Runners::TestUnitRunner do
         subject
 
         expect(ENV['KNAPSACK_PRO_TEST_SUITE_TOKEN']).to eq 'test-unit-token'
-        expect(ENV['KNAPSACK_PRO_RECORDING_ENABLED']).to eq 'true'
+        expect(ENV['KNAPSACK_PRO_REGULAR_MODE_ENABLED']).to eq 'true'
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.14.0
+  version: 7.14.1
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-23 00:00:00.000000000 Z
+date: 2025-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -433,7 +433,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel