knapsack_pro 7.0.1 → 7.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd0d61c51dbf5b1db810f1249e058149831a3e502af11158bcb112ca02f83bf8
-  data.tar.gz: 8c281aa9ed386c01f857f60212f469fdb1364ff3ffc3111e60cdcb0a1557dc35
+  metadata.gz: 5fa2cbdcdebace591370260b651732d348da4b27010a0059bd90cb4d193b8486
+  data.tar.gz: fbfd4447d1c74132d48bc29ceb0f3293be0825c5e9dd8e682ab874c53a6b3ab7
 SHA512:
-  metadata.gz: b3f306e986304db8084259385b375681b4bf7bad16351fbe15bf3c5d624ab31648a42e2efafb8cc3bdd3eef7ce2ea49df91d9fa87b1a812830aaf6d3e489cb89
-  data.tar.gz: 867302738082653b366f08265224463186ea19069e147d281020ef1a76c6c480398922913fdf92d3ad1971fe792be69e204b4087e589eeac66b705fabc6a7879
+  metadata.gz: a4d0029246717da43f525bc8826b4068c7727731e532278386ef0fc8e6d76e7108ff4f660da88d97e12e531fa8e10e85c6d8626035eb4c15c5fada7ef5318258
+  data.tar.gz: ff749f54cc9ebd40ff0ae3a06e1b4693df88ee4c307d43b59b3c6fc9ef94ff1ba462a110016511ec882f8b54a172c76e0b8e16e8bb549ebc763f245357577da9

data/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+### 7.2.0
+
+* Always use the original `Net::HTTP` client, even when WebMock replaces it with its own
+    * No action is required on your side, but you can delete the following code that you may have used to configure Knapsack Pro with WebMock or VCR:
+    ```diff
+      WebMock.disable_net_connect!(
+        allow_localhost: true,
+    -   allow: ['api.knapsackpro.com']
+      )
+
+      # VCR
+    - config.ignore_hosts('localhost', '127.0.0.1', '0.0.0.0', 'api.knapsackpro.com')
+    + config.ignore_localhost = true
+    ```
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/251
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.1.0...v7.2.0
+
+### 7.1.0
+
+* [RSpec] [Queue Mode] Log error message and backtrace when unexpected failure is raised
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/249
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.0.1...v7.1.0
+
 ### 7.0.1
 
 * fix(RSpec): conditionally adds `--require rails_helper` to cli arguments of `KnapsackPro::Runners::Queue::RSpecRunner`. Version 7.0.0 introduced some fundamental changes, namely fetching, loading and running batches of specs **after** executing suite hooks, so that such hooks are only ran once, not before every batch. As a result, if `rails_helper` is only required in spec files, which is the RSpec default, instead of e.g. in `.rspec`, then some `before(:suite)` hooks, e.g. defined by gems, are registered after suite hooks had already been executed by the test suite. By comparison, RSpec loads all the spec files **before** executing `before(:suite)` hooks.
@@ -28,6 +55,25 @@ https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.0.0...v7.0.1
     __After:__<br>
     The `KnapsackPro::Hooks::Queue.after_queue` hook is executed __inside__ of the `after(:suite)` hook.
 
+  * The RSpec `filter_run_excluding` option is not supported in Queue Mode.
+
+    __Before:__ The following option won't run tests tagged with `:manual`.<br>
+
+    ```ruby
+    # spec_helper.rb
+    RSpec.configure do |config|
+      config.filter_run_excluding :manual
+    end
+    ```
+
+    __After:__ The RSpec `filter_run_excluding` option is ignored in Queue Mode. You must manually pass the `--tag ~manual` option to the Knapsack Pro command to skip tests tagged with `:manual`.
+
+    ```
+    bundle exec rake "knapsack_pro:queue:rspec[--tag ~manual]"
+    ```
+
+  * Please [update the datadog-ci gem to the latest version](https://github.com/DataDog/datadog-ci-rb/issues/147#issuecomment-2099997045) if you use DataDog. This allows DataDog to collect RSpec data correctly in Knapsack Pro Queue Mode.
+
 * Recommended RSpec changes in your project:
   * Remove the following code if you use Queue Mode and the `rspec_junit_formatter` gem to generate JUnit XML or JSON reports:
 

data/lib/knapsack_pro/client/connection.rb

@@ -141,13 +141,21 @@ module KnapsackPro
       end
 
       def build_http(uri)
-        http = Net::HTTP.new(uri.host, uri.port)
+        http = net_http.new(uri.host, uri.port)
         http.use_ssl = (uri.scheme == 'https')
         http.open_timeout = TIMEOUT
         http.read_timeout = TIMEOUT
         http
       end
 
+      def net_http
+        if defined?(WebMock::HttpLibAdapters::NetHttpAdapter::OriginalNetHTTP)
+          WebMock::HttpLibAdapters::NetHttpAdapter::OriginalNetHTTP
+        else
+          Net::HTTP
+        end
+      end
+
       def post
         uri = URI.parse(endpoint_url)
         http = build_http(uri)

data/lib/knapsack_pro/runners/queue/rspec_runner.rb

@@ -56,6 +56,8 @@ module KnapsackPro
             Kernel.exit(exit_code)
           rescue Exception => exception
             KnapsackPro.logger.error("An unexpected exception happened. RSpec cannot handle it. The exception: #{exception.inspect}")
+            KnapsackPro.logger.error("Exception message: #{exception.message}")
+            KnapsackPro.logger.error("Exception backtrace: #{exception.backtrace.join("\n")}")
 
             message = @rspec_pure.exit_summary(unexecuted_test_files)
             KnapsackPro.logger.warn(message) if message

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '7.0.1'
+  VERSION = '7.2.0'
 end

data/spec/integration/runners/queue/rspec_runner_spec.rb

@@ -1115,6 +1115,8 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
 
       expect(actual.stdout).to include('B_describe')
       expect(actual.stdout).to include('An unexpected exception happened. RSpec cannot handle it. The exception: #<NoMemoryError: NoMemoryError>')
+      expect(actual.stdout).to include('Exception message: ')
+      expect(actual.stdout).to include('Exception backtrace: ')
       expect(actual.stdout).to_not include('B1 test example')
 
       expect(actual.stdout).to_not include('C1 test example')

data/spec/spec_helper.rb

@@ -40,4 +40,8 @@ RSpec.configure do |config|
       FileUtils.rm_r(KNAPSACK_PRO_TMP_DIR) if File.exist?(KNAPSACK_PRO_TMP_DIR)
     end
   end
+
+  config.before(:each) do
+    allow_any_instance_of(KnapsackPro::Client::Connection).to receive(:net_http).and_return(Net::HTTP)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.0.1
+  version: 7.2.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-11 00:00:00.000000000 Z
+date: 2024-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -412,7 +412,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel