knapsack_pro 7.0.0 → 7.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f27ac674f611af638b9d0ea3dd1d3441a9e680e70296738ff5b93d5d18f9741
-  data.tar.gz: 79bdc380a1c882178b4a3cde626de7e2db1d30ae64ae1a301f023a5ff5d71623
+  metadata.gz: 832322e0370ece75c8c2e53870b526e6bc4cd3f43214d4ee893a48cef6b209af
+  data.tar.gz: a3847464969d15278d84d00d9638c9e6e2cecea0190be5f773c70da0117c0d44
 SHA512:
-  metadata.gz: 75bf722c575fce515b8a1a79f7e05ad5ed8ce6f69c05f4ff7cff8fdd570e5eb3e170cbf83765c66b2d1a187a5c076235637188ef9e7bd9d3d703fa37d1bf989c
-  data.tar.gz: 1a355724b69bd0d62b23dd32b6e995dbdd882d0fcb0299d5cddb42c3b4c0635a588839c7194cfb2af83504d91ba4db192a68cc393a8380713450b44971c682bf
+  metadata.gz: d3648e3a7f77b8acfac104dc32a6f99cca7d86456cadd2127ff3b8e6d0a874df452398b5a266a887d54c9c239bf28727501a524cc3351adbb676b8887e272014
+  data.tar.gz: c7212ef6b958a7bb7aec2add6e6dc9d02e753936401f8d7705b4799c4ef1bb2b20c3456d1ad165b9e8ece86873b7393ee7afe1aa260c798b8644e6ace039fb17

data/.gitignore

@@ -36,5 +36,5 @@ Gemfile.lock
 .rvmrc
 
 # dynamically generated specs
-spec/knapsack_pro/formatters/time_tracker*_spec.rb
+spec/knapsack_pro/formatters/tmp_time_tracker*_spec.rb
 spec_integration/

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+### 7.1.0
+
+* [RSpec] [Queue Mode] Log error message and backtrace when unexpected failure is raised
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/249
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.0.1...v7.1.0
+
+### 7.0.1
+
+* fix(RSpec): conditionally adds `--require rails_helper` to cli arguments of `KnapsackPro::Runners::Queue::RSpecRunner`. Version 7.0.0 introduced some fundamental changes, namely fetching, loading and running batches of specs **after** executing suite hooks, so that such hooks are only ran once, not before every batch. As a result, if `rails_helper` is only required in spec files, which is the RSpec default, instead of e.g. in `.rspec`, then some `before(:suite)` hooks, e.g. defined by gems, are registered after suite hooks had already been executed by the test suite. By comparison, RSpec loads all the spec files **before** executing `before(:suite)` hooks.
+
+PR with the above changes: https://github.com/KnapsackPro/knapsack_pro-ruby/pull/243
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.0.0...v7.0.1
+
 ### 7.0.0
 
 * __(breaking change)__ RSpec in Queue Mode:

data/README.md

@@ -74,30 +74,32 @@ Scripted tests can be found in the [Rails App With Knapsack Pro repository](http
 
 ### Publishing
 
-Update the version in `lib/knapsack_pro/version.rb` and `CHANGELOG.md`:
+1. Update the `CHANGELOG.md` as part of your PR.
+
+2. After your PR has been merged, update the gem version in `lib/knapsack_pro/version.rb` directly on the `master` branch:
 
 ```bash
 git commit -m "Bump version X.X.X"
 git push origin master
 ```
 
-Create a git tag for the release:
+3. Create a git tag for the release:
 
 ```bash
 git tag -a vX.X.X -m "Release vX.X.X"
 git push --tags
 ```
 
-Build the gem and publish it to RubyGems:
+4. Build the gem and publish it to RubyGems:
 
 ```bash
 gem build knapsack_pro.gemspec
 gem push knapsack_pro-X.X.X.gem
 ```
 
-Update the latest available gem version in `TestSuiteClientVersionChecker` for the Knapsack Pro API repository.
+5. Update the latest available gem version in `TestSuiteClientVersionChecker` for the Knapsack Pro API repository.
 
-Update the `knapsack_pro` gem version in:
+6. Update the `knapsack_pro` gem version in:
 
 - [Rails App With Knapsack Pro repository](https://github.com/KnapsackPro/rails-app-with-knapsack_pro)
 - Knapsack Pro API internal repository

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -52,6 +52,10 @@ module KnapsackPro
         !!parsed_options(cli_args)&.[](:formatters)
       end
 
+      def self.has_require_rails_helper_option?(cli_args)
+        (parsed_options(cli_args)&.[](:requires) || []).include?("rails_helper")
+      end
+
       def self.order_option(cli_args)
         parsed_options(cli_args)&.[](:order)
       end
@@ -76,6 +80,10 @@ module KnapsackPro
         id.match(/\A(.*?)(?:\[([\d\s:,]+)\])?\z/).captures.first
       end
 
+      def self.rails_helper_exists?(test_dir)
+        File.exist?("#{test_dir}/rails_helper.rb")
+      end
+
       # private
       def self.top_level_group(example)
         group = example.metadata[:example_group]

data/lib/knapsack_pro/pure/queue/rspec_pure.rb

@@ -34,9 +34,10 @@ module KnapsackPro
           args + ['--seed', seed.value]
         end
 
-        def prepare_cli_args(args, has_format_option, test_dir)
+        def prepare_cli_args(args, has_format_option, has_require_rails_helper_option, rails_helper_exists, test_dir)
           (args || '').split
             .yield_self { args_with_at_least_one_formatter(_1, has_format_option) }
+            .yield_self { args_with_require_rails_helper_if_needed(_1, has_require_rails_helper_option, rails_helper_exists) }
             .yield_self { args_with_default_options(_1, test_dir) }
         end
 
@@ -75,6 +76,13 @@ module KnapsackPro
           cli_args + ['--format', 'progress']
         end
 
+        def args_with_require_rails_helper_if_needed(cli_args, has_require_rails_helper_option, rails_helper_exists)
+          return cli_args if has_require_rails_helper_option
+          return cli_args unless rails_helper_exists
+
+          cli_args + ['--require', 'rails_helper']
+        end
+
         def args_with_default_options(cli_args, test_dir)
           new_cli_args = cli_args + [
             '--default-path', test_dir,

data/lib/knapsack_pro/runners/queue/rspec_runner.rb

@@ -24,8 +24,11 @@ module KnapsackPro
           super(adapter_class)
           @adapter_class = adapter_class
           @rspec_pure = rspec_pure
-          has_format_option = @adapter_class.has_format_option?((args || '').split)
-          @cli_args = rspec_pure.prepare_cli_args(args, has_format_option, test_dir)
+          args_array = (args || '').split
+          has_format_option = @adapter_class.has_format_option?(args_array)
+          has_require_rails_helper_option = @adapter_class.has_require_rails_helper_option?(args_array)
+          rails_helper_exists = @adapter_class.rails_helper_exists?(test_dir)
+          @cli_args = rspec_pure.prepare_cli_args(args, has_format_option, has_require_rails_helper_option, rails_helper_exists, test_dir)
           @stream_error = stream_error
           @stream_out = stream_out
           @node_test_file_paths = []
@@ -53,6 +56,8 @@ module KnapsackPro
             Kernel.exit(exit_code)
           rescue Exception => exception
             KnapsackPro.logger.error("An unexpected exception happened. RSpec cannot handle it. The exception: #{exception.inspect}")
+            KnapsackPro.logger.error("Exception message: #{exception.message}")
+            KnapsackPro.logger.error("Exception backtrace: #{exception.backtrace.join("\n")}")
 
             message = @rspec_pure.exit_summary(unexecuted_test_files)
             KnapsackPro.logger.warn(message) if message

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '7.0.0'
+  VERSION = '7.1.0'
 end

data/spec/integration/runners/queue/rspec_runner.rb

@@ -26,7 +26,7 @@ module KnapsackProExtensions
       @batch_index += 1
 
       if SHOW_DEBUG_LOG
-        IntegrationTestLogger.log("Mocked tests from the Queue API: #{tests.inspect}")
+        IntegrationTestLogger.log("Stubbed tests from the Queue API: #{tests.inspect}")
       end
 
       tests
@@ -41,13 +41,13 @@ module KnapsackProExtensions
       end
 
       return unless SHOW_DEBUG_LOG
-      IntegrationTestLogger.log("Mocked the #{__method__} method")
+      IntegrationTestLogger.log("Stubbed the #{__method__} method")
     end
   end
 
   module RSpecAdapter
     def test_file_cases_for(slow_test_files)
-      IntegrationTestLogger.log("Mocked test file cases for slow test files: #{slow_test_files}")
+      IntegrationTestLogger.log("Stubbed test file cases for slow test files: #{slow_test_files}")
 
       test_file_paths = JSON.load(ENV.fetch('TEST__TEST_FILE_CASES_FOR_SLOW_TEST_FILES'))
       test_file_paths.map do |path|

data/spec/integration/runners/queue/rspec_runner_spec.rb

@@ -32,13 +32,18 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     )
   end
 
+  def create_rails_helper_file(rails_helper)
+    rails_helper_path = "#{SPEC_DIRECTORY}/rails_helper.rb"
+    File.open(rails_helper_path, 'w') { |file| file.write(rails_helper) }
+  end
+
   def stub_spec_batches(batched_tests)
     ENV['TEST__SPEC_BATCHES'] = batched_tests.to_json
   end
 
   # @param test_file_paths Array[String]
   #   Example: ['spec_integration/a_spec.rb[1:1]']
-  def mock_test_cases_for_slow_test_files(test_file_paths)
+  def stub_test_cases_for_slow_test_files(test_file_paths)
     ENV['TEST__TEST_FILE_CASES_FOR_SLOW_TEST_FILES'] = test_file_paths.to_json
   end
 
@@ -327,6 +332,174 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     end
   end
 
+  context 'when rails_helper file does not exist' do
+    it 'does not require the rails_helper file when running RSpec' do
+      rspec_options = ''
+
+      spec_helper = <<~SPEC
+      require 'knapsack_pro'
+      KnapsackPro::Adapters::RSpecAdapter.bind
+      SPEC
+
+      spec_a = Spec.new('a_spec.rb', <<~SPEC)
+        describe 'A_describe' do
+          it 'A1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_b = Spec.new('b_spec.rb', <<~SPEC)
+        describe 'B_describe' do
+          it 'B1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_c = Spec.new('c_spec.rb', <<~SPEC)
+        describe 'C_describe' do
+          it 'C1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      generate_specs(spec_helper, rspec_options, [
+        [spec_a, spec_b],
+        [spec_c],
+      ])
+
+      actual = subject
+
+      expect(actual.stdout).to_not include('--require rails_helper')
+
+      expect(actual.exit_code).to eq 0
+    end
+  end
+
+  context 'when rails_helper file exists' do
+    it 'requires the rails_helper file when running RSpec and runs hooks defined within it' do
+      rspec_options = ''
+
+      spec_helper = <<~SPEC
+      require 'knapsack_pro'
+      KnapsackPro::Adapters::RSpecAdapter.bind
+      SPEC
+
+      spec_a = Spec.new('a_spec.rb', <<~SPEC)
+        describe 'A_describe' do
+          it 'A1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_b = Spec.new('b_spec.rb', <<~SPEC)
+        describe 'B_describe' do
+          it 'B1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_c = Spec.new('c_spec.rb', <<~SPEC)
+        describe 'C_describe' do
+          it 'C1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      generate_specs(spec_helper, rspec_options, [
+        [spec_a, spec_b],
+        [spec_c],
+      ])
+
+      rails_helper = <<~SPEC
+      RSpec.configure do |config|
+        config.before(:suite) do
+          puts 'RSpec_before_suite_hook_from_rails_helper'
+        end
+        config.after(:suite) do
+          puts 'RSpec_after_suite_hook_from_rails_helper'
+        end
+      end
+      SPEC
+
+      create_rails_helper_file(rails_helper)
+
+      actual = subject
+
+      expect(actual.stdout).to include('--require rails_helper')
+      expect(actual.stdout.scan(/RSpec_before_suite_hook_from_rails_helper/).size).to eq 1
+      expect(actual.stdout.scan(/RSpec_after_suite_hook_from_rails_helper/).size).to eq 1
+
+      expect(actual.exit_code).to eq 0
+    end
+
+    it 'runs suite hooks defined in rails_helper only once, even if file is required multiple times' do
+      rspec_options = ''
+
+      spec_helper = <<~SPEC
+      require 'knapsack_pro'
+      KnapsackPro::Adapters::RSpecAdapter.bind
+      SPEC
+
+      spec_a = Spec.new('a_spec.rb', <<~SPEC)
+        require 'rails_helper'
+        describe 'A_describe' do
+          it 'A1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_b = Spec.new('b_spec.rb', <<~SPEC)
+        require 'rails_helper'
+        describe 'B_describe' do
+          it 'B1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      spec_c = Spec.new('c_spec.rb', <<~SPEC)
+        require 'rails_helper'
+        describe 'C_describe' do
+          it 'C1 test example' do
+            expect(1).to eq 1
+          end
+        end
+      SPEC
+
+      generate_specs(spec_helper, rspec_options, [
+        [spec_a, spec_b],
+        [spec_c],
+      ])
+
+      rails_helper = <<~SPEC
+      RSpec.configure do |config|
+        config.before(:suite) do
+          puts 'RSpec_before_suite_hook_from_rails_helper'
+        end
+        config.after(:suite) do
+          puts 'RSpec_after_suite_hook_from_rails_helper'
+        end
+      end
+      SPEC
+
+      create_rails_helper_file(rails_helper)
+
+      actual = subject
+
+      expect(actual.stdout.scan(/RSpec_before_suite_hook_from_rails_helper/).size).to eq 1
+      expect(actual.stdout.scan(/RSpec_after_suite_hook_from_rails_helper/).size).to eq 1
+
+      expect(actual.exit_code).to eq 0
+    end
+  end
+
   context 'when hooks are defined' do
     it 'calls RSpec before/after hooks only once for multiple batches of tests' do
       rspec_options = ''
@@ -942,6 +1115,8 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
 
       expect(actual.stdout).to include('B_describe')
       expect(actual.stdout).to include('An unexpected exception happened. RSpec cannot handle it. The exception: #<NoMemoryError: NoMemoryError>')
+      expect(actual.stdout).to include('Exception message: ')
+      expect(actual.stdout).to include('Exception backtrace: ')
       expect(actual.stdout).to_not include('B1 test example')
 
       expect(actual.stdout).to_not include('C1 test example')
@@ -1640,7 +1815,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
-      # remember to mock Queue API batches to include test examples (example: a_spec.rb[1:1])
+      # remember to stub Queue API batches to include test examples (example: a_spec.rb[1:1])
       # for the following slow test files
       ENV['KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN'] = "#{SPEC_DIRECTORY}/a_spec.rb"
     end
@@ -1688,7 +1863,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
       generate_specs(spec_helper_with_knapsack, rspec_options, [
         [spec_a, spec_b, spec_c]
       ])
-      mock_test_cases_for_slow_test_files([
+      stub_test_cases_for_slow_test_files([
         "#{spec_a.path}[1:1]",
         "#{spec_a.path}[1:2]",
       ])
@@ -1736,7 +1911,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
-      # remember to mock Queue API batches to include test examples (example: a_spec.rb[1:1])
+      # remember to stub Queue API batches to include test examples (example: a_spec.rb[1:1])
       # for the following slow test files
       ENV['KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN'] = "#{SPEC_DIRECTORY}/a_spec.rb"
     end
@@ -1784,7 +1959,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
       generate_specs(spec_helper_with_knapsack, rspec_options, [
         [spec_a, spec_b, spec_c]
       ])
-      mock_test_cases_for_slow_test_files([
+      stub_test_cases_for_slow_test_files([
         "#{spec_a.path}[1:1]",
         "#{spec_a.path}[1:2]",
       ])
@@ -1814,7 +1989,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
-      # remember to mock Queue API batches to include test examples (example: a_spec.rb[1:1])
+      # remember to stub Queue API batches to include test examples (example: a_spec.rb[1:1])
       # for the following slow test files
       ENV['KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN'] = "#{SPEC_DIRECTORY}/a_spec.rb"
     end
@@ -1862,7 +2037,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
       generate_specs(spec_helper_with_knapsack, rspec_options, [
         [spec_a, spec_b, spec_c]
       ])
-      mock_test_cases_for_slow_test_files([
+      stub_test_cases_for_slow_test_files([
         "#{spec_a.path}[1:1]",
         "#{spec_a.path}[1:2]",
       ])
@@ -1913,7 +2088,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
-      # remember to mock Queue API batches to include test examples (example: a_spec.rb[1:1])
+      # remember to stub Queue API batches to include test examples (example: a_spec.rb[1:1])
       # for the following slow test files
       ENV['KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN'] = "#{SPEC_DIRECTORY}/a_spec.rb"
     end
@@ -1961,7 +2136,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
       generate_specs(spec_helper_with_knapsack, rspec_options, [
         [spec_a, spec_b, spec_c]
       ])
-      mock_test_cases_for_slow_test_files([
+      stub_test_cases_for_slow_test_files([
         "#{spec_a.path}[1:1]",
         "#{spec_a.path}[1:2]",
       ])
@@ -2010,7 +2185,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
     before do
       ENV['KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES'] = 'true'
 
-      # remember to mock Queue API batches to include test examples (example: a_spec.rb[1:1])
+      # remember to stub Queue API batches to include test examples (example: a_spec.rb[1:1])
       # for the following slow test files
       ENV['KNAPSACK_PRO_SLOW_TEST_FILE_PATTERN'] = "#{SPEC_DIRECTORY}/a_spec.rb"
     end
@@ -2068,7 +2243,7 @@ describe "#{KnapsackPro::Runners::Queue::RSpecRunner} - Integration tests", :cle
       generate_specs(spec_helper, rspec_options, [
         [spec_a, spec_b, spec_c]
       ])
-      mock_test_cases_for_slow_test_files([
+      stub_test_cases_for_slow_test_files([
         "#{spec_a.path}[1:1]",
         "#{spec_a.path}[1:2]",
       ])

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -187,6 +187,60 @@ describe KnapsackPro::Adapters::RSpecAdapter do
     end
   end
 
+  describe '.has_require_rails_helper_option?' do
+    subject { described_class.has_require_rails_helper_option?(cli_args) }
+
+    context 'when require option is provided as -r' do
+      let(:cli_args) { ['-r', 'rails_helper'] }
+
+      it { expect(subject).to be true }
+    end
+
+    context 'when require option is provided as --require' do
+      let(:cli_args) { ['--require', 'rails_helper'] }
+
+      it { expect(subject).to be true }
+    end
+
+    context 'when require option is provided without delimiter' do
+      let(:cli_args) { ['-rrails_helper'] }
+
+      it { expect(subject).to be true }
+    end
+
+    context 'when require option is not provided' do
+      let(:cli_args) { ['--fake', 'value'] }
+
+      it { expect(subject).to be false }
+    end
+  end
+
+  describe '.rails_helper_exists?' do
+    subject { described_class.rails_helper_exists?(test_dir) }
+
+    let(:test_dir) { 'spec_fake' }
+
+    context 'when rails_helper exists' do
+      before do
+        File.open("#{test_dir}/rails_helper.rb", 'w')
+      end
+
+      after do
+        FileUtils.rm("#{test_dir}/rails_helper.rb")
+      end
+
+      it { expect(subject).to be true }
+    end
+
+    context 'when rails_helper does not exist' do
+      before do
+        FileUtils.rm_f("#{test_dir}/rails_helper.rb")
+      end
+
+      it { expect(subject).to be false }
+    end
+  end
+
   describe '.order_option' do
     subject { described_class.order_option(cli_args) }
 

data/spec/knapsack_pro/formatters/time_tracker_fetcher_spec.rb

@@ -0,0 +1,30 @@
+require(KnapsackPro.root + '/lib/knapsack_pro/formatters/time_tracker')
+
+describe KnapsackPro::Formatters::TimeTrackerFetcher do
+  describe '.unexecuted_test_files' do
+    subject { described_class.unexecuted_test_files(scheduled_paths) }
+
+    context 'when the time tracker formatter not found' do
+      let(:scheduled_paths) { ['a_spec.rb'] }
+
+      it do
+        expect(subject).to eq []
+      end
+    end
+
+    context 'when the time tracker formatter is found' do
+      let(:time_tracker) { instance_double(KnapsackPro::Formatters::TimeTracker) }
+      let(:scheduled_paths) { ['a_spec.rb', 'b_spec.rb'] }
+      let(:unexecuted_test_files) { double(:unexecuted_test_files) }
+
+      before do
+        expect(described_class).to receive(:call).and_return(time_tracker)
+        expect(time_tracker).to receive(:unexecuted_test_files).with(scheduled_paths).and_return(unexecuted_test_files)
+      end
+
+      it do
+        expect(subject).to eq unexecuted_test_files
+      end
+    end
+  end
+end

data/spec/knapsack_pro/formatters/time_tracker_specs.rb

@@ -382,7 +382,7 @@ class TestTimeTracker
 
   def run_specs(specs)
     files = Array(specs).map.with_index do |spec, i|
-      file = Tempfile.new(["time_tracker_#{i}", "_spec.rb"], "./spec/knapsack_pro/formatters/")
+      file = Tempfile.new(["tmp_time_tracker_#{i}", "_spec.rb"], "./spec/knapsack_pro/formatters/")
       file.write(spec)
       file.rewind
       file

data/spec/knapsack_pro/pure/queue/rspec_pure_spec.rb

@@ -117,31 +117,52 @@ describe KnapsackPro::Pure::Queue::RSpecPure do
   end
 
   describe '#prepare_cli_args' do
-    subject { rspec_pure.prepare_cli_args(args, has_format_option, test_dir) }
+    subject { rspec_pure.prepare_cli_args(args, has_format_option, has_require_rails_helper_option, rails_helper_exists, test_dir) }
 
     context 'when no args' do
       let(:args) { nil }
       let(:has_format_option) { false }
+      let(:has_require_rails_helper_option) { false }
       let(:test_dir) { 'spec' }
 
-      it 'adds the default progress formatter and the default path and the time tracker formatter' do
-        expect(subject).to eq [
-          '--format', 'progress',
-          '--default-path', 'spec',
-          '--format', 'KnapsackPro::Formatters::TimeTracker',
-        ]
+      context 'when rails_helper does not exist' do
+        let(:rails_helper_exists) { false }
+
+        it 'adds the default progress formatter, the default path and the time tracker formatter, does not add require rails_helper' do
+          expect(subject).to eq [
+            '--format', 'progress',
+            '--default-path', 'spec',
+            '--format', 'KnapsackPro::Formatters::TimeTracker',
+          ]
+        end
+      end
+
+      context 'when rails_helper exists' do
+        let(:rails_helper_exists) { true }
+
+        it 'adds the default progress formatter, require rails_helper, the default path and the time tracker formatter' do
+          expect(subject).to eq [
+            '--format', 'progress',
+            '--require', 'rails_helper',
+            '--default-path', 'spec',
+            '--format', 'KnapsackPro::Formatters::TimeTracker',
+          ]
+        end
       end
     end
 
     context 'when args are present and a custom test directory is set' do
-      let(:args) { '--color --profile' }
+      let(:args) { '--color --profile --require rails_helper' }
       let(:has_format_option) { false }
+      let(:has_require_rails_helper_option) { true }
+      let(:rails_helper_exists) { true }
       let(:test_dir) { 'custom_spec_dir' }
 
       it do
         expect(subject).to eq [
           '--color',
           '--profile',
+          '--require', 'rails_helper',
           '--format', 'progress',
           '--default-path', 'custom_spec_dir',
           '--format', 'KnapsackPro::Formatters::TimeTracker',
@@ -150,8 +171,10 @@ describe KnapsackPro::Pure::Queue::RSpecPure do
     end
 
     context 'when args are present and has format option' do
-      let(:args) { '--color --profile --format d' }
+      let(:args) { '--color --profile --format d --require rails_helper' }
       let(:has_format_option) { true }
+      let(:has_require_rails_helper_option) { true }
+      let(:rails_helper_exists) { true }
       let(:test_dir) { 'spec' }
 
       it 'uses the format option from args instead of the default formatter' do
@@ -159,6 +182,7 @@ describe KnapsackPro::Pure::Queue::RSpecPure do
           '--color',
           '--profile',
           '--format', 'd',
+          '--require', 'rails_helper',
           '--default-path', 'spec',
           '--format', 'KnapsackPro::Formatters::TimeTracker',
         ]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 7.0.0
+  version: 7.1.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-23 00:00:00.000000000 Z
+date: 2024-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -340,6 +340,7 @@ files:
 - spec/knapsack_pro/crypto/decryptor_spec.rb
 - spec/knapsack_pro/crypto/digestor_spec.rb
 - spec/knapsack_pro/crypto/encryptor_spec.rb
+- spec/knapsack_pro/formatters/time_tracker_fetcher_spec.rb
 - spec/knapsack_pro/formatters/time_tracker_specs.rb
 - spec/knapsack_pro/hooks/queue_spec.rb
 - spec/knapsack_pro/logger_wrapper_spec.rb
@@ -462,6 +463,7 @@ test_files:
 - spec/knapsack_pro/crypto/decryptor_spec.rb
 - spec/knapsack_pro/crypto/digestor_spec.rb
 - spec/knapsack_pro/crypto/encryptor_spec.rb
+- spec/knapsack_pro/formatters/time_tracker_fetcher_spec.rb
 - spec/knapsack_pro/formatters/time_tracker_specs.rb
 - spec/knapsack_pro/hooks/queue_spec.rb
 - spec/knapsack_pro/logger_wrapper_spec.rb