knapsack_pro 6.0.1 → 6.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 300a23bb327345712cf1a4c256073461ac22ac19d6aad51ab2a5c0676a6b5e3d
-  data.tar.gz: 7a2f868e5ff853f1329f676266efd23f5b2c9a6b3a8348b3ed55558394b91d0e
+  metadata.gz: '05131444388481496f61779bc12d4bb749111cf798d667d969664b5bd2668e08'
+  data.tar.gz: 9fb9f32b315e914e4f089ff0946a8204017740a23cf2fede172f4276b29dfcd4
 SHA512:
-  metadata.gz: f7a22a7ba6c8e36cf6a77149e081d07cf22053b8991252d62782332063ee92d8e42c943cdedeb8fac003fa56adcd328fa43d9c7e5e5a6c9f094a00b9a92a4905
-  data.tar.gz: 197a2568354954113ac93a74b057b36a01ba7d6aa83ac255a6e1a0092f509abe64dc47ff95bffa2d4d1fd631727689eeaf0e8b46429efd708bc6f9268e6b0fd3
+  metadata.gz: 786fc53dbf7b6c068c2135b3f1d29218b17a1d5155db591088a4642442b281e387afa1b8815a9ccd3adfd88da86aded5158a7f5110e09d057a021aa5ef563891
+  data.tar.gz: f771d87b9dcd3c2dd19cc5058d7a9dc3a56e1a2101cbaeff1210bda562bd0670341ce6f3e2f341f32a1f1e5cd49a165c96cd36999f109a7dad87a3adf7cc25ae

data/CHANGELOG.md

@@ -1,8 +1,25 @@
 # Changelog
 
+### 6.0.3
+
+* fix(Turnip): make sure `.feature` files are recorded
+* fix(RSpec): stop recording `UNKNOWN_PATH` that would generate an error in case of a CI node retry
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/233
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v6.0.2...v6.0.3
+
+### 6.0.2
+
+* fix(RSpec): allow using `TimeTracker` in RSpec < 3.10.2 when formatters were required to expose `#output`
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/232
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v6.0.1...v6.0.2
+
 ### 6.0.1
 
-* fix(RSpec): allow to use Queue Mode for RSpec <= 3.10 when the `rspec_is_quitting` method is not present for RSpec World object
+* fix(RSpec): allow using Queue Mode in RSpec <= 3.10 when the `rspec_is_quitting` method is not present for RSpec World object
 
     https://github.com/KnapsackPro/knapsack_pro-ruby/pull/231
 

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -65,7 +65,7 @@ module KnapsackPro
         ]
           .each do |path|
             p = path.call
-            return p if p.include?('_spec.rb')
+            return p if p.include?('_spec.rb') || p.include?('.feature')
           end
 
         return ''

data/lib/knapsack_pro/formatters/time_tracker.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'stringio'
+
 module KnapsackPro
   module Formatters
     class TimeTracker
@@ -10,10 +12,13 @@ module KnapsackPro
         :example_group_finished,
         :stop
 
+      attr_reader :output # RSpec < v3.10.2
+
       # Called at the beginning of each batch,
       # but only the first instance of this class is used,
       # so don't rely on the initializer to reset values.
       def initialize(_output)
+        @output = StringIO.new
         @time_each = nil
         @time_all = nil
         @before_all = 0.0
@@ -110,8 +115,9 @@ module KnapsackPro
 
       def record_example(accumulator, example, started_at)
         path = path_for(example)
-        time_execution = time_execution_for(example, started_at)
+        return if path.nil?
 
+        time_execution = time_execution_for(example, started_at)
         if accumulator.key?(path)
           accumulator[path][:time_execution] += time_execution
         else
@@ -121,7 +127,8 @@ module KnapsackPro
 
       def path_for(example)
         file = file_path_for(example)
-        return "UNKNOWN_PATH" if file == ""
+        return nil if file == ""
+
         path = rspec_split_by_test_example?(file) ? example.id : file
         KnapsackPro::TestFileCleaner.clean(path)
       end

data/lib/knapsack_pro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KnapsackPro
-  VERSION = '6.0.1'
+  VERSION = '6.0.3'
 end

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -305,6 +305,15 @@ describe KnapsackPro::Adapters::RSpecAdapter do
         expect(subject).to eq('')
       end
     end
+
+    context "when id does not end in .feature (nor _spec.rb)" do
+      it "returns the file_path" do
+        allow(current_example).to receive(:id).and_return("./foo.rb")
+        allow(current_example).to receive(:metadata).and_return(file_path: "./foo.feature")
+
+        expect(subject).to eq("./foo.feature")
+      end
+    end
   end
 
   describe 'bind methods' do

data/spec/knapsack_pro/formatters/time_tracker_specs.rb

@@ -280,9 +280,9 @@ class TestTimeTracker
     SPEC
 
     run_specs(spec) do |spec_paths, times|
-      raise unless times.size == 2
-      raise unless times[0]["path"] == "UNKNOWN_PATH"
-      raise unless times[1]["path"] == spec_paths.first
+      raise unless times.size == 1
+      raise unless times[0]["path"] == spec_paths.first
+      raise unless times[0]["time_execution"] == 0.0
     end
 
   ensure
@@ -431,7 +431,7 @@ class TestTimeTracker
       .queue(paths)
       .sort_by { |time| time["path"] }
       .filter do |time|
-        paths.any? { |path| time["path"].start_with?(path) || time["path"] == "UNKNOWN_PATH" }
+        paths.any? { |path| time["path"].start_with?(path) }
       end
     yield(paths, times, time_tracker)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 6.0.1
+  version: 6.0.3
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-04 00:00:00.000000000 Z
+date: 2023-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake