knapsack_pro 5.6.0 → 6.0.0

data/spec/knapsack_pro/runners/queue/rspec_runner_spec.rb

@@ -6,6 +6,7 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
 
     require KnapsackPro.root + '/lib/knapsack_pro/formatters/rspec_queue_summary_formatter'
     require KnapsackPro.root + '/lib/knapsack_pro/formatters/rspec_queue_profile_formatter_extension'
+    require KnapsackPro.root + '/lib/knapsack_pro/formatters/time_tracker'
   end
 
   describe '.run' do
@@ -45,7 +46,13 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
             status: :next,
             runner: runner,
             can_initialize_queue: true,
-            args: ['--example-arg', 'example-value', '--format', 'progress', '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter', '--default-path', 'fake-test-dir'],
+            args: [
+              '--example-arg', 'example-value',
+              '--format', 'progress',
+              '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter',
+              '--format', 'KnapsackPro::Formatters::TimeTracker',
+              '--default-path', 'fake-test-dir',
+            ],
             exitstatus: 0,
             all_test_file_paths: [],
           }
@@ -71,7 +78,12 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
             status: :next,
             runner: runner,
             can_initialize_queue: true,
-            args: ['--format', 'documentation', '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter', '--default-path', 'fake-test-dir'],
+            args: [
+              '--format', 'documentation',
+              '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter',
+              '--format', 'KnapsackPro::Formatters::TimeTracker',
+              '--default-path', 'fake-test-dir',
+            ],
             exitstatus: 0,
             all_test_file_paths: [],
           }
@@ -97,7 +109,12 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
             status: :next,
             runner: runner,
             can_initialize_queue: true,
-            args: ['-f', 'd', '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter', '--default-path', 'fake-test-dir'],
+            args: [
+              '-f', 'd',
+              '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter',
+              '--format', 'KnapsackPro::Formatters::TimeTracker',
+              '--default-path', 'fake-test-dir',
+            ],
             exitstatus: 0,
             all_test_file_paths: [],
           }
@@ -123,7 +140,12 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
             status: :next,
             runner: runner,
             can_initialize_queue: true,
-            args: ['-fMyCustomFormatter', '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter', '--default-path', 'fake-test-dir'],
+            args: [
+              '-fMyCustomFormatter',
+              '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter',
+              '--format', 'KnapsackPro::Formatters::TimeTracker',
+              '--default-path', 'fake-test-dir',
+            ],
             exitstatus: 0,
             all_test_file_paths: [],
           }
@@ -165,7 +187,12 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
           status: :next,
           runner: runner,
           can_initialize_queue: true,
-          args: ['--format', 'progress', '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter', '--default-path', 'fake-test-dir'],
+          args: [
+            '--format', 'progress',
+            '--format', 'KnapsackPro::Formatters::RSpecQueueSummaryFormatter',
+            '--format', 'KnapsackPro::Formatters::TimeTracker',
+            '--default-path', 'fake-test-dir',
+          ],
           exitstatus: 0,
           all_test_file_paths: [],
         }
@@ -219,12 +246,7 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
 
           expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_SUBSET_QUEUE_ID', subset_queue_id)
 
-          tracker = instance_double(KnapsackPro::Tracker)
-          expect(KnapsackPro).to receive(:tracker).twice.and_return(tracker)
-          expect(tracker).to receive(:reset!)
-          expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
-
-          expect(described_class).to receive(:ensure_spec_opts_have_rspec_queue_summary_formatter)
+          expect(described_class).to receive(:ensure_spec_opts_have_knapsack_pro_formatters)
           options = double
           expect(RSpec::Core::ConfigurationOptions).to receive(:new).with([
             '--no-color',
@@ -241,8 +263,6 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
 
           expect(KnapsackPro::Hooks::Queue).to receive(:call_after_subset_queue)
 
-          expect(KnapsackPro::Report).to receive(:save_subset_queue_to_file)
-
           configuration = double
           expect(rspec_core_runner).to receive(:configuration).twice.and_return(configuration)
           expect(configuration).to receive(:seed_used?).and_return(true)
@@ -344,12 +364,7 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
 
           expect(ENV).to receive(:[]=).with('KNAPSACK_PRO_SUBSET_QUEUE_ID', subset_queue_id)
 
-          tracker = instance_double(KnapsackPro::Tracker)
-          expect(KnapsackPro).to receive(:tracker).twice.and_return(tracker)
-          expect(tracker).to receive(:reset!)
-          expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
-
-          expect(described_class).to receive(:ensure_spec_opts_have_rspec_queue_summary_formatter)
+          expect(described_class).to receive(:ensure_spec_opts_have_knapsack_pro_formatters)
           options = double
           expect(RSpec::Core::ConfigurationOptions).to receive(:new).with([
             '--no-color',
@@ -361,16 +376,14 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
           expect(RSpec::Core::Runner).to receive(:new).with(options).and_return(rspec_core_runner)
           expect(rspec_core_runner).to receive(:run).with($stderr, $stdout).and_raise SystemExit
           expect(KnapsackPro::Hooks::Queue).to receive(:call_before_subset_queue)
-          allow(KnapsackPro::Report).to receive(:save_subset_queue_to_file)
           allow(KnapsackPro::Hooks::Queue).to receive(:call_after_subset_queue)
           allow(KnapsackPro::Hooks::Queue).to receive(:call_after_queue)
           allow(KnapsackPro::Formatters::RSpecQueueSummaryFormatter).to receive(:print_exit_summary)
           expect(Kernel).to receive(:exit).with(1)
         end
 
-        it 'does not call #save_subset_queue_to_file or #rspec_clear_examples' do
+        it 'does not call #rspec_clear_examples' do
           expect(described_class).not_to receive(:rspec_clear_examples)
-          expect(KnapsackPro::Report).not_to receive(:save_subset_queue_to_file)
           expect { subject }.to raise_error SystemExit
         end
 
@@ -411,7 +424,14 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
           expect(KnapsackPro::Formatters::RSpecQueueProfileFormatterExtension).to receive(:print_summary)
 
           expect(KnapsackPro::Hooks::Queue).to receive(:call_after_queue)
-          expect(KnapsackPro::Report).to receive(:save_node_queue_to_api)
+
+          time_tracker = instance_double(KnapsackPro::Formatters::TimeTracker)
+          times = all_test_file_paths.map do |path|
+            [{ path: path, time_execution: 1.0 }]
+          end
+          expect(time_tracker).to receive(:queue).and_return(times)
+          expect(KnapsackPro::Formatters::TimeTrackerFetcher).to receive(:call).and_return(time_tracker)
+          expect(KnapsackPro::Report).to receive(:save_node_queue_to_api).with(times)
 
           expect(logger).to receive(:info)
             .with('To retry all the tests assigned to this CI node, please run the following command on your machine:')
@@ -448,7 +468,15 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
 
         it do
           expect(KnapsackPro::Hooks::Queue).to receive(:call_after_queue)
-          expect(KnapsackPro::Report).to receive(:save_node_queue_to_api)
+
+          time_tracker = instance_double(KnapsackPro::Formatters::TimeTracker)
+          times = all_test_file_paths.map do |path|
+            [{ path: path, time_execution: 0.0 }]
+          end
+          expect(time_tracker).to receive(:queue).and_return(times)
+          expect(KnapsackPro::Formatters::TimeTrackerFetcher).to receive(:call).and_return(time_tracker)
+          expect(KnapsackPro::Report).to receive(:save_node_queue_to_api).with(times)
+
           expect(KnapsackPro).to_not receive(:logger)
 
           expect(subject).to eq({
@@ -460,29 +488,40 @@ describe KnapsackPro::Runners::Queue::RSpecRunner do
     end
   end
 
-  describe '.ensure_spec_opts_have_rspec_queue_summary_formatter' do
-    subject { described_class.ensure_spec_opts_have_rspec_queue_summary_formatter }
+  describe '.ensure_spec_opts_have_knapsack_pro_formatters' do
+    subject { described_class.ensure_spec_opts_have_knapsack_pro_formatters }
 
     context 'when `SPEC_OPTS` is set' do
-      context 'when `SPEC_OPTS` has RSpec Queue Summary Formatter' do
+      context 'when `SPEC_OPTS` has RSpecQueueSummaryFormatter' do
         before do
           stub_const('ENV', { 'SPEC_OPTS' => '--format json --format KnapsackPro::Formatters::RSpecQueueSummaryFormatter' })
         end
 
-        it 'does nothing' do
+        it 'adds TimeTracker' do
+          subject
+          expect(ENV['SPEC_OPTS']).to eq '--format json --format KnapsackPro::Formatters::RSpecQueueSummaryFormatter --format KnapsackPro::Formatters::TimeTracker'
+        end
+      end
+
+      context 'when `SPEC_OPTS` has TimeTracker' do
+        before do
+          stub_const('ENV', { 'SPEC_OPTS' => '--format json --format KnapsackPro::Formatters::TimeTracker' })
+        end
+
+        it 'adds RSpecQueueSummaryFormatter' do
           subject
-          expect(ENV['SPEC_OPTS']).to eq '--format json --format KnapsackPro::Formatters::RSpecQueueSummaryFormatter'
+          expect(ENV['SPEC_OPTS']).to eq '--format json --format KnapsackPro::Formatters::TimeTracker --format KnapsackPro::Formatters::RSpecQueueSummaryFormatter'
         end
       end
 
-      context 'when `SPEC_OPTS` has no RSpec Queue Summary Formatter' do
+      context 'when `SPEC_OPTS` has no Knapsack Pro formatters' do
         before do
           stub_const('ENV', { 'SPEC_OPTS' => '--format json' })
         end
 
-        it 'adds RSpec Queue Summary Formatter to `SPEC_OPTS`' do
+        it 'adds RSpecQueueSummaryFormatter and TimeTracker to `SPEC_OPTS`' do
           subject
-          expect(ENV['SPEC_OPTS']).to eq '--format json --format KnapsackPro::Formatters::RSpecQueueSummaryFormatter'
+          expect(ENV['SPEC_OPTS']).to eq '--format json --format KnapsackPro::Formatters::RSpecQueueSummaryFormatter --format KnapsackPro::Formatters::TimeTracker'
         end
       end
     end

data/spec/knapsack_pro/runners/rspec_runner_spec.rb

@@ -42,14 +42,11 @@ describe KnapsackPro::Runners::RSpecRunner do
         expect(KnapsackPro::Adapters::RSpecAdapter).to receive(:verify_bind_method_called).ordered
         expect(KnapsackPro::Adapters::RSpecAdapter).to receive(:ensure_no_tag_option_when_rspec_split_by_test_examples_enabled!).with(['--profile', '--color']).ordered
 
-        tracker = instance_double(KnapsackPro::Tracker)
-        expect(KnapsackPro).to receive(:tracker).and_return(tracker)
-        expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
-
         expect(Rake::Task).to receive(:[]).with('knapsack_pro:rspec_run').at_least(1).and_return(task)
 
         expect(RSpec::Core::RakeTask).to receive(:new).with('knapsack_pro:rspec_run').and_yield(task_config)
-        expect(task_config).to receive(:rspec_opts=).with('--profile --color --default-path fake-test-dir spec/a_spec.rb spec/b_spec.rb[1:1]')
+        expect(RSpec::Core::ConfigurationOptions).to receive_message_chain(:new, :options).and_return({})
+        expect(task_config).to receive(:rspec_opts=).with('--profile --color --format progress --format KnapsackPro::Formatters::TimeTracker --default-path fake-test-dir spec/a_spec.rb spec/b_spec.rb[1:1]')
         expect(task_config).to receive(:pattern=).with([])
       end
 

data/spec/knapsack_pro/tracker_spec.rb

@@ -177,29 +177,8 @@ describe KnapsackPro::Tracker do
 
     it_behaves_like 'default trakcer attributes'
 
-    it "global time since beginning won't be reset" do
-      expect(tracker.global_time_since_beginning).to be >= 0.1
-    end
-
     it 'resets prerun_tests_loaded to false' do
       expect(tracker.prerun_tests_loaded).to be false
     end
   end
-
-
-  describe '#unexecuted_test_files' do
-    before do
-      tracker.set_prerun_tests(['a_spec.rb', 'b_spec.rb', 'c_spec.rb'])
-
-      # measure execution time for b_spec.rb
-      tracker.current_test_path = 'b_spec.rb'
-      tracker.start_timer
-      sleep 0.1
-      tracker.stop_timer
-    end
-
-    it 'returns test files without measured time' do
-      expect(tracker.unexecuted_test_files).to eq(['a_spec.rb', 'c_spec.rb'])
-    end
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 5.6.0
+  version: 6.0.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-24 00:00:00.000000000 Z
+date: 2023-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -183,7 +183,7 @@ description: Run tests in parallel across CI server nodes based on tests executi
   time. Thanks to that your CI build time is as fast as possible. It works with many
   CI providers.
 email:
-- arturtrzop@gmail.com
+- support@knapsackpro.com
 executables:
 - knapsack_pro
 extensions: []
@@ -201,6 +201,7 @@ files:
 - README.md
 - Rakefile
 - bin/knapsack_pro
+- bin/test
 - knapsack_pro.gemspec
 - lib/knapsack_pro.rb
 - lib/knapsack_pro/adapters/base_adapter.rb
@@ -239,10 +240,11 @@ files:
 - lib/knapsack_pro/crypto/decryptor.rb
 - lib/knapsack_pro/crypto/digestor.rb
 - lib/knapsack_pro/crypto/encryptor.rb
-- lib/knapsack_pro/extensions/time.rb
 - lib/knapsack_pro/formatters/rspec_json_formatter.rb
 - lib/knapsack_pro/formatters/rspec_queue_profile_formatter_extension.rb
 - lib/knapsack_pro/formatters/rspec_queue_summary_formatter.rb
+- lib/knapsack_pro/formatters/time_tracker.rb
+- lib/knapsack_pro/formatters/time_tracker_fetcher.rb
 - lib/knapsack_pro/hooks/queue.rb
 - lib/knapsack_pro/logger_wrapper.rb
 - lib/knapsack_pro/mask_string.rb
@@ -335,7 +337,7 @@ files:
 - spec/knapsack_pro/crypto/decryptor_spec.rb
 - spec/knapsack_pro/crypto/digestor_spec.rb
 - spec/knapsack_pro/crypto/encryptor_spec.rb
-- spec/knapsack_pro/extensions/time_spec.rb
+- spec/knapsack_pro/formatters/time_tracker_specs.rb
 - spec/knapsack_pro/hooks/queue_spec.rb
 - spec/knapsack_pro/logger_wrapper_spec.rb
 - spec/knapsack_pro/presenter_spec.rb
@@ -388,7 +390,7 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/KnapsackPro/knapsack_pro-ruby/issues
   changelog_uri: https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md
-  documentation_uri: https://docs.knapsackpro.com/integration/
+  documentation_uri: https://docs.knapsackpro.com/knapsack_pro-ruby/guide/
   homepage_uri: https://knapsackpro.com
   source_code_uri: https://github.com/KnapsackPro/knapsack_pro-ruby
 post_install_message:
@@ -455,7 +457,7 @@ test_files:
 - spec/knapsack_pro/crypto/decryptor_spec.rb
 - spec/knapsack_pro/crypto/digestor_spec.rb
 - spec/knapsack_pro/crypto/encryptor_spec.rb
-- spec/knapsack_pro/extensions/time_spec.rb
+- spec/knapsack_pro/formatters/time_tracker_specs.rb
 - spec/knapsack_pro/hooks/queue_spec.rb
 - spec/knapsack_pro/logger_wrapper_spec.rb
 - spec/knapsack_pro/presenter_spec.rb

data/lib/knapsack_pro/extensions/time.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-require 'time'
-
-class Time
-  class << self
-    alias_method :raw_now, :now
-  end
-end

data/spec/knapsack_pro/extensions/time_spec.rb

@@ -1,5 +0,0 @@
-describe Time do
-  it do
-    expect(Time.respond_to?(:raw_now)).to be true
-  end
-end