knapsack_pro 5.2.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f00531028caf0501edea4bf33df1bd81fe7ec9fbc888875797289f488e51851e
-  data.tar.gz: dbe2e29cdb257ef772348653e40bcccc0ae4d70e8fc0fdd72fd26193784a60b7
+  metadata.gz: 8cce96343b30d782aa576d77ab957b9af2b767ff7896f6507bcf6d0fed5ad8ea
+  data.tar.gz: b1ff76bcc2c99420049e1a52d0f9715dfa8c208dc2dd5e35b1e56756982ef059
 SHA512:
-  metadata.gz: 8ac1af3bf5eff25233ddb17294c56d9de6c9ec0d94c6412182a69ce2f4c04082eb705b0f204e42a342486c2001862171503d6726012421b336fe25c851e103c8
-  data.tar.gz: 52d4b68c5793defaf162659597d63afa7461964c78e6b78385ffe21af5cdf529124a15c9d5d96f2ca7216e175daa8b9aa6d2b04698e23c59b2a71b6603b13318
+  metadata.gz: 70721672e47f388e2826baa88da884e596bc4784891ea5177e51584510579ce08f6297b853ac4c821c9e7d32861362587295a8e0ac1c5b290495df847f99acd9
+  data.tar.gz: 475fe2a76e55a56575ed8d81cb8534b8d0fd2d5df044b8dd0a35a8a98d0e9e89a0045645d23e550e6833d80b7bc4d0c526c11e7035dec06699eae7d4d6ab8efb

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+### 5.3.0
+
+* Perf: Send authors to the API only on the first request (for Queue Mode)
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.2.1...v5.3.0
+
+### 5.2.1
+
+* Shallow fetch the last month of commits only on CI
+* Ensure input to `git shortlog`
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/209
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.2.0...v5.2.1
+
 ### 5.2.0
 
 * Send authors to the API

data/lib/knapsack_pro/client/api/v1/queues.rb

@@ -17,13 +17,13 @@ module KnapsackPro
                 :node_index => args.fetch(:node_index),
                 :node_build_id => KnapsackPro::Config::Env.ci_node_build_id,
                 :user_seat => KnapsackPro::Config::Env.masked_user_seat,
-                :build_author => KnapsackPro::RepositoryAdapters::GitAdapter.new.build_author,
-                :commit_authors => KnapsackPro::RepositoryAdapters::GitAdapter.new.commit_authors,
               }
 
               if request_hash[:can_initialize_queue] && !request_hash[:attempt_connect_to_queue]
                 request_hash.merge!({
-                  :test_files => args.fetch(:test_files)
+                  :test_files => args.fetch(:test_files),
+                  :build_author => KnapsackPro::RepositoryAdapters::GitAdapter.new.build_author,
+                  :commit_authors => KnapsackPro::RepositoryAdapters::GitAdapter.new.commit_authors,
                 })
               end
 

data/lib/knapsack_pro/config/env.rb

@@ -285,6 +285,11 @@ module KnapsackPro
           ENV['KNAPSACK_PRO_TEST_RUNNER_ADAPTER'] = adapter_class.to_s.split('::').last
         end
 
+        def ci?
+          ENV.fetch('CI', 'false').downcase == 'true' ||
+            detected_ci != KnapsackPro::Config::CI::Base
+        end
+
         private
 
         def required_env(env_name)

data/lib/knapsack_pro/repository_adapters/git_adapter.rb

@@ -41,7 +41,11 @@ module KnapsackPro
       private
 
       def git_commit_authors
-        `git fetch --shallow-since "1 month ago" >/dev/null 2>&1 && git shortlog --summary --email --since "one month ago"`
+        if KnapsackPro::Config::Env.ci?
+          `git fetch --shallow-since "one month ago" --quiet`
+        end
+
+        `git log --since "one month ago" | git shortlog --summary --email`
       end
 
       def git_build_author

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '5.2.0'
+  VERSION = '5.3.0'
 end

data/spec/knapsack_pro/client/api/v1/queues_spec.rb

@@ -53,6 +53,16 @@ describe KnapsackPro::Client::API::V1::Queues do
         ).and_return(action)
         expect(subject).to eq action
       end
+
+      it "sends authors" do
+        action = double
+
+        expect(KnapsackPro::Client::API::Action).to receive(:new).with(
+          hash_including(request_hash: hash_including(:build_author, :commit_authors))
+        ).and_return(action)
+
+        expect(subject).to eq action
+      end
     end
 
     context 'when can_initialize_queue=false and attempt_connect_to_queue=false' do
@@ -67,15 +77,5 @@ describe KnapsackPro::Client::API::V1::Queues do
         expect(subject).to eq action
       end
     end
-
-    it "sends authors" do
-      action = double
-
-      expect(KnapsackPro::Client::API::Action).to receive(:new).with(
-        hash_including(request_hash: hash_including(:build_author, :commit_authors))
-      ).and_return(action)
-
-      expect(subject).to eq action
-    end
   end
 end

data/spec/knapsack_pro/config/env_spec.rb

@@ -1041,4 +1041,18 @@ describe KnapsackPro::Config::Env do
       end
     end
   end
+
+  describe '.ci?' do
+    [
+      ['CI from env', { 'CI' => 'True' }, true],
+      ['Travis CI', { 'TRAVIS' => 'true' }, true],
+      ['Unsupported', {}, false],
+    ].each do |ci, env, expected|
+      it "detects #{ci}" do
+        stub_const("ENV", env)
+
+        expect(described_class.ci?).to eq(expected)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.3.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-17 00:00:00.000000000 Z
+date: 2023-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake