knapsack_pro 4.0.0 → 5.0.0

data/spec/knapsack_pro/config/env_spec.rb

@@ -632,20 +632,6 @@ describe KnapsackPro::Config::Env do
     end
   end
 
-  describe '.fixed_test_suite_split' do
-    subject { described_class.fixed_test_suite_split }
-
-    context 'when ENV exists' do
-      before { stub_const("ENV", { 'KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT' => false }) }
-      it { should eq false }
-    end
-
-    context "when ENV doesn't exist" do
-      before { stub_const("ENV", {}) }
-      it { should be true }
-    end
-  end
-
   describe '.fixed_test_suite_split?' do
     subject { described_class.fixed_test_suite_split? }
 
@@ -667,38 +653,94 @@ describe KnapsackPro::Config::Env do
     end
   end
 
-  describe '.fixed_queue_split' do
-    subject { described_class.fixed_queue_split }
-
-    context 'when ENV exists' do
-      before { stub_const("ENV", { 'KNAPSACK_PRO_FIXED_QUEUE_SPLIT' => true }) }
-      it { should eq true }
-    end
-
-    context "when ENV doesn't exist" do
-      before { stub_const("ENV", {}) }
-      it { should be false }
-    end
-  end
-
   describe '.fixed_queue_split?' do
     subject { described_class.fixed_queue_split? }
+    after(:each) { described_class.remove_instance_variable(:@fixed_queue_split) }
 
     context 'when ENV exists' do
-      context 'when KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true' do
-        before { stub_const("ENV", { 'KNAPSACK_PRO_FIXED_QUEUE_SPLIT' => 'true' }) }
-        it { should be true }
+      context 'when KNAPSACK_PRO_FIXED_QUEUE_SPLIT=false' do
+        [
+          ['AppVeyor', { 'APPVEYOR' => '123' }],
+          ['Buildkite', { 'BUILDKITE' => 'true' }],
+          ['CircleCI', { 'CIRCLECI' => 'true' }],
+          ['Cirrus CI', { 'CIRRUS_CI' => 'true' }],
+          ['Codefresh', { 'CF_BUILD_ID' => '123' }],
+          ['Codeship', { 'CI_NAME' => 'codeship' }],
+          ['GitHub Actions', { 'GITHUB_ACTIONS' => 'true' }],
+          ['GitLab CI', { 'GITLAB_CI' => 'true' }],
+          ['Heroku CI', { 'HEROKU_TEST_RUN_ID' => '123' }],
+          ['Semaphore CI 1.0', { 'SEMAPHORE_BUILD_NUMBER' => '123' }],
+          ['Semaphore CI 2.0', { 'SEMAPHORE' => 'true', 'SEMAPHORE_WORKFLOW_ID' => '123' }],
+          ['Travis CI', { 'TRAVIS' => 'true' }],
+          ['Unsupported', {}],
+        ].each do |ci, env|
+          it "on #{ci} it is false" do
+            logger = instance_double(Logger)
+            allow(KnapsackPro).to receive(:logger).and_return(logger)
+            expect(logger).not_to receive(:info)
+
+            stub_const("ENV", env.merge({ 'KNAPSACK_PRO_FIXED_QUEUE_SPLIT' => 'false' }))
+
+            expect(subject).to eq(false)
+          end
+        end
       end
 
-      context 'when KNAPSACK_PRO_FIXED_QUEUE_SPLIT=false' do
-        before { stub_const("ENV", { 'KNAPSACK_PRO_FIXED_QUEUE_SPLIT' => 'false' }) }
-        it { should be false }
+      context 'when KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true' do
+        [
+          ['AppVeyor', { 'APPVEYOR' => '123' }],
+          ['Buildkite', { 'BUILDKITE' => 'true' }],
+          ['CircleCI', { 'CIRCLECI' => 'true' }],
+          ['Cirrus CI', { 'CIRRUS_CI' => 'true' }],
+          ['Codefresh', { 'CF_BUILD_ID' => '123' }],
+          ['Codeship', { 'CI_NAME' => 'codeship' }],
+          ['GitHub Actions', { 'GITHUB_ACTIONS' => 'true' }],
+          ['GitLab CI', { 'GITLAB_CI' => 'true' }],
+          ['Heroku CI', { 'HEROKU_TEST_RUN_ID' => '123' }],
+          ['Semaphore CI 1.0', { 'SEMAPHORE_BUILD_NUMBER' => '123' }],
+          ['Semaphore CI 2.0', { 'SEMAPHORE' => 'true', 'SEMAPHORE_WORKFLOW_ID' => '123' }],
+          ['Travis CI', { 'TRAVIS' => 'true' }],
+          ['Unsupported', {}],
+        ].each do |ci, env|
+          it "on #{ci} it is true" do
+            logger = instance_double(Logger)
+            allow(KnapsackPro).to receive(:logger).and_return(logger)
+            expect(logger).not_to receive(:info)
+
+            stub_const("ENV", env.merge({ 'KNAPSACK_PRO_FIXED_QUEUE_SPLIT' => 'true' }))
+
+            expect(subject).to eq(true)
+          end
+        end
       end
     end
 
     context "when ENV doesn't exist" do
-      before { stub_const("ENV", {}) }
-      it { should be false }
+      [
+        ['AppVeyor', { 'APPVEYOR' => '123' }, false],
+        ['Buildkite', { 'BUILDKITE' => 'true' }, true],
+        ['CircleCI', { 'CIRCLECI' => 'true' }, false],
+        ['Cirrus CI', { 'CIRRUS_CI' => 'true' }, false],
+        ['Codefresh', { 'CF_BUILD_ID' => '123' }, false],
+        ['Codeship', { 'CI_NAME' => 'codeship' }, true],
+        ['GitHub Actions', { 'GITHUB_ACTIONS' => 'true' }, true],
+        ['GitLab CI', { 'GITLAB_CI' => 'true' }, false],
+        ['Heroku CI', { 'HEROKU_TEST_RUN_ID' => '123' }, false],
+        ['Semaphore CI 1.0', { 'SEMAPHORE_BUILD_NUMBER' => '123' }, false],
+        ['Semaphore CI 2.0', { 'SEMAPHORE' => 'true', 'SEMAPHORE_WORKFLOW_ID' => '123' }, false],
+        ['Travis CI', { 'TRAVIS' => 'true' }, true],
+        ['Unsupported', {}, true],
+      ].each do |ci, env, expected|
+        it "on #{ci} it is #{expected}" do
+          logger = instance_double(Logger)
+          expect(KnapsackPro).to receive(:logger).and_return(logger)
+          expect(logger).to receive(:info).with("KNAPSACK_PRO_FIXED_QUEUE_SPLIT is not set. Using default value: #{expected}. Learn more at #{KnapsackPro::Urls::FIXED_QUEUE_SPLIT}")
+
+          stub_const("ENV", env)
+
+          expect(subject).to eq(expected)
+        end
+      end
     end
   end
 
@@ -895,57 +937,6 @@ describe KnapsackPro::Config::Env do
     end
   end
 
-  describe '.ci_env_for' do
-    let(:env_name) { :node_total }
-
-    subject { described_class.ci_env_for(env_name) }
-
-    context 'when CI has no value for env_name method' do
-      before do
-        expect(KnapsackPro::Config::CI::Circle).to receive_message_chain(:new, env_name).and_return(nil)
-        expect(KnapsackPro::Config::CI::Semaphore).to receive_message_chain(:new, env_name).and_return(nil)
-        expect(KnapsackPro::Config::CI::Buildkite).to receive_message_chain(:new, env_name).and_return(nil)
-      end
-
-      it do
-        expect(subject).to be_nil
-      end
-    end
-
-    context 'when CI has value for env_name method' do
-      let(:circle_env) { double(:circle) }
-      let(:semaphore_env) { double(:semaphore) }
-      let(:buildkite_env) { double(:buildkite) }
-
-      before do
-        allow(KnapsackPro::Config::CI::Circle).to receive_message_chain(:new, env_name).and_return(circle_env)
-        allow(KnapsackPro::Config::CI::Semaphore).to receive_message_chain(:new, env_name).and_return(semaphore_env)
-        allow(KnapsackPro::Config::CI::Buildkite).to receive_message_chain(:new, env_name).and_return(buildkite_env)
-      end
-
-      context do
-        let(:buildkite_env) { nil }
-        let(:semaphore_env) { nil }
-
-        it { should eq circle_env }
-      end
-
-      context do
-        let(:circle_env) { nil }
-        let(:buildkite_env) { nil }
-
-        it { should eq semaphore_env }
-      end
-
-      context do
-        let(:circle_env) { nil }
-        let(:semaphore_env) { nil }
-
-        it { should eq buildkite_env }
-      end
-    end
-  end
-
   describe '.log_level' do
     subject { described_class.log_level }
 
@@ -1022,4 +1013,28 @@ describe KnapsackPro::Config::Env do
       expect(described_class.test_runner_adapter).to eql 'RSpecAdapter'
     end
   end
+
+  describe '.detected_ci' do
+    [
+      ['AppVeyor', { 'APPVEYOR' => '123' }, KnapsackPro::Config::CI::AppVeyor],
+      ['Buildkite', { 'BUILDKITE' => 'true' }, KnapsackPro::Config::CI::Buildkite],
+      ['CircleCI', { 'CIRCLECI' => 'true' }, KnapsackPro::Config::CI::Circle],
+      ['Cirrus CI', { 'CIRRUS_CI' => 'true' }, KnapsackPro::Config::CI::CirrusCI],
+      ['Codefresh', { 'CF_BUILD_ID' => '123' }, KnapsackPro::Config::CI::Codefresh],
+      ['Codeship', { 'CI_NAME' => 'codeship' }, KnapsackPro::Config::CI::Codeship],
+      ['GitHub Actions', { 'GITHUB_ACTIONS' => 'true' }, KnapsackPro::Config::CI::GithubActions],
+      ['GitLab CI', { 'GITLAB_CI' => 'true' }, KnapsackPro::Config::CI::GitlabCI],
+      ['Heroku CI', { 'HEROKU_TEST_RUN_ID' => '123' }, KnapsackPro::Config::CI::Heroku],
+      ['Semaphore CI 1.0', { 'SEMAPHORE_BUILD_NUMBER' => '123' }, KnapsackPro::Config::CI::Semaphore],
+      ['Semaphore CI 2.0', { 'SEMAPHORE' => 'true', 'SEMAPHORE_WORKFLOW_ID' => '123' }, KnapsackPro::Config::CI::Semaphore2],
+      ['Travis CI', { 'TRAVIS' => 'true' }, KnapsackPro::Config::CI::Travis],
+      ['Unsupported', {}, KnapsackPro::Config::CI::Base],
+    ].each do |ci, env, expected|
+      it "detects #{ci}" do
+        stub_const("ENV", env)
+
+        expect(described_class.detected_ci).to eq(expected)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.0.0
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-22 00:00:00.000000000 Z
+date: 2023-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -404,7 +404,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.8
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel