knapsack_pro 3.2.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5baae9cb1ea264d73e085e9f475b4f775e06801992ffd715f33a90fc93fd974f
-  data.tar.gz: e74b748147d57817546675c86ea534274f65cf287e52884d3960f09aa44efbb7
+  metadata.gz: 11036d33c04d07966ab4acadc55b1fb20a885b0e9b0d78fc8cf03fe798b7c3bf
+  data.tar.gz: 8ddfce179b4f7fce9bd28ae965bf15bec132b26b217326d5ce156e94e21cb145
 SHA512:
-  metadata.gz: 8f6102eef985cb8cb6c810053be5afecefcf309eb6a8367e3bcacdde09fb6bd10aa8d6ea10f68cdcdaf9b02a83117f2720ba6613562183c1ec9d52751ca87d56
-  data.tar.gz: b8c3d75e4267141135723fd29de4d5b97dffc1485dc762d7a9df0ba449c0827fa184261ffc101435b94678a7fc89bc8ed75876937a96d90ee6fd6103d7e38362
+  metadata.gz: 4c27910d9850ad2d229864dac8b07cb17d9d23a9bd2d14aa05052b6e95a3e218667b32fb40f711324651d2bcd6ee8d180fc7d743ba5cd3b990908ab05d5c57de
+  data.tar.gz: a868ac3c2ef9c1fdefc655b2dbb59c8034cc21101717be46400fdeec087bd99c62c43c5357fbba1eccfe8a8cc23b032ee1e9e8eb14e75304357ccbe6a179a32b

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Change Log
 
+### 3.3.1
+
+* Skip loading a test file path for Minitest in Queue Mode when it does not exist on the disk
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/174
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.3.0...v3.3.1
+
+### 3.3.0
+
+* Show a JSON report file content when RSpec fails during a dry run 
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/172
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.2.1...v3.3.0
+
+### 3.2.1
+
+* Raise exception when using `:focus` tag to avoid skipping RSpec tests
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/167
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.2.0...v3.2.1
+
 ### 3.2.0
 
 * Add an error message to `KnapsackPro::Adapters::RspecAdapter#bind`

data/lib/knapsack_pro/adapters/rspec_adapter.rb

@@ -62,6 +62,10 @@ module KnapsackPro
                 current_test_path
               end
 
+            if example.metadata[:focus] && KnapsackPro::Adapters::RSpecAdapter.rspec_configuration.filter.rules[:focus]
+              raise "We detected a test file path #{current_test_path} with a test using the metadata `:focus` tag. RSpec might not run some tests in the Queue Mode (causing random tests skipping problem). Please remove the `:focus` tag from your codebase. See more: https://knapsackpro.com/faq/question/rspec-is-not-running-some-tests"
+            end
+
             example.run
           end
 
@@ -95,6 +99,14 @@ module KnapsackPro
           end
         end
       end
+
+      private
+
+      # Hide RSpec configuration so that we could mock it in the spec.
+      # Mocking existing RSpec configuration could impact test's runtime.
+      def self.rspec_configuration
+        ::RSpec.configuration
+      end
     end
 
     # This is added to provide backwards compatibility

data/lib/knapsack_pro/runners/queue/minitest_runner.rb

@@ -91,7 +91,13 @@ module KnapsackPro
 
         def self.minitest_run(runner, test_file_paths, args)
           test_file_paths.each do |test_file_path|
-            require "./#{test_file_path}"
+            relative_test_file_path = "./#{test_file_path}"
+
+            if File.exist?(relative_test_file_path)
+              require relative_test_file_path
+            else
+              KnapsackPro.logger.warn("Skip loading the #{relative_test_file_path} test file path because it does not exist on the disk. Most likely, the test file path should not be loaded. The test file path could have been recorded during the previous CI build when the knapsack_pro gem could not attribute the execution time of a test to a correct test file path. For instance, you have shared examples in your test suite, and the knapsack_pro gem could not correctly determine for which test file path they were executed. In such a case, the test file path should not be loaded because the actual test cases will be executed by loading a correct test file path. You can ignore this warning.")
+            end
           end
 
           # duplicate args because Minitest modifies args

data/lib/knapsack_pro/test_case_detectors/rspec_test_example_detector.rb

@@ -36,11 +36,19 @@ module KnapsackPro
           ] + cli_args).join(' ')
 
           KnapsackPro.logger.error('-'*10 + ' START of actionable error message ' + '-'*50)
-          KnapsackPro.logger.error('There was a problem while generating test examples for the slow test files using the RSpec dry-run flag. To reproduce the error triggered by the RSpec, please try to run below command (this way, you can find out what is causing the error):')
+          KnapsackPro.logger.error('RSpec (with a dry-run option) had a problem generating the report with test examples for the slow test files. Here is what you can do:')
+
+          KnapsackPro.logger.error("a) Please look for an error message from RSpec in the output above or below. If you don't see anything, that is fine. Sometimes RSpec does not produce any errors in the output.")
+
+          KnapsackPro.logger.error("b) Check if RSpec generated the report file #{report_path}. If the report exists, it may contain an error message. Here is a preview of the report file:")
+          KnapsackPro.logger.error(report_content || 'N/A')
+
+          KnapsackPro.logger.error('c) To reproduce the error manually, please run the following RSpec command. This way, you can find out what is causing the error. Please ensure you run the command in the same environment where the error occurred. For instance, if the error happens on the CI server, you should run the command in the CI environment:')
           KnapsackPro.logger.error(debug_cmd)
+
           KnapsackPro.logger.error('-'*10 + ' END of actionable error message ' + '-'*50)
 
-          raise 'There was a problem while generating test examples for the slow test files. Please read actionable error message above.'
+          raise 'There was a problem while generating test examples for the slow test files. Please read the actionable error message above.'
         end
       end
 
@@ -75,6 +83,10 @@ module KnapsackPro
         "#{report_dir}/rspec_dry_run_json_report_node_#{KnapsackPro::Config::Env.ci_node_index}.json"
       end
 
+      def report_content
+        File.read(report_path) if File.exist?(report_path)
+      end
+
       def adapter_class
         KnapsackPro::Adapters::RSpecAdapter
       end

data/lib/knapsack_pro/version.rb

@@ -1,3 +1,3 @@
 module KnapsackPro
-  VERSION = '3.2.0'
+  VERSION = '3.3.1'
 end

data/spec/knapsack_pro/adapters/rspec_adapter_spec.rb

@@ -175,7 +175,35 @@ describe KnapsackPro::Adapters::RSpecAdapter do
       let(:logger) { instance_double(Logger) }
       let(:global_time) { 'Global time: 01m 05s' }
       let(:test_path) { 'spec/a_spec.rb' }
-      let(:current_example) { double }
+      let(:current_example) { double(metadata: {}) }
+
+      context "when the example's metadata has :focus tag AND RSpec inclusion rule includes :focus" do
+        let(:current_example) { double(metadata: { focus: true }) }
+
+        it do
+          expect(KnapsackPro::Config::Env).to receive(:rspec_split_by_test_examples?).and_return(false)
+
+          expect(config).to receive(:prepend_before).with(:context).and_yield
+
+          allow(KnapsackPro).to receive(:tracker).and_return(tracker)
+          expect(tracker).to receive(:start_timer).ordered
+
+          expect(config).to receive(:around).with(:each).and_yield(current_example)
+          expect(::RSpec).to receive(:configure).and_yield(config)
+
+          expect(tracker).to receive(:stop_timer).ordered
+
+          expect(described_class).to receive(:test_path).with(current_example).and_return(test_path)
+
+          expect(tracker).to receive(:current_test_path=).with(test_path).ordered
+
+          expect(described_class).to receive_message_chain(:rspec_configuration, :filter, :rules, :[]).with(:focus).and_return(true)
+
+          expect {
+            subject.bind_time_tracker
+          }.to raise_error /We detected a test file path spec\/a_spec\.rb with a test using the metadata `:focus` tag/
+        end
+      end
 
       context 'when rspec split by test examples is disabled' do
         before do

data/spec/knapsack_pro/runners/queue/minitest_runner_spec.rb

@@ -100,7 +100,7 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
     end
 
     context 'when test files exist' do
-      let(:test_file_paths) { ['a_test.rb', 'b_test.rb'] }
+      let(:test_file_paths) { ['a_test.rb', 'b_test.rb', 'fake_path_test.rb'] }
 
       before do
         subset_queue_id = 'fake-subset-queue-id'
@@ -114,8 +114,12 @@ describe KnapsackPro::Runners::Queue::MinitestRunner do
         expect(tracker).to receive(:set_prerun_tests).with(test_file_paths)
 
         # .minitest_run
+        expect(File).to receive(:exist?).with('./a_test.rb').and_return(true)
+        expect(File).to receive(:exist?).with('./b_test.rb').and_return(true)
+        expect(File).to receive(:exist?).with('./fake_path_test.rb').and_return(false)
         expect(described_class).to receive(:require).with('./a_test.rb')
         expect(described_class).to receive(:require).with('./b_test.rb')
+        expect(described_class).to_not receive(:require).with('./fake_path_test.rb')
 
         expect(Minitest).to receive(:run).with(args).and_return(is_tests_green)
 

data/spec/knapsack_pro/test_case_detectors/rspec_test_example_detector_spec.rb

@@ -11,7 +11,7 @@ describe KnapsackPro::TestCaseDetectors::RSpecTestExampleDetector do
 
       expect(FileUtils).to receive(:mkdir_p).with(report_dir)
 
-      expect(File).to receive(:exist?).with(report_path).and_return(true)
+      expect(File).to receive(:exist?).at_least(:once).with(report_path).and_return(true)
       expect(File).to receive(:delete).with(report_path)
 
       expect(rspec_test_example_detector).to receive(:slow_test_files).and_return(test_file_entities)
@@ -68,8 +68,15 @@ describe KnapsackPro::TestCaseDetectors::RSpecTestExampleDetector do
         context 'when exit code from RSpec::Core::Runner is 1' do
           let(:exit_code) { 1 }
 
+          before do
+            json_file = %{
+            {"version":"3.11.0","messages":["An error occurred while loading ./spec/a_spec.rb"],"examples":[],"summary":{"duration":3.6e-05,"example_count":0,"failure_count":0,"pending_count":0,"errors_outside_of_examples_count":1},"summary_line":"0 examples, 0 failures, 1 error occurred outside of examples"}
+            }.strip
+            expect(File).to receive(:read).with(report_path).and_return(json_file)
+          end
+
           it do
-            expect { subject }.to raise_error(RuntimeError, 'There was a problem while generating test examples for the slow test files. Please read actionable error message above.')
+            expect { subject }.to raise_error(RuntimeError, 'There was a problem while generating test examples for the slow test files. Please read the actionable error message above.')
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: knapsack_pro
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.1
 platform: ruby
 authors:
 - ArturT
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-03 00:00:00.000000000 Z
+date: 2022-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -405,7 +405,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Knapsack Pro splits tests across parallel CI nodes and ensures each parallel